May 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-trx[master]: build: detect pthread_setname_np and sched_* APIs, guard usage
by Timur Davydov 01 May '26

01 May '26

Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42654?usp=email ) Change subject: build: detect pthread_setname_np and sched_* APIs, guard usage ...................................................................... Patch Set 2: (1 comment) File CommonLibs/Threads.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42654/comment/019d7587_d1d1309e?usp… : PS1, Line 39: > In general config. […] Ack, makes sense. I moved `config.h` to the top of the file and wrapped it with `#ifdef HAVE_CONFIG_H`. I also added config.h to a few other files which include uhd_specific.h indirectly via other headers, namely `ms.h`, `ms_trxcon_if.h` and `ms_upper.h`, to ensure consistent configuration visibility. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42654?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ic3f1492544439d88c5e6683330c6696de1c2f85b Gerrit-Change-Number: 42654 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 May 2026 16:58:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in osmo-trx[master]: build: detect pthread_setname_np and sched_* APIs, guard usage
by Timur Davydov 01 May '26

01 May '26

Attention is currently required from: Timur Davydov, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42654?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: build: detect pthread_setname_np and sched_* APIs, guard usage ...................................................................... build: detect pthread_setname_np and sched_* APIs, guard usage Add configure checks for pthread_setname_np and sched_* functions. Wrap their usage with HAVE_* guards to avoid build failures on platforms where they are unavailable. Return -ENOTSUP for unsupported scheduler operations. Improves portability across non-Linux and restricted environments (e.g. WebAssembly). Change-Id: Ic3f1492544439d88c5e6683330c6696de1c2f85b --- M CommonLibs/Threads.cpp M Transceiver52M/device/ipc/ipc-driver-test.c M Transceiver52M/ms/l1ctl_server_cb.cpp M Transceiver52M/ms/ms_trxcon_if.cpp M Transceiver52M/ms/ms_upper.cpp M Transceiver52M/ms/threadsched.cpp M Transceiver52M/ms/uhd_specific.h M Transceiver52M/osmo-trx.cpp M configure.ac 9 files changed, 58 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/54/42654/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42654?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ic3f1492544439d88c5e6683330c6696de1c2f85b Gerrit-Change-Number: 42654 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[L] Change in osmo-bts[master]: trx, bts: add optional WebSDR backend (callback-based transport)
by Jenkins Builder 01 May '26

01 May '26

Attention is currently required from: Timur Davydov. Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email ) Change subject: trx, bts: add optional WebSDR backend (callback-based transport) ...................................................................... Patch Set 9: (1 comment) File src/osmo-bts-trx/osmo-bts-trx-websdr.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/2ce0cf40_0a11328c?usp… : PS9, Line 90: const char *params[] = { char * array declaration might be better as static const -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idebd588f33afd85021813ad5821391781db683a9 Gerrit-Change-Number: 42703 Gerrit-PatchSet: 9 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Fri, 01 May 2026 16:37:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-bts[master]: build: make sched_* usage optional
by Timur Davydov 01 May '26

01 May '26

Attention is currently required from: laforge, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42690?usp=email ) Change subject: build: make sched_* usage optional ...................................................................... Patch Set 7: (1 comment) File src/common/main.c: https://gerrit.osmocom.org/c/osmo-bts/+/42690/comment/0decc337_30c25d4e?usp… : PS6, Line 314: #ifdef HAVE_SCHED_SETSCHEDULER > since rt_prio can't be set by command line above, this if block cannot be ever entered. […] You are right. Since rt_prio cannot be set in this configuration, the condition can never be true. I will move the #ifdef to cover the entire `if (rt_prio != -1)` block, including the declaration of `rt_prio` itself. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42690?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5af357c1e2074fa1e05ac6bc20af8535c474d906 Gerrit-Change-Number: 42690 Gerrit-PatchSet: 7 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 May 2026 16:31:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: build: make sched_* usage optional
by Timur Davydov 01 May '26

01 May '26

Attention is currently required from: Timur Davydov, laforge. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/42690?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: build: make sched_* usage optional ...................................................................... build: make sched_* usage optional Add configure checks for sched_* APIs and guard usage of sched_setscheduler with HAVE_SCHED_SETSCHEDULER. This avoids build/runtime issues on platforms without scheduler support. Change-Id: I5af357c1e2074fa1e05ac6bc20af8535c474d906 --- M configure.ac M src/common/main.c 2 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/90/42690/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42690?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5af357c1e2074fa1e05ac6bc20af8535c474d906 Gerrit-Change-Number: 42690 Gerrit-PatchSet: 7 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[L] Change in osmo-bts[master]: trx: add JSON stats export for WebSDR API
by Timur Davydov 01 May '26

01 May '26

Attention is currently required from: fixeria, laforge, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42704?usp=email ) Change subject: trx: add JSON stats export for WebSDR API ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: > As mentioned in the osmo-trx similar commit, I doubt this has to be merged into the repository. […] Similar to the osmo-trx case, this is only built when --with-websdr is enabled, so it does not affect the default/native builds. In the WebSDR setup, VTY/CTRL/stats interfaces are not directly accessible from the web frontend. While it is technically possible to emulate VTY access via callbacks (e.g. trigger a VTY command, capture its textual output and forward it to the frontend for parsing), this would require modifying core VTY paths (e.g. vty_out) under conditional compilation. That approach would be more invasive and harder to maintain than keeping this separate implementation. Also, in this case I only need a limited subset of information (mainly stats from osmo-bts-trx), so introducing a full VTY round-trip + parsing would be unnecessary overhead. So the intention here is to keep the core code untouched and provide a minimal, isolated path for the WebSDR use case. Of course, I’m open to alternative approaches if there is a cleaner way to achieve this. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42704?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifb82adfab879a65ecd222c45e06551983aa90a0f Gerrit-Change-Number: 42704 Gerrit-PatchSet: 8 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 May 2026 16:30:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: nokia: make Rx diversity configurable
by csaba.sipos 01 May '26

01 May '26

Attention is currently required from: falconia, fixeria, pespin. csaba.sipos has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email ) Change subject: nokia: make Rx diversity configurable ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42714/comment/de62206d_f0d90e3f?usp… : PS3, Line 1214: fu_config[len + 7] = bts->nokia.rx_diversity; > Through hard-coded bits in `bts_config_2[]` array. […] @pespin@sysmocom.de And just to confirm: with Rx diversity capable models (Metro/Ultra and now Multiradio) the BTS manager also indicates after bootstrap that the TRXes are running in 2way RX diversity mode, plus the lab test also indicate that the two RX channels are doing MRC. Which means in a nutshell that this config option really does work :-) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I73bd91b717a8c8b338bacb6ed9db73bb07245c12 Gerrit-Change-Number: 42714 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: csaba.sipos <metro4(a)freemail.hu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 May 2026 16:29:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: bts: guard AMR RTP decoder stub with HAVE_LIBOSMOCODEC_STATIC
by Timur Davydov 01 May '26

01 May '26

Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42701?usp=email ) Change subject: bts: guard AMR RTP decoder stub with HAVE_LIBOSMOCODEC_STATIC ...................................................................... Patch Set 6: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/osmo-bts/+/42701/comment/737d2821_30c5f62a?usp… : PS6, Line 350: if test -n "$osmocodec_libdir" && test -f "$osmocodec_libdir/libosmocodec.a" ; then > AFAIU the fact that an static library exists doesn't mean you are statically linking against that li […] You are right in general, but in this case it is under the condition that --with-websdr is enabled, where only static linking is possible (Emscripten/WASM target). So the library is not just built as static, it is actually linked statically into the final module. I would be happy to hear suggestions if there is a better way to structure or verify this. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42701?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie19ae2013893575a2f74a87af2151034abf57870 Gerrit-Change-Number: 42701 Gerrit-PatchSet: 6 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 May 2026 16:21:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: abis: add helper to update BTS identity
by Timur Davydov 01 May '26

01 May '26

Attention is currently required from: fixeria, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42699?usp=email ) Change subject: abis: add helper to update BTS identity ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > This function in osmo-bts should only be added/merged once there's a patch using it. […] Sure. It will be used in src/osmo-bts-trx/osmo-bts-trx-websdr.c as part of this patch: https://gerrit.osmocom.org/c/osmo-bts/+/42703 I can also squash this change with that patch if you prefer. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42699?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibafd66a1e1dc42ad0063c412087bee10d212fe33 Gerrit-Change-Number: 42699 Gerrit-PatchSet: 6 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 May 2026 16:15:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: nokia skip-reset: make consistent with other vty settings
by falconia 01 May '26

01 May '26

falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42718?usp=email ) Change subject: nokia skip-reset: make consistent with other vty settings ...................................................................... nokia skip-reset: make consistent with other vty settings All other Nokia-specific vty settings use is_nokia_bts() helper function, while the code for skip-reset directly compares bts->type against GSM_BTS_TYPE_NOKIA_SITE. Change to use the helper function: it is consistent with other vty settings, and avoids one more place that erroneously refers to *Site instead of all Nokia BTS. Change-Id: Ie8cdac51f82185e2d4f37a8da00acba633670052 --- M src/osmo-bsc/bts_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 54a9fab..cbf00d0 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -399,7 +399,7 @@ { struct gsm_bts *bts = vty->index; - if (bts->type != GSM_BTS_TYPE_NOKIA_SITE) { + if (!is_nokia_bts(bts)) { vty_out(vty, "%% BTS is not of Nokia type%s", VTY_NEWLINE); return CMD_WARNING; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42718?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie8cdac51f82185e2d4f37a8da00acba633670052 Gerrit-Change-Number: 42718 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log May 2026