falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42718?usp=email )

Change subject: nokia skip-reset: make consistent with other vty settings ......................................................................

nokia skip-reset: make consistent with other vty settings

All other Nokia-specific vty settings use is_nokia_bts() helper function, while the code for skip-reset directly compares bts->type against GSM_BTS_TYPE_NOKIA_SITE. Change to use the helper function: it is consistent with other vty settings, and avoids one more place that erroneously refers to *Site instead of all Nokia BTS.

Change-Id: Ie8cdac51f82185e2d4f37a8da00acba633670052 --- M src/osmo-bsc/bts_vty.c 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified

diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 54a9fab..cbf00d0 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -399,7 +399,7 @@ { struct gsm_bts *bts = vty->index;

- if (bts->type != GSM_BTS_TYPE_NOKIA_SITE) { + if (!is_nokia_bts(bts)) { vty_out(vty, "%% BTS is not of Nokia type%s", VTY_NEWLINE); return CMD_WARNING; }