May 2026 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: nokia cosmetic: factor out BTS_CONF_COMPL handling
by falconia 06 May '26

06 May '26

falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42726?usp=email ) Change subject: nokia cosmetic: factor out BTS_CONF_COMPL handling ...................................................................... nokia cosmetic: factor out BTS_CONF_COMPL handling When the BTS accepts the config sent to it via BTS_CONF_DATA, it responds with BTS_CONF_COMPL. Upon receiving the latter message, we have to send TRX unlock and TRX reset commands, and we have to start LAPD for RSL. Factor out this logic into a helper function, to reduce the level of indentation and make it easier to extend. Change-Id: I26e9b25ba4e68e945f7dd8a632009cc3683a322c --- M src/osmo-bsc/bts_nokia_site.c 1 file changed, 45 insertions(+), 35 deletions(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c index 29b1929..c8ac578 100644 --- a/src/osmo-bsc/bts_nokia_site.c +++ b/src/osmo-bsc/bts_nokia_site.c @@ -1784,6 +1784,48 @@ * when the developer-operator resets the BTS manually before each test run. */ +static int handle_conf_complete(struct e1inp_sign_link *sign_link, uint16_t ref) +{ + struct gsm_bts *bts = sign_link->trx->bts; + struct gsm_bts_trx *trx; + int bcch_trx_nr = -1; + + /* we first need to unlock and reset the TRX that runs BCCH */ + llist_for_each_entry(trx, &bts->trx_list, list) { + if (trx->ts[0].pchan_from_config == GSM_PCHAN_CCCH || + trx->ts[0].pchan_from_config == GSM_PCHAN_CCCH_SDCCH4 || + trx->ts[0].pchan_from_config == GSM_PCHAN_CCCH_SDCCH4_CBCH) { + /* saving the number of TRX that has BCCH on it */ + bcch_trx_nr = trx->nr; + /* unlock TRX */ + abis_nm_cha_adm_trx_unlock(bts, trx->nr+1, ref); + /* reset TRX */ + abis_nm_trx_reset(bts, trx->nr+1, ref); + } + } + /* now unlocking all other TRXs */ + llist_for_each_entry(trx, &bts->trx_list, list) { + if (trx->nr != bcch_trx_nr) { + /* unlock TRX */ + abis_nm_cha_adm_trx_unlock(bts, trx->nr+1, ref); + } + } + /* start TRX (RSL link) */ + struct gsm_e1_subslot *e1_link = &sign_link->trx->rsl_e1_link; + struct e1inp_line *line; + bts->nokia.configured = 0; + /* RSL Link */ + line = e1inp_line_find(e1_link->e1_nr); + if (!line) { + LOG_BTS(bts, DLINP, LOGL_ERROR, "RSL link referring to " + "non-existing E1 line %u\n", e1_link->e1_nr); + return -ENOMEM; + } + /* start TRX */ + start_sabm_in_line(line, 1, SAPI_RSL); /* start only RSL */ + return 0; +} + #define FIND_ELEM(data, data_len, ei, var, len) (find_element(data, data_len, ei, var, len) == len) static int abis_nm_rcvmsg_fom(struct e1inp_sign_link *sign_link, uint8_t *l3_msg, unsigned l3_msg_len) @@ -1900,41 +1942,9 @@ /* send ACK */ abis_nm_ack(bts, ref); if (bts->nokia.configured != 0) { - struct gsm_bts_trx *trx; - int bcch_trx_nr = -1; - /* we first need to unlock and reset the TRX that runs BCCH */ - llist_for_each_entry(trx, &bts->trx_list, list) { - if (trx->ts[0].pchan_from_config == GSM_PCHAN_CCCH || - trx->ts[0].pchan_from_config == GSM_PCHAN_CCCH_SDCCH4 || - trx->ts[0].pchan_from_config == GSM_PCHAN_CCCH_SDCCH4_CBCH) { - /* saving the number of TRX that has BCCH on it */ - bcch_trx_nr = trx->nr; - /* unlock TRX */ - abis_nm_cha_adm_trx_unlock(bts, trx->nr+1, ref); - /* reset TRX */ - abis_nm_trx_reset(bts, trx->nr+1, ref); - } - } - /* now unlocking all other TRXs */ - llist_for_each_entry(trx, &bts->trx_list, list) { - if (trx->nr != bcch_trx_nr) { - /* unlock TRX */ - abis_nm_cha_adm_trx_unlock(bts, trx->nr+1, ref); - } - } - /* start TRX (RSL link) */ - struct gsm_e1_subslot *e1_link = &sign_link->trx->rsl_e1_link; - struct e1inp_line *line; - bts->nokia.configured = 0; - /* RSL Link */ - line = e1inp_line_find(e1_link->e1_nr); - if (!line) { - LOG_BTS(bts, DLINP, LOGL_ERROR, "RSL link referring to " - "non-existing E1 line %u\n", e1_link->e1_nr); - return -ENOMEM; - } - /* start TRX */ - start_sabm_in_line(line, 1, SAPI_RSL); /* start only RSL */ + ret = handle_conf_complete(sign_link, ref); + if (ret < 0) + return ret; } /* fake 12.21 OM */ nokia_abis_nm_fake_1221_ok(bts); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42726?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I26e9b25ba4e68e945f7dd8a632009cc3683a322c Gerrit-Change-Number: 42726 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: nokia cosmetic: add bts_is_insite() function
by falconia 06 May '26

06 May '26

falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42725?usp=email ) Change subject: nokia cosmetic: add bts_is_insite() function ...................................................................... nokia cosmetic: add bts_is_insite() function Nokia InSite gets a different config than the larger Nokia BTS models, and make_bts_config() function checks the BTS type to decide which config to send. Change the BTS type check from a long 'if' line that compares against 3 different InSite BTS type codes to bts_is_insite() helper function that encapsulates a switch statement. Upcoming code additions will need to check for Flexi Multiradio BTS family in a similar manner - so be consistent. Change-Id: I44bbcd79d9741f1df280b6b2391f04f754598035 --- M src/osmo-bsc/bts_nokia_site.c 1 file changed, 14 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c index 340405e..29b1929 100644 --- a/src/osmo-bsc/bts_nokia_site.c +++ b/src/osmo-bsc/bts_nokia_site.c @@ -1162,12 +1162,24 @@ /* TODO: put in a separate file ? */ +static bool bts_is_insite(uint8_t bts_type) +{ + switch (bts_type) { + case 0x0E: /* InSite 900 MHz */ + case 0x0F: /* InSite 1800 MHz */ + case 0x10: /* InSite 1900 MHz */ + return true; + default: + return false; + } +} + /* build the configuration data */ static int make_bts_config(struct gsm_bts *bts, uint8_t bts_type, int n_trx, uint8_t * fu_config, int need_hopping, int hopping_type) { - /* is it an InSite BTS ? */ - if (bts_type == 0x0E || bts_type == 0x0F || bts_type == 0x10) { /* TODO */ + /* InSite BTS gets its own special config */ + if (bts_is_insite(bts_type)) { if (n_trx != 1) { LOG_BTS(bts, DNM, LOGL_ERROR, "InSite has only one TRX\n"); return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I44bbcd79d9741f1df280b6b2391f04f754598035 Gerrit-Change-Number: 42725 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-trx[master]: transceiver: add optional Laurent burst LUT modulation (int16)
by Timur Davydov 05 May '26

05 May '26

Attention is currently required from: Hoernchen, laforge, pespin, tnt. Hello Hoernchen, Jenkins Builder, tnt, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42248?usp=email to look at the new patch set (#18). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: transceiver: add optional Laurent burst LUT modulation (int16) ...................................................................... transceiver: add optional Laurent burst LUT modulation (int16) Introduce an optional Burst LUT optimization for Laurent-based burst modulation, enabled via --with-burst-lut. - Add precomputed Laurent LUT tables (float and int16 I/Q variants) - Generate LUT at initialization (prepareBurstLUT) - Use LUT-based modulation for sps=4 when enabled - Add configure.ac option and USE_BURST_LUT define This reduces runtime computation by replacing per-burst Laurent processing with memcpy-based LUT lookups. Change-Id: I1715c2d33dc55fe1c7be5c6e7259d378ea5e80b2 --- M Transceiver52M/sigProcLib.cpp M configure.ac 2 files changed, 167 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/48/42248/18 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42248?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1715c2d33dc55fe1c7be5c6e7259d378ea5e80b2 Gerrit-Change-Number: 42248 Gerrit-PatchSet: 18 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: nokia cosmetic: add bts_is_insite() function
by fixeria 05 May '26

05 May '26

Attention is currently required from: falconia, laforge. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42725?usp=email ) Change subject: nokia cosmetic: add bts_is_insite() function ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I44bbcd79d9741f1df280b6b2391f04f754598035 Gerrit-Change-Number: 42725 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 05 May 2026 20:34:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: nokia cosmetic: add bts_is_insite() function
by falconia 05 May '26

05 May '26

Attention is currently required from: laforge. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42725?usp=email ) Change subject: nokia cosmetic: add bts_is_insite() function ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I think I'd prefer something like @if (nokia_bts_type(bts) == NOKIA_BTS_INSITE)@ as it would scale m […] Right now we have the following situation: * Out of supported and tested models, MetroSite and UltraSite require one handling (currently treated as default), InSite requires different handling (was there from the beginning) and Flexi MR requires third handling, added with my third patch in this series. * After Flexi MR, there is Multiradio 10, the last model to support E1 Abis via add-on card. I don't have an MR10 system unit yet, but I see plenty of them on ebay, and I plan on buying one for testing. It works with the same radio modules as plain Flexi MR. I expect MR10 to require the same handling in osmo-bsc as plain FMR, and my third patch in this series currently assumes so. * In between UltraSite and Flexi MR there is also Flexi EDGE, intermediate evolutionary step. However, I and A2GC are essentially skipping Flexi EDGE, going directly to Flexi MR or MR10. It is not clear whether or not anyone else will ever invest time and money into acquiring Flexi EDGE hw and putting it together just to test osmo-bsc on it - hence it may remain forever in unknown state. * After MR10, all newer models are IP Abis only. Csaba and I are looking into the possibility of implementing IP Abis support on Flexi MR and MR10, using hw in my lab, as a stepping stone toward subsequent IP-only models - but nothing is certain with this idea. Going back to your idea of a `nokia_bts_type(bts)` function that distills Nokia's own BTS model ID codes into a smaller set of `NOKIA_BTS_*` return values that capture different handling required in osmo-bsc, right now I would feel a little uneasy defining and implementing such grouping: we don't know if Flexi EDGE should be handled like Metro/UltraSite or like Flexi MR, and the use of exactly the same handling between MR and MR10 remains to be tested on the latter. Since you said this issue is not a blocker, if I don't see any further comments in the next couple of days, I'll CR+2 to myself (based on CR+1 from you and @pespin@sysmocom.de) and merge. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I44bbcd79d9741f1df280b6b2391f04f754598035 Gerrit-Change-Number: 42725 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 05 May 2026 18:05:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: ConfigurableParameter: do not magically overwrite the 'name' attribute
by neels 05 May '26

05 May '26

Attention is currently required from: fixeria, laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41918?usp=email ) Change subject: ConfigurableParameter: do not magically overwrite the 'name' attribute ...................................................................... Patch Set 6: (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/41918/comment/bb8982c7_7651b9ae?usp=em… : PS2, Line 7: Co > > This tiny detail is just not worth even considering to spend time on. […] I apologized out-of-band for the emotional outburst, let me repeat this here: sorry for the rant. The automatic naming has the problem that the names have to be valid python class names. For example, "5GS-SUCI-CalcInfo" would not work as a name. You are right, we can check in __new__() whether it is already set and only change it otherwise. Indeed that is an ok solution with even a slight advantage (in the mix of disadvantages), over my different solution, using the get_name() classmethod. But: * It is not necessary to create automatic names. I would rather set manual names explicitly on every subclass. I have gotten code review that the automatic naming should remain. So I've put it back in the form of the get_name() classmethod, using normal python inheritance. * It is a bad idea to do anything hidden in a __new__() of a superclass, because "explicit is better than implicit" https://peps.python.org/pep-0020/ and it makes it hard to adjust subclass behavior in the usual pythonic inheritance. This is my opinion and you do not have to agree, even though I know I'm right =) * My get_name() classmethod implementation has a problem that I don't like very much: callers have to call get_name() to get the automatic name. They could also just access `foo.name`, but then they will get only a manually set name. So callers have to be aware of that, which is not very good API design from my side. This is ofc not a problem whenever a name was set manually. * When all names are set manually anyway, which is the case in my patches, the discussion has very low to actually zero relevance to the real world. That is why my opinion is that my colleagues should be aware of that, and simply trust my judgement (if i am wrong it would have no actual effect, either), so that we can work with the actually important parts of the code. This has not happened for something like a year, we are still discussing this topic of zero real world effect, and comments here even sounded to me like i were the one stopping the progress, which I would not accept to be accurate. That is why my patience has been inapproriately low on this particular aspect. Sorry about that, and I greatly appreciate that you are here to resolve this. Back to the conclusion, I am fine with either * removing all automatic names * or, if you really have to, go on and put a new decision in __new__() and remove the get_name() classmethod. I can then adjust all callers on my side later. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41918?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6f631444c6addeb7ccc5f6c55b9be3dc83409169 Gerrit-Change-Number: 41918 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 May 2026 17:30:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: personalization audit: optionally audit all (unknown) SD keys
by neels 05 May '26

05 May '26

Attention is currently required from: fixeria, laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40209?usp=email ) Change subject: personalization audit: optionally audit all (unknown) SD keys ...................................................................... Patch Set 12: (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/40209/comment/7e5112f2_39361e2a?usp=em… : PS12, Line 14: 0x03 0x04..0x0f -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40209?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icaf6f7b589f117868633c0968a99f2f0252cf612 Gerrit-Change-Number: 40209 Gerrit-PatchSet: 12 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 May 2026 16:56:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-bsc[master]: Nokia Flexi Multiradio: reset non-BCCH TRX
by pespin 05 May '26

05 May '26

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42727?usp=email ) Change subject: Nokia Flexi Multiradio: reset non-BCCH TRX ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42727?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I270c1ffab074c1e5a43ab9dfa103725a1518f718 Gerrit-Change-Number: 42727 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 05 May 2026 16:33:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bsc[master]: nokia cosmetic: factor out BTS_CONF_COMPL handling
by pespin 05 May '26

05 May '26

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42726?usp=email ) Change subject: nokia cosmetic: factor out BTS_CONF_COMPL handling ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42726?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I26e9b25ba4e68e945f7dd8a632009cc3683a322c Gerrit-Change-Number: 42726 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 05 May 2026 16:32:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: nokia cosmetic: add bts_is_insite() function
by pespin 05 May '26

05 May '26

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42725?usp=email ) Change subject: nokia cosmetic: add bts_is_insite() function ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I44bbcd79d9741f1df280b6b2391f04f754598035 Gerrit-Change-Number: 42725 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 05 May 2026 16:30:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log May 2026