May 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: build: make sched_* usage optional
by laforge 06 May '26

06 May '26

Attention is currently required from: Timur Davydov, pespin. laforge has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42690?usp=email ) Change subject: build: make sched_* usage optional ...................................................................... Patch Set 7: Code-Review+1 (2 comments) File src/common/main.c: https://gerrit.osmocom.org/c/osmo-bts/+/42690/comment/b049c60d_5d17dc39?usp… : PS3, Line 322: #endif /* HAVE_SCHED_SETSCHEDULER */ > Good point. I updated this accordingly. Done File src/common/main.c: https://gerrit.osmocom.org/c/osmo-bts/+/42690/comment/fb6fa8db_51cfd3b3?usp… : PS6, Line 314: #ifdef HAVE_SCHED_SETSCHEDULER > You are right. Since rt_prio cannot be set in this configuration, the condition can never be true. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42690?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5af357c1e2074fa1e05ac6bc20af8535c474d906 Gerrit-Change-Number: 42690 Gerrit-PatchSet: 7 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 06 May 2026 07:53:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in osmo-trx[master]: convolve: avoid function pointer casts by adding wrapper functions
by laforge 06 May '26

06 May '26

Attention is currently required from: Hoernchen, Timur Davydov. laforge has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42655?usp=email ) Change subject: convolve: avoid function pointer casts by adding wrapper functions ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: I'm not an expert in this part of the code but .... wouldn't it make more sense to either change the implementations of those functions to "return void" or to chnage the function pointer declarations to "return int"? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42655?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Idecb118be285eb3e4691d1761d0d8fa24fd80c75 Gerrit-Change-Number: 42655 Gerrit-PatchSet: 4 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 06 May 2026 07:52:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O
by laforge 06 May '26

06 May '26

Attention is currently required from: Timur Davydov, fixeria, pespin. laforge has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email ) Change subject: transceiver: split control command handling from socket I/O ...................................................................... Patch Set 8: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/da8cfa9f_cd6e44bd?usp… : PS5, Line 11: - switch response formatting from sprintf() to snprintf() > You're right — I've updated the commit message. Done File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/400548bb_7be87ef3?usp… : PS3, Line 831: static bool match_cmd(const char *buf, > I've added a separate patch for this - https://gerrit.osmocom. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 8 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 06 May 2026 07:49:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in libosmocore[master]: vty: fix osmo_cpu_sched_vty_init() prototype
by laforge 06 May '26

06 May '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/42709?usp=email ) Change subject: vty: fix osmo_cpu_sched_vty_init() prototype ...................................................................... vty: fix osmo_cpu_sched_vty_init() prototype Change return type of osmo_cpu_sched_vty_init() from void to int to match its implementation. This fixes a prototype mismatch rejected by stricter compilers (e.g. Emscripten). Change-Id: Ia86e8063178ad82de098c2ff693cfbcd7e9f2192 --- M include/osmocom/vty/cpu_sched_vty.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved fixeria: Looks good to me, approved diff --git a/include/osmocom/vty/cpu_sched_vty.h b/include/osmocom/vty/cpu_sched_vty.h index 171f168..b04ee34 100644 --- a/include/osmocom/vty/cpu_sched_vty.h +++ b/include/osmocom/vty/cpu_sched_vty.h @@ -31,7 +31,7 @@ * \file cpu_sched_vty.h */ -void osmo_cpu_sched_vty_init(void *tall_ctx); +int osmo_cpu_sched_vty_init(void *tall_ctx); int osmo_cpu_sched_vty_apply_localthread(void); /*! @} */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42709?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia86e8063178ad82de098c2ff693cfbcd7e9f2192 Gerrit-Change-Number: 42709 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: vty: make CPU scheduling optional based on platform support
by laforge 06 May '26

06 May '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/42653?usp=email ) Change subject: vty: make CPU scheduling optional based on platform support ...................................................................... vty: make CPU scheduling optional based on platform support Add configure checks for sched_* APIs and guard their usage in cpu_sched_vty with HAVE_SCHED_* macros. If scheduler functions are not available, return -ENOTSUP instead of failing at build time. This improves portability on platforms lacking full sched support (e.g. non-Linux or restricted environments). Change-Id: Ic5b7e39fac16531d370cb81f769ba87fef18cb81 --- M configure.ac M src/vty/cpu_sched_vty.c 2 files changed, 14 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, approved diff --git a/configure.ac b/configure.ac index b5f858f..cde4446 100644 --- a/configure.ac +++ b/configure.ac @@ -162,6 +162,10 @@ AC_CHECK_HEADERS([sched.h sys/mount.h sys/param.h]) AC_CHECK_FUNCS([setns unshare mount]) +dnl Check the scheduller functions +AC_CHECK_HEADERS([sched.h]) +AC_CHECK_FUNCS([sched_setaffinity sched_setscheduler sched_getaffinity]) + dnl Check whether CLONE_NEWNET is available AC_CHECK_DECL([CLONE_NEWNET], [AC_DEFINE([HAVE_CLONE_NEWNET], [1], diff --git a/src/vty/cpu_sched_vty.c b/src/vty/cpu_sched_vty.c index 4f3eeb1..a712860 100644 --- a/src/vty/cpu_sched_vty.c +++ b/src/vty/cpu_sched_vty.c @@ -331,6 +331,7 @@ static int my_sched_setaffinity(enum sched_vty_thread_id tid_type, pid_t pid, cpu_set_t *cpuset, size_t cpuset_size) { +#ifdef HAVE_SCHED_SETAFFINITY DIR *proc_dir; struct dirent *entry; char dirname[100]; @@ -369,7 +370,9 @@ closedir(proc_dir); return rc; - +#else /* HAVE_SCHED_SETAFFINITY */ + return -ENOTSUP; +#endif /* HAVE_SCHED_SETAFFINITY */ } DEFUN_ATTR(cfg_sched_cpu_affinity, cfg_sched_cpu_affinity_cmd, @@ -464,6 +467,7 @@ static int set_sched_rr(unsigned int prio) { +#ifdef HAVE_SCHED_SETSCHEDULER struct sched_param param; int rc; memset(&param, 0, sizeof(param)); @@ -476,6 +480,9 @@ return -1; } return 0; +#else /* HAVE_SCHED_SETSCHEDULER */ + return -ENOTSUP; +#endif /* HAVE_SCHED_SETSCHEDULER */ } DEFUN_ATTR(cfg_sched_policy, cfg_sched_policy_cmd, @@ -558,10 +565,12 @@ cpuset = CPU_ALLOC(get_num_cpus()); cpuset_size = CPU_ALLOC_SIZE(get_num_cpus()); CPU_ZERO_S(cpuset_size, cpuset); +#ifdef HAVE_SCHED_GETAFFINITY if (sched_getaffinity(tid_it, cpuset_size, cpuset) == 0) { if (generate_cpu_hex_mask(str_mask, sizeof(str_mask), cpuset, cpuset_size) < 0) str_mask[0] = '\0'; } +#endif /* HAVE_SCHED_GETAFFINITY */ CPU_FREE(cpuset); vty_out(vty, " TID: %lu, NAME: '%s', cpu-affinity: %s%s", -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic5b7e39fac16531d370cb81f769ba87fef18cb81 Gerrit-Change-Number: 42653 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bsc[master]: nokia: rename vty settings, drop _site
by laforge 06 May '26

06 May '26

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42730?usp=email ) Change subject: nokia: rename vty settings, drop _site ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: I tend to agree with those changes more than with the general rename of the BTS_MODEL, as all changes in this patch likely actually related to specifics of the nokia BTS and not the transport protocol. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42730?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I807c0ad14f4436a21f0be0a5ed291539cd4af7e8 Gerrit-Change-Number: 42730 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Wed, 06 May 2026 07:46:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bsc[master]: nokia: rename BTS model from nokia_site to nokia-e1
by laforge 06 May '26

06 May '26

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42729?usp=email ) Change subject: nokia: rename BTS model from nokia_site to nokia-e1 ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I think this is probably an unneccessary change, and one thet will be reverted if and when you ever support the IP based nokia abis. In the end, a lot of the nokia specific code is about specifics of the nokia bts hardware, and not specifics of the protocol used to talk to that hardware. So you could just keep it at the current slightly incorrect/outdated name, instead of introducing something that is very likely also incorrect as we currently have no separation between "nokia BTS type" and "protocol used to talk to nokia BTS". -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42729?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3e993bda577964922e29dbbaf9554fa53bb2d445 Gerrit-Change-Number: 42729 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Wed, 06 May 2026 07:45:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ci[master]: lint/checkpatch: ignore STATIC_CONST_CHAR_ARRAY
by laforge 06 May '26

06 May '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42731?usp=email ) Change subject: lint/checkpatch: ignore STATIC_CONST_CHAR_ARRAY ...................................................................... lint/checkpatch: ignore STATIC_CONST_CHAR_ARRAY include/osmocom/vty/command.h has the following: #define DEFUN_CMD_FUNC_DECL(funcname) \ static int funcname (struct cmd_element *, struct vty *, int, const char *[]); \ #define DEFUN_CMD_FUNC_TEXT(funcname) \ static int funcname \ (struct cmd_element *self, struct vty *vty, int argc, const char *argv[]) So the pointer to argv is const, but the elements in the array are not. Functions can in theory modify the elements of argv (just like argv in main()). I don't know if we have users of this API that are actually doing that, but as long as the API is defined like this it doesn't make sense for the linter to complain about using it correctly. Therefore, ignore STATIC_CONST_CHAR_ARRAY. Related: https://gerrit.osmocom.org/c/osmo-bsc/+/42729/comment/f3bc5254_5f30d1bb/ Change-Id: Iae0d3ff4ca648d6a3b6ca0f7805ec18e50befa80 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index de14044..50551b0 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -77,6 +77,7 @@ # * SPDX_LICENSE_TAG: we don't place it on line 1 # * SPLIT_STRING: we do split long messages over multiple lines # * SSCANF_TO_KSTRTO: kernel specific +# * STATIC_CONST_CHAR_ARRAY: incompatible with DEFUN_* API from libosmocore # * STRING_FRAGMENTS: sometimes used intentionally to improve readability # * SYMBOLIC_PERMS: recommends using octal permissions over symbolic ones, not followed # * TRACING_LOGGING: recommends to use kernel's internal ftrace instead of printf("%s()\n", __func__) @@ -116,6 +117,7 @@ --ignore SPDX_LICENSE_TAG \ --ignore SPLIT_STRING \ --ignore SSCANF_TO_KSTRTO \ + --ignore STATIC_CONST_CHAR_ARRAY \ --ignore STRING_FRAGMENTS \ --ignore SYMBOLIC_PERMS \ --ignore TRACING_LOGGING \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42731?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iae0d3ff4ca648d6a3b6ca0f7805ec18e50befa80 Gerrit-Change-Number: 42731 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ci[master]: lint/checkpatch: ignore STATIC_CONST_CHAR_ARRAY
by laforge 06 May '26

06 May '26

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42731?usp=email ) Change subject: lint/checkpatch: ignore STATIC_CONST_CHAR_ARRAY ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42731?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iae0d3ff4ca648d6a3b6ca0f7805ec18e50befa80 Gerrit-Change-Number: 42731 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 May 2026 07:42:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bsc[master]: gsm_set_bts_type(): fix switch statement
by laforge 06 May '26

06 May '26

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42728?usp=email ) Change subject: gsm_set_bts_type(): fix switch statement ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42728?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibf500c373b69a69182885d5e700abc6fb1b03ccd Gerrit-Change-Number: 42728 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Wed, 06 May 2026 07:41:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log May 2026