May 2026 - gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: card_key_provider: move boiler-plate code into helper functions
by dexter 07 May '26

07 May '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42734?usp=email ) Change subject: card_key_provider: move boiler-plate code into helper functions ...................................................................... card_key_provider: move boiler-plate code into helper functions in pySim-shell.py we add the commandline options for the card key provider and do the setup accordingly. Let's put this boilerplate code into helper functions instead, so that we can re-use it in other pySim programs as well. Let's use pySim.transport as a pattern. Related: SYS#6959 Change-Id: I6d095cbb644e608f4a751a1d0749b1484cdc781d --- M pySim-shell.py M pySim/card_key_provider.py 2 files changed, 53 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/34/42734/1 diff --git a/pySim-shell.py b/pySim-shell.py index bd7d0c0..aba1a6a 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -69,8 +69,8 @@ from pySim.gsm_r import DF_EIRENE from pySim.cat import ProactiveCommand -from pySim.card_key_provider import CardKeyProviderCsv, CardKeyProviderPgsql -from pySim.card_key_provider import card_key_provider_register, card_key_provider_get_field, card_key_provider_get +from pySim.card_key_provider import argparse_add_card_key_provider_args, init_card_key_provider +from pySim.card_key_provider import card_key_provider_get_field, card_key_provider_get from pySim.app import init_card @@ -1143,18 +1143,6 @@ global_group.add_argument("--verbose", help="Enable verbose logging", action='store_true', default=False) -card_key_group = option_parser.add_argument_group('Card Key Provider Options') -card_key_group.add_argument('--csv', metavar='FILE', - default="~/.osmocom/pysim/card_data.csv", - help='Read card data from CSV file') -card_key_group.add_argument('--pgsql', metavar='FILE', - default="~/.osmocom/pysim/card_data_pgsql.cfg", - help='Read card data from PostgreSQL database (config file)') -card_key_group.add_argument('--csv-column-key', metavar='FIELD:AES_KEY_HEX', default=[], action='append', - help=argparse.SUPPRESS, dest='column_key') -card_key_group.add_argument('--column-key', metavar='FIELD:AES_KEY_HEX', default=[], action='append', - help='per-column AES transport key', dest='column_key') - adm_group = global_group.add_mutually_exclusive_group() adm_group.add_argument('-a', '--pin-adm', metavar='PIN_ADM1', dest='pin_adm', default=None, help='ADM PIN used for provisioning (overwrites default)') @@ -1167,6 +1155,7 @@ help="A pySim-shell command that would optionally be executed at startup") option_parser.add_argument('command_args', nargs=argparse.REMAINDER, help="Optional Arguments for command") +argparse_add_card_key_provider_args(option_parser) if __name__ == '__main__': startup_errors = False @@ -1175,16 +1164,8 @@ # Ensure that we are able to print formatted warnings from the beginning. PySimLogger.setup(print, {logging.WARN: YELLOW}, opts.verbose) - # Register csv-file as card data provider, either from specified CSV - # or from CSV file in home directory - column_keys = {} - for par in opts.column_key: - name, key = par.split(':') - column_keys[name] = key - if os.path.isfile(os.path.expanduser(opts.csv)): - card_key_provider_register(CardKeyProviderCsv(os.path.expanduser(opts.csv), column_keys)) - if os.path.isfile(os.path.expanduser(opts.pgsql)): - card_key_provider_register(CardKeyProviderPgsql(os.path.expanduser(opts.pgsql), column_keys)) + # Init card key provider for automatic card key retrieval + init_card_key_provider(opts) # Init card reader driver sl = init_reader(opts, proactive_handler = Proact()) diff --git a/pySim/card_key_provider.py b/pySim/card_key_provider.py index 2403694..f4aec0f 100644 --- a/pySim/card_key_provider.py +++ b/pySim/card_key_provider.py @@ -33,10 +33,12 @@ from osmocom.utils import h2b, b2h from pySim.log import PySimLogger +import os import abc import csv import logging import yaml +import argparse log = PySimLogger.get(__name__) @@ -130,6 +132,14 @@ cipher = AES.new(h2b(self.transport_keys[field_name.upper()]), AES.MODE_CBC, self.__IV) return b2h(cipher.encrypt(h2b(plaintext_val))) + @staticmethod + def argparse_add_args(arg_parser: argparse.ArgumentParser): + arg_parser.add_argument('--column-key', metavar='FIELD:AES_KEY_HEX', default=[], action='append', + help='per-column AES transport key', dest='column_key') + # Depprecated argument, replaced by --column-key (see above) + arg_parser.add_argument('--csv-column-key', metavar='FIELD:AES_KEY_HEX', default=[], action='append', + help=argparse.SUPPRESS, dest='column_key') + class CardKeyProvider(abc.ABC): """Base class, not containing any concrete implementation.""" @@ -148,6 +158,15 @@ fond None shall be returned. """ + @staticmethod + def argparse_add_args(arg_parser: argparse.ArgumentParser): + """ + Add the commandline arguments relevant for this card key provider. + + Args: + arg_parser : argument parser group + """ + def __str__(self): return type(self).__name__ @@ -188,6 +207,12 @@ return None return return_dict + @staticmethod + def argparse_add_args(arg_parser: argparse.ArgumentParser): + arg_parser.add_argument('--csv', metavar='FILE', + default="~/.osmocom/pysim/card_data.csv", + help='Read card data from CSV file') + class CardKeyProviderPgsql(CardKeyProvider): """Card key provider implementation that allows to query against a specified PostgreSQL database table.""" @@ -252,6 +277,11 @@ result[k] = self.crypt.decrypt_field(k, result.get(k)) return result + @staticmethod + def argparse_add_args(arg_parser: argparse.ArgumentParser): + arg_parser.add_argument('--pgsql', metavar='FILE', + default="~/.osmocom/pysim/card_data_pgsql.cfg", + help='Read card data from PostgreSQL database (config file)') def card_key_provider_register(provider: CardKeyProvider, provider_list=card_key_providers): """Register a new card key provider. @@ -303,3 +333,21 @@ fields = [field] result = card_key_provider_get(fields, key, value, card_key_providers) return result.get(field.upper()) + +def argparse_add_card_key_provider_args(arg_parser: argparse.ArgumentParser): + """Add card key provider commandline options to the given argument parser""" + card_key_group = arg_parser.add_argument_group('Card Key Provider Options') + CardKeyProviderCsv.argparse_add_args(card_key_group) + CardKeyProviderPgsql.argparse_add_args(card_key_group) + CardKeyFieldCryptor.argparse_add_args(card_key_group) + +def init_card_key_provider(opts: argparse.Namespace): + """Initialize card key provider depending on the user provided commandline options""" + column_keys = {} + for par in opts.column_key: + name, key = par.split(':') + column_keys[name] = key + if os.path.isfile(os.path.expanduser(opts.csv)): + card_key_provider_register(CardKeyProviderCsv(os.path.expanduser(opts.csv), column_keys)) + if os.path.isfile(os.path.expanduser(opts.pgsql)): + card_key_provider_register(CardKeyProviderPgsql(os.path.expanduser(opts.pgsql), column_keys)) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42734?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6d095cbb644e608f4a751a1d0749b1484cdc781d Gerrit-Change-Number: 42734 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: card_key_provider: pass CardKeyFieldCryptor to constructor
by dexter 07 May '26

07 May '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42735?usp=email ) Change subject: card_key_provider: pass CardKeyFieldCryptor to constructor ...................................................................... card_key_provider: pass CardKeyFieldCryptor to constructor We currently create the CardKeyFieldCryptor object inside the constructor of the concrete CardKeyProvider classes. There is currently no problem with that, but when we create the CardKeyFieldCryptor object first and then pass it as parameter to the constructor, we gain more flexibility in case we want to support other CardKeyFieldCryptor variants in the future. Related: SYS#6959 Change-Id: If43552740aadacab9126f8a002749a9582eef8f4 --- M pySim/card_key_provider.py M tests/unittests/test_card_key_provider.py 2 files changed, 11 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/35/42735/1 diff --git a/pySim/card_key_provider.py b/pySim/card_key_provider.py index f4aec0f..ecf8c40 100644 --- a/pySim/card_key_provider.py +++ b/pySim/card_key_provider.py @@ -173,18 +173,18 @@ class CardKeyProviderCsv(CardKeyProvider): """Card key provider implementation that allows to query against a specified CSV file.""" - def __init__(self, csv_filename: str, transport_keys: dict): + def __init__(self, csv_filename: str, field_cryptor: CardKeyFieldCryptor): """ Args: csv_filename : file name (path) of CSV file containing card-individual key/data - transport_keys : (see class CardKeyFieldCryptor) + field_cryptor : (see class CardKeyFieldCryptor) """ log.info("Using CSV file as card key data source: %s" % csv_filename) self.csv_file = open(csv_filename, 'r') if not self.csv_file: raise RuntimeError("Could not open CSV file '%s'" % csv_filename) self.csv_filename = csv_filename - self.crypt = CardKeyFieldCryptor(transport_keys) + self.crypt = field_cryptor def get(self, fields: List[str], key: str, value: str) -> Dict[str, str]: self.csv_file.seek(0) @@ -216,11 +216,11 @@ class CardKeyProviderPgsql(CardKeyProvider): """Card key provider implementation that allows to query against a specified PostgreSQL database table.""" - def __init__(self, config_filename: str, transport_keys: dict): + def __init__(self, config_filename: str, field_cryptor: CardKeyFieldCryptor): """ Args: config_filename : file name (path) of CSV file containing card-individual key/data - transport_keys : (see class CardKeyFieldCryptor) + field_cryptor : (see class CardKeyFieldCryptor) """ import psycopg2 log.info("Using SQL database as card key data source: %s" % config_filename) @@ -237,7 +237,7 @@ host=config.get('host')) self.tables = config.get('table_names') log.info("Card key database tables: %s" % str(self.tables)) - self.crypt = CardKeyFieldCryptor(transport_keys) + self.crypt = field_cryptor def get(self, fields: List[str], key: str, value: str) -> Dict[str, str]: import psycopg2 @@ -347,7 +347,8 @@ for par in opts.column_key: name, key = par.split(':') column_keys[name] = key + card_key_field_cryptor = CardKeyFieldCryptor(transport_keys) if os.path.isfile(os.path.expanduser(opts.csv)): - card_key_provider_register(CardKeyProviderCsv(os.path.expanduser(opts.csv), column_keys)) + card_key_provider_register(CardKeyProviderCsv(os.path.expanduser(opts.csv), card_key_field_cryptor)) if os.path.isfile(os.path.expanduser(opts.pgsql)): - card_key_provider_register(CardKeyProviderPgsql(os.path.expanduser(opts.pgsql), column_keys)) + card_key_provider_register(CardKeyProviderPgsql(os.path.expanduser(opts.pgsql), card_key_field_cryptor)) diff --git a/tests/unittests/test_card_key_provider.py b/tests/unittests/test_card_key_provider.py index 121998c..a70394a 100644 --- a/tests/unittests/test_card_key_provider.py +++ b/tests/unittests/test_card_key_provider.py @@ -20,7 +20,8 @@ "KIK3" : "00010204040506070809488B0C0D0E0F"} csv_file_path = os.path.dirname(os.path.abspath(__file__)) + "/test_card_key_provider.csv" - card_key_provider_register(CardKeyProviderCsv(csv_file_path, column_keys)) + card_key_field_cryptor = CardKeyFieldCryptor(column_keys) + card_key_provider_register(CardKeyProviderCsv(csv_file_path, card_key_field_cryptor)) super().__init__(*args, **kwargs) def test_card_key_provider_get(self): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42735?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If43552740aadacab9126f8a002749a9582eef8f4 Gerrit-Change-Number: 42735 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: vty: update help string for nokia_site model
by pespin 06 May '26

06 May '26

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42732?usp=email ) Change subject: vty: update help string for nokia_site model ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42732?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8a2d91aacc984e6a818f9782e728674306f4ebe4 Gerrit-Change-Number: 42732 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Wed, 06 May 2026 19:33:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bsc[master]: nokia: rename vty settings, drop _site
by pespin 06 May '26

06 May '26

Attention is currently required from: falconia, laforge. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42730?usp=email ) Change subject: nokia: rename vty settings, drop _site ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42730?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I807c0ad14f4436a21f0be0a5ed291539cd4af7e8 Gerrit-Change-Number: 42730 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 06 May 2026 19:33:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bsc[master]: gsm_set_bts_type(): fix switch statement
by pespin 06 May '26

06 May '26

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42728?usp=email ) Change subject: gsm_set_bts_type(): fix switch statement ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42728?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibf500c373b69a69182885d5e700abc6fb1b03ccd Gerrit-Change-Number: 42728 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Wed, 06 May 2026 19:30:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bsc[master]: nokia: rename vty settings, drop _site
by falconia 06 May '26

06 May '26

Attention is currently required from: laforge. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42730?usp=email ) Change subject: nokia: rename vty settings, drop _site ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > I tend to agree with those changes more than with the general rename of the BTS_MODEL, as all change […] At the present moment every one of Nokia-specific vty settings applies equally to both Site and Flexi families - but calling them "nokia" rather than "nokia_site" is shorter and clearer. Furthermore, some of the changes, while strictly applicable to both, were needed primarily for Flexi MR - and I easily foresee the possibility of new vty settings that will be meaningful only for Flexi MR or newer BTS. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42730?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I807c0ad14f4436a21f0be0a5ed291539cd4af7e8 Gerrit-Change-Number: 42730 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 06 May 2026 16:35:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-bsc[master]: vty: update help string for nokia_site model
by falconia 06 May '26

06 May '26

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42732?usp=email ) Change subject: vty: update help string for nokia_site model ...................................................................... vty: update help string for nokia_site model Original Nokia BTS support in OsmoBSC was limited to MetroSite, UltraSite and InSite, aka the Site family. After the recent series of fixes, the same code also supports Flexi Multiradio (actively used in the present) and will most likely also work on Flexi EDGE (intermediate between UltraSite and Flexi MR), although that model is currently untested. BTS model name "nokia_site" is thus outdated and inaccurate now. It has been decided (see https://gerrit.osmocom.org/c/osmo-bsc/+/42729) to keep this model name unchanged for now, given the uncertainty of how Nokia BTS support will evolve in the future if and when we implement support for IP Abis on Flexi family, potentially followed by future support for subsequent IP-only models. In the meantime, change vty help string to reflect current support for both Site and Flexi families with the same model selection. Change-Id: I8a2d91aacc984e6a818f9782e728674306f4ebe4 --- M src/osmo-bsc/bts.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/32/42732/1 diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index d295bfd..d070774 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -78,7 +78,7 @@ { GSM_BTS_TYPE_BS11, "Siemens BTS (BS-11 or compatible)" }, { GSM_BTS_TYPE_NANOBTS, "ip.access nanoBTS or compatible" }, { GSM_BTS_TYPE_RBS2000, "Ericsson RBS2000 Series" }, - { GSM_BTS_TYPE_NOKIA_SITE, "Nokia {Metro,Ultra,In}Site" }, + { GSM_BTS_TYPE_NOKIA_SITE, "Nokia Site and Flexi families" }, { GSM_BTS_TYPE_OSMOBTS, "Osmocom Base Transceiver Station" }, { 0, NULL } }; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42732?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8a2d91aacc984e6a818f9782e728674306f4ebe4 Gerrit-Change-Number: 42732 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0

[M] Change in osmo-bsc[master]: nokia: rename vty settings, drop _site
by falconia 06 May '26

06 May '26

Attention is currently required from: falconia, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/42730?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: nokia: rename vty settings, drop _site ...................................................................... nokia: rename vty settings, drop _site All Nokia-specific vty settings previously had names beginning with nokia_site, creating needless confusion for operators of Nokia BTS models that are newer than *Site family. Rename these vty settings to begin with just nokia, with nokia_site supported as a backward compatibility alias. Change-Id: I807c0ad14f4436a21f0be0a5ed291539cd4af7e8 --- M src/osmo-bsc/bts_vty.c 1 file changed, 57 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/30/42730/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42730?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I807c0ad14f4436a21f0be0a5ed291539cd4af7e8 Gerrit-Change-Number: 42730 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-bsc[master]: nokia: rename BTS model from nokia_site to nokia-e1
by falconia 06 May '26

06 May '26

Attention is currently required from: laforge. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42729?usp=email ) Change subject: nokia: rename BTS model from nokia_site to nokia-e1 ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I think this is probably an unneccessary change, and one thet will be reverted if and when you ever […] Upon further thought, I agree with your reasoning. We can indeed live with the outdated model name while we are uncertain as to exactly what will happen if and when we add support for IP dialect of Nokia Abis. I will replace this patch with a smaller one that changes only vty help text for nokia_site model selection. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42729?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3e993bda577964922e29dbbaf9554fa53bb2d445 Gerrit-Change-Number: 42729 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 06 May 2026 15:24:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-trx[master]: convolve: avoid function pointer casts by adding wrapper functions
by Timur Davydov 06 May '26

06 May '26

Attention is currently required from: Hoernchen, laforge. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42655?usp=email ) Change subject: convolve: avoid function pointer casts by adding wrapper functions ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > I'm not an expert in this part of the code but .... […] Changing `_base_convolve_complex` to return void would indeed be simpler in isolation. However, it is used by `base_convolve_complex()`, which in turn is called from `convolve()` in sigProcLib.c. So changing its return type would propagate further up the call chain and potentially affect other code. To avoid a broader impact, I preferred to keep the existing return type and align the declarations instead. The only alternative (without introducing wrapper functions) would be to also make all `sse_conv_cmplx_*` and `sse_conv_real_*` functions return `len`, or to refactor all call sites of `_base_convolve_complex` / `_base_convolve_real` to stop relying on the return value and use `len` directly instead. If you have a preferred approach here, I’m happy to rework it accordingly. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42655?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Idecb118be285eb3e4691d1761d0d8fa24fd80c75 Gerrit-Change-Number: 42655 Gerrit-PatchSet: 4 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 06 May 2026 14:43:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log May 2026