May 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bsc[master]: vty: update help string for nokia_site model
by laforge 08 May '26

08 May '26

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42732?usp=email ) Change subject: vty: update help string for nokia_site model ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42732?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8a2d91aacc984e6a818f9782e728674306f4ebe4 Gerrit-Change-Number: 42732 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 08 May 2026 08:25:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: cosmetic: remove excess linebreaks
by laforge 08 May '26

08 May '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42733?usp=email ) Change subject: cosmetic: remove excess linebreaks ...................................................................... Patch Set 1: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42733?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2272abcdbba0e57c5118b69bc9398cd909a469b5 Gerrit-Change-Number: 42733 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 May 2026 08:24:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: cosmetic: remove excess linebreaks
by osmith 08 May '26

08 May '26

Attention is currently required from: dexter. osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42733?usp=email ) Change subject: cosmetic: remove excess linebreaks ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/42733/comment/ebcc38d7_40bcf949?usp=em… : PS1, Line 10: difficult to maintain consistence with that scheme. Note that PEP 8 says: > Surround top-level function and class definitions with two blank lines. https://peps.python.org/pep-0008/#blank-lines We use `ruff format` in some projects to have that consistently, e.g. testenv in osmo-ttcn3-hacks. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42733?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2272abcdbba0e57c5118b69bc9398cd909a469b5 Gerrit-Change-Number: 42733 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 May 2026 08:15:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-bsc[master]: gsm_set_bts_type(): fix switch statement
by laforge 07 May '26

07 May '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42728?usp=email ) Change subject: gsm_set_bts_type(): fix switch statement ...................................................................... gsm_set_bts_type(): fix switch statement The switch statement on (bts->type) in this function exhibited two defects: 1) From the beginning, each unhandled BTS type was listed explicitly, instead of providing a default case; 2) When Nokia-specific initialization was added in 2015, the addition was erroneously applied to GSM_BTS_TYPE_BS11 and GSM_BTS_TYPE_UNKNOWN cases, besides the intended case of GSM_BTS_TYPE_NOKIA_SITE. Fixes: 56e1766dba1a03e304e51d079e65406542e7887c Change-Id: Ibf500c373b69a69182885d5e700abc6fb1b03ccd --- M src/osmo-bsc/bts.c 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 2ec4865..d295bfd 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -742,14 +742,12 @@ INIT_LLIST_HEAD(&bts->rbs2000.is.conn_groups); INIT_LLIST_HEAD(&bts->rbs2000.con.conn_groups); break; - case GSM_BTS_TYPE_BS11: - case GSM_BTS_TYPE_UNKNOWN: case GSM_BTS_TYPE_NOKIA_SITE: /* Set default BTS reset timer */ bts->nokia.bts_reset_timer_cnf = 15; /* Enable Rx diversity by default, for backward compat */ bts->nokia.rx_diversity = 1; - case _NUM_GSM_BTS_TYPE: + default: break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42728?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibf500c373b69a69182885d5e700abc6fb1b03ccd Gerrit-Change-Number: 42728 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bsc[master]: nokia: rename vty settings, drop _site
by laforge 07 May '26

07 May '26

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42730?usp=email ) Change subject: nokia: rename vty settings, drop _site ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42730?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I807c0ad14f4436a21f0be0a5ed291539cd4af7e8 Gerrit-Change-Number: 42730 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Thu, 07 May 2026 19:20:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in pysim[master]: pySim/global_platform: make functionality available outside of cmd2
by laforge 07 May '26

07 May '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42741?usp=email ) Change subject: pySim/global_platform: make functionality available outside of cmd2 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I don't really like the approach to expose lots of functions at the module that are not part of some kind of object-oriented code / classes. This looks like C code and quite un-pythonic to me, and I think we need a better architecture for this. It's almost like the pySim.commands.SimCardCommands what we're adding here. We possibly need something more modular where differnt modules (like global_platform here) can implement (and register?) a class containing methods for various commands? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42741?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idf4e4b58bf49ba62b2c22de4c49a2dcacfa872cb Gerrit-Change-Number: 42741 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 May 2026 19:20:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in pysim[master]: pySim/scp: migrate to pySimLogger
by laforge 07 May '26

07 May '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42740?usp=email ) Change subject: pySim/scp: migrate to pySimLogger ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42740?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5db7180f93f116dd2d99c33da264f74ea16a1a37 Gerrit-Change-Number: 42740 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 May 2026 19:15:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pySim/filesystem: use pySimLogger instead of print
by laforge 07 May '26

07 May '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42739?usp=email ) Change subject: pySim/filesystem: use pySimLogger instead of print ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42739?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3a7188ad33706df66b2113e15cc7d06004c9bc39 Gerrit-Change-Number: 42739 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 May 2026 19:15:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: pySim/app: use pySimLogger instead of print
by laforge 07 May '26

07 May '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42738?usp=email ) Change subject: pySim/app: use pySimLogger instead of print ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42738?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95b4536cc8853e7ba6a5dd573b903dfb85e56b9a Gerrit-Change-Number: 42738 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 May 2026 19:15:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pySimLogger: fix default log format string
by laforge 07 May '26

07 May '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42737?usp=email ) Change subject: pySimLogger: fix default log format string ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42737?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3951a70ad6ce864a7158b093cba46ae9fc1cb5bd Gerrit-Change-Number: 42737 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 May 2026 19:14:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log May 2026