Attention is currently required from: fixeria, neels.
laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40825?usp=email )
Change subject: personalization: add int as input type for BinaryParameter
......................................................................
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40825?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I31d8142cb0847a8b291f8dc614d57cb4734f0190
Gerrit-Change-Number: 40825
Gerrit-PatchSet: 10
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 08 May 2026 08:33:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, neels.
laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41918?usp=email )
Change subject: ConfigurableParameter: do not magically overwrite the 'name' attribute
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/41918/comment/fddc3b06_a58ea1e1?usp=em… :
PS2, Line 7: Co
> I apologized out-of-band for the emotional outburst, let me repeat this here: sorry for the rant. […]
so can we get a summary of the rationale in the commit log then?
Historical remark on why it was writtne how it is before this patch: I personally enjoy automati/automagic things very much and prefer to reduce code size/boilerplate in favour of auto-generation whenever possible.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41918?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6f631444c6addeb7ccc5f6c55b9be3dc83409169
Gerrit-Change-Number: 41918
Gerrit-PatchSet: 6
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 08 May 2026 08:32:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, neels.
laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40208?usp=email )
Change subject: personalization: implement UppAudit and BatchAudit
......................................................................
Patch Set 11: Code-Review+1
(1 comment)
File pySim/esim/saip/batch.py:
https://gerrit.osmocom.org/c/pysim/+/40208/comment/92da3694_f3fa7ccd?usp=em… :
PS11, Line 143: {'001010000000023'}
why is a set returned? and if a set is returned, to what do multiple instances relate? If this is about an EF.IMSI in multiple NAA (like one USIM and one ISIM) then I think the NAA should be named rather than assuming any implicit ordering. Theoretically a eSIM profile could also contain multiple instances of a USIM NAA, as far as I can tell.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40208?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iaab336ca91b483ecdddd5c6c8e08dc475dc6bd0a
Gerrit-Change-Number: 40208
Gerrit-PatchSet: 11
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 08 May 2026 08:29:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42732?usp=email )
Change subject: vty: update help string for nokia_site model
......................................................................
vty: update help string for nokia_site model
Original Nokia BTS support in OsmoBSC was limited to MetroSite,
UltraSite and InSite, aka the Site family. After the recent series
of fixes, the same code also supports Flexi Multiradio (actively
used in the present) and will most likely also work on Flexi EDGE
(intermediate between UltraSite and Flexi MR), although that model
is currently untested.
BTS model name "nokia_site" is thus outdated and inaccurate now.
It has been decided (see https://gerrit.osmocom.org/c/osmo-bsc/+/42729)
to keep this model name unchanged for now, given the uncertainty
of how Nokia BTS support will evolve in the future if and when
we implement support for IP Abis on Flexi family, potentially
followed by future support for subsequent IP-only models.
In the meantime, change vty help string to reflect current support
for both Site and Flexi families with the same model selection.
Change-Id: I8a2d91aacc984e6a818f9782e728674306f4ebe4
---
M src/osmo-bsc/bts.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c
index d295bfd..d070774 100644
--- a/src/osmo-bsc/bts.c
+++ b/src/osmo-bsc/bts.c
@@ -78,7 +78,7 @@
{ GSM_BTS_TYPE_BS11, "Siemens BTS (BS-11 or compatible)" },
{ GSM_BTS_TYPE_NANOBTS, "ip.access nanoBTS or compatible" },
{ GSM_BTS_TYPE_RBS2000, "Ericsson RBS2000 Series" },
- { GSM_BTS_TYPE_NOKIA_SITE, "Nokia {Metro,Ultra,In}Site" },
+ { GSM_BTS_TYPE_NOKIA_SITE, "Nokia Site and Flexi families" },
{ GSM_BTS_TYPE_OSMOBTS, "Osmocom Base Transceiver Station" },
{ 0, NULL }
};
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42732?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8a2d91aacc984e6a818f9782e728674306f4ebe4
Gerrit-Change-Number: 42732
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>