Attention is currently required from: Timur Davydov.
laforge has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email )
Change subject: trx, bts: add optional WebSDR backend (callback-based transport)
......................................................................
Patch Set 12: Code-Review-1
(1 comment)
Patchset:
PS12:
still too many ifdefs in comon code
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Idebd588f33afd85021813ad5821391781db683a9
Gerrit-Change-Number: 42703
Gerrit-PatchSet: 12
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Tue, 12 May 2026 10:25:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Timur Davydov.
laforge has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42700?usp=email )
Change subject: build: add WebSDR configure option and Emscripten detection
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42700?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iff4b76e339e2873686c8c15885dd498458ceb546
Gerrit-Change-Number: 42700
Gerrit-PatchSet: 7
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Tue, 12 May 2026 10:24:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Timur Davydov.
laforge has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42696?usp=email )
Change subject: trx: split TRXD parsing from socket callback
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42696?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I50ad8b6d2edfd91f2d569cd8badf5c036fbf87ed
Gerrit-Change-Number: 42696
Gerrit-PatchSet: 7
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Tue, 12 May 2026 10:23:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42741?usp=email )
Change subject: pySim/global_platform: make functionality available outside of cmd2
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> I don't really like the approach to expose lots of functions at the module that are not part of some […]
I am also not so convinced with the current approach. We need to find something that allows us to decouple the business logic (global platform, lchan, etc.) from the user interface (cmd2)
My first idea would be to have an abstract base class that accepts an lchan via its constructor. The lchan, can then be accessed by methods implemented by a specific class. With such a base class we could implement all kinds of utility classes. And it would be a simple scheme.
I have also tried to explore an alternative where we would separate the nested AddlShellCommands from the ADF_SD class. I thought we then could keep the business logic method (the ones we have currently split aside) inside ADF_SD to access them from the AddlShellCommands, which is now outside. Unfortunately this quickly becomes a mess since the lchan object is somewhere in the _cmd object and that only exists in AddlShellCommands. We could pass a reference to the ADF_SD object and access the methods by passing the lchan object from the AddlShellCommands object, but that would be also not a clean solution. I think removing the dependency to cmd2 on that level is very complicated.
Which path do you think we should take?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42741?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Idf4e4b58bf49ba62b2c22de4c49a2dcacfa872cb
Gerrit-Change-Number: 42741
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 12 May 2026 09:01:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: fixeria.
dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42674?usp=email )
Change subject: personalization: fix EF_SMSP length, alpha_id padding
......................................................................
Patch Set 5: Code-Review+1
(4 comments)
Patchset:
PS5:
As far as I can see this patch is almost ready for merging. Since we do not need to set the alpha id here anymore I would recommend to re-align the patch a bit. Otherwise everything should be fine.
PS5:
> I think this might possibly no longer be needed with https://gerrit.osmocom. […]
One still has to ensure to pass the file length (total_len=f_smsp.rec_len) to encode_record_hex. So this patch is still relevant.
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/42674/comment/95fb4454_44ae9b00?usp=em… :
PS5, Line 637: ef_smsp_dec['alpha_id'] = ''
With (I0ec99b2648b22c56f9145345e4cd8776f9217701, already merged), setting the alpha id is optional. You could remove this line and it would still work.
https://gerrit.osmocom.org/c/pysim/+/42674/comment/50a07c90_d3a63b55?usp=em… :
PS5, Line 638: f_smsp.rec_len = 42
Keep in mind that this hardcoded value (42) must be consistent with the file length assigned in the PE. But as far as I remember we already discussed that and found that the generator would ensure the consistency. I just wanted to remind you to be sure.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42674?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ief6e02517f3e96158a2509d763b88aec4bd5a296
Gerrit-Change-Number: 42674
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 11 May 2026 09:12:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42736?usp=email )
Change subject: card_key_provider: add a static method to parse --column-keys args
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42736?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic955f271b1de1b1b855b21c82ed10343044e45fa
Gerrit-Change-Number: 42736
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 10 May 2026 17:56:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42735?usp=email )
Change subject: card_key_provider: pass CardKeyFieldCryptor to constructor
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42735?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: If43552740aadacab9126f8a002749a9582eef8f4
Gerrit-Change-Number: 42735
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 10 May 2026 17:56:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Timur Davydov, laforge.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email
to look at the new patch set (#12).
The following approvals got outdated and were removed:
Code-Review-1 by laforge, Verified+1 by Jenkins Builder
Change subject: trx, bts: add optional WebSDR backend (callback-based transport)
......................................................................
trx, bts: add optional WebSDR backend (callback-based transport)
Introduce WebSDR backend enabled via ENABLE_WEBSDR,
adding an alternative callback-based transport alongside
existing socket-based TRX/OSMUX I/O
Implement:
- TRX control via osmotrxlib_process_command()
- TRXD data via apitrx_tx_call()/trx_data_read()
- clock handling via apibts_clock_ind() and external timers
- Osmux integration via ws_osmux_* helpers
Adapt scheduler to support API-based burst submission and
external timer callbacks in WebSDR mode
Disable signal handling, stats and socket I/O when building
with ENABLE_WEBSDR
Add WebSDR API entrypoint, Emscripten build target and
example configuration
Enables running BTS/TRX stack in WebAssembly environments
Change-Id: Idebd588f33afd85021813ad5821391781db683a9
---
M .gitignore
A doc/examples/trx/osmo-bts-trx-websdr.cfg
M src/common/main.c
M src/common/osmux.c
M src/osmo-bts-trx/Makefile.am
M src/osmo-bts-trx/main.c
A src/osmo-bts-trx/osmo-bts-trx-websdr.c
A src/osmo-bts-trx/osmo-bts-trx-websdr.h
M src/osmo-bts-trx/scheduler_trx.c
M src/osmo-bts-trx/trx_if.c
M src/osmo-bts-trx/trx_vty.c
11 files changed, 722 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/03/42703/12
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Idebd588f33afd85021813ad5821391781db683a9
Gerrit-Change-Number: 42703
Gerrit-PatchSet: 12
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>