Attention is currently required from: daniel, laforge, lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42746?usp=email )
Change subject: Radical reduce the asn1 code to the essential parts
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
AFAIU if our ASN1 files are the same as the ones in wireshark, so in that case if asn1c fails to decode a correct packet then we should be fixing asn1c we use the generate the code, instead of reducing the amount of TCAP being decoded.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42746?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: Ib8afe0dbe8d4436b80c71048f3b572fcda6cd33e
Gerrit-Change-Number: 42746
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 13 May 2026 20:13:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42741?usp=email )
Change subject: pySim/global_platform: make functionality available outside of cmd2
......................................................................
Patch Set 3:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42741?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Idf4e4b58bf49ba62b2c22de4c49a2dcacfa872cb
Gerrit-Change-Number: 42741
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 13 May 2026 16:28:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42747?usp=email )
Change subject: pySim/ara_m, cosmetic: swap --nfc-always and --nfc-never options
......................................................................
pySim/ara_m, cosmetic: swap --nfc-always and --nfc-never options
The commandline options --nfc-always and --nfc-never appear in the
opposite order when compared to --apdu-never and --apdu-always.
Let's swap the options to make the helpscreen and the code more
consistent.
Change-Id: I7289c3628b1b8dd3eec2f1c8f2132e3015422960
Related: SYS#6959
---
M pySim/ara_m.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/47/42747/1
diff --git a/pySim/ara_m.py b/pySim/ara_m.py
index e1c26f6..6fc0e20 100644
--- a/pySim/ara_m.py
+++ b/pySim/ara_m.py
@@ -334,10 +334,10 @@
apdu_grp.add_argument(
'--apdu-filter', help='APDU filter: multiple groups of 8 hex bytes (4 byte CLA/INS/P1/P2 followed by 4 byte mask)')
nfc_grp = store_ref_ar_do_parse.add_mutually_exclusive_group()
- nfc_grp.add_argument('--nfc-always', action='store_true',
- help='NFC event access is allowed')
nfc_grp.add_argument('--nfc-never', action='store_true',
help='NFC event access is not allowed')
+ nfc_grp.add_argument('--nfc-always', action='store_true',
+ help='NFC event access is allowed')
store_ref_ar_do_parse.add_argument(
'--android-permissions', help='Android UICC Carrier Privilege Permissions (8 hex bytes)')
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42747?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7289c3628b1b8dd3eec2f1c8f2132e3015422960
Gerrit-Change-Number: 42747
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: lynxis lazus.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743?usp=email )
Change subject: tests: improve test infrastructure to support multiple test vectors
......................................................................
Patch Set 2:
(2 comments)
File tests/parse/tcap_parse_test.c:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/11f84b10_457… :
PS2, Line 51: printf("Decoding testvector no %i - %s\n", i, testvectors[i].name);
Use %d instead of %i
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/04d0c550_84e… :
PS2, Line 54: if (rc.code != RC_OK) {
braces {} are not necessary for any arm of this statement
--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: I4a69167647dd0a8eb650b4c7cc47fd97928ebf5d
Gerrit-Change-Number: 42743
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 13 May 2026 16:04:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42745?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: tests: add decode tests for TCAP End tests
......................................................................
tests: add decode tests for TCAP End tests
Change-Id: I5679c4a873176d73e973f5cfccff796fe6dbd941
---
M tests/parse/tcap_parse_test.c
M tests/parse/tcap_parse_test.ok
2 files changed, 33 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/45/42745/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42745?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: I5679c4a873176d73e973f5cfccff796fe6dbd941
Gerrit-Change-Number: 42745
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743?usp=email )
Change subject: tests: improve test infrastructure to support multiple test vectors
......................................................................
Patch Set 1:
(2 comments)
File tests/parse/tcap_parse_test.c:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/f86ef24d_e92… :
PS1, Line 51: printf("Decoding testvector no %i - %s\n", i, testvectors[i].name);
Use %d instead of %i
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/3af280d9_e17… :
PS1, Line 54: if (rc.code != RC_OK) {
braces {} are not necessary for any arm of this statement
--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: I4a69167647dd0a8eb650b4c7cc47fd97928ebf5d
Gerrit-Change-Number: 42743
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Wed, 13 May 2026 15:55:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No