Attention is currently required from: daniel, laforge, lynxis lazus, pespin.
Hello Jenkins Builder, daniel, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: tcap loadshare: allow to define the fallback mechanism for unroutable TCAP messages
......................................................................
tcap loadshare: allow to define the fallback mechanism for unroutable TCAP messages
When a TCAP Continue/End/Abort message is received, but no TCAP session entry can be found
and no valid TCAP range is available for the dtid, the message can be either:
- rejected by returning an error with udts
- routed by round robin to all available ASP of this AS
To define the behaviour, a new vty option is introduced:
```
tcap-unroutable-sessions (reject-udts | load-share-over-as)
```
Defaults to reject-udts.
Related: SYS#5432
Change-Id: Ic1c876da30b05065a476d3a7c1bbf0680adf55bd
---
M src/ss7_as.c
M src/ss7_as.h
M src/ss7_as_vty.c
M src/tcap_as_loadshare.c
4 files changed, 52 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/60/42760/5
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ic1c876da30b05065a476d3a7c1bbf0680adf55bd
Gerrit-Change-Number: 42760
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42764?usp=email )
Change subject: vty-tests: remove help from expected output
......................................................................
vty-tests: remove help from expected output
Until the vty tests support regex, remove the help message
as it depends on the compile option TCAP Routing and can't
handle both compile options.
It will be re-introduced later
Change-Id: I0d8141c00525f49c0a9f9f63b73fee531f591e5c
---
M tests/vty/osmo_stp_test_tcap.vty
1 file changed, 0 insertions(+), 25 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/64/42764/1
diff --git a/tests/vty/osmo_stp_test_tcap.vty b/tests/vty/osmo_stp_test_tcap.vty
index 3085074..7afd197 100644
--- a/tests/vty/osmo_stp_test_tcap.vty
+++ b/tests/vty/osmo_stp_test_tcap.vty
@@ -20,28 +20,3 @@
tcap-routing
no tcap-routing
...
-
-OsmoSTP(config-cs7-as)# ?
- help Description of the interactive help system
- list Print command list
- show Show running system information
- write Write running configuration to memory, network, or terminal
- exit Exit current mode and down to previous mode
- end End current mode and change to enable mode.
- description Save human-readable description of the object
- asp Specify that a given ASP is part of this AS
- no Negate a command or set its defaults
- traffic-mode Specifies traffic mode of operation of the ASP within the AS
- sls-shift Shift SLS bits used during routing decision
- tcap-routing Enable TCAP-based routing when in traffic-mode loadshare
- binding-table AS Loadshare binding table operations
- recovery-timeout Specifies RFC4666 recovery timer T(r) timeout
- qos-class Specity QoS Class of AS
- routing-key Define a routing key
- point-code Point Code Specific Features
-
-OsmoSTP(config-cs7-as)# no ?
- asp Specify ASP to be removed from this AS
- traffic-mode Remove explicit traffic mode of operation of this AS
- tcap-routing Disable TCAP-based routing when in traffic-mode loadshare
- point-code Point Code Specific Features
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42764?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I0d8141c00525f49c0a9f9f63b73fee531f591e5c
Gerrit-Change-Number: 42764
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: daniel, laforge, pespin.
Hello Jenkins Builder, daniel, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: tcap loadshare: allow to define the fallback mechanism for unroutable TCAP messages
......................................................................
tcap loadshare: allow to define the fallback mechanism for unroutable TCAP messages
When a TCAP Continue/End/Abort message is received, but no TCAP session entry can be found
and no valid TCAP range is available for the dtid, the message can be either:
- rejected by returning an error with UTDS
- routed by round robin to all available ASP of this AS
To define the behaviour, a new vty option is introduced:
```
tcap-unroutable-sessions (reject-utds | load-share-over-as)
```
Defaults to reject-utds.
Related: SYS#5432
Change-Id: Ic1c876da30b05065a476d3a7c1bbf0680adf55bd
---
M src/ss7_as.c
M src/ss7_as.h
M src/ss7_as_vty.c
M src/tcap_as_loadshare.c
4 files changed, 52 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/60/42760/4
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ic1c876da30b05065a476d3a7c1bbf0680adf55bd
Gerrit-Change-Number: 42760
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42765?usp=email )
Change subject: vty-tests: Re-introduce the check on the help
......................................................................
vty-tests: Re-introduce the check on the help
With the support of regex within vty tests,
the help message can be checked again.
Depends-on: Iadcd7a8c3677548a6405e098fe53d0614ef2012c (osmo-python-tests)
Change-Id: I3fad268b7a8925f378f6331fcab073637bd80e08
---
M tests/vty/osmo_stp_test_tcap.vty
1 file changed, 25 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/65/42765/1
diff --git a/tests/vty/osmo_stp_test_tcap.vty b/tests/vty/osmo_stp_test_tcap.vty
index 7afd197..2f6f9ae 100644
--- a/tests/vty/osmo_stp_test_tcap.vty
+++ b/tests/vty/osmo_stp_test_tcap.vty
@@ -20,3 +20,28 @@
tcap-routing
no tcap-routing
...
+
+OsmoSTP(config-cs7-as)# ?
+!r![ ]+help [ ]+Description of the interactive help system
+!r![ ]+list [ ]+Print command list
+!r![ ]+show [ ]+Show running system information
+!r![ ]+write [ ]+Write running configuration to memory, network, or terminal
+!r![ ]+exit [ ]+Exit current mode and down to previous mode
+!r![ ]+end [ ]+End current mode and change to enable mode.
+!r![ ]+description [ ]+Save human-readable description of the object
+!r![ ]+asp [ ]+Specify that a given ASP is part of this AS
+!r![ ]+no [ ]+Negate a command or set its defaults
+!r![ ]+traffic-mode[ ]+Specifies traffic mode of operation of the ASP within the AS
+!r![ ]+sls-shift [ ]+Shift SLS bits used during routing decision
+...
+!r![ ]+binding-table [ ]+AS Loadshare binding table operations
+!r![ ]+recovery-timeout[ ]+Specifies RFC4666 recovery timer T\(r\) timeout
+!r![ ]+qos-class [ ]+Specity QoS Class of AS
+!r![ ]+routing-key [ ]+Define a routing key
+!r![ ]+point-code [ ]+Point Code Specific Features
+
+OsmoSTP(config-cs7-as)# no ?
+ asp Specify ASP to be removed from this AS
+ traffic-mode Remove explicit traffic mode of operation of this AS
+ tcap-routing Disable TCAP-based routing when in traffic-mode loadshare
+ point-code Point Code Specific Features
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42765?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I3fad268b7a8925f378f6331fcab073637bd80e08
Gerrit-Change-Number: 42765
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: daniel, laforge, neels, osmith.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/42762?usp=email )
Change subject: osmo_interact: improve vty transcript language by a regular rexex
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/python/osmo-python-tests/+/42762/comment/09fb1… :
PS1, Line 17: E.g.
> Can you show the actual match line that would match both indents as an example?
Done
--
To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/42762?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Change-Id: Iadcd7a8c3677548a6405e098fe53d0614ef2012c
Gerrit-Change-Number: 42762
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 26 May 2026 10:00:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: laforge, lynxis lazus, neels, osmith.
Hello Jenkins Builder, daniel, laforge, neels, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/python/osmo-python-tests/+/42762?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by osmith
Change subject: osmo_interact: improve vty transcript language by a regular rexex
......................................................................
osmo_interact: improve vty transcript language by a regular rexex
Currently the transcript language understand 3 different tokens:
... (ignore all lines until the following line matches)
... !REGEX (ignore all lines except REXEX)
But to support osmo-stp with different compile options, the
vty help is indented with different amount of spaces depending on the compile options.
To support those add a regular regex using the prefix !r!
E.g.
```
OsmoSTP(config-cs7-as)# ?
- description Save human-readable description of the object
vs
+ description Save human-readable description of the object
```
To use the new regex, the line would be:
```
!r! description[ ]+Save human-readable description of the object
```
Further all regex special characters needs to be escaped.
```
description Save human-readable description of the object (for humans)
!r! description[ ]+Save human-readable description of the object \(for humans\)
```
Change-Id: Iadcd7a8c3677548a6405e098fe53d0614ef2012c
---
M osmopy/osmo_interact/common.py
1 file changed, 15 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests refs/changes/62/42762/2
--
To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/42762?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Change-Id: Iadcd7a8c3677548a6405e098fe53d0614ef2012c
Gerrit-Change-Number: 42762
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: Hoernchen, laforge, neels, osmith.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42625?usp=email )
Change subject: osmo-smdpp.py: fix path Traversal Bypass in SM-DP+ (CWE-22)
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
@neels and @laforge: I would suggest to filter the MatchinID according to SGP.22, section 4.1.1, but I am worried about compatibility. Please let me know what you think. (see also comment).
File osmo-smdpp.py:
https://gerrit.osmocom.org/c/pysim/+/42625/comment/b1cc06b0_dc56c827?usp=em… :
PS1, Line 643: if os.path.commonprefix((os.path.realpath(path),self.upp_dir)) != self.upp_dir:
> The commit message doesn't make sense, given that there is `os.path. […]
Thanks for testing this. I didn't test it. I trusted the report as it seemed plausible.
In any case I think we should approach the problem differently. SGP.22, section 4.1.1 has a clear assumption on how a MachingID should look like. The spec is very clear that a MatchingID should only contain 0-9, A-Z, "-" and nothing else. We could just filter correctly and be free of all worries.
Unfortunately we have incompatible file names in the /smdp-data/upp directory. So we may either rename those files or use a less strict filter.
As a compromise, we could allow a-z, ., and _ in addition.
What do you think?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42625?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7a42b40aa2bbcd5f0ec99f172503354c6eaa9828
Gerrit-Change-Number: 42625
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 26 May 2026 09:51:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: laforge, lynxis lazus, neels.
daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/42762?usp=email )
Change subject: osmo_interact: improve vty transcript language by a regular rexex
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/python/osmo-python-tests/+/42762/comment/46edd… :
PS1, Line 17: E.g.
Can you show the actual match line that would match both indents as an example?
--
To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/42762?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Change-Id: Iadcd7a8c3677548a6405e098fe53d0614ef2012c
Gerrit-Change-Number: 42762
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 26 May 2026 09:18:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No