May 2026 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-asn1-tcap[master]: tests: split tests into own functions
by fixeria 14 May '26

14 May '26

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42744?usp=email ) Change subject: tests: split tests into own functions ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42744?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: If9db94d17e288875fdaed52ec95b3785a78d5fa6 Gerrit-Change-Number: 42744 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 14 May 2026 13:01:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-asn1-tcap[master]: tests: improve test infrastructure to support multiple test vectors
by fixeria 14 May '26

14 May '26

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743?usp=email ) Change subject: tests: improve test infrastructure to support multiple test vectors ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I4a69167647dd0a8eb650b4c7cc47fd97928ebf5d Gerrit-Change-Number: 42743 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 14 May 2026 13:00:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in libosmo-asn1-tcap[master]: Radical reduce the asn1 code to the essential parts
by fixeria 14 May '26

14 May '26

Attention is currently required from: daniel, laforge, lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42746?usp=email ) Change subject: Radical reduce the asn1 code to the essential parts ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > @pespin@sysmocom.de @laforge@osmocom. […] What's the point of having this library then? If only a small subset of TCAP is needed by osmo-stp, then it would have been easier to have the related files in libosmo-sigtran.git. -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42746?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: Ib8afe0dbe8d4436b80c71048f3b572fcda6cd33e Gerrit-Change-Number: 42746 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 14 May 2026 12:57:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XL] Change in libosmo-asn1-tcap[master]: Radical reduce the asn1 code to the essential parts
by lynxis lazus 14 May '26

14 May '26

Attention is currently required from: daniel, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42746?usp=email ) Change subject: Radical reduce the asn1 code to the essential parts ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Yes, parts of the asn1 files were taken from wireshark. […] @pespin@sysmocom.de @laforge@osmocom.org any opinion on reducing the asn1 files to the essential parts for tcap routing? Or should we take this library as general tcap decoder and because of it, I should fix the asn1 files? -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42746?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: Ib8afe0dbe8d4436b80c71048f3b572fcda6cd33e Gerrit-Change-Number: 42746 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 May 2026 06:46:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmo-asn1-tcap[master]: tests: add decode tests for TCAP End tests
by lynxis lazus 14 May '26

14 May '26

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42745?usp=email ) Change subject: tests: add decode tests for TCAP End tests ...................................................................... Patch Set 2: (1 comment) File tests/parse/tcap_parse_test.c: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42745/comment/4d894b23_791… : PS2, Line 34: static const unsigned char pkt_end_dialog_wo11_wo12[] = { 0x64, 0x06, 0x49, 0x04, 0x7f, 0xc2, 0x92, 0x3a}; > Same as older patch: can you paste here the decoded wireshark field tree? Acknowledged -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42745?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I5679c4a873176d73e973f5cfccff796fe6dbd941 Gerrit-Change-Number: 42745 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 May 2026 06:45:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-asn1-tcap[master]: tests: improve test infrastructure to support multiple test vectors
by lynxis lazus 14 May '26

14 May '26

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743?usp=email ) Change subject: tests: improve test infrastructure to support multiple test vectors ...................................................................... Patch Set 2: (3 comments) File tests/parse/tcap_parse_test.c: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/fac260d0_17a… : PS2, Line 18: #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) > we have an OSMO_ define for this already in libosmocore. […] No, it doesn't depend on any other libraries, not even libosmocore https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/43327a83_72b… : PS2, Line 30: static const unsigned char pkt_begin[] = {0x62, 0x06, 0x48, 0x04, 0x00, 0x01, 0x02, 0x03}; > Can you please put in the file as a comment the decoded tree by wireshark? Acknowledged https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/41dfdbaa_7a1… : PS2, Line 55: printf("Broken encoding %u at byte %lu\n", rc.code, rc.consumed); > broken decoding? Acknowledged -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I4a69167647dd0a8eb650b4c7cc47fd97928ebf5d Gerrit-Change-Number: 42743 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 May 2026 06:44:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in libosmo-asn1-tcap[master]: Radical reduce the asn1 code to the essential parts
by lynxis lazus 14 May '26

14 May '26

Attention is currently required from: daniel, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42746?usp=email ) Change subject: Radical reduce the asn1 code to the essential parts ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > AFAIU if our ASN1 files are the same as the ones in wireshark, so in that case if asn1c fails to dec […] Yes, parts of the asn1 files were taken from wireshark. But wireshark decodes it different (over multiple files) and in the end decodes it correct. I could try to fix the asn1 files, but because we don't need it and we should not take a such deep look into the packet from the TCAP routing case, I reduced it. -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42746?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: Ib8afe0dbe8d4436b80c71048f3b572fcda6cd33e Gerrit-Change-Number: 42746 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 May 2026 06:42:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-asn1-tcap[master]: tests: add decode tests for TCAP End tests
by pespin 13 May '26

13 May '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42745?usp=email ) Change subject: tests: add decode tests for TCAP End tests ...................................................................... Patch Set 2: (1 comment) File tests/parse/tcap_parse_test.c: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42745/comment/7a108386_fac… : PS2, Line 34: static const unsigned char pkt_end_dialog_wo11_wo12[] = { 0x64, 0x06, 0x49, 0x04, 0x7f, 0xc2, 0x92, 0x3a}; Same as older patch: can you paste here the decoded wireshark field tree? -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42745?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I5679c4a873176d73e973f5cfccff796fe6dbd941 Gerrit-Change-Number: 42745 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 13 May 2026 20:18:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmo-asn1-tcap[master]: tests: split tests into own functions
by pespin 13 May '26

13 May '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42744?usp=email ) Change subject: tests: split tests into own functions ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42744?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: If9db94d17e288875fdaed52ec95b3785a78d5fa6 Gerrit-Change-Number: 42744 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 13 May 2026 20:17:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-asn1-tcap[master]: tests: improve test infrastructure to support multiple test vectors
by pespin 13 May '26

13 May '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743?usp=email ) Change subject: tests: improve test infrastructure to support multiple test vectors ...................................................................... Patch Set 2: (3 comments) File tests/parse/tcap_parse_test.c: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/e8116201_63a… : PS2, Line 18: #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) we have an OSMO_ define for this already in libosmocore. Aren't we depending on libosmocore in this library? https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/efe7aeb7_c92… : PS2, Line 30: static const unsigned char pkt_begin[] = {0x62, 0x06, 0x48, 0x04, 0x00, 0x01, 0x02, 0x03}; Can you please put in the file as a comment the decoded tree by wireshark? https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/3cae7959_a0c… : PS2, Line 55: printf("Broken encoding %u at byte %lu\n", rc.code, rc.consumed); broken decoding? -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I4a69167647dd0a8eb650b4c7cc47fd97928ebf5d Gerrit-Change-Number: 42743 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 13 May 2026 20:15:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log May 2026