Attention is currently required from: lynxis lazus.

pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743?usp=email )

Change subject: tests: improve test infrastructure to support multiple test vectors ......................................................................

Patch Set 2:

(3 comments)

File tests/parse/tcap_parse_test.c:

https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/e8116201_63ac... : PS2, Line 18: #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) we have an OSMO_ define for this already in libosmocore. Aren't we depending on libosmocore in this library?

https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/efe7aeb7_c925... : PS2, Line 30: static const unsigned char pkt_begin[] = {0x62, 0x06, 0x48, 0x04, 0x00, 0x01, 0x02, 0x03}; Can you please put in the file as a comment the decoded tree by wireshark?

https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/3cae7959_a0c8... : PS2, Line 55: printf("Broken encoding %u at byte %lu\n", rc.code, rc.consumed); broken decoding?