Attention is currently required from: lynxis lazus.

View Change

3 comments:

• File tests/parse/tcap_parse_test.c:

  • Patch Set #2, Line 18: #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))

    we have an OSMO_ define for this already in libosmocore. Aren't we depending on libosmocore in this library?

  • Patch Set #2, Line 30: static const unsigned char pkt_begin[] = {0x62, 0x06, 0x48, 0x04, 0x00, 0x01, 0x02, 0x03};

    Can you please put in the file as a comment the decoded tree by wireshark?

  • Patch Set #2, Line 55: printf("Broken encoding %u at byte %lu\n", rc.code, rc.consumed);

    broken decoding?

To view, visit change 42743. To unsubscribe, or for help writing mail filters, visit settings.