May 2026 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: TCAP loadshare: allow to define the fallback mechanism for unroutable...
by lynxis lazus 27 May '26

27 May '26

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: TCAP loadshare: allow to define the fallback mechanism for unroutable TCAP messages ...................................................................... TCAP loadshare: allow to define the fallback mechanism for unroutable TCAP messages When a TCAP Continue/End/Abort message is received, but no TCAP session entry can be found and no valid TCAP range is available for the dtid, the message can be either: - rejected by returning an error with UTDS - routed by round robin to all available ASP of this AS To define the behaviour, a new vty option is introduced: ``` tcap-unroutable-sessions (reject-utds | load-share-over-as) ``` Defaults to reject-utds. Related: SYS#5432 Change-Id: Ic1c876da30b05065a476d3a7c1bbf0680adf55bd --- M src/ss7_as.c M src/ss7_as.h M src/ss7_as_vty.c M src/tcap_as_loadshare.c M tests/vty/osmo_stp_test.vty M tests/vty/osmo_stp_test_tcap.vty 6 files changed, 80 insertions(+), 31 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/60/42760/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic1c876da30b05065a476d3a7c1bbf0680adf55bd Gerrit-Change-Number: 42760 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmo-sigtran[master]: tcap loadshare: Add session miss counter
by daniel 27 May '26

27 May '26

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42758?usp=email ) Change subject: tcap loadshare: Add session miss counter ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42758?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I23319294e899e6acb6421d89675ce456048f7475 Gerrit-Change-Number: 42758 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 26 May 2026 07:51:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: TCAP loadshare: move last_asp_idx_sent from cfg to runtime struct
by lynxis lazus 27 May '26

27 May '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42761?usp=email ) Change subject: TCAP loadshare: move last_asp_idx_sent from cfg to runtime struct ...................................................................... TCAP loadshare: move last_asp_idx_sent from cfg to runtime struct The last_asp_idx_sent is a runtime information and not configurable. Move it to the other runtime state. Change-Id: Id52bb0f6c67949b5e03f7ad36996f37a0d25214a --- M src/ss7_as.h M src/tcap_as_loadshare.c 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/61/42761/1 diff --git a/src/ss7_as.h b/src/ss7_as.h index 8293e0c..877a4f0 100644 --- a/src/ss7_as.h +++ b/src/ss7_as.h @@ -133,6 +133,7 @@ /* TODO: the hash tables size might not be optimal */ DECLARE_HASHTABLE(trans_track_own, 10); DECLARE_HASHTABLE(trans_track_peer, 10); + struct ss7_as_asp_assoc *last_asp_idx_sent; } tcap; #endif /* WITH_TCAP_LOADSHARING */ @@ -179,7 +180,6 @@ struct { bool enabled; unsigned int timeout_s; - struct ss7_as_asp_assoc *last_asp_idx_sent; enum ss7_as_tcap_unroutable unroutable_tcap_msg; } tcap; #endif /* WITH_TCAP_LOADSHARING */ diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index dccf84f..9ffd4ee 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -259,7 +259,7 @@ struct ss7_as_asp_assoc *assoc; for (unsigned int i = 0; i < as->num_assoc_asps; i++) { - assoc = ss7_as_asp_assoc_llist_round_robin(as, &as->cfg.loadshare.tcap.last_asp_idx_sent); + assoc = ss7_as_asp_assoc_llist_round_robin(as, &as->tcap.last_asp_idx_sent); if (assoc && osmo_ss7_asp_active(assoc->asp) && assoc->asp->tcap.enabled) { if (fallback) rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FALLBACK); @@ -938,7 +938,7 @@ return; /* Update round robin state */ - ss7_as_del_asp_update_llist_round_robin(as, asp, &as->cfg.loadshare.tcap.last_asp_idx_sent); + ss7_as_del_asp_update_llist_round_robin(as, asp, &as->tcap.last_asp_idx_sent); _tcap_range_asp_down(as, asp); if (as->tcap.contains_pc || as->tcap.contains_ssn) tcap_range_as_update_pc_ssn(as); @@ -961,7 +961,7 @@ as->cfg.loadshare.tcap.enabled = false; as->tcap.contains_pc = false; as->tcap.contains_ssn = false; - as->cfg.loadshare.tcap.last_asp_idx_sent = NULL; + as->tcap.last_asp_idx_sent = NULL; tcap_trans_track_garbage_collect_stop(as); tcap_trans_track_entries_free_all(as); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42761?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id52bb0f6c67949b5e03f7ad36996f37a0d25214a Gerrit-Change-Number: 42761 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmo-sigtran[master]: tcap loadshare: count all ENOKEY as a FAILED
by pespin 27 May '26

27 May '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42756?usp=email ) Change subject: tcap loadshare: count all ENOKEY as a FAILED ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42756?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8bee6db5c75195855a3d378579e30886cd4d6fa8 Gerrit-Change-Number: 42756 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 22 May 2026 20:22:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-python-tests[master]: osmo_interact: improve vty transcript language by a regular rexex
by osmith 27 May '26

27 May '26

Attention is currently required from: laforge, lynxis lazus, neels. osmith has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/42762?usp=email ) Change subject: osmo_interact: improve vty transcript language by a regular rexex ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: Note: It would be nice to have the possible patterns documented in a location that is easy to find (not only inside code). File osmopy/osmo_interact/common.py: https://gerrit.osmocom.org/c/python/osmo-python-tests/+/42762/comment/52e0c… : PS1, Line 221: - If the line starts with '!r!' following the regex, but a exact match has priority ```suggestion - If the line starts with '!r!' following the regex, but a exact match has priority ``` -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/42762?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: Iadcd7a8c3677548a6405e098fe53d0614ef2012c Gerrit-Change-Number: 42762 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 26 May 2026 06:26:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: osmo-smdpp.py: use commonpath in transversal check
by osmith 27 May '26

27 May '26

Attention is currently required from: Hoernchen, dexter, laforge, neels. osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42625?usp=email ) Change subject: osmo-smdpp.py: use commonpath in transversal check ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42625?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7a42b40aa2bbcd5f0ec99f172503354c6eaa9828 Gerrit-Change-Number: 42625 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 May 2026 08:05:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: osmo-smdpp.py: use commonpath in transversal check
by osmith 27 May '26

27 May '26

Attention is currently required from: Hoernchen, dexter, laforge, neels. osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42625?usp=email ) Change subject: osmo-smdpp.py: use commonpath in transversal check ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File osmo-smdpp.py: https://gerrit.osmocom.org/c/pysim/+/42625/comment/4588c911_1ed085f5?usp=em… : PS1, Line 643: if os.path.commonprefix((os.path.realpath(path),self.upp_dir)) != self.upp_dir: > Olivers test misses the actual issue. […] thanks, you are right: ``` >>> upp_dir = "/tmp/path1" >>> path = "/tmp/path1234" >>> os.path.commonprefix((os.path.realpath(path), upp_dir)) == upp_dir True >>> os.path.commonpath((os.path.realpath(path), upp_dir)) == upp_dir False ``` updated the patch to do commonprefix -> commonpath. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42625?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7a42b40aa2bbcd5f0ec99f172503354c6eaa9828 Gerrit-Change-Number: 42625 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 May 2026 08:05:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: osmo-smdpp.py: use commonpath in transversal check
by osmith 27 May '26

27 May '26

Attention is currently required from: dexter, laforge, neels, osmith. osmith has uploaded a new patch set (#2) to the change originally created by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42625?usp=email ) The following approvals got outdated and were removed: Code-Review-1 by osmith, Verified+1 by Jenkins Builder Change subject: osmo-smdpp.py: use commonpath in transversal check ...................................................................... osmo-smdpp.py: use commonpath in transversal check Use commonpath, as commonprefix allows accessing a sibiling directory with the same prefix. Change-Id: I7a42b40aa2bbcd5f0ec99f172503354c6eaa9828 --- M osmo-smdpp.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/25/42625/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42625?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7a42b40aa2bbcd5f0ec99f172503354c6eaa9828 Gerrit-Change-Number: 42625 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-remsim[master]: Bump version: 1.1.3 → 1.2.0
by laforge 27 May '26

27 May '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42763?usp=email ) Change subject: Bump version: 1.1.3 → 1.2.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Icee7895ada6551f4805fc3da114655360698617e Gerrit-Change-Number: 42763 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 27 May 2026 07:55:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-asf4-dfu[master]: dfu: set poll timeout to 128 ms to reduce EPIPE errors
by laforge 27 May '26

27 May '26

Attention is currently required from: Hoernchen, lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42435?usp=email ) Change subject: dfu: set poll timeout to 128 ms to reduce EPIPE errors ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42435?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I4abe812e17194f37ce5d97fd1d866aeebd1d4239 Gerrit-Change-Number: 42435 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 27 May 2026 07:55:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log May 2026