May 2026 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: improve logging of lookup failures
by pespin 27 May '26

27 May '26

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42753?usp=email ) Change subject: tcap_as_loadshare: improve logging of lookup failures ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42753?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I80878dfd080c705de28175260cb392186dafed6a Gerrit-Change-Number: 42753 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 22 May 2026 20:18:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: tcap loadshare: allow to define the fallback mechanism for unroutable...
by lynxis lazus 27 May '26

27 May '26

Attention is currently required from: daniel, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email ) Change subject: tcap loadshare: allow to define the fallback mechanism for unroutable TCAP messages ...................................................................... Patch Set 3: (6 comments) Patchset: PS3: > why is VTY tests failing here? please explain. Answer in the thread above. PS3: > /unresolv it. The vty tests fails, because I'm adding a new command which contains more characters than all previous valid commands, which adds more indention to the help message. But I can't change the expected output to contain more spaces, because than this would fails when not compiling with tcap loadsharing. Only one of the build checks fails here Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760/comment/dc3afb20_338fa… : PS3, Line 19: Defaults to reject-utds. > udts (everywhere you wrote it) I was very consistent and wrote it everywhere the wrong way. will fix it. File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760/comment/f27bc9b0_873eb… : PS3, Line 257: static struct osmo_ss7_asp *select_asp_tcap_enabled_rr(struct osmo_ss7_as *as, bool fallback) > Having this param here only to tick a rate_ctr look weird tbh, I'd rather move this to the caller, a […] ok, will change it. https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760/comment/05064a26_273f3… : PS3, Line 555: if (!asp && as->cfg.loadshare.tcap.unroutable_tcap_msg == SS7_AS_TCAP_UNROUTABLE_LOAD_SHARE_AS) > else if (as->cfg.loadshare.tcap. […] Acknowledged https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760/comment/9b29106c_06f58… : PS3, Line 556: asp = select_asp_tcap_enabled_rr(as, true); > shouldn't we be adding a track_entry here (move the call above here) so that when an Abort/End for t […] yes, you're right. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic1c876da30b05065a476d3a7c1bbf0680adf55bd Gerrit-Change-Number: 42760 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 May 2026 07:43:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmo-sigtran[master]: TCAP loadshare: count all ENOKEY as a FAILED
by lynxis lazus 27 May '26

27 May '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42756?usp=email ) Change subject: TCAP loadshare: count all ENOKEY as a FAILED ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42756?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8bee6db5c75195855a3d378579e30886cd4d6fa8 Gerrit-Change-Number: 42756 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 22 May 2026 13:29:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in libosmo-sigtran[master]: tcap loadshare: count all ENOKEY as a FAILED
by daniel 27 May '26

27 May '26

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42756?usp=email ) Change subject: tcap loadshare: count all ENOKEY as a FAILED ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42756?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8bee6db5c75195855a3d378579e30886cd4d6fa8 Gerrit-Change-Number: 42756 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 26 May 2026 07:51:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: tcap loadshare: count all ENOKEY as a FAILED
by lynxis lazus 27 May '26

27 May '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42756?usp=email to look at the new patch set (#3). Change subject: tcap loadshare: count all ENOKEY as a FAILED ...................................................................... tcap loadshare: count all ENOKEY as a FAILED The ASP should count all message which couldn't routed as failed. Related: SYS#5432 Change-Id: I8bee6db5c75195855a3d378579e30886cd4d6fa8 --- M src/tcap_as_loadshare.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/56/42756/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42756?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8bee6db5c75195855a3d378579e30886cd4d6fa8 Gerrit-Change-Number: 42756 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in libosmo-sigtran[master]: ss7_as: fix indention
by daniel 27 May '26

27 May '26

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42757?usp=email ) Change subject: ss7_as: fix indention ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42757?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id006f4fcbf9ae6b5b50be3d41fb216c7f9bb2dfb Gerrit-Change-Number: 42757 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 26 May 2026 07:51:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tcap loadshare: Rework initial selection of a node
by lynxis lazus 27 May '26

27 May '26

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42755?usp=email ) Change subject: tcap loadshare: Rework initial selection of a node ...................................................................... Patch Set 3: (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42755/comment/8ef436c0_795cc… : PS3, Line 525: asp = select_asp_tcap_enabled_rr(as); > so does that mean tcap ranges provisioned over IPA extension are not used any more? They are still in use, but they are only used when the session tracking don't have an entry for an ongoing session, then the dtid will be used together with the TCAP ranges. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42755?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I151e6acb59e1f3c481487e76d2b01236fcee755f Gerrit-Change-Number: 42755 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 May 2026 07:34:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: ss7_as: fix indention
by pespin 27 May '26

27 May '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42757?usp=email ) Change subject: ss7_as: fix indention ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42757?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id006f4fcbf9ae6b5b50be3d41fb216c7f9bb2dfb Gerrit-Change-Number: 42757 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 22 May 2026 20:22:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: tcap loadshare: allow to define the fallback mechanism for unroutable...
by pespin 27 May '26

27 May '26

Attention is currently required from: daniel, laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email ) Change subject: tcap loadshare: allow to define the fallback mechanism for unroutable TCAP messages ...................................................................... Patch Set 3: (5 comments) Patchset: PS3: why is VTY tests failing here? please explain. Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760/comment/dd8e4618_b685a… : PS3, Line 19: Defaults to reject-utds. udts (everywhere you wrote it) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760/comment/cc9c8bbe_85f43… : PS3, Line 257: static struct osmo_ss7_asp *select_asp_tcap_enabled_rr(struct osmo_ss7_as *as, bool fallback) Having this param here only to tick a rate_ctr look weird tbh, I'd rather move this to the caller, and leave this helper without that kind of logic. https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760/comment/18dccdfc_73954… : PS3, Line 555: if (!asp && as->cfg.loadshare.tcap.unroutable_tcap_msg == SS7_AS_TCAP_UNROUTABLE_LOAD_SHARE_AS) else if (as->cfg.loadshare.tcap.unroutable_tcap_msg == SS7_AS_TCAP_UNROUTABLE_LOAD_SHARE_AS) https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760/comment/99f17b12_1227a… : PS3, Line 556: asp = select_asp_tcap_enabled_rr(as, true); shouldn't we be adding a track_entry here (move the call above here) so that when an Abort/End for the same session arrives it is actually delivered to the same place? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic1c876da30b05065a476d3a7c1bbf0680adf55bd Gerrit-Change-Number: 42760 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 22 May 2026 20:35:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-sigtran[master]: tcap loadshare: Rework initial selection of a node
by lynxis lazus 27 May '26

27 May '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42755?usp=email to look at the new patch set (#3). Change subject: tcap loadshare: Rework initial selection of a node ...................................................................... tcap loadshare: Rework initial selection of a node The original TCAP loadshare plan was to used the OTID of a TCAP Begin to select the node. However this should not be used anymore. Instead the correct one would be to do a load-sharing across all available ASP and keep this relation ("sticky" sessions). The counter SS7_AS_CTR_TCAP_ASP_FALLBACK will be re-used by a later patch. Related: SYS#5432 Change-Id: I151e6acb59e1f3c481487e76d2b01236fcee755f --- M src/tcap_as_loadshare.c 1 file changed, 6 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/55/42755/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42755?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I151e6acb59e1f3c481487e76d2b01236fcee755f Gerrit-Change-Number: 42755 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

1 0

2026

2025

2024

2023

2022

gerrit-log May 2026