May 2026 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: pySim/ts_51_011: rewrite comment for better understanding
by dexter 27 May '26

27 May '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42771?usp=email ) Change subject: pySim/ts_51_011: rewrite comment for better understanding ...................................................................... pySim/ts_51_011: rewrite comment for better understanding The comment reads like that we were applying TS 102.221 here, but we only mean our internal decoding format. The spec that actually matters here is TS 51.011. Let's rephrase the comment so that this becomes more clear. Related: OS#7018 Change-Id: Ie0184eea25f4d9f4baf9ab137c53a926edba2bf8 --- M pySim/ts_51_011.py 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/71/42771/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 89ff824..4cad049 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -1263,9 +1263,11 @@ @staticmethod def decode_select_response(resp_hex: str) -> object: - # we try to build something that resembles a dict resulting from the TLV decoder - # of TS 102.221 (FcpTemplate), so that higher-level code only has to deal with one - # format of SELECT response + """ + Decode the select response to a dict representation, similar to the one of TS 102.221 (see ts_102_221.py, + class FcpTemplate), so that higher-level code only has to deal with one respresentation. See also + 3GPP TS 51.011, section 9.2.1 + """ resp_bin = h2b(resp_hex) struct_of_file_map = { 0: 'transparent', -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42771?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie0184eea25f4d9f4baf9ab137c53a926edba2bf8 Gerrit-Change-Number: 42771 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: fix(ts_51_011): apply correct access conditions length
by dexter 27 May '26

27 May '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42772?usp=email ) Change subject: fix(ts_51_011): apply correct access conditions length ...................................................................... fix(ts_51_011): apply correct access conditions length When the access conditions are extracted from resp_bin, the wrong length is used and only 2 bytes instead of 3 are extracted. 3GPP TS 51.011, section 9.2.1, table below "Response parameters/data in case of an EF", clearly states that the length should be 3 bytes (position 9-11) Related: OS#7018 Change-Id: I410fb58c395beafba8de6d5ab4e71452f424cdf2 --- M pySim/ts_51_011.py M tests/unittests/test_decode_select_resp.py 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/72/42772/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 4cad049..24cf5c5 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -1305,7 +1305,7 @@ record_len = resp_bin[14] ret['file_descriptor']['record_len'] = record_len ret['file_descriptor']['num_of_rec'] = ret['file_size'] // record_len - ret['access_conditions'] = b2h(resp_bin[8:10]) + ret['access_conditions'] = b2h(resp_bin[8:11]) if resp_bin[11] & 0x01 == 0: ret['life_cycle_status_int'] = 'operational_activated' elif resp_bin[11] & 0x04: diff --git a/tests/unittests/test_decode_select_resp.py b/tests/unittests/test_decode_select_resp.py index bfb76cb..f8356f1 100644 --- a/tests/unittests/test_decode_select_resp.py +++ b/tests/unittests/test_decode_select_resp.py @@ -47,10 +47,10 @@ "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'df'}}, 'proprietary_info': {'available_memory': 0}, 'file_id': '7f10', 'file_characteristics': '81', 'num_direct_child_df': 0, 'num_direct_child_ef': 13, 'num_chv_unblock_adm_codes': 4}}, # EF.MSISDN {"resp_hex" : "000000346f40040011ffff0102011a", - "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'working_ef', 'structure': 'linear_fixed'}, 'record_len': 26, 'num_of_rec': 2}, 'proprietary_info': {}, 'file_id': '6f40', 'file_size': 52, 'access_conditions': '11ff', 'life_cycle_status_int': 'terminated'}}, + "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'working_ef', 'structure': 'linear_fixed'}, 'record_len': 26, 'num_of_rec': 2}, 'proprietary_info': {}, 'file_id': '6f40', 'file_size': 52, 'access_conditions': '11ffff', 'life_cycle_status_int': 'terminated'}}, # EF.ICCID {"resp_hex" : "0000000a2fe204000cffff01020000", - "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'working_ef', 'structure': 'transparent'}}, 'proprietary_info': {}, 'file_id': '2fe2', 'file_size': 10, 'access_conditions': '0cff', 'life_cycle_status_int': 'terminated'}}, + "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'working_ef', 'structure': 'transparent'}}, 'proprietary_info': {}, 'file_id': '2fe2', 'file_size': 10, 'access_conditions': '0cffff', 'life_cycle_status_int': 'terminated'}}, ] self.decode_select_response(CardProfileSIM, testcases) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42772?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I410fb58c395beafba8de6d5ab4e71452f424cdf2 Gerrit-Change-Number: 42772 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: fix(ts_51_011): fix lifecycle decoding
by dexter 27 May '26

27 May '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42773?usp=email ) Change subject: fix(ts_51_011): fix lifecycle decoding ...................................................................... fix(ts_51_011): fix lifecycle decoding - implement proper LCS decoding per TS 102 221 / TS 31.101 - previous implementation misclassified multiple states Related: OS#7018 Change-Id: I8a3bd820b9fbc13c025f8302d1d2eac21686c541 --- M pySim/ts_51_011.py M tests/unittests/test_decode_select_resp.py 2 files changed, 16 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/73/42773/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 24cf5c5..af7a433 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -1306,12 +1306,23 @@ ret['file_descriptor']['record_len'] = record_len ret['file_descriptor']['num_of_rec'] = ret['file_size'] // record_len ret['access_conditions'] = b2h(resp_bin[8:11]) - if resp_bin[11] & 0x01 == 0: + + # Life cycle status integer, see also ETSI TS 102 221, table 11.7b + lcsi = resp_bin[11] + if lcsi == 0x00: + ret['life_cycle_status_int'] = 'no_information' + elif lcsi == 0x01: + ret['life_cycle_status_int'] = 'creation' + elif lcsi == 0x03: + ret['life_cycle_status_int'] = 'initialization' + elif lcsi & 0xFD == 0x05: ret['life_cycle_status_int'] = 'operational_activated' - elif resp_bin[11] & 0x04: + elif lcsi & 0xFD == 0x04: ret['life_cycle_status_int'] = 'operational_deactivated' + elif lcsi & 0xFC == 0x0C: + ret['life_cycle_status_int'] = 'termination' else: - ret['life_cycle_status_int'] = 'terminated' + ret['life_cycle_status_int'] = lcsi return ret @classmethod diff --git a/tests/unittests/test_decode_select_resp.py b/tests/unittests/test_decode_select_resp.py index f8356f1..0533d5b 100644 --- a/tests/unittests/test_decode_select_resp.py +++ b/tests/unittests/test_decode_select_resp.py @@ -47,10 +47,10 @@ "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'df'}}, 'proprietary_info': {'available_memory': 0}, 'file_id': '7f10', 'file_characteristics': '81', 'num_direct_child_df': 0, 'num_direct_child_ef': 13, 'num_chv_unblock_adm_codes': 4}}, # EF.MSISDN {"resp_hex" : "000000346f40040011ffff0102011a", - "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'working_ef', 'structure': 'linear_fixed'}, 'record_len': 26, 'num_of_rec': 2}, 'proprietary_info': {}, 'file_id': '6f40', 'file_size': 52, 'access_conditions': '11ffff', 'life_cycle_status_int': 'terminated'}}, + "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'working_ef', 'structure': 'linear_fixed'}, 'record_len': 26, 'num_of_rec': 2}, 'proprietary_info': {}, 'file_id': '6f40', 'file_size': 52, 'access_conditions': '11ffff', 'life_cycle_status_int': 'creation'}}, # EF.ICCID {"resp_hex" : "0000000a2fe204000cffff01020000", - "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'working_ef', 'structure': 'transparent'}}, 'proprietary_info': {}, 'file_id': '2fe2', 'file_size': 10, 'access_conditions': '0cffff', 'life_cycle_status_int': 'terminated'}}, + "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'working_ef', 'structure': 'transparent'}}, 'proprietary_info': {}, 'file_id': '2fe2', 'file_size': 10, 'access_conditions': '0cffff', 'life_cycle_status_int': 'creation'}}, ] self.decode_select_response(CardProfileSIM, testcases) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42773?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8a3bd820b9fbc13c025f8302d1d2eac21686c541 Gerrit-Change-Number: 42773 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in pysim[master]: unittests: add testcases for decode_select_response
by dexter 27 May '26

27 May '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42770?usp=email ) Change subject: unittests: add testcases for decode_select_response ...................................................................... unittests: add testcases for decode_select_response A CardProfile class usually contains a static method decode_select_response. Unfortunately those methods have no unit-test coverage yet. Let's add unit tests for the decoders in CardProfileSIM and CardProfileUICC. Related: OS#7018 Change-Id: Id2b5e005d7ad30d56c5c936e612600213620a0ed --- A tests/unittests/test_decode_select_resp.py 1 file changed, 78 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/70/42770/1 diff --git a/tests/unittests/test_decode_select_resp.py b/tests/unittests/test_decode_select_resp.py new file mode 100644 index 0000000..bfb76cb --- /dev/null +++ b/tests/unittests/test_decode_select_resp.py @@ -0,0 +1,78 @@ +#!/usr/bin/env python3 + +# (C) 2026 by sysmocom - s.f.m.c. GmbH +# All Rights Reserved +# +# Author: Philipp Maier <pmaier(a)sysmocom.de> +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +import unittest +import os +from pySim.profile import CardProfile +from pySim.ts_51_011 import CardProfileSIM +from pySim.ts_102_221 import CardProfileUICC + +class TestDecodeSelectResponse_CardProfile(unittest.TestCase): + + def decode_select_response(self, card_Profile: CardProfile, testcases: list[dict]): + for testcase in testcases: + resp_hex = testcase['resp_hex'] + decoded = card_Profile.decode_select_response(resp_hex) + if testcase['decoded']: + self.assertEqual(decoded, testcase['decoded']) + else: + print("no testvector to compare against, assuming the following output is correct:") + print("resp_hex:", resp_hex) + print("decoded:", decoded) + + def test_CardProfileSIM(self): + testcases = [ + # MF + {"resp_hex" : "000000003f000100000000000981020c0400838a838a", + "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'mf'}}, 'proprietary_info': {'available_memory': 0}, 'file_id': '3f00', 'file_characteristics': '81', 'num_direct_child_df': 2, 'num_direct_child_ef': 12, 'num_chv_unblock_adm_codes': 4}}, + # DF.TELECOM + {"resp_hex" : "000000007f100200000000000981000d0400838a838a", + "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'df'}}, 'proprietary_info': {'available_memory': 0}, 'file_id': '7f10', 'file_characteristics': '81', 'num_direct_child_df': 0, 'num_direct_child_ef': 13, 'num_chv_unblock_adm_codes': 4}}, + # EF.MSISDN + {"resp_hex" : "000000346f40040011ffff0102011a", + "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'working_ef', 'structure': 'linear_fixed'}, 'record_len': 26, 'num_of_rec': 2}, 'proprietary_info': {}, 'file_id': '6f40', 'file_size': 52, 'access_conditions': '11ff', 'life_cycle_status_int': 'terminated'}}, + # EF.ICCID + {"resp_hex" : "0000000a2fe204000cffff01020000", + "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'working_ef', 'structure': 'transparent'}}, 'proprietary_info': {}, 'file_id': '2fe2', 'file_size': 10, 'access_conditions': '0cff', 'life_cycle_status_int': 'terminated'}}, + ] + self.decode_select_response(CardProfileSIM, testcases) + + def test_CardProfileUICC(self): + testcases = [ + # MF + {"resp_hex" : "622c8202782183023f00a50c80017183040003a7388701018a01058b032f0601c60c90016083010183010a83010b", + "decoded" : {'file_descriptor': {'file_descriptor_byte': {'shareable': True, 'file_type': 'df', 'structure': 'no_info_given'}, 'record_len': None, 'num_of_rec': None}, 'file_identifier': b'?\x00', 'proprietary_information': {'uicc_characteristics': b'q', 'available_memory': 239416, 'supported_filesystem_commands': {'terminal_capability': True}}, 'life_cycle_status_integer': 'operational_activated', 'security_attrib_referenced': {'ef_arr_file_id': b'/\x06', 'ef_arr_record_nr': 1}, 'pin_status_template_do': [{'ps_do': b'`'}, {'key_reference': 1}, {'key_reference': 10}, {'key_reference': 11}]}}, + # ADF.USIM + {"resp_hex" : "623d8202782183027fd0840ca0000000871002ff49ff0589a50c80017183040003a7388701018a01058b032f0601c60f90017083010183018183010a83010b", + "decoded" : {'file_descriptor': {'file_descriptor_byte': {'shareable': True, 'file_type': 'df', 'structure': 'no_info_given'}, 'record_len': None, 'num_of_rec': None}, 'file_identifier': b'\x7f\xd0', 'df_name': b'\xa0\x00\x00\x00\x87\x10\x02\xffI\xff\x05\x89', 'proprietary_information': {'uicc_characteristics': b'q', 'available_memory': 239416, 'supported_filesystem_commands': {'terminal_capability': True}}, 'life_cycle_status_integer': 'operational_activated', 'security_attrib_referenced': {'ef_arr_file_id': b'/\x06', 'ef_arr_record_nr': 1}, 'pin_status_template_do': [{'ps_do': b'p'}, {'key_reference': 1}, {'key_reference': 129}, {'key_reference': 10}, {'key_reference': 11}]}}, + # ADF.ISIM + {"resp_hex" : "623d8202782183027fb0840ca0000000871004ff49ff0589a50c80017183040003a7388701018a01058b032f0601c60f90017083010183018183010a83010b", + "decoded" : {'file_descriptor': {'file_descriptor_byte': {'shareable': True, 'file_type': 'df', 'structure': 'no_info_given'}, 'record_len': None, 'num_of_rec': None}, 'file_identifier': b'\x7f\xb0', 'df_name': b'\xa0\x00\x00\x00\x87\x10\x04\xffI\xff\x05\x89', 'proprietary_information': {'uicc_characteristics': b'q', 'available_memory': 239416, 'supported_filesystem_commands': {'terminal_capability': True}}, 'life_cycle_status_integer': 'operational_activated', 'security_attrib_referenced': {'ef_arr_file_id': b'/\x06', 'ef_arr_record_nr': 1}, 'pin_status_template_do': [{'ps_do': b'p'}, {'key_reference': 1}, {'key_reference': 129}, {'key_reference': 10}, {'key_reference': 11}]}}, + # EF.IMSI + {"resp_hex" : "62178202412183026f078a01058b036f060a80020009880138", + "decoded" : {'file_descriptor': {'file_descriptor_byte': {'shareable': True, 'file_type': 'working_ef', 'structure': 'transparent'}, 'record_len': None, 'num_of_rec': None}, 'file_identifier': b'o\x07', 'life_cycle_status_integer': 'operational_activated', 'security_attrib_referenced': {'ef_arr_file_id': b'o\x06', 'ef_arr_record_nr': 10}, 'file_size': 9, 'short_file_identifier': 7}}, + # EF.ECC + {"resp_hex" : "621a82054221000e0283026fb78a01058b036f06088002001c880108", + "decoded" : {'file_descriptor': {'file_descriptor_byte': {'shareable': True, 'file_type': 'working_ef', 'structure': 'linear_fixed'}, 'record_len': 14, 'num_of_rec': 2}, 'file_identifier': b'o\xb7', 'life_cycle_status_integer': 'operational_activated', 'security_attrib_referenced': {'ef_arr_file_id': b'o\x06', 'ef_arr_record_nr': 8}, 'file_size': 28, 'short_file_identifier': 1}}, + ] + self.decode_select_response(CardProfileUICC, testcases) + +if __name__ == "__main__": + unittest.main() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42770?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id2b5e005d7ad30d56c5c936e612600213620a0ed Gerrit-Change-Number: 42770 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in simtrace2[master]: firmware/Makefile: remove -Wredundant-decls
by fixeria 27 May '26

27 May '26

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/simtrace2/+/42769?usp=email ) Change subject: firmware/Makefile: remove -Wredundant-decls ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/42769?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I32ff78f2a27191d1c6e114429d2e0713674732fe Gerrit-Change-Number: 42769 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 May 2026 12:48:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in simtrace2[master]: firmware: replace libnewlib with picolibc
by fixeria 27 May '26

27 May '26

Attention is currently required from: laforge, lynxis lazus, osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/simtrace2/+/42768?usp=email ) Change subject: firmware: replace libnewlib with picolibc ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/42768?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: If136397b71435ea0850002ef6406067962e8d4d7 Gerrit-Change-Number: 42768 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 27 May 2026 12:47:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: personalization: implement UppAudit and BatchAudit
by neels 27 May '26

27 May '26

Attention is currently required from: fixeria, laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40208?usp=email ) Change subject: personalization: implement UppAudit and BatchAudit ...................................................................... Patch Set 11: (1 comment) File pySim/esim/saip/batch.py: https://gerrit.osmocom.org/c/pysim/+/40208/comment/34a51bb9_3d948ed1?usp=em… : PS11, Line 143: {'001010000000023'} > My point is: There are multiple constellations in which there could be multiple IMSIs. […] Ok, I wasn't aware of the possibility... An exception is not a good way to solve this, because it interrupts the audit. The audit should, without imposing constraints, show what it can find. The exception would happen in the code that evaluates the audit result. This is also used in ConfigurableParameters tests: on error, I get a missing/empty or mismatching value for a given parameter name, which the test then complains about after the entire audit is done. Multiple ADF.USIM opens a profound discussion on how the ConfigurableParameter API works: So far the idea is that there is a single value in a PES per ConfigurableParameter (that can occur multiple times). For ADF.USIM + ADF.ISIM, my first idea was to keep this current Imsi() ConfigurableParameter for USIM, and add a new ImsiIsim() for IMSIs kept in ADF-ISIM, but.. But you also mention multiple USIM entries, where each USIM would reflect separate data from identical PE structures. This is beyond the scope of the current API design: our ConfigurableParameters are not able to distinguish between different ADF-USIM. To support that, we need to refactor/enhance the ConfigurableParameter API to support selectors for different entries of the same name (like an ADF index?). My first idea is to pre-select subsections of a PES before applying ConfigurableParameter: For example, currently we have a flat list of params: BatchPersonalization().add_param_and_src(Imsi, IncDigitSource(...)) we could change it to a tree where each Imsi() has a reduced scope: BatchPersonalization().add_param_and_src_limited( limit_to={"adf":"usim", "index": 0}, Imsi, IncDigitSource(first_usim_imsi...)) BatchPersonalization().add_param_and_src_limited( limit_to={"adf":"usim", "index": 1}, Imsi, IncDigitSource(second_usim_imsi...)) BatchPersonalization().add_param_and_src_limited( limit_to={"adf":"isim"}, Imsi, IncDigitSource(isim_imsi...)) So that we pre-select the scope before applying the ConfigurableParameter instances, so that the ConfigurableParameter API does not need to know the difference. For the audit part, calling code could also pre-select a scope in which to perform the audit, then run two separate audits: one for USIM and one for ISIM. Simpler for audit: run one Imsi() across all ADF and expect a set of exactly the two IMSIs, without checking in detail whether each was in the expected place. (How to handle this would be up to the calling code) More complex idea: the audit could indicate in detail where it found the values, by some sort of xpath: instead of a set, return a dict like ~~~~ { 'IMSI': { 'usim[0]/ef-imsi': '098765432123456', 'usim[1]/ef-imsi': '098765432123457', 'isim[0]/ef-imsi': '987654345678765', }, 'IMSI-ACC': { 'usim[0]/ef-acc': '5', 'usim[1]/ef-acc': '5', 'isim[0]/ef-acc': '7', } } ~~~~ The caller can then still form a set() on the dict values to still follow the current logic, and can decide when to implement distinguishing by location. However, it would be much simpler for callers to first constrain to one "usim" and then run on the current logic that expects a single value. This design discussion is a bit out of place in a CR comment, because it has a larger scope than this patch. How important is the use case of multiple USIM in the same PES? -- all profiles I've seen so far have one ADF-USIM. When we continue this, I'll make a redmine issue and we should probably have a planning meeting first. Given that this code is in active use, my "tactical" decision would be to merge this as-is, accepting the constraints that we do not yet support multiple ADF.USIM, as simple fact of the initial ConfigurableParameter design that has been in pysim before I started. I would create a redmine issue to enhance the API as soon as we encounter the need to add support for multiple distinct ADF.USIM in practice. Does that make sense to CRers? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40208?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iaab336ca91b483ecdddd5c6c8e08dc475dc6bd0a Gerrit-Change-Number: 40208 Gerrit-PatchSet: 11 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 May 2026 12:46:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in simtrace2[master]: firmware: replace libnewlib with picolibc
by osmith 27 May '26

27 May '26

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/simtrace2/+/42768?usp=email ) Change subject: firmware: replace libnewlib with picolibc ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: I've verified that a debian package can be built for debian unstable with this. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/42768?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: If136397b71435ea0850002ef6406067962e8d4d7 Gerrit-Change-Number: 42768 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 May 2026 12:16:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in simtrace2[master]: firmware: replace libnewlib with picolibc
by osmith 27 May '26

27 May '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/42768?usp=email ) Change subject: firmware: replace libnewlib with picolibc ...................................................................... firmware: replace libnewlib with picolibc libnewlib-arm-none-eabi has been removed in debian unstable, build the firmware with picolibc instead. Fixes: OS#7017 Change-Id: If136397b71435ea0850002ef6406067962e8d4d7 --- M debian/control M firmware/Makefile 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/68/42768/1 diff --git a/debian/control b/debian/control index 75826be..c0e5a6f 100644 --- a/debian/control +++ b/debian/control @@ -12,7 +12,7 @@ dh-autoreconf, libosmocore-dev (>= 1.11.0), libpcsclite-dev, - libnewlib-arm-none-eabi, + picolibc-arm-none-eabi, libusb-1.0-0-dev, gcc-arm-none-eabi Standards-Version: 3.9.8 diff --git a/firmware/Makefile b/firmware/Makefile index 2f7a370..13f6bd2 100644 --- a/firmware/Makefile +++ b/firmware/Makefile @@ -171,6 +171,7 @@ INCLUDES += -Ilibosmocore/include INCLUDES += -Isrc_simtrace -Iinclude INCLUDES += -Iapps/$(APP) +INCLUDES += -I/usr/lib/picolibc/arm-none-eabi/include ifneq ("$(USE_CLANG)","0") CFLAGS += -Wno-unknown-warning-option -Wno-empty-body -fno-exceptions -fno-unwind-tables --config armv7em_soft_nofp_nosys -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/42768?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: If136397b71435ea0850002ef6406067962e8d4d7 Gerrit-Change-Number: 42768 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in simtrace2[master]: firmware/Makefile: remove -Wredundant-decls
by osmith 27 May '26

27 May '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/42769?usp=email ) Change subject: firmware/Makefile: remove -Wredundant-decls ...................................................................... firmware/Makefile: remove -Wredundant-decls picolibc has redundant declarations of free and strdtold, which results in lots of warnings with -Wredundant-decls. Adjust CFLAGS to remove -Wredundant-decls to make the compiler log more readable. /usr/lib/picolibc/arm-none-eabi/include/stdlib.h:147:9: warning: redundant redeclaration of 'free' [-Wredundant-decls] 147 | void free (void *) __nothrow; | ^~~~ /usr/lib/picolibc/arm-none-eabi/include/stdlib.h:99:9: note: previous declaration of 'free' with type 'void(void *)' 99 | void free (void *) __nothrow; | ^~~~ /usr/lib/picolibc/arm-none-eabi/include/stdlib.h:307:9: warning: redundant redeclaration of 'strtold' [-Wredundant-decls] 307 | strtold (const char *__restrict, char **__restrict); | ^~~~~~~ /usr/lib/picolibc/arm-none-eabi/include/stdlib.h:286:9: note: previous declaration of 'strtold' with type 'long double(const char * restrict, char ** restrict)' 286 | strtold (const char *__restrict __n, char **__restrict __end_PTR); | ^~~~~~~ Change-Id: I32ff78f2a27191d1c6e114429d2e0713674732fe --- M firmware/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/69/42769/1 diff --git a/firmware/Makefile b/firmware/Makefile index 13f6bd2..7692885 100644 --- a/firmware/Makefile +++ b/firmware/Makefile @@ -186,7 +186,7 @@ CFLAGS += -Waggregate-return #-Wsign-compare CFLAGS += -Wmissing-format-attribute -Wno-deprecated-declarations CFLAGS += #-Wpacked -CFLAGS += -Wredundant-decls -Wnested-externs #-Winline -Wlong-long +CFLAGS += -Wnested-externs #-Winline -Wlong-long -Wredundant-decls CFLAGS += -Wunreachable-code #CFLAGS += -Wcast-align #CFLAGS += -std=c11 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/42769?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I32ff78f2a27191d1c6e114429d2e0713674732fe Gerrit-Change-Number: 42769 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log May 2026