Attention is currently required from: daniel, laforge, lynxis lazus, neels, osmith.
Hello Jenkins Builder, daniel, laforge, neels, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/python/osmo-python-tests/+/42762?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by daniel, Code-Review+1 by laforge, Code-Review+2 by lynxis lazus, Verified+1 by Jenkins Builder
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: osmo_interact: improve vty transcript language by a regular rexex
......................................................................
osmo_interact: improve vty transcript language by a regular rexex
Currently the transcript language understand 3 different tokens:
... (ignore all lines until the following line matches)
... !REGEX (ignore all lines except REXEX)
But to support osmo-stp with different compile options, the
vty help is indented with different amount of spaces depending on the compile options.
To support those add a regular regex using the prefix !r!
E.g.
```
OsmoSTP(config-cs7-as)# ?
- description Save human-readable description of the object
vs
+ description Save human-readable description of the object
```
To use the new regex, the line would be:
```
!r! description[ ]+Save human-readable description of the object
```
Further all regex special characters needs to be escaped.
```
description Save human-readable description of the object (for humans)
!r! description[ ]+Save human-readable description of the object \(for humans\)
```
Change-Id: Iadcd7a8c3677548a6405e098fe53d0614ef2012c
---
M osmopy/osmo_interact/common.py
1 file changed, 16 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests refs/changes/62/42762/3
--
To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/42762?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Change-Id: Iadcd7a8c3677548a6405e098fe53d0614ef2012c
Gerrit-Change-Number: 42762
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: dexter.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/42770?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: unittests: add testcases for decode_select_response
......................................................................
unittests: add testcases for decode_select_response
A CardProfile class usually contains a static method decode_select_response.
Unfortunately those methods have no unit-test coverage yet. Let's add unit
tests for the decoders in CardProfileSIM and CardProfileUICC.
Related: OS#7018
Change-Id: Id2b5e005d7ad30d56c5c936e612600213620a0ed
---
A tests/unittests/test_decode_select_resp.py
1 file changed, 78 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/70/42770/2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42770?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id2b5e005d7ad30d56c5c936e612600213620a0ed
Gerrit-Change-Number: 42770
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42775?usp=email )
Change subject: C5G: Release UE Context before sending Service request
......................................................................
C5G: Release UE Context before sending Service request
A recent fix in Open5GS rejects RAN_UE_NGAP_ID in InitialUEMessage. This
causes all tests to fail that send a subsequent InitialUEMessage with
the same RAN_UE_NGAP_ID.
Release the UE Context before re-using the RAN_UE_NGAP_ID, because the
connection handler can only handle one context at a time.
Note that the AMF_UE_NGAP_ID is incremented by Open5GS for every
context.
This fixes:
TC_ue_service_request_cm_idle_inact_sess
TC_ue_service_request_cm_idle_ul_data
TC_ue_service_request_cm_idle_unknown_sess_active
Related: Open5GS Issues #4481
Change-Id: If6fae56487aebd810c51cbab170d95d5dec7e138
---
M 5gc/C5G_Tests.ttcn
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/75/42775/1
diff --git a/5gc/C5G_Tests.ttcn b/5gc/C5G_Tests.ttcn
index f1c46c8..a89d023 100644
--- a/5gc/C5G_Tests.ttcn
+++ b/5gc/C5G_Tests.ttcn
@@ -579,11 +579,14 @@
f_register();
f_pdu_sess_establish(configure_userplane := false);
+ f_sleep(1.0);
+ f_ue_context_release();
+ f_sleep(1.0);
pdu_session_status := f_PDU_SessionStatus();
f_service_request_cm_idle(ul_data_status := pdu_session_status,
pdu_sess_status := pdu_session_status);
- as_ngap_handle_PDUSessionResourceSetupReq();
+ as_ngap_handle_InitialCtxReq_withPDUSessionList();
NGAP.receive(cr_NG_SERVICE_ACCEPT(p_PDU_SessionStatus := cr_PDU_SessionStatus('00000010'B, '00000000'B)));
@@ -602,9 +605,15 @@
/* 3GPP TS 23.502 4.2.3.2 UE Triggered Service Request.
* UE signals that the active session is now inactive. AMF sends a PFCP Session Delete to SMF. */
private function f_TC_ue_service_request_cm_idle_inact_sess() runs on ConnHdlr {
+ var NGAP_PDU rx_ngap;
+
f_register();
f_pdu_sess_establish(configure_userplane := false);
+ f_sleep(1.0);
+ f_ue_context_release();
+ f_sleep(1.0);
f_service_request_cm_idle(pdu_sess_status := cs_PDU_SessionStatus('00000000'B, '00000000'B));
+ g_pars.ue_pars.amf_id := g_pars.ue_pars.amf_id + 1;
NGAP.receive(cr_NG_SERVICE_ACCEPT(p_PDU_SessionStatus := cr_PDU_SessionStatus('00000000'B, '00000000'B)));
f_deregister();
}
@@ -622,7 +631,11 @@
* UE signals that a session unknown to network is active: */
private function f_TC_ue_service_request_cm_idle_unknown_sess_active() runs on ConnHdlr {
f_register();
+ f_sleep(1.0);
+ f_ue_context_release();
+ f_sleep(1.0);
f_service_request_cm_idle(pdu_sess_status := cs_PDU_SessionStatus('00000010'B, '00000000'B));
+ g_pars.ue_pars.amf_id := g_pars.ue_pars.amf_id + 1;
NGAP.receive(cr_NG_SERVICE_ACCEPT(p_PDU_SessionStatus := cr_PDU_SessionStatus('00000000'B, '00000000'B)));
f_deregister();
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42775?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If6fae56487aebd810c51cbab170d95d5dec7e138
Gerrit-Change-Number: 42775
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>