Attention is currently required from: Hoernchen, dexter, laforge, neels.

osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42625?usp=email )

Change subject: osmo-smdpp.py: use commonpath in transversal check ......................................................................

Patch Set 1: Code-Review-1

(1 comment)

File osmo-smdpp.py:

https://gerrit.osmocom.org/c/pysim/+/42625/comment/4588c911_1ed085f5?usp=ema... : PS1, Line 643: if os.path.commonprefix((os.path.realpath(path),self.upp_dir)) != self.upp_dir:

Olivers test misses the actual issue. […]

thanks, you are right:

```

...

...

upp_dir = "/tmp/path1" path = "/tmp/path1234" os.path.commonprefix((os.path.realpath(path), upp_dir)) == upp_dir

True

...

...

os.path.commonpath((os.path.realpath(path), upp_dir)) == upp_dir

False ```

updated the patch to do commonprefix -> commonpath.