Attention is currently required from: Hoernchen, dexter, laforge, neels. osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42625?usp=email ) Change subject: osmo-smdpp.py: use commonpath in transversal check ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File osmo-smdpp.py: https://gerrit.osmocom.org/c/pysim/+/42625/comment/4588c911_1ed085f5?usp=ema... : PS1, Line 643: if os.path.commonprefix((os.path.realpath(path),self.upp_dir)) != self.upp_dir:
Olivers test misses the actual issue. […] thanks, you are right:
```
upp_dir = "/tmp/path1" path = "/tmp/path1234" os.path.commonprefix((os.path.realpath(path), upp_dir)) == upp_dir True os.path.commonpath((os.path.realpath(path), upp_dir)) == upp_dir False
updated the patch to do commonprefix -> commonpath.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42625?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7a42b40aa2bbcd5f0ec99f172503354c6eaa9828
Gerrit-Change-Number: 42625
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: Hoernchen <ewild@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Wed, 27 May 2026 08:05:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith@sysmocom.de>
Comment-In-Reply-To: Hoernchen <ewild@sysmocom.de>
Comment-In-Reply-To: dexter <pmaier@sysmocom.de>