Attention is currently required from: Hoernchen, dexter, laforge, neels.

Patch set 1:Code-Review -1

View Change

1 comment:

• File osmo-smdpp.py:

  • Patch Set #1, Line 643: if os.path.commonprefix((os.path.realpath(path),self.upp_dir)) != self.upp_dir:

    Olivers test misses the actual issue. […]

    thanks, you are right:

    ```
    >>> upp_dir = "/tmp/path1"
    >>> path = "/tmp/path1234"
    >>> os.path.commonprefix((os.path.realpath(path), upp_dir)) == upp_dir
    True
    >>> os.path.commonpath((os.path.realpath(path), upp_dir)) == upp_dir
    False
    ```

    updated the patch to do commonprefix -> commonpath.

To view, visit change 42625. To unsubscribe, or for help writing mail filters, visit settings.