Attention is currently required from: Timur Davydov, laforge, pespin.
fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42689?usp=email )
Change subject: build: remove unused sys/timerfd.h include
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
File src/osmo-bts-trx/scheduler_trx.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42689/comment/48376847_429df94c?usp=... :
PS2, Line 31: #ifdef HAVE_SYS_TIMERFD_H
: #include <sys/timerfd.h>
: #e
Yes, it makes sense. I moved this check after including btsconfig. […]
Done
File src/osmo-bts-trx/scheduler_trx.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42689/comment/b7426eb3_3427e3b2?usp=... :
PS3, Line 56: #endif
Right, the code builds fine without this header. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/42689?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id5a700c865f984e8f99199a1e365bb7f1462030a
Gerrit-Change-Number: 42689
Gerrit-PatchSet: 4
Gerrit-Owner: Timur Davydov
dtv.comp@gmail.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: Timur Davydov
dtv.comp@gmail.com
Gerrit-Comment-Date: Fri, 01 May 2026 20:06:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: Timur Davydov
dtv.comp@gmail.com
fixeria