lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[S] Change in pysim[master]: saip: fix key usage qualifier of helper created SD keys
by laforge 19 Nov '26

19 Nov '26
Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43723?usp=email ) Change subject: saip: fix key usage qualifier of helper created SD keys ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43723?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4a94562d6052c6796929b81b1f9b9ce5b56dcd20 Gerrit-Change-Number: 43723 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Nov 2026 00:48:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in pysim[master]: ota: argparse helpers for the SCP80 key set and SPI
by laforge 19 Nov '26

19 Nov '26
Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43720?usp=email ) Change subject: ota: argparse helpers for the SCP80 key set and SPI ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43720?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I599a07f7e4e100ddce91ee7eae70bab3cf9c07c1 Gerrit-Change-Number: 43720 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Nov 2026 00:47:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XL] Change in pysim[master]: cattp: ETSI TS 102 127 transport for OTA over BIP UDP
by laforge 19 Nov '26

19 Nov '26
Attention is currently required from: Hoernchen, dexter. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43719?usp=email ) Change subject: cattp: ETSI TS 102 127 transport for OTA over BIP UDP ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43719?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6f31493c1f0fb48fb3fd5382d8af2c905d365e54 Gerrit-Change-Number: 43719 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Nov 2026 00:47:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[L] Change in pysim[master]: ota: CAT_TP / TCP dialect of TS 102 225 secured packet
by laforge 19 Nov '26

19 Nov '26
Attention is currently required from: Hoernchen, dexter. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43717?usp=email ) Change subject: ota: CAT_TP / TCP dialect of TS 102 225 secured packet ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I122a13000e622f7550468845e8560dec5a3c55a6 Gerrit-Change-Number: 43717 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Nov 2026 00:46:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[L] Change in pysim[master]: bip: UDP channels for CAT_TP
by laforge 19 Nov '26

19 Nov '26
Attention is currently required from: Hoernchen, dexter. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43716?usp=email ) Change subject: bip: UDP channels for CAT_TP ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43716?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I015c5eb8768c70751b198d9259c58dab22e4a8ff Gerrit-Change-Number: 43716 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Nov 2026 00:45:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[L] Change in pysim[master]: ota: CAT_TP / TCP dialect of TS 102 225 secured packet
by Hoernchen 18 Nov '26

18 Nov '26
Attention is currently required from: dexter, laforge. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43717?usp=email ) Change subject: ota: CAT_TP / TCP dialect of TS 102 225 secured packet ...................................................................... Patch Set 2: (7 comments) File pySim/ota.py: https://gerrit.osmocom.org/c/pysim/+/43717/comment/dc4ff67c_5d919d08?usp=em… : PS1, Line 745: RPI = 0x02 > maybe put a […] Done https://gerrit.osmocom.org/c/pysim/+/43717/comment/d176fb5d_8cb75c02?usp=em… : PS1, Line 782: padding = otak.crypt._get_padding(6 + len_sig + len(apdu), otak.crypt.blocksize) > Here we have a hardcoded length of 6. […] Done https://gerrit.osmocom.org/c/pysim/+/43717/comment/57236f58_c0d592c8?usp=em… : PS1, Line 788: cnt = otak.cntr.to_bytes(5, 'big') + bytes([pad_cnt]) > Here you convert the counter value (CNTR) to bytes (5). […] Done https://gerrit.osmocom.org/c/pysim/+/43717/comment/44a59551_a33b11a4?usp=em… : PS1, Line 790: cpl = len(bertlv_encode_len(chl)) + chl + len(apdu) # CHI (absent) .. end of data > I think you should put comments and a spec ref everwhere where the CHI (RHI) is absent, people who a […] Done https://gerrit.osmocom.org/c/pysim/+/43717/comment/5c6fb216_fa71ca31?usp=em… : PS1, Line 801: raise ValueError('Unexpected CPI 0x%02x' % encoded[0]) > maybe extend this a bit with "..., was expecting CPI" and then you output self.CPI. […] Done https://gerrit.osmocom.org/c/pysim/+/43717/comment/10da64c4_035ad1b8?usp=em… : PS1, Line 806: hdr_len = 7 > this is SPI(2) + KIc(1) + KID(1) + and TAR(3) […] Done https://gerrit.osmocom.org/c/pysim/+/43717/comment/cc2a321a_18393f71?usp=em… : PS1, Line 816: raise ValueError('CHL %u does not match SPI' % chl) > we have a lot of 6s there. But its actually 5+1 (PCNTR+CNTR), this is hard to read... Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I122a13000e622f7550468845e8560dec5a3c55a6 Gerrit-Change-Number: 43717 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 18 Nov 2026 22:59:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
1 0
0 0
[XL] Change in pysim[master]: cattp: ETSI TS 102 127 transport for OTA over BIP UDP
by Hoernchen 18 Nov '26

18 Nov '26
Attention is currently required from: dexter, laforge. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43719?usp=email ) Change subject: cattp: ETSI TS 102 127 transport for OTA over BIP UDP ...................................................................... Patch Set 2: (13 comments) File pySim/cattp.py: https://gerrit.osmocom.org/c/pysim/+/43719/comment/2b1002e6_a5c2a33d?usp=em… : PS1, Line 54: HDR_LEN = 18 # TS 102 127 5.6.2, without a variable header area > Shouldn't this be 12 instead of 18? - However, in the code below I can see that 18 is actually corre […] Done https://gerrit.osmocom.org/c/pysim/+/43719/comment/6f4f7380_69f536a5?usp=em… : PS1, Line 105: self.data = bytes(data) > what if someone tries to instantiate a SYN PDU with data in it? Wouldn't that be illegal (see my oth […] checked now. https://gerrit.osmocom.org/c/pysim/+/43719/comment/94ed3862_ff12d324?usp=em… : PS1, Line 136: var = self._variable_header() > As far as I can see you are calling _variable_header only from here. […] Done https://gerrit.osmocom.org/c/pysim/+/43719/comment/89b73790_38409be5?usp=em… : PS1, Line 137: hdr = bytearray([self.flags | (self.version & 0x03), 0, 0, HDR_LEN + len(var)]) > using construct wasn't an option? In other location you use it quite often, why not use it here too? Done https://gerrit.osmocom.org/c/pysim/+/43719/comment/40dcae68_a38aec30?usp=em… : PS1, Line 144: return bytes(hdr) + self.data > I wonder what would happen if self.syn is true and self.data has bytes. […] checked now. https://gerrit.osmocom.org/c/pysim/+/43719/comment/5b0e92e0_9a823534?usp=em… : PS1, Line 154: (hdr_len, data_len, len(raw))) > I would recommend to split this. […] Done https://gerrit.osmocom.org/c/pysim/+/43719/comment/cfb3e93c_2658a631?usp=em… : PS1, Line 156: raise CatTpError('checksum mismatch') > maybe use constants for those offsets. I think this would be a lot easier to read. Done https://gerrit.osmocom.org/c/pysim/+/43719/comment/3d75d647_e47706cc?usp=em… : PS1, Line 163: if len(var) < 5 or len(var) != 5 + var[4]: > I think you should comment this. […] Done https://gerrit.osmocom.org/c/pysim/+/43719/comment/b0a55699_16512361?usp=em… : PS1, Line 172: raise CatTpError('malformed EACK variable header') > So this checks if we have an uneven or even number of bytes in the variable part of the PDU. […] Done https://gerrit.osmocom.org/c/pysim/+/43719/comment/8c7e8bb5_ffb3eb72?usp=em… : PS1, Line 537: ACK into the same PDU.""" > maybe put an API docstring for every constructor parameter? I think here it is most important as thi […] Done https://gerrit.osmocom.org/c/pysim/+/43719/comment/31ef7055_b775a6cc?usp=em… : PS1, Line 551: def bind(self) -> int: > Called by the API user, add API docstring. Done https://gerrit.osmocom.org/c/pysim/+/43719/comment/32fd2e2b_a22f2825?usp=em… : PS1, Line 558: def serve_forever(self): > Called by the API user, add API docstring. Done https://gerrit.osmocom.org/c/pysim/+/43719/comment/7f008c62_f2cd90ed?usp=em… : PS1, Line 564: raw, addr = self._sock.recvfrom(65535) > maybe add a constant for the number of bytes? Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43719?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6f31493c1f0fb48fb3fd5382d8af2c905d365e54 Gerrit-Change-Number: 43719 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 18 Nov 2026 22:55:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
1 0
0 0
[M] Change in pysim[master]: ota: TS 102 226 PUSH command and CAT_TP trigger
by Hoernchen 18 Nov '26

18 Nov '26
Attention is currently required from: laforge. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43718?usp=email ) Change subject: ota: TS 102 226 PUSH command and CAT_TP trigger ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > I think this is technically ok, but there is one technical detail that is not quite right: […] trigger output is compact format (TS 102 226 5.1.1, C-TPDU coding, one P3) for smpp-ota-tool -a, -> goes inside a SCP80 packet. the resulting PUSH is not a contact interface command at all! You cant just paste that into pysim-shell! -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43718?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib3423c4fe582dbcc9434c8234709a7b845fa6bcd Gerrit-Change-Number: 43718 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 18 Nov 2026 22:54:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
1 0
0 0
[L] Change in pysim[master]: bip: UDP channels for CAT_TP
by Hoernchen 18 Nov '26

18 Nov '26
Attention is currently required from: dexter, laforge. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43716?usp=email ) Change subject: bip: UDP channels for CAT_TP ...................................................................... Patch Set 2: (3 comments) File pySim/bip.py: https://gerrit.osmocom.org/c/pysim/+/43716/comment/721b0348_19ac940c?usp=em… : PS1, Line 83: class ProactChannel: > I see below you are just overloading entire methods (e.g. […] Done https://gerrit.osmocom.org/c/pysim/+/43716/comment/54f2bd1b_acfaad5d?usp=em… : PS1, Line 233: name='bip-rx-%d' % self.chan_nr, daemon=True) > This (thread creation) is a code dup you could easily get rid off with the approach I mentioned abov […] Done https://gerrit.osmocom.org/c/pysim/+/43716/comment/624f1223_32580dfd?usp=em… : PS1, Line 297: """Create a new proactive channel, allocating its integer number.""" > I recommend to document proto in the apidoc. Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43716?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I015c5eb8768c70751b198d9259c58dab22e4a8ff Gerrit-Change-Number: 43716 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 18 Nov 2026 22:52:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
1 0
0 0
[M] Change in pysim[master]: pySim-shell: verify apdu commands in scripts and -e options up front
by Hoernchen 18 Nov '26

18 Nov '26
Attention is currently required from: Hoernchen, dexter, laforge. Hello Jenkins Builder, dexter, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/43727?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim-shell: verify apdu commands in scripts and -e options up front ...................................................................... pySim-shell: verify apdu commands in scripts and -e options up front Statically verify -e parameters and scripts so we don't end up with half executed command chains that leave the card in a weird state due to malformed commands. This is a structural check, and not a strict mode linter, it will not magically fix a case 4 with missing Le that looks like a valid case 3! run_script, bulk_script and the @ / @@ shortcuts are followed recursively, aliases and macros are not resolved. A script that an earlier line writes via output redirection is skipped. Change-Id: Ida84b982d7577faa5b37f121599a59bcb2feefec --- M pySim-shell.py A tests/unittests/test_shell_startup_verify.py 2 files changed, 231 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/27/43727/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43727?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ida84b982d7577faa5b37f121599a59bcb2feefec Gerrit-Change-Number: 43727 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 6
  • 7
  • 8
  • 9
  • 10
  • 11
  • 12
  • ...
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.