[L] Change in pysim[master]: bip: UDP channels for CAT_TP
Attention is currently required from: dexter, laforge. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43716?usp=email ) Change subject: bip: UDP channels for CAT_TP ...................................................................... Patch Set 2: (3 comments) File pySim/bip.py: https://gerrit.osmocom.org/c/pysim/+/43716/comment/721b0348_19ac940c?usp=ema... : PS1, Line 83: class ProactChannel:
I see below you are just overloading entire methods (e.g. […] Done
https://gerrit.osmocom.org/c/pysim/+/43716/comment/54f2bd1b_acfaad5d?usp=ema... : PS1, Line 233: name='bip-rx-%d' % self.chan_nr, daemon=True)
This (thread creation) is a code dup you could easily get rid off with the approach I mentioned abov […] Done
https://gerrit.osmocom.org/c/pysim/+/43716/comment/624f1223_32580dfd?usp=ema... : PS1, Line 297: """Create a new proactive channel, allocating its integer number."""
I recommend to document proto in the apidoc. Done
-- To view, visit https://gerrit.osmocom.org/c/pysim/+/43716?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I015c5eb8768c70751b198d9259c58dab22e4a8ff Gerrit-Change-Number: 43716 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Wed, 18 Nov 2026 22:52:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier@sysmocom.de>
participants (1)
-
Hoernchen