Attention is currently required from: dexter, laforge.
3 comments:
File pySim/bip.py:
Patch Set #1, Line 83: class ProactChannel:
I see below you are just overloading entire methods (e.g. […]
Done
Patch Set #1, Line 233: name='bip-rx-%d' % self.chan_nr, daemon=True)
This (thread creation) is a code dup you could easily get rid off with the approach I mentioned abov […]
Done
Patch Set #1, Line 297: """Create a new proactive channel, allocating its integer number."""
I recommend to document proto in the apidoc.
Done
To view, visit change 43716. To unsubscribe, or for help writing mail filters, visit settings.