[L] Change in pysim[master]: ota: CAT_TP / TCP dialect of TS 102 225 secured packet
Attention is currently required from: dexter, laforge. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43717?usp=email ) Change subject: ota: CAT_TP / TCP dialect of TS 102 225 secured packet ...................................................................... Patch Set 2: (7 comments) File pySim/ota.py: https://gerrit.osmocom.org/c/pysim/+/43717/comment/dc4ff67c_5d919d08?usp=ema... : PS1, Line 745: RPI = 0x02
maybe put a […] Done
https://gerrit.osmocom.org/c/pysim/+/43717/comment/d176fb5d_8cb75c02?usp=ema... : PS1, Line 782: padding = otak.crypt._get_padding(6 + len_sig + len(apdu), otak.crypt.blocksize)
Here we have a hardcoded length of 6. […] Done
https://gerrit.osmocom.org/c/pysim/+/43717/comment/57236f58_c0d592c8?usp=ema... : PS1, Line 788: cnt = otak.cntr.to_bytes(5, 'big') + bytes([pad_cnt])
Here you convert the counter value (CNTR) to bytes (5). […] Done
https://gerrit.osmocom.org/c/pysim/+/43717/comment/44a59551_a33b11a4?usp=ema... : PS1, Line 790: cpl = len(bertlv_encode_len(chl)) + chl + len(apdu) # CHI (absent) .. end of data
I think you should put comments and a spec ref everwhere where the CHI (RHI) is absent, people who a […] Done
https://gerrit.osmocom.org/c/pysim/+/43717/comment/5c6fb216_fa71ca31?usp=ema... : PS1, Line 801: raise ValueError('Unexpected CPI 0x%02x' % encoded[0])
maybe extend this a bit with "..., was expecting CPI" and then you output self.CPI. […] Done
https://gerrit.osmocom.org/c/pysim/+/43717/comment/10da64c4_035ad1b8?usp=ema... : PS1, Line 806: hdr_len = 7
this is SPI(2) + KIc(1) + KID(1) + and TAR(3) […] Done
https://gerrit.osmocom.org/c/pysim/+/43717/comment/cc2a321a_18393f71?usp=ema... : PS1, Line 816: raise ValueError('CHL %u does not match SPI' % chl)
we have a lot of 6s there. But its actually 5+1 (PCNTR+CNTR), this is hard to read... Done
-- To view, visit https://gerrit.osmocom.org/c/pysim/+/43717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I122a13000e622f7550468845e8560dec5a3c55a6 Gerrit-Change-Number: 43717 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Wed, 18 Nov 2026 22:59:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier@sysmocom.de>
participants (1)
-
Hoernchen