[XL] Change in pysim[master]: cattp: ETSI TS 102 127 transport for OTA over BIP UDP
Attention is currently required from: dexter, laforge. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43719?usp=email ) Change subject: cattp: ETSI TS 102 127 transport for OTA over BIP UDP ...................................................................... Patch Set 2: (13 comments) File pySim/cattp.py: https://gerrit.osmocom.org/c/pysim/+/43719/comment/2b1002e6_a5c2a33d?usp=ema... : PS1, Line 54: HDR_LEN = 18 # TS 102 127 5.6.2, without a variable header area
Shouldn't this be 12 instead of 18? - However, in the code below I can see that 18 is actually corre […] Done
https://gerrit.osmocom.org/c/pysim/+/43719/comment/6f4f7380_69f536a5?usp=ema... : PS1, Line 105: self.data = bytes(data)
what if someone tries to instantiate a SYN PDU with data in it? Wouldn't that be illegal (see my oth […] checked now.
https://gerrit.osmocom.org/c/pysim/+/43719/comment/94ed3862_ff12d324?usp=ema... : PS1, Line 136: var = self._variable_header()
As far as I can see you are calling _variable_header only from here. […] Done
https://gerrit.osmocom.org/c/pysim/+/43719/comment/89b73790_38409be5?usp=ema... : PS1, Line 137: hdr = bytearray([self.flags | (self.version & 0x03), 0, 0, HDR_LEN + len(var)])
using construct wasn't an option? In other location you use it quite often, why not use it here too? Done
https://gerrit.osmocom.org/c/pysim/+/43719/comment/40dcae68_a38aec30?usp=ema... : PS1, Line 144: return bytes(hdr) + self.data
I wonder what would happen if self.syn is true and self.data has bytes. […] checked now.
https://gerrit.osmocom.org/c/pysim/+/43719/comment/5b0e92e0_9a823534?usp=ema... : PS1, Line 154: (hdr_len, data_len, len(raw)))
I would recommend to split this. […] Done
https://gerrit.osmocom.org/c/pysim/+/43719/comment/cfb3e93c_2658a631?usp=ema... : PS1, Line 156: raise CatTpError('checksum mismatch')
maybe use constants for those offsets. I think this would be a lot easier to read. Done
https://gerrit.osmocom.org/c/pysim/+/43719/comment/3d75d647_e47706cc?usp=ema... : PS1, Line 163: if len(var) < 5 or len(var) != 5 + var[4]:
I think you should comment this. […] Done
https://gerrit.osmocom.org/c/pysim/+/43719/comment/b0a55699_16512361?usp=ema... : PS1, Line 172: raise CatTpError('malformed EACK variable header')
So this checks if we have an uneven or even number of bytes in the variable part of the PDU. […] Done
https://gerrit.osmocom.org/c/pysim/+/43719/comment/8c7e8bb5_ffb3eb72?usp=ema... : PS1, Line 537: ACK into the same PDU."""
maybe put an API docstring for every constructor parameter? I think here it is most important as thi […] Done
https://gerrit.osmocom.org/c/pysim/+/43719/comment/31ef7055_b775a6cc?usp=ema... : PS1, Line 551: def bind(self) -> int:
Called by the API user, add API docstring. Done
https://gerrit.osmocom.org/c/pysim/+/43719/comment/32fd2e2b_a22f2825?usp=ema... : PS1, Line 558: def serve_forever(self):
Called by the API user, add API docstring. Done
https://gerrit.osmocom.org/c/pysim/+/43719/comment/7f008c62_f2cd90ed?usp=ema... : PS1, Line 564: raw, addr = self._sock.recvfrom(65535)
maybe add a constant for the number of bytes? Done
-- To view, visit https://gerrit.osmocom.org/c/pysim/+/43719?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6f31493c1f0fb48fb3fd5382d8af2c905d365e54 Gerrit-Change-Number: 43719 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Wed, 18 Nov 2026 22:55:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier@sysmocom.de>
participants (1)
-
Hoernchen