Attention is currently required from: dexter, laforge.
7 comments:
File pySim/ota.py:
Patch Set #1, Line 745: RPI = 0x02
maybe put a […]
Done
Patch Set #1, Line 782: padding = otak.crypt._get_padding(6 + len_sig + len(apdu), otak.crypt.blocksize)
Here we have a hardcoded length of 6. […]
Done
Patch Set #1, Line 788: cnt = otak.cntr.to_bytes(5, 'big') + bytes([pad_cnt])
Here you convert the counter value (CNTR) to bytes (5). […]
Done
Patch Set #1, Line 790: cpl = len(bertlv_encode_len(chl)) + chl + len(apdu) # CHI (absent) .. end of data
I think you should put comments and a spec ref everwhere where the CHI (RHI) is absent, people who a […]
Done
Patch Set #1, Line 801: raise ValueError('Unexpected CPI 0x%02x' % encoded[0])
maybe extend this a bit with "..., was expecting CPI" and then you output self.CPI. […]
Done
Patch Set #1, Line 806: hdr_len = 7
this is SPI(2) + KIc(1) + KID(1) + and TAR(3) […]
Done
Patch Set #1, Line 816: raise ValueError('CHL %u does not match SPI' % chl)
we have a lot of 6s there. But its actually 5+1 (PCNTR+CNTR), this is hard to read...
Done
To view, visit change 43717. To unsubscribe, or for help writing mail filters, visit settings.