lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[S] Change in osmo-msc[master]: mgw: add type selection between rtpbridge and transcoder
by laforge 18 Nov '26

18 Nov '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/44002?usp=email ) Change subject: mgw: add type selection between rtpbridge and transcoder ...................................................................... mgw: add type selection between rtpbridge and transcoder Hera TC MGW is an alternative MGW implementation intended for use with OsmoMSC. Unlike standard OsmoMGW, the new MGW incorporates speech transcoder functionality, acting as a software equivalent of a traditional GSM TRAU. Add ability to drive this alternative MGW, selected via new vty setting 'mgw type'. Because Hera TC MGW includes a pass-through mode for GSM speech codecs in addition to its primary function of TRAU-like transcoding, a network configuration in which the MSC instance of osmo-mgw has been replaced with hera-tc-mgw, accompanied by 'mgw type transcoder' setting in OsmoMSC, is still a working config, although not really useful. Instead the configuration with OsmoMSC driving Hera TC MGW acquires useful functionality with subsequent patches in this series, adding MNCC raw mode for operation with Hera MSC back end components in the place of osmo-sip-connector. Depends: I713147d6567fb30de09b2272478d717093d6170e (osmo-mgw.git) Change-Id: I095ab75b65f57583ab7f579ba419bbfbfa686afa Related: OS#6652 --- M TODO-RELEASE M include/osmocom/msc/gsm_data.h M src/libmsc/call_leg.c M src/libmsc/msc_vty.c M tests/test_nodes.vty 5 files changed, 30 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/TODO-RELEASE b/TODO-RELEASE index 0a167bd..f4b5220 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -10,3 +10,4 @@ libosmo-sigtran >2.3.0 OSMO_SCCP_REL_REASON_NSU_* libosmo-sigtran >2.3.0 OSMO_SCCP_RETURN_REASON_*, osmo_sccp_return_reason_name() libosmo-mgcp-client >1.16.0 x_side[] in struct mgcp_conn_peer +libosmo-mgcp-client >1.16.0 mgcp_client_transcoder_wildcard() diff --git a/include/osmocom/msc/gsm_data.h b/include/osmocom/msc/gsm_data.h index f1537ff..928eeca 100644 --- a/include/osmocom/msc/gsm_data.h +++ b/include/osmocom/msc/gsm_data.h @@ -283,6 +283,13 @@ */ uint8_t tw_rtp_formats; + /* OsmoMSC requires an associated MGCP-speaking MGW, but it can now be + * one of two types: either rtpbridge (standard OsmoMGW) or transcoder + * (Themyscira Wireless add-ons to Osmocom CNI suite). The selection + * is configured via vty. + */ + bool use_transcoder_mgw; + /* Should we send X-Side extension parameter line to our attached MGW, * telling it which CRCX is for CN vs RAN? */ bool mgw_indicate_side; diff --git a/src/libmsc/call_leg.c b/src/libmsc/call_leg.c index 7402c5a..7b81008 100644 --- a/src/libmsc/call_leg.c +++ b/src/libmsc/call_leg.c @@ -291,14 +291,20 @@ if (!cl->mgw_endpoint) { struct mgcp_client *mgcp_client = mgcp_client_pool_get(gsmnet->mgw.mgw_pool); + const char *mgw_wildcard; + if (!mgcp_client) { LOG_CALL_LEG(cl, LOGL_ERROR, "cannot ensure MGW endpoint -- no MGW configured, check configuration!\n"); return -ENODEV; } + if (gsmnet->use_transcoder_mgw) + mgw_wildcard = mgcp_client_transcoder_wildcard(mgcp_client); + else + mgw_wildcard = mgcp_client_rtpbridge_wildcard(mgcp_client); cl->mgw_endpoint = osmo_mgcpc_ep_alloc(cl->fi, CALL_LEG_EV_MGW_ENDPOINT_GONE, mgcp_client, gsmnet->mgw.tdefs, cl->fi->id, - "%s", mgcp_client_rtpbridge_wildcard(mgcp_client)); + "%s", mgw_wildcard); } if (!cl->mgw_endpoint) { LOG_CALL_LEG(cl, LOGL_ERROR, "failed to setup MGW endpoint\n"); diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c index 895bd7e..2c873f6 100644 --- a/src/libmsc/msc_vty.c +++ b/src/libmsc/msc_vty.c @@ -726,6 +726,17 @@ #define MGW_STR MGCP_CLIENT_MGW_STR +DEFUN(cfg_msc_mgw_type, + cfg_msc_mgw_type_cmd, + "mgw type (rtpbridge|transcoder)", + MGW_STR "Type of Media Gateway to be used\n" + "Symmetric RTP bridge (Osmocom standard)\n" + "Asymmetric transcoding MGW\n") +{ + gsmnet->use_transcoder_mgw = (strcmp(argv[0], "transcoder") == 0); + return CMD_SUCCESS; +} + DEFUN(cfg_msc_mgw_side, cfg_msc_mgw_side_cmd, "mgw indicate-side", @@ -883,6 +894,8 @@ vty_out(vty, "%s", VTY_NEWLINE); } + if (gsmnet->use_transcoder_mgw) + vty_out(vty, " mgw type transcoder%s", VTY_NEWLINE); if (gsmnet->mgw_indicate_side) vty_out(vty, " mgw indicate-side%s", VTY_NEWLINE); @@ -2186,6 +2199,7 @@ install_element(MSC_NODE, &cfg_msc_osmux_cmd); install_element(MSC_NODE, &cfg_msc_twformat_cmd); install_element(MSC_NODE, &cfg_msc_no_twformat_cmd); + install_element(MSC_NODE, &cfg_msc_mgw_type_cmd); install_element(MSC_NODE, &cfg_msc_mgw_side_cmd); install_element(MSC_NODE, &cfg_msc_no_mgw_side_cmd); install_element(MSC_NODE, &cfg_msc_handover_number_range_cmd); diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty index 109ec9d..f95dcc6 100644 --- a/tests/test_nodes.vty +++ b/tests/test_nodes.vty @@ -69,6 +69,7 @@ osmux (on|off|only) tw-rtp-formats (fr|hr|amr|csd) [(fr|hr|amr|csd)] [(fr|hr|amr|csd)] [(fr|hr|amr|csd)] no tw-rtp-formats + mgw type (rtpbridge|transcoder) mgw indicate-side no mgw indicate-side handover-number range MSISDN_FIRST MSISDN_LAST -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/44002?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I095ab75b65f57583ab7f579ba419bbfbfa686afa Gerrit-Change-Number: 44002 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in libosmocore[master]: gb: ns2: clamp embedded NS PDU to msgb tailroom
by ws1004 18 Nov '26

18 Nov '26
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/44138?usp=email to look at the new patch set (#2). Change subject: gb: ns2: clamp embedded NS PDU to msgb tailroom ...................................................................... gb: ns2: clamp embedded NS PDU to msgb tailroom Per TS 48.016 9.2.7.2 an NS-STATUS PDU embeds the PDU that caused the error. reject_status_msg() copies it in without any length check, and ns2_tx_status() clamps it against nsvc->bind->mtu only, not against the space left in the reply msgb. For an NS-over-IP bind that MTU is 65527 (gprs_ns2_udp.c:344), while the STATUS msgb from ns2_msgb_alloc() offers 3052 usable bytes (NS_ALLOC_SIZE 3072 minus NS_ALLOC_HEADROOM 20), of which 3048 remain after the NS header and the Cause IE. A received PDU of 3046 bytes or more therefore makes msgb_tvlv_put() -> msgb_put() hit MSGB_ABORT, which aborts the process. No NS-VC, handshake or credentials are needed to reach either site. Clamp against the msgb tailroom in both places, and use a saturating clamp instead of a subtraction on an unsigned (the old form could underflow if the MTU were smaller than the message built so far). bssgp_tx_status() in the same tree already does this correctly via OSMO_MIN(..., msgb_tailroom(msg) - 3). Fixes: 6a161497cfd8cacfef10c2e81cff85a45447e107 Change-Id: Iac1c5c15875f30f34d0f7e9fc74264530a02b6ae --- M src/gb/gprs_ns2.c M src/gb/gprs_ns2_message.c 2 files changed, 28 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/38/44138/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/44138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iac1c5c15875f30f34d0f7e9fc74264530a02b6ae Gerrit-Change-Number: 44138 Gerrit-PatchSet: 2 Gerrit-Owner: ws1004 <ws1004(a)kakao.com> Gerrit-Reviewer: Jenkins Builder
1 0
0 0
[S] Change in libosmocore[master]: gb: ns2: clamp the embedded NS PDU to the msgb, not just to the MTU
by ws1004 18 Nov '26

18 Nov '26
ws1004 has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/44138?usp=email ) Change subject: gb: ns2: clamp the embedded NS PDU to the msgb, not just to the MTU ...................................................................... gb: ns2: clamp the embedded NS PDU to the msgb, not just to the MTU reject_status_msg() embeds the offending PDU into the NS-STATUS reply without any length check, and ns2_tx_status() clamps it against nsvc->bind->mtu only. For an NS-over-IP bind that MTU is 65527 (gprs_ns2_udp.c:344), while the STATUS msgb from ns2_msgb_alloc() offers 3052 usable bytes (NS_ALLOC_SIZE 3072 minus NS_ALLOC_HEADROOM 20), of which 3048 remain after the NS header and the Cause IE. A received PDU of 3046 bytes or more therefore makes msgb_tvlv_put() -> msgb_put() hit MSGB_ABORT, which aborts the process. No NS-VC, handshake or credentials are needed to reach either site. Clamp against the msgb tailroom in both places, and use a saturating clamp instead of a subtraction on an unsigned (the old form could underflow if the MTU were smaller than the message built so far). bssgp_tx_status() in the same tree already does this correctly via OSMO_MIN(..., msgb_tailroom(msg) - 3). Fixes: 6a161497cfd8cacfef10c2e81cff85a45447e107 Change-Id: Iac1c5c15875f30f34d0f7e9fc74264530a02b6ae --- M src/gb/gprs_ns2.c M src/gb/gprs_ns2_message.c 2 files changed, 28 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/38/44138/1 diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c index 4e496c1..773498a 100644 --- a/src/gb/gprs_ns2.c +++ b/src/gb/gprs_ns2.c @@ -751,10 +751,20 @@ case NS_CAUSE_PDU_INCOMP_PSTATE: case NS_CAUSE_PROTO_ERR_UNSPEC: case NS_CAUSE_INVAL_ESSENT_IE: - case NS_CAUSE_MISSING_ESSENT_IE: - msgb_tvlv_put(msg, NS_IE_PDU, msgb_l2len(orig_msg), - orig_msg->l2h); + case NS_CAUSE_MISSING_ESSENT_IE: { + /* The original PDU can be larger than what is left in our own + * msgb (NS_ALLOC_SIZE), so clamp it. TvLV header is 3 bytes. */ + int avail = (int)msgb_tailroom(msg) - 3; + unsigned int embed_len = msgb_l2len(orig_msg); + + if (avail < 0) + avail = 0; + if (embed_len > (unsigned int)avail) + embed_len = (unsigned int)avail; + if (embed_len) + msgb_tvlv_put(msg, NS_IE_PDU, embed_len, orig_msg->l2h); break; + } default: break; } diff --git a/src/gb/gprs_ns2_message.c b/src/gb/gprs_ns2_message.c index de63b7a..3431c0c 100644 --- a/src/gb/gprs_ns2_message.c +++ b/src/gb/gprs_ns2_message.c @@ -458,12 +458,22 @@ case NS_CAUSE_INVAL_ESSENT_IE: case NS_CAUSE_MISSING_ESSENT_IE: /* Section 9.2.7.2: Static conditions for NS PDU */ - /* ensure the PDU doesn't exceed the MTU */ + /* Ensure the embedded PDU fits both into the link MTU and into + * our own message buffer. bind->mtu can be far larger than + * NS_ALLOC_SIZE (65527 for NS-over-IP), so clamping against the + * MTU alone lets msgb_put() hit MSGB_ABORT. */ orig_len = msgb_l2len(orig_msg); - max_orig_len = msgb_length(msg) + TVLV_GROSS_LEN(orig_len); - if (max_orig_len > nsvc->bind->mtu) - orig_len -= max_orig_len - nsvc->bind->mtu; - msgb_tvlv_put(msg, NS_IE_PDU, orig_len, orig_msg->l2h); + max_orig_len = msgb_tailroom(msg); + if (nsvc->bind->mtu <= msgb_length(msg)) + max_orig_len = 0; + else if (nsvc->bind->mtu - msgb_length(msg) < max_orig_len) + max_orig_len = nsvc->bind->mtu - msgb_length(msg); + /* TvLV header: 1 byte tag + 2 bytes length */ + max_orig_len = (max_orig_len > 3) ? max_orig_len - 3 : 0; + if (orig_len > max_orig_len) + orig_len = max_orig_len; + if (orig_len) + msgb_tvlv_put(msg, NS_IE_PDU, orig_len, orig_msg->l2h); break; case NS_CAUSE_BVCI_UNKNOWN: /* Section 9.2.7.3: Static conditions for BVCI */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/44138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iac1c5c15875f30f34d0f7e9fc74264530a02b6ae Gerrit-Change-Number: 44138 Gerrit-PatchSet: 1 Gerrit-Owner: ws1004 <ws1004(a)kakao.com>
1 0
0 0
[S] Change in libosmocore[master]: core: osmo_init_logging2(): Log talloc output through osmo_logging sy...
by pespin 18 Nov '26

18 Nov '26
Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/44137?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: core: osmo_init_logging2(): Log talloc output through osmo_logging system ...................................................................... core: osmo_init_logging2(): Log talloc output through osmo_logging system The logging functionality of talloc is mainly used to log warnings and errors about spotted problems. By default, the logging callback is NULL and hence nothing is printed. Set up the callback so we can print the problems spotted. Change-Id: Ibe85438616d731636579981cce3756922295f48a --- M src/core/application.c M src/pseudotalloc/pseudotalloc.c M src/pseudotalloc/talloc.h 3 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/37/44137/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/44137?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibe85438616d731636579981cce3756922295f48a Gerrit-Change-Number: 44137 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in libosmocore[master]: core: osmo_init_logging2(): Log talloc output through osmo_logging sy...
by pespin 18 Nov '26

18 Nov '26
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/44137?usp=email ) Change subject: core: osmo_init_logging2(): Log talloc output through osmo_logging system ...................................................................... core: osmo_init_logging2(): Log talloc output through osmo_logging system The logging functionality of talloc is mainly used to log warnings and errors about spotted problems. By default, the logging callback is NULL and hence nothing is printed. Set up the callback so we can print the problems spotted. Change-Id: Ibe85438616d731636579981cce3756922295f48a --- M src/core/application.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/37/44137/1 diff --git a/src/core/application.c b/src/core/application.c index bb89adb..e71f4e2 100644 --- a/src/core/application.c +++ b/src/core/application.c @@ -78,6 +78,7 @@ #include <unistd.h> #include <errno.h> #include <sys/stat.h> +#include <talloc.h> struct log_target *osmo_stderr_target; @@ -102,6 +103,11 @@ #endif } +static void log_talloc_cb(const char *message) +{ + LOGP(DLGLOBAL, LOGL_NOTICE, "%s", message); +} + /*! Initialize the osmocom logging framework * \param[in] log_info Array of available logging sub-systems * \returns 0 on success, -1 in case of error @@ -114,6 +120,7 @@ return osmo_init_logging2(NULL, log_info); } + int osmo_init_logging2(void *ctx, const struct log_info *log_info) { static int logging_initialized = 0; @@ -129,6 +136,8 @@ log_add_target(osmo_stderr_target); log_set_all_filter(osmo_stderr_target, 1); + + talloc_set_log_fn(log_talloc_cb); return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/44137?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibe85438616d731636579981cce3756922295f48a Gerrit-Change-Number: 44137 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-msc[master]: codec mapping: add support for compressed CSD
by fixeria 18 Nov '26

18 Nov '26
Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-msc/+/44046?usp=email ) Change subject: codec mapping: add support for compressed CSD ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/44046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I97964ef7edeab3bb29300adb03a8374725eb2a1e Gerrit-Change-Number: 44046 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Wed, 18 Nov 2026 15:37:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in libgtpnl[HEAD]: .gitignore: Ignore new autofoo tmp files
by pespin 18 Nov '26

18 Nov '26
pespin has abandoned this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/22680?usp=email ) Change subject: .gitignore: Ignore new autofoo tmp files ...................................................................... Abandoned wrong target branch -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/22680?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libgtpnl Gerrit-Branch: HEAD Gerrit-Change-Id: Iaf853783679815e74b6b8e5f3e8631c53ed20613 Gerrit-Change-Number: 22680 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-msc[master]: mgw: add type selection between rtpbridge and transcoder
by fixeria 18 Nov '26

18 Nov '26
Attention is currently required from: falconia, neels. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-msc/+/44002?usp=email ) Change subject: mgw: add type selection between rtpbridge and transcoder ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/44002?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I095ab75b65f57583ab7f579ba419bbfbfa686afa Gerrit-Change-Number: 44002 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Nov 2026 15:15:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-msc[master]: mgw: add type selection between rtpbridge and transcoder
by pespin 18 Nov '26

18 Nov '26
Attention is currently required from: falconia, fixeria, neels. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-msc/+/44002?usp=email ) Change subject: mgw: add type selection between rtpbridge and transcoder ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/44002?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I095ab75b65f57583ab7f579ba419bbfbfa686afa Gerrit-Change-Number: 44002 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Nov 2026 14:36:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-remsim[master]: Move commonly used remsim-client code into .la file
by laforge 18 Nov '26

18 Nov '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/44069?usp=email ) Change subject: Move commonly used remsim-client code into .la file ...................................................................... Move commonly used remsim-client code into .la file Clean up the Makefile.am by moving all commonly used code into a 'noinst' library. Change-Id: I2ba00fde01ab6a8a2b0972fb5eee16f9cf61967e --- M src/client/Makefile.am 1 file changed, 18 insertions(+), 9 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/client/Makefile.am b/src/client/Makefile.am index 6c7abc6..5ddd58f 100644 --- a/src/client/Makefile.am +++ b/src/client/Makefile.am @@ -10,12 +10,21 @@ $(OSMOSIMTRACE2_CFLAGS) \ $(NULL) +noinst_LTLIBRARIES = libremsim_client_common.la + +libremsim_client_common_la_SOURCES = \ + remsim_client.c \ + main_fsm.c \ + ../rspro_client_fsm.c \ + ../debug.c \ + $(NULL) + bin_PROGRAMS = osmo-remsim-client-shell -osmo_remsim_client_shell_SOURCES = user_shell.c remsim_client_main.c \ - remsim_client.c main_fsm.c ../rspro_client_fsm.c ../debug.c +osmo_remsim_client_shell_SOURCES = user_shell.c remsim_client_main.c osmo_remsim_client_shell_CFLAGS = $(AM_CFLAGS) -osmo_remsim_client_shell_LDADD = $(top_builddir)/src/libosmo-rspro.la \ +osmo_remsim_client_shell_LDADD = $(builddir)/libremsim_client_common.la \ + $(top_builddir)/src/libosmo-rspro.la \ $(OSMONETIF_LIBS) \ $(OSMOGSM_LIBS) \ $(OSMOCORE_LIBS) \ @@ -28,12 +37,12 @@ bundle_DATA=PkgInfo bundlelinuxdir=$(bundledir)/Linux bundlelinux_LTLIBRARIES = libifd_remsim_client.la -libifd_remsim_client_la_SOURCES = user_ifdhandler.c \ - remsim_client.c main_fsm.c ../rspro_client_fsm.c ../debug.c +libifd_remsim_client_la_SOURCES = user_ifdhandler.c libifd_remsim_client_la_CFLAGS = $(AM_CFLAGS) libifd_remsim_client_la_CPPFLAGS = $(PCSC_CFLAGS) libifd_remsim_client_la_LDFLAGS = -no-undefined -libifd_remsim_client_la_LIBADD = $(top_builddir)/src/libosmo-rspro.la \ +libifd_remsim_client_la_LIBADD = $(builddir)/libremsim_client_common.la \ + $(top_builddir)/src/libosmo-rspro.la \ $(OSMONETIF_LIBS) \ $(OSMOGSM_LIBS) \ $(OSMOCORE_LIBS) \ @@ -42,11 +51,11 @@ if BUILD_CLIENT_ST2 bin_PROGRAMS += osmo-remsim-client-st2 -osmo_remsim_client_st2_SOURCES = user_simtrace2.c remsim_client_main.c \ - remsim_client.c main_fsm.c ../rspro_client_fsm.c ../debug.c +osmo_remsim_client_st2_SOURCES = user_simtrace2.c remsim_client_main.c osmo_remsim_client_st2_CPPFLAGS = -DUSB_SUPPORT -DSIMTRACE_SUPPORT osmo_remsim_client_st2_CFLAGS = $(AM_CFLAGS) -osmo_remsim_client_st2_LDADD = $(top_builddir)/src/libosmo-rspro.la \ +osmo_remsim_client_st2_LDADD = $(builddir)/libremsim_client_common.la \ + $(top_builddir)/src/libosmo-rspro.la \ $(OSMONETIF_LIBS) \ $(OSMOSIMTRACE2_LIBS) \ $(OSMOGSM_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/44069?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2ba00fde01ab6a8a2b0972fb5eee16f9cf61967e Gerrit-Change-Number: 44069 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 9
  • 10
  • 11
  • 12
  • 13
  • 14
  • 15
  • ...
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.