lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[S] Change in osmo-ci[master]: jobs/registry-rebuild-upload-gerrit: new job
by osmith 18 Nov '26

18 Nov '26
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/44134?usp=email ) Change subject: jobs/registry-rebuild-upload-gerrit: new job ...................................................................... jobs/registry-rebuild-upload-gerrit: new job Change-Id: I03038eecb46208aa4bdafe1dc5379cfb5b7e16c7 --- A jobs/registry-rebuild-upload-gerrit.yml 1 file changed, 36 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/jobs/registry-rebuild-upload-gerrit.yml b/jobs/registry-rebuild-upload-gerrit.yml new file mode 100644 index 0000000..3f6e51f --- /dev/null +++ b/jobs/registry-rebuild-upload-gerrit.yml @@ -0,0 +1,36 @@ +- job: + name: 'registry-rebuild-upload-gerrit' + description: | + Build the <code>gerrit</code> image from + <a href="https://gitea.osmocom.org/osmocom/docker-playground/"> + docker-playground + </a> and push it to the Osmocom registry. + concurrent: false + parameters: + - string: + name: BRANCH + description: | + Branch of <code>docker-playground.git</code> + default: 'master' + scm: + - git: + url: https://gerrit.osmocom.org/docker-playground + skip-tag: true + branches: + - '$BRANCH' + builders: + - shell: | + REGISTRY="registry.osmocom.org" + TAG="$(grep 'FROM.*gerritcodereview/gerrit:' gerrit/Dockerfile | cut -d : -f 2)" + + test -n "$TAG" + echo "release=$TAG" >gerrit/.release + make -C "gerrit" REGISTRY_HOST="$REGISTRY" + docker tag "$REGISTRY"/gerrit:latest "$REGISTRY"/gerrit:"$TAG" + docker push "$REGISTRY"/gerrit:"$TAG" + properties: + - build-discarder: + num-to-keep: 120 + wrappers: + - ansicolor: + colormap: xterm -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/44134?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I03038eecb46208aa4bdafe1dc5379cfb5b7e16c7 Gerrit-Change-Number: 44134 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ci[master]: jobs/registry-rebuild-upload-gerrit: new job
by pespin 18 Nov '26

18 Nov '26
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/44134?usp=email ) Change subject: jobs/registry-rebuild-upload-gerrit: new job ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/44134?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I03038eecb46208aa4bdafe1dc5379cfb5b7e16c7 Gerrit-Change-Number: 44134 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Nov 2026 14:17:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in docker-playground[master]: gerrit: upload to registry.osmocom.org
by pespin 18 Nov '26

18 Nov '26
Attention is currently required from: laforge, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/44136?usp=email ) Change subject: gerrit: upload to registry.osmocom.org ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/44136?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I34486624f8a57de2fd68bcc1fd85234ecc07f17c Gerrit-Change-Number: 44136 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Nov 2026 14:17:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in osmo-remsim[master]: Update osmo-remsim-apitool to support maintenance flag
by pespin 18 Nov '26

18 Nov '26
Attention is currently required from: jolly, laforge, lynxis. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43747?usp=email ) Change subject: Update osmo-remsim-apitool to support maintenance flag ...................................................................... Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43747?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Iaac6423b3a2f7209d0c26e9624d90b21b7c39f89 Gerrit-Change-Number: 43747 Gerrit-PatchSet: 12 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 18 Nov 2026 14:16:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-remsim[master]: Add optional timeout to mapping
by pespin 18 Nov '26

18 Nov '26
Attention is currently required from: jolly, laforge, lynxis. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43746?usp=email ) Change subject: Add optional timeout to mapping ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43746?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2f7ee24e6c926b65876af2b14da3534555398769 Gerrit-Change-Number: 43746 Gerrit-PatchSet: 12 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 18 Nov 2026 14:16:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in osmo-remsim[master]: Add priority mapping support to osmo-remsim-server
by pespin 18 Nov '26

18 Nov '26
Attention is currently required from: jolly, laforge, lynxis. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43745?usp=email ) Change subject: Add priority mapping support to osmo-remsim-server ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43745?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I885b3b529276f46fbbe6d86be2170b0bffbb8434 Gerrit-Change-Number: 43745 Gerrit-PatchSet: 12 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 18 Nov 2026 14:16:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in libosmocore[master]: core/socket: init_osa: pass family-correct len
by laforge 18 Nov '26

18 Nov '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/43574?usp=email ) Change subject: core/socket: init_osa: pass family-correct len ...................................................................... core/socket: init_osa: pass family-correct len osmo_sock_init_osa() hands bind() and connect() sizeof(struct osmo_sockaddr), the 128 byte union, whatever the address family. Linux accepts a namelen longer than the family needs and reads only the family-appropriate part. Darwin returns EINVAL because the kernel enforces the exact length (16 for IPv4, 28 for IPv6). The BSDs behave like Darwin. Use osmo_sockaddr_size(), which the header already provides and which the sendto() callers already use. It returns sizeof(struct sockaddr_in) or sizeof(struct sockaddr_in6) by family. Linux behaviour is unchanged. Consequence on Darwin without this fix: gprs_ns2_ip_bind() cannot bind its NS-VC UDP socket ("unable to bind socket: 0.0.0.0:23001: Invalid argument"), so osmo-pcu exits with "No NSVC available to connect to the SGSN" right after the INFO_IND from osmo-bts. osmo-sgsn and osmo-gbproxy reach the same call. Change-Id: I37cb08a6e1809d51c97e666f980d4c68f8b56933 Signed-off-by: Andrei Gosman <andrei.gosman(a)gmail.com> --- M src/core/socket.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/core/socket.c b/src/core/socket.c index 9755e06..6dd476b 100644 --- a/src/core/socket.c +++ b/src/core/socket.c @@ -598,7 +598,9 @@ } } - if (bind(sfd, &local->u.sa, sizeof(struct osmo_sockaddr)) == -1) { + /* Pass the length of the address family in use, not of the union: + * Darwin and the BSDs reject a longer namelen with EINVAL. */ + if (bind(sfd, &local->u.sa, osmo_sockaddr_size(local)) == -1) { int err = errno; _SOCKADDR_TO_STR(sastr, local); LOGP(DLGLOBAL, LOGL_ERROR, "unable to bind socket: " OSMO_SOCKADDR_STR_FMT ": %s\n", @@ -621,7 +623,7 @@ } } - rc = connect(sfd, &remote->u.sa, sizeof(struct osmo_sockaddr)); + rc = connect(sfd, &remote->u.sa, osmo_sockaddr_size(remote)); if (rc != 0 && errno != EINPROGRESS) { int err = errno; _SOCKADDR_TO_STR(sastr, remote); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43574?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I37cb08a6e1809d51c97e666f980d4c68f8b56933 Gerrit-Change-Number: 43574 Gerrit-PatchSet: 2 Gerrit-Owner: andrei.gosman(a)gmail.com <andrei.gosman(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in libosmocore[master]: core/socket: init_osa: pass family-correct len
by laforge 18 Nov '26

18 Nov '26
Attention is currently required from: andrei.gosman(a)gmail.com, pespin. laforge has posted comments on this change by andrei.gosman(a)gmail.com. ( https://gerrit.osmocom.org/c/libosmocore/+/43574?usp=email ) Change subject: core/socket: init_osa: pass family-correct len ...................................................................... Patch Set 1: (1 comment) File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/43574/comment/92620538_d4e3522a?… : PS1, Line 603: if (bind(sfd, &local->u.sa, osmo_sockaddr_size(local)) == -1) { > Correction to my previous comment in this thread, which is wrong. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43574?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I37cb08a6e1809d51c97e666f980d4c68f8b56933 Gerrit-Change-Number: 43574 Gerrit-PatchSet: 1 Gerrit-Owner: andrei.gosman(a)gmail.com <andrei.gosman(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: andrei.gosman(a)gmail.com <andrei.gosman(a)gmail.com> Gerrit-Comment-Date: Wed, 18 Nov 2026 14:14:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: andrei.gosman(a)gmail.com <andrei.gosman(a)gmail.com>
1 0
0 0
[XS] Change in libosmocore[master]: core/socket: init_osa: pass family-correct len
by laforge 18 Nov '26

18 Nov '26
Attention is currently required from: andrei.gosman(a)gmail.com. laforge has posted comments on this change by andrei.gosman(a)gmail.com. ( https://gerrit.osmocom.org/c/libosmocore/+/43574?usp=email ) Change subject: core/socket: init_osa: pass family-correct len ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43574?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I37cb08a6e1809d51c97e666f980d4c68f8b56933 Gerrit-Change-Number: 43574 Gerrit-PatchSet: 1 Gerrit-Owner: andrei.gosman(a)gmail.com <andrei.gosman(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: andrei.gosman(a)gmail.com <andrei.gosman(a)gmail.com> Gerrit-Comment-Date: Wed, 18 Nov 2026 14:14:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in osmo-remsim[master]: Add INACTIVE state to slot mapping
by pespin 18 Nov '26

18 Nov '26
Attention is currently required from: jolly, lynxis. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43744?usp=email ) Change subject: Add INACTIVE state to slot mapping ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43744?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I95dff90deb965f8198effdd355d45419bb4c2b02 Gerrit-Change-Number: 43744 Gerrit-PatchSet: 9 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 18 Nov 2026 14:14:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 11
  • 12
  • 13
  • 14
  • 15
  • 16
  • 17
  • ...
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.