January 2026 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: transport/init: use PySimLogger to print messages
by fixeria 19 Jan '26

19 Jan '26

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41812?usp=email ) Change subject: transport/init: use PySimLogger to print messages ...................................................................... Patch Set 1: (3 comments) File pySim/transport/__init__.py: https://gerrit.osmocom.org/c/pysim/+/41812/comment/15d4aabd_75e6313c?usp=em… : PS1, Line 34: TRANSPORT I am wondering why are you doing this instead of using `__name__`. This would match the module hierarchy, e.g. for this module it would be `pySim.transport`. And this makes logging configuration flexible, allowing to set logging level for specific module(s). For instance, one could set `pySim.transport` to `DEBUG`, resulting in all modules in this directory to use thing logging level. This is exactly what the official documentation (https://docs.python.org/3/library/logging.html#logger-objects) recommends doing. Also, with this approach it's not needed to do `logger.addHandler()` for each and every logger (this is what `PySimLogger.get` does) because child loggers do inherit logging configuration of the parent loggers. This enables other applications using pySim as a library to have their own logging configuration (formatting, handlers, etc.). https://gerrit.osmocom.org/c/pysim/+/41812/comment/750862b2_f0053b1f?usp=em… : PS1, Line 49: log.info Please use lazy format string rendering here and below. https://gerrit.osmocom.org/c/pysim/+/41812/comment/14b3eee7_0b0c5cb1?usp=em… : PS1, Line 368: os.environ.get('PYSIM_INTEGRATION_TEST') This workaround can be removed in a follow-up patch, thanks to proper logging. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41812?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2e2ec2b84f3b84dbd8a029ae9bb64b7a96ddbde3 Gerrit-Change-Number: 41812 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 07:34:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ccid-firmware[master]: contrib/jenkins.sh: fix build: add --disable-syslog-logging
by mschramm 19 Jan '26

19 Jan '26

mschramm has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41866?usp=email ) Change subject: contrib/jenkins.sh: fix build: add --disable-syslog-logging ...................................................................... contrib/jenkins.sh: fix build: add --disable-syslog-logging Since recently (see the related patch), libosmocore requires header file syslog.h to be present, unless --disable-syslog-logging is given. Change-Id: Ia49709dfebdf22cb00f70d667c996c3fbb8a1f51 Related: libosmocore.git Ifc54d60e24547696b3059b6eb75572f8c84874d0 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified mschramm: Looks good to me, approved; Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 0e3e414..c355dd3 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -44,7 +44,7 @@ ./configure --enable-static --prefix="$inst/stow/libosmocore" --host=arm-none-eabi \ --enable-embedded --disable-log-macros --disable-doxygen --disable-shared --disable-pseudotalloc \ --disable-libsctp --disable-libusb --disable-gb --enable-external-tests \ - --disable-libmnl \ + --disable-libmnl --disable-syslog-logging \ CFLAGS="-Os -ffunction-sections -fdata-sections -nostartfiles -nodefaultlibs -Werror -Wno-error=deprecated -Wno-error=deprecated-declarations -Wno-error=cpp -mthumb -Os -mlong-calls -g3 -mcpu=cortex-m4 -mfloat-abi=softfp -mfpu=fpv4-sp-d16 -I /home/laforge/projects/git/osmo-ccid-firmware/sysmoOCTSIM -Wno-error=format" \ CPPFLAGS="-D__thread=''" make $PARALLEL_MAKE install -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41866?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ia49709dfebdf22cb00f70d667c996c3fbb8a1f51 Gerrit-Change-Number: 41866 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: mschramm <mschramm(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: contrib/jenkins.sh: fix build: add --disable-syslog-logging
by mschramm 19 Jan '26

19 Jan '26

Attention is currently required from: fixeria. mschramm has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41866?usp=email ) Change subject: contrib/jenkins.sh: fix build: add --disable-syslog-logging ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41866?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ia49709dfebdf22cb00f70d667c996c3fbb8a1f51 Gerrit-Change-Number: 41866 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: mschramm <mschramm(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 18 Jan 2026 13:42:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: contrib/jenkins.sh: fix build: add --disable-syslog-logging
by mschramm 19 Jan '26

19 Jan '26

Attention is currently required from: fixeria. mschramm has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41866?usp=email ) Change subject: contrib/jenkins.sh: fix build: add --disable-syslog-logging ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41866?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ia49709dfebdf22cb00f70d667c996c3fbb8a1f51 Gerrit-Change-Number: 41866 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: mschramm <mschramm(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 18 Jan 2026 13:42:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: contrib/jenkins.sh: fix build: add --disable-syslog-logging
by fixeria 19 Jan '26

19 Jan '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41866?usp=email ) Change subject: contrib/jenkins.sh: fix build: add --disable-syslog-logging ...................................................................... contrib/jenkins.sh: fix build: add --disable-syslog-logging Since recently (see the related patch), libosmocore requires header file syslog.h to be present, unless --disable-syslog-logging is given. Change-Id: Ia49709dfebdf22cb00f70d667c996c3fbb8a1f51 Related: libosmocore.git Ifc54d60e24547696b3059b6eb75572f8c84874d0 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/66/41866/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 0e3e414..c355dd3 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -44,7 +44,7 @@ ./configure --enable-static --prefix="$inst/stow/libosmocore" --host=arm-none-eabi \ --enable-embedded --disable-log-macros --disable-doxygen --disable-shared --disable-pseudotalloc \ --disable-libsctp --disable-libusb --disable-gb --enable-external-tests \ - --disable-libmnl \ + --disable-libmnl --disable-syslog-logging \ CFLAGS="-Os -ffunction-sections -fdata-sections -nostartfiles -nodefaultlibs -Werror -Wno-error=deprecated -Wno-error=deprecated-declarations -Wno-error=cpp -mthumb -Os -mlong-calls -g3 -mcpu=cortex-m4 -mfloat-abi=softfp -mfpu=fpv4-sp-d16 -I /home/laforge/projects/git/osmo-ccid-firmware/sysmoOCTSIM -Wno-error=format" \ CPPFLAGS="-D__thread=''" make $PARALLEL_MAKE install -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41866?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ia49709dfebdf22cb00f70d667c996c3fbb8a1f51 Gerrit-Change-Number: 41866 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: gmstap_log: optimization: Add talloc_pool for transmitted messages
by fixeria 18 Jan '26

18 Jan '26

Attention is currently required from: daniel, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email ) Change subject: gmstap_log: optimization: Add talloc_pool for transmitted messages ...................................................................... Patch Set 4: -Code-Review (1 comment) File src/core/logging_gsmtap.c: https://gerrit.osmocom.org/c/libosmocore/+/41865/comment/0e7e2418_c5e10bbf?… : PS4, Line 77: msgb_alloc_c > Well, embedded does not always imply pseudotalloc. […] And BTW, osmo-ccid-firmware is a good example using talloc: `--host=arm-none-eabi --enable-embedded ... --disable-pseudotalloc`. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I19cdf09f21d856e8e3646de495ce7ae040195268 Gerrit-Change-Number: 41865 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sun, 18 Jan 2026 12:39:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: saip: ProfileElementSD: call _post_decode() when instantiating with d...
by laforge 18 Jan '26

18 Jan '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41837?usp=email ) Change subject: saip: ProfileElementSD: call _post_decode() when instantiating with decoded argument ...................................................................... saip: ProfileElementSD: call _post_decode() when instantiating with decoded argument Otherwise self.keys is not generated from the given data and encoding will fail. Change-Id: I3020f581a908fecc01d5d255ab5991ce1652e3ec --- M pySim/esim/saip/__init__.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index f8a854d..5ca87aa 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -1032,6 +1032,7 @@ def __init__(self, decoded: Optional[dict] = None, **kwargs): super().__init__(decoded, **kwargs) if decoded: + self._post_decode() return # provide some reasonable defaults for a MNO-SD self.decoded['instance'] = { -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3020f581a908fecc01d5d255ab5991ce1652e3ec Gerrit-Change-Number: 41837 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: saip: ProfileElementSD: call _post_decode() when instantiating with d...
by laforge 18 Jan '26

18 Jan '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/41837?usp=email ) Change subject: saip: ProfileElementSD: call _post_decode() when instantiating with decoded argument ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3020f581a908fecc01d5d255ab5991ce1652e3ec Gerrit-Change-Number: 41837 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 17 Jan 2026 21:52:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: gmstap_log: optimization: Add talloc_pool for transmitted messages
by fixeria 18 Jan '26

18 Jan '26

Attention is currently required from: daniel, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email ) Change subject: gmstap_log: optimization: Add talloc_pool for transmitted messages ...................................................................... Patch Set 4: (1 comment) File src/core/logging_gsmtap.c: https://gerrit.osmocom.org/c/libosmocore/+/41865/comment/865a727a_61025ac0?… : PS4, Line 77: msgb_alloc_c > In pseudotalloc the context pointer is actually not used, so it doesn't really matter. Well, embedded does not always imply pseudotalloc. We do enable pseudotalloc implicitly when configured with `--enable-embedded`. But the user may still want an embedded build to use full-blown talloc, e.g. for debugging memleaks. This should be possible with `--enable-embedded --enable-pseudotalloc=no`. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I19cdf09f21d856e8e3646de495ce7ae040195268 Gerrit-Change-Number: 41865 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Jan 2026 20:59:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: gmstap_log: optimization: Add talloc_pool for transmitted messages
by pespin 18 Jan '26

18 Jan '26

Attention is currently required from: daniel, fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email ) Change subject: gmstap_log: optimization: Add talloc_pool for transmitted messages ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File src/core/logging_gsmtap.c: https://gerrit.osmocom.org/c/libosmocore/+/41865/comment/1c518889_cc021b37?… : PS4, Line 77: msgb_alloc_c > Maybe keep using `tall_msgb_ctx` for embedded builds? […] In pseudotalloc the context pointer is actually not used, so it doesn't really matter. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I19cdf09f21d856e8e3646de495ce7ae040195268 Gerrit-Change-Number: 41865 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Jan 2026 15:16:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026