January 2026 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: gmstap_log: optimization: Add talloc_pool for transmitted messages
by pespin 19 Jan '26

19 Jan '26

Attention is currently required from: daniel, laforge, osmith, pespin. Hello Jenkins Builder, daniel, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified-1 by Jenkins Builder Change subject: gmstap_log: optimization: Add talloc_pool for transmitted messages ...................................................................... gmstap_log: optimization: Add talloc_pool for transmitted messages In synchronous modes (blocking and non-blocking), set a pool size of 1 msgb. This way we avoid re-allocating the msgb with malloc/free everytime a gsmtap_log msg is transmitted over the target, and instead we allocate the msgb during creation of the target. In asynchronous mode (workqueue), create a pool of 100 msgbs, which should in general be enough to speedup more usual needs. If more than 100 msgbs are to be enqueued into the gsmtap_inst, then they will be allocated as normal talloc contexts. Since the struct log_target is public, it is currently not possible to add new fields to it under "tgt_gsmtap" without breaking the ABI. Hence, the ->output field, which is unused in this target, is reused to store the pool object internally. Change-Id: I19cdf09f21d856e8e3646de495ce7ae040195268 --- M configure.ac M src/core/logging_gsmtap.c 2 files changed, 34 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/65/41865/7 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I19cdf09f21d856e8e3646de495ce7ae040195268 Gerrit-Change-Number: 41865 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: configure.ac: EMBEDDED modifies default AC_ARG_ENABLE values
by osmith 19 Jan '26

19 Jan '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41867?usp=email ) Change subject: configure.ac: EMBEDDED modifies default AC_ARG_ENABLE values ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41867?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I164eb461fb59c7675393219102740f40c1119fdd Gerrit-Change-Number: 41867 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 09:58:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: gmstap_log: optimization: Add talloc_pool for transmitted messages
by osmith 19 Jan '26

19 Jan '26

Attention is currently required from: daniel, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email ) Change subject: gmstap_log: optimization: Add talloc_pool for transmitted messages ...................................................................... Patch Set 6: Code-Review+1 (1 comment) File src/core/logging_gsmtap.c: https://gerrit.osmocom.org/c/libosmocore/+/41865/comment/c673ea6a_45cd974e?… : PS5, Line 178: target->output = tall_msgb_ctx; > I already say it in commit description: "Hence, the ->output field, which is unused in this target, […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I19cdf09f21d856e8e3646de495ce7ae040195268 Gerrit-Change-Number: 41865 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 09:51:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: gmstap_log: optimization: Add talloc_pool for transmitted messages
by pespin 19 Jan '26

19 Jan '26

Attention is currently required from: daniel, laforge, osmith. Hello Jenkins Builder, daniel, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: gmstap_log: optimization: Add talloc_pool for transmitted messages ...................................................................... gmstap_log: optimization: Add talloc_pool for transmitted messages In synchronous modes (blocking and non-blocking), set a pool size of 1 msgb. This way we avoid re-allocating the msgb with malloc/free everytime a gsmtap_log msg is transmitted over the target, and instead we allocate the msgb during creation of the target. In asynchronous mode (workqueue), create a pool of 100 msgbs, which should in general be enough to speedup more usual needs. If more than 100 msgbs are to be enqueued into the gsmtap_inst, then they will be allocated as normal talloc contexts. Since the struct log_target is public, it is currently not possible to add new fields to it under "tgt_gsmtap" without breaking the ABI. Hence, the ->output field, which is unused in this target, is reused to store the pool object internally. Change-Id: I19cdf09f21d856e8e3646de495ce7ae040195268 --- M configure.ac M src/core/logging_gsmtap.c 2 files changed, 33 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/65/41865/6 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I19cdf09f21d856e8e3646de495ce7ae040195268 Gerrit-Change-Number: 41865 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: gmstap_log: optimization: Add talloc_pool for transmitted messages
by pespin 19 Jan '26

19 Jan '26

Attention is currently required from: daniel, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email ) Change subject: gmstap_log: optimization: Add talloc_pool for transmitted messages ...................................................................... Patch Set 5: (3 comments) File src/core/logging_gsmtap.c: https://gerrit.osmocom.org/c/libosmocore/+/41865/comment/fe4d18b5_25957c13?… : PS5, Line 171: sutrct > struct Done https://gerrit.osmocom.org/c/libosmocore/+/41865/comment/dfd4ef59_65448fbf?… : PS5, Line 178: target->output = tall_msgb_ctx; > `target->output` gets set in this patch. […] I already say it in commit description: "Hence, the ->output field, which is unused in this target, is reused to store the pool object internally." https://gerrit.osmocom.org/c/libosmocore/+/41865/comment/9eca8bf1_acfa16ac?… : PS5, Line 179: #endif /* ifndef EMBEDDED */ > ```suggestion […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I19cdf09f21d856e8e3646de495ce7ae040195268 Gerrit-Change-Number: 41865 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 09:46:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: configure.ac: EMBEDDED modifies default AC_ARG_ENABLE values
by pespin 19 Jan '26

19 Jan '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41867?usp=email to look at the new patch set (#2). Change subject: configure.ac: EMBEDDED modifies default AC_ARG_ENABLE values ...................................................................... configure.ac: EMBEDDED modifies default AC_ARG_ENABLE values With this patch, EMBEDDED simply modifies the default enable/disable configure args, as in a preset, instead of changing state after checks have been done. This way the logic is clarified since the same logic in configure is always checked, regardless of EMBEDDED being set or not. Change-Id: I164eb461fb59c7675393219102740f40c1119fdd --- M configure.ac 1 file changed, 89 insertions(+), 77 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/67/41867/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41867?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I164eb461fb59c7675393219102740f40c1119fdd Gerrit-Change-Number: 41867 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in osmo-ci[master]: ansible: allow jenkins users to set rtprio 30
by pespin 19 Jan '26

19 Jan '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41863?usp=email ) Change subject: ansible: allow jenkins users to set rtprio 30 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id79851b3e3a47d19773aa9bba134b9bf99dbecbb Gerrit-Change-Number: 41863 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 09:33:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-gsm-manuals[master]: logging: Improve syslog log documentation
by pespin 19 Jan '26

19 Jan '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41864?usp=email ) Change subject: logging: Improve syslog log documentation ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I think it's fine leaving it as an option since some osmocom program may actually be fine with block […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41864?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ic3ab275fd1448e590a43251e226d690beee67004 Gerrit-Change-Number: 41864 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 09:32:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-gsm-manuals[master]: logging: Improve syslog log documentation
by pespin 19 Jan '26

19 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41864?usp=email ) Change subject: logging: Improve syslog log documentation ...................................................................... logging: Improve syslog log documentation Change-Id: Ic3ab275fd1448e590a43251e226d690beee67004 --- M common/chapters/logging.adoc 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve diff --git a/common/chapters/logging.adoc b/common/chapters/logging.adoc index 4cf2e15..2275d65 100644 --- a/common/chapters/logging.adoc +++ b/common/chapters/logging.adoc @@ -358,10 +358,20 @@ `logging filter`, `logging level` as well as `logging color` and `logging timestamp`. -NOTE: Syslog daemons will normally automatically prefix every message +TIP: Syslog daemons will normally automatically prefix every message with a time-stamp, so you should disable the libosmocore time-stamping by issuing the `logging timestamp 0` command. +NOTE: Typical syslog implementations (such as glibc's one) write to _AF_UNIX_ +socket in `/dev/log` in a synchronous blocking I/O fashion, which means +transmitting a big amount of messages or text over it in a short amount of time +(before syslogd has time to read it) could potentially block the osmocom +program's thread issuing the logging. It is hence advised avoiding use of this +log target to log notable amounts of information in any osmocom program driven +by an event loop (which includes any program using a VTY), since it may block +the thread for an unspecified (potentially long or even infinite) amount of time +and hence prevent the event loop to run and process events. + ==== Logging to systemd-journal -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41864?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ic3ab275fd1448e590a43251e226d690beee67004 Gerrit-Change-Number: 41864 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: ansible: allow jenkins users to set rtprio 30
by osmith 19 Jan '26

19 Jan '26

Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41863?usp=email ) Change subject: ansible: allow jenkins users to set rtprio 30 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > what about --ulimit rtprio=30 when calling podman/docker? I just tried it, but it doesn't work with podman (which is what testenv uses): ``` Error: crun: setrlimit `RLIMIT_RTPRIO`: Operation not permitted: OCI permission denied ``` This seems to be expected behavior when running podman rootless (as we do): https://github.com/containers/podman/discussions/22011#discussioncomment-87… -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id79851b3e3a47d19773aa9bba134b9bf99dbecbb Gerrit-Change-Number: 41863 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 09:32:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026