laforge has submitted this change. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/41804?usp=email )
Change subject: OmapiCallbackHandlerVpcd: fetch SELECT response from OMAPI
......................................................................
OmapiCallbackHandlerVpcd: fetch SELECT response from OMAPI
At the moment we get the select response by selecting 7FFF, which
is an alias for the currently selected application. This returns a
select response when an ISIM or USIM application is selected. Other
applications may react differently here.
OMAPI has a getSelectResponse method through which we can get the
actual response that was received from the card when the application
was selected when openLogicalChannel was called. This is far more
accurate, so lets use getSelectResponse instead of selecting 7FFF.
Change-Id: Iacbc907ef157f20bed88325fcf6b58717990005a
---
M app/src/main/java/org/osmocom/androidApduProxy/Omapi.java
M app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
2 files changed, 23 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/app/src/main/java/org/osmocom/androidApduProxy/Omapi.java b/app/src/main/java/org/osmocom/androidApduProxy/Omapi.java
index afd4515..1ee173c 100644
--- a/app/src/main/java/org/osmocom/androidApduProxy/Omapi.java
+++ b/app/src/main/java/org/osmocom/androidApduProxy/Omapi.java
@@ -192,6 +192,28 @@
}
/**
+ * Read the SELECT response after method open was called successfully.
+ * @param channelId id-number of the OMAPI Channel
+ * @return array of bytes that contains the SELECT response or, throws Exception on error
+ */
+ public byte[] getSelRes(int channelId) throws Exception {
+ try {
+ ensureSeService();
+ if (!channels.containsKey(channelId))
+ throw new Exception(String.format("no channel open under channelId = %d", channelId));
+ Channel channel = channels.get(channelId);
+ byte[] response = channel.getSelectResponse();
+ if (response == null)
+ throw new Exception("unresponsive card!");
+ Log.d("OMAPI", "SELECT RESPONSE: " + Utils.b2h(response) + "\n");
+ return response;
+ } catch (Exception e) {
+ Log.e("OMAPI", e.getMessage() + "\n");
+ throw e;
+ }
+ }
+
+ /**
* Perform an APDU transaction on the card.
* @param channelId id-number of the OMAPI Channel
* @param apdu array of bytes that contains the command APDU (to card)
diff --git a/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java b/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
index 56db37f..9d1ebb9 100644
--- a/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
+++ b/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
@@ -163,7 +163,7 @@
int newOmapiChannel;
byte[] response;
newOmapiChannel = omapi.open(omapiReader, aidReq);
- response = omapi.transact(newOmapiChannel, Utils.h2b("00a40004027fff"));
+ response = omapi.getSelRes(newOmapiChannel);
Log.i("PROXY", String.format("Opening new channel (%d) for AID (%s) was successful, now closing the old channel (%d)...\n",
newOmapiChannel, Utils.b2h(aidReq), omapiChannel));
omapi.close(omapiChannel);
--
To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41804?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: android-apdu-proxy
Gerrit-Branch: master
Gerrit-Change-Id: Iacbc907ef157f20bed88325fcf6b58717990005a
Gerrit-Change-Number: 41804
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
laforge has submitted this change. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/41805?usp=email )
Change subject: OmapiCallbackHandlerVpcd: pass SELECT parameter P2 to OMAPI
......................................................................
OmapiCallbackHandlerVpcd: pass SELECT parameter P2 to OMAPI
The OMAPI method openLogicalChannel may take an optional parameter p2,
This parameter. Among other function, this paramter in particular
controls how to deal with short DF-Names that match the AIDs of several
applications.
Since we always know this parameter from the TPDU that we receive from
VPCD, let's pass it on to OMAPI when we create a new channel.
Related: OS#6836
Change-Id: Ibab2cc197284e6177a83338007a0b7f77e0ab8b9
---
M app/src/main/java/org/osmocom/androidApduProxy/Omapi.java
M app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
2 files changed, 14 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/app/src/main/java/org/osmocom/androidApduProxy/Omapi.java b/app/src/main/java/org/osmocom/androidApduProxy/Omapi.java
index 1ee173c..bc9a872 100644
--- a/app/src/main/java/org/osmocom/androidApduProxy/Omapi.java
+++ b/app/src/main/java/org/osmocom/androidApduProxy/Omapi.java
@@ -170,13 +170,14 @@
* Open a channel on the specified reader to the specified AID.
* @param readerName string that contains the reader name (e.g. "SIM1")
* @param aid array of bytes that contains the AID of the application to access
+ * @param p2 parameter value to use with the SELECT APDU
* @return OMAPI Channel number on success, throws Exception on error
*/
- public int open(String readerName, byte[] aid) throws Exception {
+ public int open(String readerName, byte[] aid, byte p2) throws Exception {
try {
ensureSeService();
Session session = getOrCreateSession(readerName);
- Channel channel = session.openLogicalChannel(aid);
+ Channel channel = session.openLogicalChannel(aid, p2);
if (channel == null)
throw new Exception(String.format("could not open channel for AID (%s) on reader: %s!\n",
Utils.b2h(aid), readerName));
@@ -192,6 +193,16 @@
}
/**
+ * Open a channel on the specified reader to the specified AID.
+ * @param readerName string that contains the reader name (e.g. "SIM1")
+ * @param aid array of bytes that contains the AID of the application to access
+ * @return OMAPI Channel number on success, throws Exception on error
+ */
+ public int open(String readerName, byte[] aid) throws Exception {
+ return open(readerName, aid, (byte)0x04);
+ }
+
+ /**
* Read the SELECT response after method open was called successfully.
* @param channelId id-number of the OMAPI Channel
* @return array of bytes that contains the SELECT response or, throws Exception on error
diff --git a/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java b/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
index 9d1ebb9..e2bd359 100644
--- a/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
+++ b/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
@@ -162,7 +162,7 @@
try {
int newOmapiChannel;
byte[] response;
- newOmapiChannel = omapi.open(omapiReader, aidReq);
+ newOmapiChannel = omapi.open(omapiReader, aidReq, tpdu[3]);
response = omapi.getSelRes(newOmapiChannel);
Log.i("PROXY", String.format("Opening new channel (%d) for AID (%s) was successful, now closing the old channel (%d)...\n",
newOmapiChannel, Utils.b2h(aidReq), omapiChannel));
--
To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41805?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: android-apdu-proxy
Gerrit-Branch: master
Gerrit-Change-Id: Ibab2cc197284e6177a83338007a0b7f77e0ab8b9
Gerrit-Change-Number: 41805
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
laforge has submitted this change. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/41806?usp=email )
Change subject: OmapiCallbackHandlerVpcd: simplify/fix SELECT by DF-Name (aid)
......................................................................
OmapiCallbackHandlerVpcd: simplify/fix SELECT by DF-Name (aid)
When a TPDU with a SELECT by DF-Name is received from the VPCD end,
it cannot be transparently passed through the OMAPI channel as OMAPI
will block those TDPUs for security reasons. To overcome this, we
close the current OMAPI channel and re-open a new one under the new
DF-Name (AID).
To reduce the likelyhood for unexpected behaviour and possible loss
of state we have replaced the SELECT by DF-Name with a SELECT to
7fff (alias for the currently selected application), in case the
SELECT by DF-Name would target the currently selected application.
This workaround requires preceise tracking of which application is
currently selected. Unfortunately this has proven as difficult and
error prone.
After looking closer at the problem we noticed that we do not even
need the aforementioned workaround. The opening and closing of the
OMAPI channel just opens and closes logical channels on the card.
It does not perform a reset. This in particular means that the ADM
or PIN verification state is retained. (states like the currently
selected file, the current tag and the current record are reset by
SELECT anyway).
So let's remove the workaround and re-open the OMAPI channel each
time a SELECT by DF-Name is received.
Related: OS#6836
Change-Id: Ib4873b18d233e549e075b9384906a536907c6260
---
M app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
1 file changed, 24 insertions(+), 44 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java b/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
index e2bd359..f341b09 100644
--- a/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
+++ b/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
@@ -17,7 +17,6 @@
private int remotePort = 0;
private Handler uiHandler = null;
private int omapiChannel = -1;
- private byte[] omapiAid = null;
//When we open the OMPI channel the first time, we must provide an AID. The following AID is
//the prefix (RID) of 3GPP (see also ETSI TS 101 220, section 4.1) This prefix should select
@@ -74,7 +73,6 @@
sendErrorMessage(e);
return;
}
- omapiAid = DEFAULT_AID;
sendMessageInd(MainActivity.IND_CHANNEL_OPEN);
}
@Override
@@ -89,14 +87,12 @@
return;
}
sendMessageInd(MainActivity.IND_CHANNEL_OPEN);
- omapiAid = DEFAULT_AID;
}
@Override
public void vpcdPwrOff() {
Log.i("PROXY", "Closing OMAPI channel as an alternative to power-off...\n");
omapi.close(omapiChannel);
sendMessageInd(MainActivity.IND_CHANNEL_CLOSE);
- omapiAid = null;
}
@Override
public byte[] vpcdTransact(byte[] tpdu) {
@@ -111,14 +107,11 @@
return (Utils.h2b("6700"));
}
- //In case the TPDU contains a SELECT by DF-Name, which is forbidden by OMAPI by design, we must
- //find an alternative solution: In case the SELECT targets the currently selected application,
- //we just use the FID 7FFF, which is an alias for the currently selected application. In case the
- //AID is different, we close the OMAPI channel and re-open it with the new AID. If this fails, we
- //we just pretend that we haven't found the file.
+ //In case the TPDU contains a SELECT by DF-Name (AID), we cannot transparently pass on the TPDU through
+ //the OMAPI channel since OMAPI will block such TPDUs for security reasons. The only way to archive a
+ //similar result is to close the existing OMAPI channel to and re-open a new OMAPI channel under the
+ //DF-Name (AID) given in in the TPDU.
if (Arrays.equals(Arrays.copyOf(tpdu, 3), Utils.h2b("00A404"))) {
- int compareLength = 0;
-
//Make sure that the Lc field of the TPDU does not exceed the TPDU length
if (tpdu[4] > tpdu.length - 5) {
Log.e("PROXY", String.format("SELECT by DF-Name with invalid length field, rejecting TPDU (%s)...\n",
@@ -142,39 +135,26 @@
aidReq = new byte[0];
}
- if (omapiAid != null) {
- if (aidReq.length < omapiAid.length)
- compareLength = aidReq.length;
- else
- compareLength = omapiAid.length;
- }
- if (omapiAid != null && Arrays.equals(Arrays.copyOf(omapiAid, compareLength), Arrays.copyOf(aidReq, compareLength))) {
- Log.i("PROXY", String.format("Selecting the currently selected ADF (%s->7fff), as a replacement for SELECT by DF-Name...\n",
- Utils.b2h(aidReq)));
- try {
- return omapi.transact(omapiChannel, Utils.h2b("00a40004027fff"));
- } catch (Exception e) {
- sendErrorMessage(e);
- }
- } else {
- Log.i("PROXY", String.format("Opening new channel for AID (%s) as a replacement for SELECT by DF-Name...\n",
- Utils.b2h(aidReq)));
- try {
- int newOmapiChannel;
- byte[] response;
- newOmapiChannel = omapi.open(omapiReader, aidReq, tpdu[3]);
- response = omapi.getSelRes(newOmapiChannel);
- Log.i("PROXY", String.format("Opening new channel (%d) for AID (%s) was successful, now closing the old channel (%d)...\n",
- newOmapiChannel, Utils.b2h(aidReq), omapiChannel));
- omapi.close(omapiChannel);
- omapiAid = aidReq;
- omapiChannel = newOmapiChannel;
- return response;
- } catch (Exception e) {
- Log.i("PROXY", String.format("Opening new channel for new AID (%s) was not successful, pretending that the file was not found...\n",
- Utils.b2h(aidReq)));
- return (Utils.h2b("6A82"));
- }
+ //Compare the given DF-Name to the AID of the current OMAPI channel. If the DF-Name still matches
+ //the AID of the current OMAPI channel, we stay on the current OMAPI channel. If the DF-Name
+ //references the AID of a different application, we will close the current OMAPI channel and open a
+ //new one.
+ Log.i("PROXY", String.format("Opening new channel for AID (%s) as a replacement for SELECT by DF-Name...\n",
+ Utils.b2h(aidReq)));
+ try {
+ int newOmapiChannel;
+ byte[] response;
+ newOmapiChannel = omapi.open(omapiReader, aidReq, tpdu[3]);
+ response = omapi.getSelRes(newOmapiChannel);
+ Log.i("PROXY", String.format("Opening new channel (%d) for AID (%s) was successful, now closing the old channel (%d)...\n",
+ newOmapiChannel, Utils.b2h(aidReq), omapiChannel));
+ omapi.close(omapiChannel);
+ omapiChannel = newOmapiChannel;
+ return response;
+ } catch (Exception e) {
+ Log.i("PROXY", String.format("Opening new channel for new AID (%s) was not successful, pretending that the file was not found...\n",
+ Utils.b2h(aidReq)));
+ return (Utils.h2b("6A82"));
}
}
--
To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41806?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: android-apdu-proxy
Gerrit-Branch: master
Gerrit-Change-Id: Ib4873b18d233e549e075b9384906a536907c6260
Gerrit-Change-Number: 41806
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
laforge has submitted this change. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/41801?usp=email )
Change subject: OmapiCallbackHandlerVpcd: add check to filter shortTPDUs
......................................................................
OmapiCallbackHandlerVpcd: add check to filter shortTPDUs
Related: OS#6836
Change-Id: I4e76afd7cf4d63c67b1525202fbe74e0796b2ba3
---
M app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java b/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
index c71581c..0b880fb 100644
--- a/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
+++ b/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
@@ -101,6 +101,16 @@
@Override
public byte[] vpcdTransact(byte[] tpdu) {
Log.i("PROXY", "Exchanging TPDU...\n");
+
+ //All TPDUs that we receive here should have a minimum length of 5 bytes. Under normal conditins, short
+ //TPDUs should not occurr as they should already be filtered out by the layers that call this method.
+ //To ensure seamless operation, let's check the TPDU length and reject short TPDUs immediately.
+ if (tpdu.length < 5) {
+ Log.e("PROXY", String.format("Rejecting short TPDU (%s)...\n", Utils.b2h(tpdu)));
+ //see also ISO/IEC 7816-4, table 5 (wrong length; no further indication)
+ return (Utils.h2b("6700"));
+ }
+
//In case the TPDU contains a SELECT by DF-Name, which is forbidden by OMAPI by design, we must
//find an alternative solution: In case the SELECT targets the currently selected application,
//we just use the FID 7FFF, which is an alias for the currently selected application. In case the
--
To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41801?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: android-apdu-proxy
Gerrit-Branch: master
Gerrit-Change-Id: I4e76afd7cf4d63c67b1525202fbe74e0796b2ba3
Gerrit-Change-Number: 41801
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
laforge has submitted this change. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/41800?usp=email )
Change subject: OmapiCallbackHandlerVpcd: use appropriate status word to reject MANAGE CHANNEL
......................................................................
OmapiCallbackHandlerVpcd: use appropriate status word to reject MANAGE CHANNEL
ISO/IEC 7816-4 specifies a status word to reject MANAGE CHANNEL instructions
in case the card does not support multiple channels.
Let's also print an error message in the log to simplify debugging for users
who aren't aware of OMAPI's logical channel limitation.
Change-Id: I42529a6ae61378e41f33f1ec34124e346d4805df
Related: OS#6836
---
M app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java b/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
index 0b880fb..02f3028 100644
--- a/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
+++ b/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
@@ -158,7 +158,10 @@
//Block all attempts to manage a channel, this is a feature we do not support here.
//(OMAPI also does not support the MANAGE CHANNEL command)
if (Arrays.equals(Arrays.copyOf(tpdu, 2), Utils.h2b("0070"))) {
- return (Utils.h2b("6D00"));
+ Log.e("PROXY", String.format("Rejecting unsupported MANAGE CHANNEL (%s) command...\n",
+ Utils.b2h(tpdu)));
+ //see also ISO/IEC 7816-4, table 6 (logical channel not supported)
+ return (Utils.h2b("6881"));
}
//Normal APDU/TPDU exchange
--
To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41800?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: android-apdu-proxy
Gerrit-Branch: master
Gerrit-Change-Id: I42529a6ae61378e41f33f1ec34124e346d4805df
Gerrit-Change-Number: 41800
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
laforge has submitted this change. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/41802?usp=email )
Change subject: OmapiCallbackHandlerVpcd: improve log output
......................................................................
OmapiCallbackHandlerVpcd: improve log output
When we select the currently selected ADF, we actually select 7fff,
which is an alias for the currently selected ADF. Let's express this
also more clearly in the log output.
Change-Id: I7004bec25f07b1a7498003231070205d2d659717
Related: OS#6836
---
M app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java b/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
index 02f3028..df0786b 100644
--- a/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
+++ b/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java
@@ -126,7 +126,7 @@
compareLength = omapiAid.length;
}
if (omapiAid != null && Arrays.equals(Arrays.copyOf(omapiAid, compareLength), Arrays.copyOf(aidReq, compareLength))) {
- Log.i("PROXY", String.format("Selecting the currently selected ADF (%s), as a replacement for SELECT by DF-Name...\n",
+ Log.i("PROXY", String.format("Selecting the currently selected ADF (%s->7fff), as a replacement for SELECT by DF-Name...\n",
Utils.b2h(aidReq)));
try {
return omapi.transact(omapiChannel, Utils.h2b("00a40004027fff"));
--
To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41802?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: android-apdu-proxy
Gerrit-Branch: master
Gerrit-Change-Id: I7004bec25f07b1a7498003231070205d2d659717
Gerrit-Change-Number: 41802
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/41806?usp=email )
Change subject: OmapiCallbackHandlerVpcd: simplify/fix SELECT by DF-Name (aid)
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
sadly noone adds any review, so we have to move ahead with just one reviewer 😞
--
To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41806?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: android-apdu-proxy
Gerrit-Branch: master
Gerrit-Change-Id: Ib4873b18d233e549e075b9384906a536907c6260
Gerrit-Change-Number: 41806
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Jan 2026 11:34:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/41805?usp=email )
Change subject: OmapiCallbackHandlerVpcd: pass SELECT parameter P2 to OMAPI
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
sadly noone adds any review, so we have to move ahead with just one reviewer 😞
--
To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41805?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: android-apdu-proxy
Gerrit-Branch: master
Gerrit-Change-Id: Ibab2cc197284e6177a83338007a0b7f77e0ab8b9
Gerrit-Change-Number: 41805
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Jan 2026 11:34:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/41804?usp=email )
Change subject: OmapiCallbackHandlerVpcd: fetch SELECT response from OMAPI
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Patchset:
PS3:
sadly noone adds any review, so we have to move ahead with just one reviewer 😞
--
To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41804?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: android-apdu-proxy
Gerrit-Branch: master
Gerrit-Change-Id: Iacbc907ef157f20bed88325fcf6b58717990005a
Gerrit-Change-Number: 41804
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Jan 2026 11:34:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/41803?usp=email )
Change subject: OmapiCallbackHandlerVpcd: fix extration of DF-Name (AID)
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
sadly noone adds any review, so we have to move ahead with just one reviewer 😞
--
To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41803?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: android-apdu-proxy
Gerrit-Branch: master
Gerrit-Change-Id: Idf08d752d046e012680c872552960cc069272777
Gerrit-Change-Number: 41803
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Jan 2026 11:34:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes