January 2026 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: select.c: Check for ENABLE_PSEUDOTALLOC instead of EMBEDDED
by laforge 19 Jan '26

19 Jan '26

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41869?usp=email ) Change subject: select.c: Check for ENABLE_PSEUDOTALLOC instead of EMBEDDED ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9c4aa66a55beac710912db9b8d3ad9ae5c1679ef Gerrit-Change-Number: 41869 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 11:27:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: select.c: Check for ENABLE_PLUGIN instead of EMBEDDED
by pespin 19 Jan '26

19 Jan '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41870?usp=email to look at the new patch set (#2). Change subject: select.c: Check for ENABLE_PLUGIN instead of EMBEDDED ...................................................................... select.c: Check for ENABLE_PLUGIN instead of EMBEDDED Change-Id: I6cae7781a94e4eb6daaf97c16638fd933a3c9123 --- M configure.ac M src/gsm/auth_core.c M src/gsm/gprs_cipher_core.c 3 files changed, 8 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/70/41870/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41870?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6cae7781a94e4eb6daaf97c16638fd933a3c9123 Gerrit-Change-Number: 41870 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[S] Change in libosmocore[master]: select.c: Check for ENABLE_PSEUDOTALLOC instead of EMBEDDED
by pespin 19 Jan '26

19 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41870?usp=email ) Change subject: select.c: Check for ENABLE_PSEUDOTALLOC instead of EMBEDDED ...................................................................... select.c: Check for ENABLE_PSEUDOTALLOC instead of EMBEDDED Change-Id: I6cae7781a94e4eb6daaf97c16638fd933a3c9123 --- M configure.ac M src/gsm/auth_core.c M src/gsm/gprs_cipher_core.c 3 files changed, 8 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/70/41870/1 diff --git a/configure.ac b/configure.ac index b0914f7..64690f9 100644 --- a/configure.ac +++ b/configure.ac @@ -360,13 +360,12 @@ AM_CONDITIONAL(ENABLE_URING_TESTS, test x"$ENABLE_URING_TESTS" = x"yes") AC_SUBST(ENABLE_URING_TESTS) -AC_ARG_ENABLE(plugin, - [AS_HELP_STRING( - [--disable-plugin], - [Disable support for dlopen plugins], - )], +AC_ARG_ENABLE(plugin, [AS_HELP_STRING([--disable-plugin], [Disable support for dlopen plugins],)], [enable_plugin=$enableval], [enable_plugin=$ENABLE_PLUGIN_DEFAULT]) AM_CONDITIONAL(ENABLE_PLUGIN, test x"$enable_plugin" = x"yes") +AS_IF([test "x$enable_plugin" = "xyes"], [ + AC_DEFINE([ENABLE_PLUGIN], [1], [Enable support for dlopen plugins]) +]) AC_ARG_ENABLE(vty, [AS_HELP_STRING( diff --git a/src/gsm/auth_core.c b/src/gsm/auth_core.c index 6972cb7..80bf7c8 100644 --- a/src/gsm/auth_core.c +++ b/src/gsm/auth_core.c @@ -98,11 +98,11 @@ int osmo_auth_load(const char *path) { /* load all plugins available from path */ -#if !defined(EMBEDDED) +#ifdef ENABLE_PLUGIN return osmo_plugin_load_all(path); #else return -1; -#endif +#endif /* ifdef ENABLE_PLUGIN */ } /*! Determine if a given authentication algorithm is supported diff --git a/src/gsm/gprs_cipher_core.c b/src/gsm/gprs_cipher_core.c index 97e581d..5f28084 100644 --- a/src/gsm/gprs_cipher_core.c +++ b/src/gsm/gprs_cipher_core.c @@ -66,11 +66,11 @@ /* load all available GPRS cipher plugins */ int gprs_cipher_load(const char *path) { -#if !defined(EMBEDDED) +#ifdef ENABLE_PLUGIN /* load all plugins available from path */ if (path) return osmo_plugin_load_all(path); -#endif +#endif /* ifdef ENABLE_PLUGIN */ return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41870?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6cae7781a94e4eb6daaf97c16638fd933a3c9123 Gerrit-Change-Number: 41870 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: select.c: Check for ENABLE_PSEUDOTALLOC instead of EMBEDDED
by pespin 19 Jan '26

19 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41869?usp=email ) Change subject: select.c: Check for ENABLE_PSEUDOTALLOC instead of EMBEDDED ...................................................................... select.c: Check for ENABLE_PSEUDOTALLOC instead of EMBEDDED The reason to avoid that code is that pseudotalloc doesn't implement that function. Hence check for pseudotalloc support specifically. Change-Id: I9c4aa66a55beac710912db9b8d3ad9ae5c1679ef --- M src/core/select.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/69/41869/1 diff --git a/src/core/select.c b/src/core/select.c index 267f041..a577c5b 100644 --- a/src/core/select.c +++ b/src/core/select.c @@ -509,12 +509,12 @@ int osmo_select_main(int polling) { int rc = _osmo_select_main(polling); -#ifndef EMBEDDED +#ifndef ENABLE_PSEUDOTALLOC if (talloc_total_size(osmo_ctx->select) != 0) { osmo_panic("You cannot use the 'select' volatile " "context if you don't use osmo_select_main_ctx()!\n"); } -#endif +#endif /* ifndef ENABLE_PSEUDOTALLOC */ return rc; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9c4aa66a55beac710912db9b8d3ad9ae5c1679ef Gerrit-Change-Number: 41869 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: less cluttered output for failed cmds
by pespin 19 Jan '26

19 Jan '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41868?usp=email ) Change subject: testenv: less cluttered output for failed cmds ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I508322b017e5ed9c21396384ef759a4c49c8d3da Gerrit-Change-Number: 41868 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 10:52:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: testenv: check ulimit -r in prepare=
by pespin 19 Jan '26

19 Jan '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41862?usp=email ) Change subject: bts: testenv: check ulimit -r in prepare= ...................................................................... Patch Set 2: (1 comment) File _testenv/README.md: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41862/comment/d148c662_a13c… : PS2, Line 275: * `USER_HOST`: IMHO this should be called HOST_USER, following english sytanx where adjective goes before name. Otherwise it seems to indicate it contains a host name. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41862?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7bc1414f95e4a54a40eb7c6f7b3d6c83ce3500c6 Gerrit-Change-Number: 41862 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 10:52:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: testenv: check ulimit -r in prepare=
by osmith 19 Jan '26

19 Jan '26

Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41862?usp=email ) Change subject: bts: testenv: check ulimit -r in prepare= ...................................................................... Patch Set 2: (1 comment) File bts/run_osmo_bts_trx.sh: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41862/comment/da0ea25d_90a2… : PS1, Line 5: if [ $EXIT_CODE != 0 ] && grep -q "SCHED_RR.*Operation not permitted" bts.log; then > I think all this can probably be checked with "ulimit -r" -ge 30 ? ACK, patch adjusted -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41862?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7bc1414f95e4a54a40eb7c6f7b3d6c83ce3500c6 Gerrit-Change-Number: 41862 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 10:30:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: less cluttered output for failed cmds
by osmith 19 Jan '26

19 Jan '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41868?usp=email ) Change subject: testenv: less cluttered output for failed cmds ...................................................................... testenv: less cluttered output for failed cmds The testenv.cmd.run() already prints the command to run at the start, prints the command output and blocks until the command is done. If the command fails, do not print the command again, and do not print a python stack trace. The reason for the failure is most likely in the output shown by the program itself (e.g. a prepare= script that failed). Make it easier for the user to spot this error by uncluttering the output. Change-Id: I508322b017e5ed9c21396384ef759a4c49c8d3da --- M _testenv/testenv/cmd.py 1 file changed, 4 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/68/41868/1 diff --git a/_testenv/testenv/cmd.py b/_testenv/testenv/cmd.py index c14f694..bde0bf3 100644 --- a/_testenv/testenv/cmd.py +++ b/_testenv/testenv/cmd.py @@ -1,10 +1,11 @@ -# Copyright 2024 sysmocom - s.f.m.c. GmbH +# Copyright 2026 sysmocom - s.f.m.c. GmbH # SPDX-License-Identifier: GPL-3.0-or-later import logging import os import os.path import re import subprocess +import sys import testenv import testenv.testsuite @@ -79,15 +80,6 @@ env_extra["TESTENV_QEMU_SCRIPTS"] = os.path.join(testenv.data_dir, "scripts/qemu") -def exit_error_cmd(completed, error_msg): - """:param completed: return from run_cmd() below""" - - logging.error(error_msg) - logging.debug(f"Command: {completed.args}") - logging.debug(f"Returncode: {completed.returncode}") - raise RuntimeError("shell command related error, find details right above this python trace") - - def generate_env(env={}, podman=False): ret = dict(env_extra) path = os.path.join(testenv.data_dir, "scripts") @@ -139,4 +131,5 @@ if p.returncode == 0 or not check: return p - exit_error_cmd(p, "Command failed unexpectedly") + logging.error(f"Command failed unexpectedly (returncode: {p.returncode})") + sys.exit(1) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I508322b017e5ed9c21396384ef759a4c49c8d3da Gerrit-Change-Number: 41868 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: testenv: check ulimit -r in prepare=
by osmith 19 Jan '26

19 Jan '26

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41862?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: bts: testenv: check ulimit -r in prepare= ...................................................................... bts: testenv: check ulimit -r in prepare= Don't respawning over and over again if osmo-bts-trx fails to start up because the user isn't allowed to set the rtpriority. Show instructions for fixing it instead. Change-Id: I7bc1414f95e4a54a40eb7c6f7b3d6c83ce3500c6 --- M _testenv/README.md A _testenv/data/scripts/require_ulimit_r.sh M _testenv/testenv/podman.py M bts/testenv_generic.cfg M bts/testenv_hopping.cfg M bts/testenv_oml.cfg 6 files changed, 31 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/62/41862/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41862?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7bc1414f95e4a54a40eb7c6f7b3d6c83ce3500c6 Gerrit-Change-Number: 41862 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: gmstap_log: optimization: Add talloc_pool for transmitted messages
by osmith 19 Jan '26

19 Jan '26

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email ) Change subject: gmstap_log: optimization: Add talloc_pool for transmitted messages ...................................................................... Patch Set 7: Code-Review+1 (1 comment) File src/core/logging_gsmtap.c: https://gerrit.osmocom.org/c/libosmocore/+/41865/comment/4372e85e_9875eab9?… : PS4, Line 77: msgb_alloc_c > And BTW, osmo-ccid-firmware is a good example using talloc: `--host=arm-none-eabi --enable-embedded […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I19cdf09f21d856e8e3646de495ce7ae040195268 Gerrit-Change-Number: 41865 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 10:04:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026