January 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-gsm-manuals[master]: logging: Improve syslog log documentation
by pespin 19 Jan '26

19 Jan '26

Attention is currently required from: daniel, fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41864?usp=email ) Change subject: logging: Improve syslog log documentation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41864?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ic3ab275fd1448e590a43251e226d690beee67004 Gerrit-Change-Number: 41864 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 09:32:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-abis[master]: ipaccess: Move bts/bsc specific line_update code to helper functions
by pespin 19 Jan '26

19 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41861?usp=email ) Change subject: ipaccess: Move bts/bsc specific line_update code to helper functions ...................................................................... ipaccess: Move bts/bsc specific line_update code to helper functions This simplifies a bit that code path, specially since reader usually only is interested at looking at only one of either bts or bsc. Change-Id: If2c081128bf8f14537d8c2c7223de371454aee6b --- M src/input/ipaccess.c 1 file changed, 126 insertions(+), 119 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index cf04538..6f3c980 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -1,6 +1,6 @@ /* OpenBSC Abis input driver for ip.access */ -/* (C) 2024 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> +/* (C) 2024-2026 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> * (C) 2009-2021 by Harald Welte <laforge(a)gnumonks.org> * (C) 2010 by Holger Hans Peter Freyther * (C) 2010 by On-Waves @@ -1010,12 +1010,128 @@ return 0; } -static int ipaccess_line_update(struct e1inp_line *line) +static int ipaccess_bsc_line_update(struct e1inp_line *line) { - int ret = -ENOENT; - struct ipaccess_line *il; + struct ipaccess_line *il = line->driver_data; + + /* We only initialize this line once. */ + if (il->line_already_initialized) + return 0; + + struct osmo_stream_srv_link *oml_link, *rsl_link; + const char *ipa = e1inp_ipa_get_bind_addr(); char conn_name[128]; + LOGPIL(line, DLINP, LOGL_NOTICE, "enabling ipaccess BSC mode on %s " + "with OML %u and RSL %u TCP ports\n", ipa, IPA_TCP_PORT_OML, IPA_TCP_PORT_RSL); + + oml_link = osmo_stream_srv_link_create(tall_ipa_ctx); + OSMO_ASSERT(oml_link); + snprintf(conn_name, sizeof(conn_name), "ts-%u-oml", line->num); + osmo_stream_srv_link_set_name(oml_link, conn_name); + osmo_stream_srv_link_set_proto(oml_link, IPPROTO_TCP); + osmo_stream_srv_link_set_addr(oml_link, ipa); + osmo_stream_srv_link_set_port(oml_link, IPA_TCP_PORT_OML); + osmo_stream_srv_link_set_data(oml_link, line); + osmo_stream_srv_link_set_nodelay(oml_link, true); + osmo_stream_srv_link_set_priority(oml_link, g_e1inp_ipaccess_pars.oml.dscp); + osmo_stream_srv_link_set_ip_dscp(oml_link, g_e1inp_ipaccess_pars.oml.priority); + osmo_stream_srv_link_set_accept_cb(oml_link, ipaccess_bsc_oml_accept_cb); + + if (osmo_stream_srv_link_open(oml_link)) { + LOGPIL(line, DLINP, LOGL_ERROR, "cannot open OML BTS link %s:%u (%s)\n", + ipa, IPA_TCP_PORT_OML, strerror(errno)); + osmo_stream_srv_link_destroy(oml_link); + return -EIO; + } + + rsl_link = osmo_stream_srv_link_create(tall_ipa_ctx); + OSMO_ASSERT(rsl_link); + snprintf(conn_name, sizeof(conn_name), "ts-%u-rsl", line->num); + osmo_stream_srv_link_set_name(rsl_link, conn_name); + osmo_stream_srv_link_set_proto(rsl_link, IPPROTO_TCP); + osmo_stream_srv_link_set_addr(rsl_link, ipa); + osmo_stream_srv_link_set_port(rsl_link, IPA_TCP_PORT_RSL); + osmo_stream_srv_link_set_data(rsl_link, line); + osmo_stream_srv_link_set_nodelay(rsl_link, true); + osmo_stream_srv_link_set_priority(rsl_link, g_e1inp_ipaccess_pars.rsl.dscp); + osmo_stream_srv_link_set_ip_dscp(rsl_link, g_e1inp_ipaccess_pars.rsl.priority); + osmo_stream_srv_link_set_accept_cb(rsl_link, ipaccess_bsc_rsl_accept_cb); + + if (osmo_stream_srv_link_open(rsl_link)) { + LOGPIL(line, DLINP, LOGL_ERROR, "cannot open RSL BTS link %s:%u (%s)\n", + ipa, IPA_TCP_PORT_RSL, strerror(errno)); + osmo_stream_srv_link_destroy(rsl_link); + return -EIO; + } + + il->line_already_initialized = true; + return 0; +} + +static int ipaccess_bts_line_update(struct e1inp_line *line) +{ + struct ipaccess_line *il = line->driver_data; + struct osmo_stream_cli *cli; + struct e1inp_ts *e1i_ts = e1inp_line_ipa_oml_ts(line); + char cli_name[128]; + + LOGPITS(e1i_ts, DLINP, LOGL_NOTICE, "enabling ipaccess BTS mode, " + "OML connecting to %s:%u\n", line->ops->cfg.ipa.addr, IPA_TCP_PORT_OML); + + /* Drop previous line */ + if (il->ipa_cli[0]) { + osmo_stream_cli_close(il->ipa_cli[0]); + ipaccess_keepalive_fsm_cleanup(e1i_ts); + e1i_ts->driver.ipaccess.fd.fd = -1; + osmo_stream_cli_destroy(il->ipa_cli[0]); + il->ipa_cli[0] = NULL; + } + + e1inp_ts_config_sign(e1i_ts, line); + + cli = osmo_stream_cli_create(tall_ipa_ctx); + OSMO_ASSERT(cli); + + snprintf(cli_name, sizeof(cli_name), "ts-%u-%u-oml", line->num, e1i_ts->num); + osmo_stream_cli_set_name(cli, cli_name); + osmo_stream_cli_set_data(cli, e1i_ts); + osmo_stream_cli_set_addr(cli, line->ops->cfg.ipa.addr); + osmo_stream_cli_set_port(cli, IPA_TCP_PORT_OML); + osmo_stream_cli_set_proto(cli, IPPROTO_TCP); + osmo_stream_cli_set_nodelay(cli, true); + osmo_stream_cli_set_priority(cli, g_e1inp_ipaccess_pars.oml.dscp); + osmo_stream_cli_set_ip_dscp(cli, g_e1inp_ipaccess_pars.oml.priority); + + /* Reconnect is handled by upper layers: */ + osmo_stream_cli_set_reconnect_timeout(cli, -1); + + osmo_stream_cli_set_segmentation_cb(cli, osmo_ipa_segmentation_cb); + osmo_stream_cli_set_connect_cb(cli, ipaccess_bts_connect_cb); + osmo_stream_cli_set_disconnect_cb(cli, ipaccess_bts_disconnect_cb); + osmo_stream_cli_set_read_cb2(cli, ipaccess_bts_read_cb); + + cli_apply_tcp_pars(line, cli); + + if (osmo_stream_cli_open(cli)) { + LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "cannot open OML BTS link: %s\n", strerror(errno)); + osmo_stream_cli_destroy(cli); + return -EIO; + } + + /* Compatibility with older ofd based implementation. osmo-bts accesses + * this fd directly in get_signlink_remote_ip() and get_rsl_local_ip() */ + e1i_ts->driver.ipaccess.fd.fd = osmo_stream_cli_get_fd(cli); + + ipaccess_bts_keepalive_fsm_alloc(e1i_ts, cli, "oml_bts_to_bsc"); + il->ipa_cli[0] = cli; + + il->line_already_initialized = true; + return 0; +} + +static int ipaccess_line_update(struct e1inp_line *line) +{ if (!line->driver_data) line->driver_data = talloc_zero(line, struct ipaccess_line); @@ -1023,124 +1139,15 @@ LOGPIL(line, DLINP, LOGL_ERROR, "ipaccess: OOM in line update\n"); return -ENOMEM; } - il = line->driver_data; - switch(line->ops->cfg.ipa.role) { - case E1INP_LINE_R_BSC: { - /* We only initialize this line once. */ - if (il->line_already_initialized) - return 0; - struct osmo_stream_srv_link *oml_link, *rsl_link; - const char *ipa = e1inp_ipa_get_bind_addr(); - - LOGPIL(line, DLINP, LOGL_NOTICE, "enabling ipaccess BSC mode on %s " - "with OML %u and RSL %u TCP ports\n", ipa, IPA_TCP_PORT_OML, IPA_TCP_PORT_RSL); - - oml_link = osmo_stream_srv_link_create(tall_ipa_ctx); - OSMO_ASSERT(oml_link); - snprintf(conn_name, sizeof(conn_name), "ts-%u-oml", line->num); - osmo_stream_srv_link_set_name(oml_link, conn_name); - osmo_stream_srv_link_set_proto(oml_link, IPPROTO_TCP); - osmo_stream_srv_link_set_addr(oml_link, ipa); - osmo_stream_srv_link_set_port(oml_link, IPA_TCP_PORT_OML); - osmo_stream_srv_link_set_data(oml_link, line); - osmo_stream_srv_link_set_nodelay(oml_link, true); - osmo_stream_srv_link_set_priority(oml_link, g_e1inp_ipaccess_pars.oml.dscp); - osmo_stream_srv_link_set_ip_dscp(oml_link, g_e1inp_ipaccess_pars.oml.priority); - osmo_stream_srv_link_set_accept_cb(oml_link, ipaccess_bsc_oml_accept_cb); - - if (osmo_stream_srv_link_open(oml_link)) { - LOGPIL(line, DLINP, LOGL_ERROR, "cannot open OML BTS link %s:%u (%s)\n", - ipa, IPA_TCP_PORT_OML, strerror(errno)); - osmo_stream_srv_link_destroy(oml_link); - return -EIO; - } - - rsl_link = osmo_stream_srv_link_create(tall_ipa_ctx); - OSMO_ASSERT(rsl_link); - snprintf(conn_name, sizeof(conn_name), "ts-%u-rsl", line->num); - osmo_stream_srv_link_set_name(rsl_link, conn_name); - osmo_stream_srv_link_set_proto(rsl_link, IPPROTO_TCP); - osmo_stream_srv_link_set_addr(rsl_link, ipa); - osmo_stream_srv_link_set_port(rsl_link, IPA_TCP_PORT_RSL); - osmo_stream_srv_link_set_data(rsl_link, line); - osmo_stream_srv_link_set_nodelay(rsl_link, true); - osmo_stream_srv_link_set_priority(rsl_link, g_e1inp_ipaccess_pars.rsl.dscp); - osmo_stream_srv_link_set_ip_dscp(rsl_link, g_e1inp_ipaccess_pars.rsl.priority); - osmo_stream_srv_link_set_accept_cb(rsl_link, ipaccess_bsc_rsl_accept_cb); - - if (osmo_stream_srv_link_open(rsl_link)) { - LOGPIL(line, DLINP, LOGL_ERROR, "cannot open RSL BTS link %s:%u (%s)\n", - ipa, IPA_TCP_PORT_RSL, strerror(errno)); - osmo_stream_srv_link_destroy(rsl_link); - return -EIO; - } - ret = 0; - break; - } - case E1INP_LINE_R_BTS: { - struct osmo_stream_cli *cli; - struct e1inp_ts *e1i_ts = e1inp_line_ipa_oml_ts(line); - char cli_name[128]; - - LOGPITS(e1i_ts, DLINP, LOGL_NOTICE, "enabling ipaccess BTS mode, " - "OML connecting to %s:%u\n", line->ops->cfg.ipa.addr, IPA_TCP_PORT_OML); - - /* Drop previous line */ - if (il->ipa_cli[0]) { - osmo_stream_cli_close(il->ipa_cli[0]); - ipaccess_keepalive_fsm_cleanup(e1i_ts); - e1i_ts->driver.ipaccess.fd.fd = -1; - osmo_stream_cli_destroy(il->ipa_cli[0]); - il->ipa_cli[0] = NULL; - } - - e1inp_ts_config_sign(e1i_ts, line); - - cli = osmo_stream_cli_create(tall_ipa_ctx); - OSMO_ASSERT(cli); - - snprintf(cli_name, sizeof(cli_name), "ts-%u-%u-oml", line->num, e1i_ts->num); - osmo_stream_cli_set_name(cli, cli_name); - osmo_stream_cli_set_data(cli, e1i_ts); - osmo_stream_cli_set_addr(cli, line->ops->cfg.ipa.addr); - osmo_stream_cli_set_port(cli, IPA_TCP_PORT_OML); - osmo_stream_cli_set_proto(cli, IPPROTO_TCP); - osmo_stream_cli_set_nodelay(cli, true); - osmo_stream_cli_set_priority(cli, g_e1inp_ipaccess_pars.oml.dscp); - osmo_stream_cli_set_ip_dscp(cli, g_e1inp_ipaccess_pars.oml.priority); - - /* Reconnect is handled by upper layers: */ - osmo_stream_cli_set_reconnect_timeout(cli, -1); - - osmo_stream_cli_set_segmentation_cb(cli, osmo_ipa_segmentation_cb); - osmo_stream_cli_set_connect_cb(cli, ipaccess_bts_connect_cb); - osmo_stream_cli_set_disconnect_cb(cli, ipaccess_bts_disconnect_cb); - osmo_stream_cli_set_read_cb2(cli, ipaccess_bts_read_cb); - - cli_apply_tcp_pars(line, cli); - - if (osmo_stream_cli_open(cli)) { - LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "cannot open OML BTS link: %s\n", strerror(errno)); - osmo_stream_cli_destroy(cli); - return -EIO; - } - - /* Compatibility with older ofd based implementation. osmo-bts accesses - * this fd directly in get_signlink_remote_ip() and get_rsl_local_ip() */ - e1i_ts->driver.ipaccess.fd.fd = osmo_stream_cli_get_fd(cli); - - ipaccess_bts_keepalive_fsm_alloc(e1i_ts, cli, "oml_bts_to_bsc"); - il->ipa_cli[0] = cli; - ret = 0; - break; - } + switch (line->ops->cfg.ipa.role) { + case E1INP_LINE_R_BSC: + return ipaccess_bsc_line_update(line); + case E1INP_LINE_R_BTS: + return ipaccess_bts_line_update(line); default: - break; + return -ENOENT; } - - il->line_already_initialized = true; - return ret; } /* backwards compatibility */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41861?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: If2c081128bf8f14537d8c2c7223de371454aee6b Gerrit-Change-Number: 41861 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: configure.ac: EMBEDDED modifies default AC_ARG_ENABLE values
by pespin 19 Jan '26

19 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41867?usp=email ) Change subject: configure.ac: EMBEDDED modifies default AC_ARG_ENABLE values ...................................................................... configure.ac: EMBEDDED modifies default AC_ARG_ENABLE values Change-Id: I164eb461fb59c7675393219102740f40c1119fdd --- M configure.ac 1 file changed, 89 insertions(+), 77 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/67/41867/1 diff --git a/configure.ac b/configure.ac index aa3e251..565d392 100644 --- a/configure.ac +++ b/configure.ac @@ -187,13 +187,69 @@ PKG_CHECK_MODULES(TALLOC, [talloc >= 2.1.0]) +ENABLE_URING_DEFAULT="yes" +ENABLE_PCSC_DEFAULT="yes" +ENABLE_LIBUSB_DEFAULT="yes" +ENABLE_GNUTLS_DEFAULT="yes" +ENABLE_SYSLOG_LOGGING_DEFAULT="yes" +ENABLE_SYSTEMD_LOGGING_DEFAULT="no" +ENABLE_LIBMNL_DEFAULT="yes" +ENABLE_LIBSCTP_DEFAULT="yes" +ENABLE_SCTP_TESTS_DEFAULT="yes" +ENABLE_URING_TESTS_DEFAULT="yes" +ENABLE_PLUGIN_DEFAULT="yes" +ENABLE_VTY_DEFAULT="yes" +ENABLE_PANIC_INFLOOP_DEFAULT="no" +ENABLE_OSMO_FD_CHECK_DEFAULT="no" +ENABLE_FORCE_IO_SELECT_DEFAULT="no" +ENABLE_MSGFILE_DEFAULT="yes" +ENABLE_SERIAL_DEFAULT="yes" +ENABLE_UTILITIES_DEFAULT="yes" +ENABLE_GB_DEFAULT="yes" +ENABLE_CTRL_DEFAULT="yes" +ENABLE_PSEUDOTALLOC_DEFAULT="no" +ENABLE_EMBEDDED_DEFAULT="no" +ENABLE_LIBOSMOCORE_NO_LOGGING_DEFAULT="no" +ENABLE_SANITIZE_DEFAULT="no" +ENABLE_WERROR_DEFAULT="no" +ENABLE_EXT_TESTS_DEFAULT="no" +ENABLE_SIMD_SUPPORT_DEFAULT="yes" +ENABLE_NEON_SUPPORT_DEFAULT="no" +ENABLE_SYSTEMTAP_DEFAULT="no" + +AC_ARG_ENABLE(embedded, + [AS_HELP_STRING( + [--enable-embedded], + [Enable building for embedded use and disable unsupported features] + )], + [embedded=$enableval], [embedded=$ENABLE_EMBEDDED_DEFAULT]) +AM_CONDITIONAL(EMBEDDED, test x"$embedded" = x"yes") +AM_CONDITIONAL(ENABLE_SERCOM_STUB, test x"$embedded" = x"yes") + +if test x"$embedded" = x"yes" +then + AC_DEFINE([EMBEDDED],[1],[Select building for embedded use]) + ENABLE_PLUGIN_DEFAULT="no" + ENABLE_MSGFILE_DEFAULT="no" + ENABLE_SERIAL_DEFAULT="no" + ENABLE_GNUTLS_DEFAULT="no" + ENABLE_VTY_DEFAULT="no" + ENABLE_CTRL_DEFAULT="no" + ENABLE_UTILITIES_DEFAULT="no" + ENABLE_GB_DEFAULT="no" + ENABLE_LIBMNL_DEFAULT="no" + ENABLE_LIBSCTP_DEFAULT="no" + ENABLE_LIBUSB_DEFAULT="no" + ENABLE_PCSC_DEFAULT="no" + ENABLE_URING_DEFAULT="no" + ENABLE_PSEUDOTALLOC_DEFAULT="yes" + ENABLE_SYSLOG_LOGGING_DEFAULT="no" + ENABLE_PANIC_INFLOOP_DEFAULT="yes" + ENABLE_GNUTLS_DEFAULT="no" +fi + AC_ARG_ENABLE([uring], [AS_HELP_STRING([--disable-uring], [Build without io_uring support])], - [ - ENABLE_URING=$enableval - ], - [ - ENABLE_URING="yes" - ]) + [ENABLE_URING=$enableval], [ENABLE_URING=$ENABLE_URING_DEFAULT]) AS_IF([test "x$ENABLE_URING" = "xyes"], [ PKG_CHECK_MODULES(URING, [liburing >= 0.7]) AC_DEFINE([HAVE_URING],[1],[Build with io_uring support]) @@ -202,12 +258,7 @@ AC_SUBST(ENABLE_URING) AC_ARG_ENABLE([pcsc], [AS_HELP_STRING([--disable-pcsc], [Build without PC/SC support])], - [ - ENABLE_PCSC=$enableval - ], - [ - ENABLE_PCSC="yes" - ]) + [ENABLE_PCSC=$enableval], [ENABLE_PCSC=$ENABLE_PCSC_DEFAULT]) AS_IF([test "x$ENABLE_PCSC" = "xyes"], [ PKG_CHECK_MODULES(PCSC, libpcsclite) AC_DEFINE([HAVE_PCSC],[1],[Build with PC/SC support]) @@ -216,12 +267,7 @@ AC_SUBST(ENABLE_PCSC) AC_ARG_ENABLE([libusb], [AS_HELP_STRING([--disable-libusb], [Build without libusb support])], - [ - ENABLE_LIBUSB=$enableval - ], - [ - ENABLE_LIBUSB="yes" - ]) + [ENABLE_LIBUSB=$enableval], [ENABLE_LIBUSB=$ENABLE_LIBUSB_DEFAULT]) AS_IF([test "x$ENABLE_LIBUSB" = "xyes"], [ PKG_CHECK_MODULES(LIBUSB, libusb-1.0) ]) @@ -229,7 +275,7 @@ AC_SUBST(ENABLE_LIBUSB) AC_ARG_ENABLE([gnutls], [AS_HELP_STRING([--disable-gnutls], [Do not use GnuTLS fallback for missing getrandom()])], - [ENABLE_GNUTLS=$enableval], [ENABLE_GNUTLS="yes"]) + [ENABLE_GNUTLS=$enableval], [ENABLE_GNUTLS=$ENABLE_GNUTLS_DEFAULT]) AM_CONDITIONAL(ENABLE_GNUTLS, test x"$ENABLE_GNUTLS" = x"yes") AS_IF([test "x$ENABLE_GNUTLS" = "xyes"], [ PKG_CHECK_MODULES([LIBGNUTLS], [gnutls >= 2.12.0]) @@ -247,7 +293,7 @@ [--disable-syslog-logging], [Build without syslog logging support] )], - [syslog_logging=$enableval], [syslog_logging="yes"]) + [syslog_logging=$enableval], [syslog_logging=$ENABLE_SYSLOG_LOGGING_DEFAULT]) AS_IF([test "x$syslog_logging" = "xyes"], [ AC_CHECK_HEADER([syslog.h], [SYSLOG_H_FOUND='yes'], [SYSLOG_H_FOUND='no'; @@ -262,7 +308,7 @@ [--enable-systemd-logging], [Build with systemd-journal logging support] )], - [systemd_logging=$enableval], [systemd_logging="no"]) + [systemd_logging=$enableval], [systemd_logging=$ENABLE_SYSTEMD_LOGGING_DEFAULT]) AS_IF([test "x$systemd_logging" = "xyes"], [ PKG_CHECK_MODULES(SYSTEMD, libsystemd) AC_DEFINE([ENABLE_SYSTEMD_LOGGING], [1], [Enable systemd-journal logging target]) @@ -275,7 +321,7 @@ [--disable-libmnl], [Build without netlink socket support via libmnl] )], - [mnl=$enableval], [mnl="yes"]) + [mnl=$enableval], [mnl=$ENABLE_LIBMNL_DEFAULT]) AS_IF([test "x$mnl" = "xyes"], [ PKG_CHECK_MODULES(LIBMNL, libmnl, [AC_SUBST(LIBMNL_PC, [libmnl])]) AC_DEFINE([ENABLE_LIBMNL], [1], [Enable netlink socket support via libmnl]) @@ -284,7 +330,7 @@ AC_SUBST(ENABLE_LIBMNL) AC_ARG_ENABLE([libsctp], [AS_HELP_STRING([--disable-libsctp], [Do not enable socket multiaddr APIs requiring libsctp])], - [ENABLE_LIBSCTP=$enableval], [ENABLE_LIBSCTP="yes"]) + [ENABLE_LIBSCTP=$enableval], [ENABLE_LIBSCTP=$ENABLE_LIBSCTP_DEFAULT]) AM_CONDITIONAL(ENABLE_LIBSCTP, test x"$ENABLE_LIBSCTP" = x"yes") AS_IF([test "x$ENABLE_LIBSCTP" = "xyes"], [ AC_DEFINE(HAVE_LIBSCTP, 1, [Define 1 to enable SCTP support]) @@ -306,11 +352,11 @@ ]) AC_ARG_ENABLE([sctp-tests], [AS_HELP_STRING([--disable-sctp-tests], [Do not run socket tests requiring system SCTP support])], - [ENABLE_SCTP_TESTS=$enableval], [ENABLE_SCTP_TESTS="yes"]) + [ENABLE_SCTP_TESTS=$enableval], [ENABLE_SCTP_TESTS=$ENABLE_SCTP_TESTS_DEFAULT]) AM_CONDITIONAL(ENABLE_SCTP_TESTS, test x"$ENABLE_SCTP_TESTS" = x"yes") AC_ARG_ENABLE([uring-tests], [AS_HELP_STRING([--disable-uring-tests], [Do not run io_uring tests])], - [ENABLE_URING_TESTS=$enableval], [ENABLE_URING_TESTS="yes"]) + [ENABLE_URING_TESTS=$enableval], [ENABLE_URING_TESTS=$ENABLE_URING_TESTS_DEFAULT]) AM_CONDITIONAL(ENABLE_URING_TESTS, test x"$ENABLE_URING_TESTS" = x"yes") AC_SUBST(ENABLE_URING_TESTS) @@ -319,7 +365,7 @@ [--disable-plugin], [Disable support for dlopen plugins], )], - [enable_plugin=$enableval], [enable_plugin="yes"]) + [enable_plugin=$enableval], [enable_plugin=$ENABLE_PLUGIN_DEFAULT]) AM_CONDITIONAL(ENABLE_PLUGIN, test x"$enable_plugin" = x"yes") AC_ARG_ENABLE(vty, @@ -327,7 +373,7 @@ [--disable-vty], [Disable building VTY telnet interface] )], - [enable_vty=$enableval], [enable_vty="yes"]) + [enable_vty=$enableval], [enable_vty=$ENABLE_VTY_DEFAULT]) AM_CONDITIONAL(ENABLE_VTY, test x"$enable_vty" = x"yes") AC_ARG_ENABLE(panic_infloop, @@ -335,7 +381,7 @@ [--enable-panic-infloop], [Trigger infinite loop on panic rather than fprintf/abort] )], - [panic_infloop=$enableval], [panic_infloop="no"]) + [panic_infloop=$enableval], [panic_infloop=$ENABLE_PANIC_INFLOOP_DEFAULT]) if test x"$panic_infloop" = x"yes" then AC_DEFINE([PANIC_INFLOOP],[1],[Use infinite loop on panic rather than fprintf/abort]) @@ -346,7 +392,7 @@ [--enable-ofd-check], [Instrument osmo_fd_register to check that the fd is registered] )], - [fd_check=$enableval], [fd_check="no"]) + [fd_check=$enableval], [fd_check=$ENABLE_OSMO_FD_CHECK_DEFAULT]) if test x"$fd_check" = x"yes" then AC_DEFINE([OSMO_FD_CHECK], [1], [Instrument the osmo_fd_register]) @@ -357,7 +403,7 @@ [--enable-force-io-select], [Build with old select I/O instead of poll] )], - [force_io_select=$enableval], [force_io_select="no"]) + [force_io_select=$enableval], [force_io_select=$ENABLE_FORCE_IO_SELECT_DEFAULT]) AS_IF([test "x$force_io_select" = "xyes"], [ AC_DEFINE([FORCE_IO_SELECT], [1], [Force the use of select() instead of poll()]) ]) @@ -367,7 +413,7 @@ [--disable-msgfile], [Disable support for the msgfile], )], - [enable_msgfile=$enableval], [enable_msgfile="yes"]) + [enable_msgfile=$enableval], [enable_msgfile=$ENABLE_MSGFILE_DEFAULT]) AM_CONDITIONAL(ENABLE_MSGFILE, test x"$enable_msgfile" = x"yes") AC_ARG_ENABLE(serial, @@ -375,7 +421,7 @@ [--disable-serial], [Disable support for the serial helpers], )], - [enable_serial=$enableval], [enable_serial="yes"]) + [enable_serial=$enableval], [enable_serial=$ENABLE_SERIAL_DEFAULT]) AM_CONDITIONAL(ENABLE_SERIAL, test x"$enable_serial" = x"yes") AC_ARG_ENABLE(utilities, @@ -383,7 +429,7 @@ [--disable-utilities], [Disable building utility programs], )], - [enable_utilities=$enableval], [enable_utilities="yes"]) + [enable_utilities=$enableval], [enable_utilities=$ENABLE_UTILITIES_DEFAULT]) AM_CONDITIONAL(ENABLE_UTILITIES, test x"$enable_utilities" = x"yes") AC_ARG_ENABLE(gb, @@ -391,7 +437,7 @@ [--disable-gb], [Disable building Gb library], )], - [enable_gb=$enableval], [enable_gb="yes"]) + [enable_gb=$enableval], [enable_gb=$ENABLE_GB_DEFAULT]) AM_CONDITIONAL(ENABLE_GB, test x"$enable_gb" = x"yes") AC_ARG_ENABLE(ctrl, @@ -399,7 +445,7 @@ [--disable-ctrl], [Disable building CTRL library], )], - [enable_ctrl=$enableval], [enable_ctrl="yes"]) + [enable_ctrl=$enableval], [enable_ctrl=$ENABLE_CTRL_DEFAULT]) AM_CONDITIONAL(ENABLE_CTRL, test x"$enable_ctrl" = x"yes") AC_ARG_ENABLE(pseudotalloc, @@ -407,49 +453,15 @@ [--enable-pseudotalloc], [Enable building pseudotalloc library], )], - [enable_pseudotalloc=$enableval], [enable_pseudotalloc="no"]) + [enable_pseudotalloc=$enableval], [enable_pseudotalloc=$ENABLE_PSEUDOTALLOC_DEFAULT]) AM_CONDITIONAL(ENABLE_PSEUDOTALLOC, test x"$enable_pseudotalloc" = x"yes") -AC_ARG_ENABLE(embedded, - [AS_HELP_STRING( - [--enable-embedded], - [Enable building for embedded use and disable unsupported features] - )], - [embedded=$enableval], [embedded="no"]) - -AM_CONDITIONAL(EMBEDDED, false) -AM_CONDITIONAL(ENABLE_SERCOM_STUB, false) - -if test x"$embedded" = x"yes" -then - AC_DEFINE([EMBEDDED],[1],[Select building for embedded use]) - AM_CONDITIONAL(ENABLE_PLUGIN, false) - AM_CONDITIONAL(ENABLE_MSGFILE, false) - AM_CONDITIONAL(ENABLE_SERIAL, false) - AM_CONDITIONAL(ENABLE_GNUTLS, false) - AM_CONDITIONAL(ENABLE_VTY, false) - AM_CONDITIONAL(ENABLE_CTRL, false) - AM_CONDITIONAL(ENABLE_UTILITIES, false) - AM_CONDITIONAL(ENABLE_GB, false) - AM_CONDITIONAL(ENABLE_LIBMNL, false) - AM_CONDITIONAL(ENABLE_LIBSCTP, false) - AM_CONDITIONAL(ENABLE_LIBUSB, false) - AM_CONDITIONAL(ENABLE_PCSC, false) - AM_CONDITIONAL(ENABLE_URING, false) - AM_CONDITIONAL(ENABLE_PSEUDOTALLOC, true) - AM_CONDITIONAL(ENABLE_SERCOM_STUB, true) - AM_CONDITIONAL(ENABLE_SYSLOG_LOGGING, false) - AM_CONDITIONAL(EMBEDDED, true) - AC_DEFINE([USE_GNUTLS], [0]) - AC_DEFINE([PANIC_INFLOOP],[1],[Use infinite loop on panic rather than fprintf/abort]) -fi - AC_ARG_ENABLE(log_macros, [AS_HELP_STRING( [--disable-log-macros], [Disable logging macros that are also used internally to print information] )], - [log_macros="yes"], [log_macros="no"]) + [log_macros=$enableval], [log_macros=$ENABLE_LIBOSMOCORE_NO_LOGGING_DEFAULT]) if test x"$log_macros" == x"yes" then AC_DEFINE([LIBOSMOCORE_NO_LOGGING],[1],[Disable logging macros]) @@ -460,7 +472,7 @@ [--enable-sanitize], [Compile with address sanitizer enabled], )], - [sanitize=$enableval], [sanitize="no"]) + [sanitize=$enableval], [sanitize=$ENABLE_SANITIZE_DEFAULT]) if test x"$sanitize" = x"yes" then CFLAGS="$CFLAGS -fsanitize=address -fsanitize=undefined" @@ -475,7 +487,7 @@ b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) ] )], - [werror=$enableval], [werror="no"]) + [werror=$enableval], [werror=$ENABLE_WERROR_DEFAULT]) if test x"$werror" = x"yes" then WERROR_FLAGS="-Werror" @@ -489,7 +501,7 @@ AC_ARG_ENABLE([external_tests], AC_HELP_STRING([--enable-external-tests], [Include the VTY/CTRL tests in make check [default=no]]), - [enable_ext_tests="$enableval"],[enable_ext_tests="no"]) + [enable_ext_tests="$enableval"],[enable_ext_tests=$ENABLE_EXT_TESTS_DEFAULT]) if test "x$enable_ext_tests" = "xyes" ; then AC_CHECK_PROG(OSMOTESTEXT_CHECK,osmo_verify_transcript_vty.py,yes) if test "x$OSMOTESTEXT_CHECK" != "xyes" ; then @@ -508,7 +520,7 @@ [--disable-simd], [Disable SIMD support] )], - [simd=$enableval], [simd="yes"]) + [simd=$enableval], [simd=$ENABLE_SIMD_SUPPORT_DEFAULT]) if test x"$simd" = x"yes" then # Find and define supported SIMD extensions @@ -524,7 +536,7 @@ [--enable-neon], [Enable ARM NEON instructions support [default=no]] )], - [neon=$enableval], [neon="no"]) + [neon=$enableval], [neon=$ENABLE_NEON_SUPPORT_DEFAULT]) AS_IF([test "x$neon" = "xyes"], [ AC_DEFINE([HAVE_NEON],, [Support ARM NEON instructions]) ]) @@ -539,7 +551,7 @@ AC_ARG_ENABLE([systemtap], [AS_HELP_STRING([--enable-systemtap], [Enable inclusion of systemtap trace support])], - [ENABLE_SYSTEMTAP="${enableval}"], [ENABLE_SYSTEMTAP='no']) + [ENABLE_SYSTEMTAP="${enableval}"], [ENABLE_SYSTEMTAP=$ENABLE_SYSTEMTAP_DEFAULT]) AM_CONDITIONAL([ENABLE_SYSTEMTAP], [test x$ENABLE_SYSTEMTAP = xyes]) AC_MSG_RESULT(${ENABLE_SYSTEMTAP}) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41867?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I164eb461fb59c7675393219102740f40c1119fdd Gerrit-Change-Number: 41867 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: add MME pool related REST definitions
by osmith 19 Jan '26

19 Jan '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41764?usp=email ) Change subject: s1gw: add MME pool related REST definitions ...................................................................... Patch Set 1: (1 comment) File s1gw/S1GW_REST_Functions.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41764/comment/f0bb2658_2f8d… : PS1, Line 66: var HTTPMessage rsp := f_http_transact("/mme-list", method := "POST", Is `/mme-list` correct here, or should it be `/mme`? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41764?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I76f1a5cf41331d021c08fbefdf78e34da4ac2121 Gerrit-Change-Number: 41764 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 09:19:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-gsm-manuals[master]: logging: Improve syslog log documentation
by osmith 19 Jan '26

19 Jan '26

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41864?usp=email ) Change subject: logging: Improve syslog log documentation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41864?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ic3ab275fd1448e590a43251e226d690beee67004 Gerrit-Change-Number: 41864 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 09:17:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-abis[master]: ipaccess: Move bts/bsc specific line_update code to helper functions
by osmith 19 Jan '26

19 Jan '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41861?usp=email ) Change subject: ipaccess: Move bts/bsc specific line_update code to helper functions ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41861?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: If2c081128bf8f14537d8c2c7223de371454aee6b Gerrit-Change-Number: 41861 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 09:15:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in docker-playground[master]: ttcn3-bts-test: bpftrace: filter by executable name
by osmith 19 Jan '26

19 Jan '26

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/docker-playground/+/41778?usp=email ) Change subject: ttcn3-bts-test: bpftrace: filter by executable name ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I04c2e36806534a8ca650733bacf521ea57950692 Gerrit-Change-Number: 41778 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 09:14:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: gmstap_log: optimization: Add talloc_pool for transmitted messages
by osmith 19 Jan '26

19 Jan '26

Attention is currently required from: daniel, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email ) Change subject: gmstap_log: optimization: Add talloc_pool for transmitted messages ...................................................................... Patch Set 5: (3 comments) File src/core/logging_gsmtap.c: https://gerrit.osmocom.org/c/libosmocore/+/41865/comment/264efcc3_aaa73842?… : PS5, Line 171: sutrct struct https://gerrit.osmocom.org/c/libosmocore/+/41865/comment/7b66e8ab_7f6b7e0b?… : PS5, Line 178: target->output = tall_msgb_ctx; `target->output` gets set in this patch. But where will it get used, maybe explain in the commit message? https://gerrit.osmocom.org/c/libosmocore/+/41865/comment/eb98031d_0be031c4?… : PS5, Line 179: #endif /* ifndef EMBEDDED */ ```suggestion #endif /* ifndef PSEUDO_TALLOC */ ``` -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I19cdf09f21d856e8e3646de495ce7ae040195268 Gerrit-Change-Number: 41865 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 09:09:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-bts[master]: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state
by pespin 19 Jan '26

19 Jan '26

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email ) Change subject: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: ping -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0e2a6c2c33e0ac9a0bc1734d83eaeafc27f2f4df Gerrit-Change-Number: 41807 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 08:43:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmocore[master]: gmstap_log: optimization: Add talloc_pool for transmitted messages
by pespin 19 Jan '26

19 Jan '26

Attention is currently required from: daniel, laforge, osmith, pespin. Hello Jenkins Builder, daniel, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+2 by pespin, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: gmstap_log: optimization: Add talloc_pool for transmitted messages ...................................................................... gmstap_log: optimization: Add talloc_pool for transmitted messages In synchronous modes (blocking and non-blocking), set a pool size of 1 msgb. This way we avoid re-allocating the msgb with malloc/free everytime a gsmtap_log msg is transmitted over the target, and instead we allocate the msgb during creation of the target. In asynchronous mode (workqueue), create a pool of 100 msgbs, which should in general be enough to speedup more usual needs. If more than 100 msgbs are to be enqueued into the gsmtap_inst, then they will be allocated as normal talloc contexts. Since the struct log_target is public, it is currently not possible to add new fields to it under "tgt_gsmtap" without breaking the ABI. Hence, the ->output field, which is unused in this target, is reused to store the pool object internally. Change-Id: I19cdf09f21d856e8e3646de495ce7ae040195268 --- M configure.ac M src/core/logging_gsmtap.c 2 files changed, 33 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/65/41865/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I19cdf09f21d856e8e3646de495ce7ae040195268 Gerrit-Change-Number: 41865 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026