January 2026 - gerrit-log - lists.osmocom.org

[XL] Change in pysim[master]: pySim-shell: add testsuite for pySim-shell
by dexter 05 Jan '26

05 Jan '26

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/23802?usp=email ) Change subject: pySim-shell: add testsuite for pySim-shell ...................................................................... Abandoned This is an older approach that is superseded by the pySim-shell testsuite we currently have in place. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23802?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibb1bdc89a7e2b7a1232124ae28f054e5c920aadc Gerrit-Change-Number: 23802 Gerrit-PatchSet: 16 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[M] Change in pysim[master]: contrib: add a tool to parse the SIMA response from an eUICC
by dexter 05 Jan '26

05 Jan '26

Attention is currently required from: laforge, osmith. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/40936?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: contrib: add a tool to parse the SIMA response from an eUICC ...................................................................... contrib: add a tool to parse the SIMA response from an eUICC When an eUICC performs a profile installation it returns a (concatenated) series of ASN.1 encoded strings as "simaResponse". In case the profile installation fails for some reason the simaResponse contains diagnostic information to diagnose why the profile installation failed. Unfortunately there are currently no practical tools available to decode and display the information in the simaResponse. Let's add a tool for that. Related SYS#7617 Change-Id: Ida4c3c5446653b283a3869c0c387f328ae51e55e --- A contrib/analyze_simaResponse.py 1 file changed, 112 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/36/40936/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40936?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ida4c3c5446653b283a3869c0c387f328ae51e55e Gerrit-Change-Number: 40936 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[M] Change in pysim[master]: contrib: add a tool to parse the SIMA response from an eUICC
by dexter 05 Jan '26

05 Jan '26

Attention is currently required from: laforge, osmith. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/40936?usp=email ) Change subject: contrib: add a tool to parse the SIMA response from an eUICC ...................................................................... Patch Set 4: (2 comments) File contrib/analyze_simaResponse.py: https://gerrit.osmocom.org/c/pysim/+/40936/comment/2d086679_5d5a2f4a?usp=em… : PS3, Line 3: # A tool to anylaze the eUICC simaResponse (series of EUICCResponse) > sp: analyze Done https://gerrit.osmocom.org/c/pysim/+/40936/comment/74c8ed9f_b918cfe8?usp=em… : PS3, Line 5: Sysmocom s.f.m.c. GmbH > the correct abbreviated version of the company name is "sysmocom - s.f.m.c. GmbH", i.e. […] I have copied the header from another file. Its actually written wrong in a lot of places. I have fixed this in a follow up patch. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40936?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ida4c3c5446653b283a3869c0c387f328ae51e55e Gerrit-Change-Number: 40936 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 05 Jan 2026 15:21:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: cosmetic: fix company name in copyright header.
by dexter 05 Jan '26

05 Jan '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41767?usp=email ) Change subject: cosmetic: fix company name in copyright header. ...................................................................... cosmetic: fix company name in copyright header. The correct abbreviated version of the company name is "sysmocom - s.f.m.c. GmbH", i.e. lowercase and with dash. Change-Id: Id768d2f4b78162ff83320a800e4e66f1bd324d6d --- M pySim/card_handler.py M pySim/card_key_provider.py M pySim/global_platform/install_param.py M pySim/javacard.py M pySim/log.py M pySim/profile.py M tests/pySim-prog_test/pySim-prog_test.sh M tests/pySim-trace_test/pySim-trace_test.sh M tests/unittests/test_log.py 9 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/67/41767/1 diff --git a/pySim/card_handler.py b/pySim/card_handler.py index e7884ad..f081b90 100644 --- a/pySim/card_handler.py +++ b/pySim/card_handler.py @@ -7,7 +7,7 @@ """ # -# (C) 2019 by Sysmocom s.f.m.c. GmbH +# (C) 2019 by sysmocom - s.f.m.c. GmbH # All Rights Reserved # # This program is free software: you can redistribute it and/or modify diff --git a/pySim/card_key_provider.py b/pySim/card_key_provider.py index f614edc..227046c 100644 --- a/pySim/card_key_provider.py +++ b/pySim/card_key_provider.py @@ -10,7 +10,7 @@ operation with pySim-shell. """ -# (C) 2021-2025 by Sysmocom s.f.m.c. GmbH +# (C) 2021-2025 by sysmocom - s.f.m.c. GmbH # All Rights Reserved # # Author: Philipp Maier, Harald Welte diff --git a/pySim/global_platform/install_param.py b/pySim/global_platform/install_param.py index ec0ef66..89e6c7f 100644 --- a/pySim/global_platform/install_param.py +++ b/pySim/global_platform/install_param.py @@ -1,6 +1,6 @@ # GlobalPlatform install parameter generator # -# (C) 2024 by Sysmocom s.f.m.c. GmbH +# (C) 2024 by sysmocom - s.f.m.c. GmbH # All Rights Reserved # # This program is free software: you can redistribute it and/or modify diff --git a/pySim/javacard.py b/pySim/javacard.py index 2d4fd34..2c97fac 100644 --- a/pySim/javacard.py +++ b/pySim/javacard.py @@ -1,6 +1,6 @@ # JavaCard related utilities # -# (C) 2024 by Sysmocom s.f.m.c. GmbH +# (C) 2024 by sysmocom - s.f.m.c. GmbH # All Rights Reserved # # This program is free software: you can redistribute it and/or modify diff --git a/pySim/log.py b/pySim/log.py index a2325a6..c7e5239 100644 --- a/pySim/log.py +++ b/pySim/log.py @@ -4,7 +4,7 @@ """ # -# (C) 2025 by Sysmocom s.f.m.c. GmbH +# (C) 2025 by sysmocom - s.f.m.c. GmbH # All Rights Reserved # # Author: Philipp Maier <pmaier(a)sysmocom.de> diff --git a/pySim/profile.py b/pySim/profile.py index 360aa46..22db21c 100644 --- a/pySim/profile.py +++ b/pySim/profile.py @@ -4,7 +4,7 @@ """ # -# (C) 2021 by Sysmocom s.f.m.c. GmbH +# (C) 2021 by sysmocom - s.f.m.c. GmbH # All Rights Reserved # # This program is free software: you can redistribute it and/or modify diff --git a/tests/pySim-prog_test/pySim-prog_test.sh b/tests/pySim-prog_test/pySim-prog_test.sh index 9279c6c..6541acb 100755 --- a/tests/pySim-prog_test/pySim-prog_test.sh +++ b/tests/pySim-prog_test/pySim-prog_test.sh @@ -2,7 +2,7 @@ # Utility to verify the functionality of pySim-prog.py # -# (C) 2018 by Sysmocom s.f.m.c. GmbH +# (C) 2018 by sysmocom - s.f.m.c. GmbH # All Rights Reserved # # Author: Philipp Maier diff --git a/tests/pySim-trace_test/pySim-trace_test.sh b/tests/pySim-trace_test/pySim-trace_test.sh index ec23ad3..0a9fb47 100755 --- a/tests/pySim-trace_test/pySim-trace_test.sh +++ b/tests/pySim-trace_test/pySim-trace_test.sh @@ -2,7 +2,7 @@ # Utility to verify the functionality of pySim-trace.py # -# (C) 2023 by Sysmocom s.f.m.c. GmbH +# (C) 2023 by sysmocom - s.f.m.c. GmbH # All Rights Reserved # # Author: Philipp Maier diff --git a/tests/unittests/test_log.py b/tests/unittests/test_log.py index cc67b78..6a0f7ff 100755 --- a/tests/unittests/test_log.py +++ b/tests/unittests/test_log.py @@ -1,6 +1,6 @@ #!/usr/bin/env python3 -# (C) 2025 by Sysmocom s.f.m.c. GmbH +# (C) 2025 by sysmocom - s.f.m.c. GmbH # All Rights Reserved # # Author: Philipp Maier <pmaier(a)sysmocom.de> -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41767?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id768d2f4b78162ff83320a800e4e66f1bd324d6d Gerrit-Change-Number: 41767 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pySim/runtime: use log.warning instead of log.warn
by dexter 05 Jan '26

05 Jan '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41766?usp=email ) Change subject: pySim/runtime: use log.warning instead of log.warn ...................................................................... pySim/runtime: use log.warning instead of log.warn The python logger method warn is deprecated since pyton 3.3, let's us the warning method as suggested. Change-Id: I3a4c0ca43768198ac6011ebe79050f91c04862e5 --- M pySim/runtime.py 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/66/41766/1 diff --git a/pySim/runtime.py b/pySim/runtime.py index 35452a0..7bb215e 100644 --- a/pySim/runtime.py +++ b/pySim/runtime.py @@ -115,7 +115,7 @@ for a in aids_unknown: log.info(" unknown: %s (EF.DIR)" % a) else: - log.warn("EF.DIR seems to be empty!") + log.warning("EF.DIR seems to be empty!") # Some card applications may not be registered in EF.DIR, we will actively # probe for those applications @@ -556,8 +556,8 @@ raise TypeError("Data length (%u) exceeds %s size (%u) by %u bytes" % (data_len, writeable_name, writeable_size, data_len - writeable_size)) elif data_len < writeable_size: - log.warn("Data length (%u) less than %s size (%u), leaving %u unwritten bytes at the end of the %s" % - (data_len, writeable_name, writeable_size, writeable_size - data_len, writeable_name)) + log.warning("Data length (%u) less than %s size (%u), leaving %u unwritten bytes at the end of the %s" % + (data_len, writeable_name, writeable_size, writeable_size - data_len, writeable_name)) def update_binary(self, data_hex: str, offset: int = 0): """Update transparent EF binary data. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41766?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3a4c0ca43768198ac6011ebe79050f91c04862e5 Gerrit-Change-Number: 41766 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pySim-shell: do not show user home path in help text
by dexter 05 Jan '26

05 Jan '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41748?usp=email ) Change subject: pySim-shell: do not show user home path in help text ...................................................................... pySim-shell: do not show user home path in help text At the moment, the help text for the --csv option shows the path to the users home. This is due to the default value, which is dynamically generated. Let's use a static string with "~/" and resolve the full path later when we need it. Related: SYS#7725 Change-Id: Ied8b1e553de8f5370369c4485a2360906c874ed2 --- M pySim-shell.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pySim-shell.py b/pySim-shell.py index 75b7ef7..da3a26b 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -1138,7 +1138,7 @@ card_key_group = option_parser.add_argument_group('Card Key Provider Options') card_key_group.add_argument('--csv', metavar='FILE', - default=str(Path.home()) + "/.osmocom/pysim/card_data.csv", + default="~/.osmocom/pysim/card_data.csv", help='Read card data from CSV file') card_key_group.add_argument('--csv-column-key', metavar='FIELD:AES_KEY_HEX', default=[], action='append', help=argparse.SUPPRESS, dest='column_key') @@ -1177,8 +1177,8 @@ for par in opts.column_key: name, key = par.split(':') column_keys[name] = key - if os.path.isfile(opts.csv): - card_key_provider_register(CardKeyProviderCsv(opts.csv, column_keys)) + if os.path.isfile(os.path.expanduser(opts.csv)): + card_key_provider_register(CardKeyProviderCsv(os.path.expanduser(opts.csv), column_keys)) # Init card reader driver sl = init_reader(opts, proactive_handler = Proact()) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41748?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ied8b1e553de8f5370369c4485a2360906c874ed2 Gerrit-Change-Number: 41748 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: pySim-shell/cosmetic: remove unnecessary brackets
by dexter 05 Jan '26

05 Jan '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41751?usp=email ) Change subject: pySim-shell/cosmetic: remove unnecessary brackets ...................................................................... pySim-shell/cosmetic: remove unnecessary brackets Change-Id: I6929aa4fa189414217c05a4ef5180d4ed44eb3a4 --- M pySim-shell.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pySim-shell.py b/pySim-shell.py index a8b15d5..75b7ef7 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -1164,7 +1164,7 @@ # Ensure that we are able to print formatted warnings from the beginning. PySimLogger.setup(print, {logging.WARN: YELLOW}) - if (opts.verbose): + if opts.verbose: PySimLogger.set_verbose(True) PySimLogger.set_level(logging.DEBUG) else: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41751?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6929aa4fa189414217c05a4ef5180d4ed44eb3a4 Gerrit-Change-Number: 41751 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in osmo-e1d[master]: Add Channel-Associated Signalling (CAS) support
by laforge 05 Jan '26

05 Jan '26

Attention is currently required from: jolly, tnt. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-e1d/+/41139?usp=email ) Change subject: Add Channel-Associated Signalling (CAS) support ...................................................................... Patch Set 3: -Code-Review (1 comment) File src/mux_demux.c: https://gerrit.osmocom.org/c/osmo-e1d/+/41139/comment/e58f2b6e_6d5de452?usp… : PS3, Line 397: if (!line->cas.rx.buf_valid[line->cas.rx.frame_count + 14] || this looks to me like the event is signalled at a per-line level, and not at a per-timeslot level. IMHO, the comparison should be iterating over the timeslots and for each timeslot comparing the 4 past CAS bits of one timeslot with the 4 current/new CAS bits and then indicate a signal for the specific timeslot. Basically, nothing in a client should relate to the entire line, everything should happen at a per-timeslot level. Of course one could keep the signal in the protocol at a line-level and then have the libosmo-e1d client code figure out the affected timeslots and signal those in the application. But any application that holds open any timeslot within the line should get that notification. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/41139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib4f5e6ef02c9b0d1eec2a86d9c48376112805972 Gerrit-Change-Number: 41139 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Mon, 05 Jan 2026 12:51:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-e1d[master]: Add Channel-Associated Signalling (CAS) support
by laforge 05 Jan '26

05 Jan '26

Attention is currently required from: jolly, tnt. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-e1d/+/41139?usp=email ) Change subject: Add Channel-Associated Signalling (CAS) support ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/41139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib4f5e6ef02c9b0d1eec2a86d9c48376112805972 Gerrit-Change-Number: 41139 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Mon, 05 Jan 2026 12:46:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-abis[master]: Add CAS channel support
by laforge 05 Jan '26

05 Jan '26

Attention is currently required from: jolly, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41140?usp=email ) Change subject: Add CAS channel support ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I81cc89e01bb4207dc899ab28f24a131f24b61c9c Gerrit-Change-Number: 41140 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Jan 2026 12:44:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026