January 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: bts: TC_tx_power_ramp_adm_state_change: Fix Tguard too low sometimes ...
by pespin 12 Jan '26

12 Jan '26

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809?usp=email ) Change subject: bts: TC_tx_power_ramp_adm_state_change: Fix Tguard too low sometimes triggering ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I95448c732d08a30893cb958af79bf21c39ff10cb Gerrit-Change-Number: 41809 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jan 2026 12:40:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: TC_tx_power_ramp_adm_state_change: Fix Tguard too low sometimes ...
by pespin 12 Jan '26

12 Jan '26

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809?usp=email ) Change subject: bts: TC_tx_power_ramp_adm_state_change: Fix Tguard too low sometimes triggering ...................................................................... Patch Set 1: (1 comment) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809/comment/907b66a3_4ec1… : PS1, Line 3038: pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN, t_guard := 60.0)); > 60s seems very high. […] No, the current value of Tguard is 20-30 seconds. Setting it to 60s is totally fine since that time amount should only be wasted in the event this test fails due to Tguard timeout, which shouldn't usually happen. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I95448c732d08a30893cb958af79bf21c39ff10cb Gerrit-Change-Number: 41809 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jan 2026 12:40:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-bts[master]: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state
by osmith 12 Jan '26

12 Jan '26

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email ) Change subject: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0e2a6c2c33e0ac9a0bc1734d83eaeafc27f2f4df Gerrit-Change-Number: 41807 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jan 2026 12:37:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: ipaccess-config-e1-driver: Make sure struct input_signal_data is zero...
by fixeria 12 Jan '26

12 Jan '26

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email ) Change subject: ipaccess-config-e1-driver: Make sure struct input_signal_data is zero initialized ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/41773/comment/369451dc_1d02a81f?usp… : PS1, Line 7: struct input_signal_data is zero initialized What's the goal of doing that? Keep in mind that only the actual struct fields are initialized when using designated initializers, but not padding. So ASAN/UBSAN may still complain when `memcpy()ing` this structure. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If97c4a4202eaf96446d48e821d5e59c98bafe51c Gerrit-Change-Number: 41773 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jan 2026 12:31:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: TC_tx_power_ramp_adm_state_change: Fix Tguard too low sometimes ...
by osmith 12 Jan '26

12 Jan '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809?usp=email ) Change subject: bts: TC_tx_power_ramp_adm_state_change: Fix Tguard too low sometimes triggering ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809/comment/91020a42_c08c… : PS1, Line 3038: pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN, t_guard := 60.0)); 60s seems very high. If the current value is 2s, maybe set it to 10s instead? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I95448c732d08a30893cb958af79bf21c39ff10cb Gerrit-Change-Number: 41809 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jan 2026 12:29:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: bs_power_control: Apply defaults during reset
by osmith 12 Jan '26

12 Jan '26

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41794?usp=email ) Change subject: bs_power_control: Apply defaults during reset ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41794?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I00d9205d114b2d507c1048375693de4aa06bebbe Gerrit-Change-Number: 41794 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jan 2026 12:26:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: ipaccess-config-e1-driver: Make sure struct input_signal_data is zero...
by jolly 12 Jan '26

12 Jan '26

Attention is currently required from: fixeria, osmith, pespin. jolly has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email ) Change subject: ipaccess-config-e1-driver: Make sure struct input_signal_data is zero initialized ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If97c4a4202eaf96446d48e821d5e59c98bafe51c Gerrit-Change-Number: 41773 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jan 2026 12:15:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: ipaccess-config-e1-driver: Make sure struct input_signal_data is zero...
by laforge 12 Jan '26

12 Jan '26

Attention is currently required from: fixeria, jolly, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email ) Change subject: ipaccess-config-e1-driver: Make sure struct input_signal_data is zero initialized ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If97c4a4202eaf96446d48e821d5e59c98bafe51c Gerrit-Change-Number: 41773 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jan 2026 12:12:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: gbproxy: Fix several tests on titan 11
by laforge 12 Jan '26

12 Jan '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740?usp=email ) Change subject: gbproxy: Fix several tests on titan 11 ...................................................................... gbproxy: Fix several tests on titan 11 Rework altsteps to avoid race condition showing up under titan 11.1.0. It's not really clear whether the previous implementation is actually expected/permitted by TTCN-3, where an altstep variable is initialized multiple times with different values through activate(). In any case, the new implementation is much cleaner, only requiring 1 altstep instead of N. Related: OS#6800 Change-Id: Ib17c7dcb3d224a6b9e75ce5f9121a05126f81909 --- M gbproxy/GBProxy_Tests.ttcn M gbproxy/testenv.cfg 2 files changed, 77 insertions(+), 73 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn index 7f70f96..f606d31 100644 --- a/gbproxy/GBProxy_Tests.ttcn +++ b/gbproxy/GBProxy_Tests.ttcn @@ -2683,31 +2683,50 @@ /*********************************************************************** * BVC-RESET procedure ***********************************************************************/ -private altstep as_count_bvc_reset(integer sgsn_idx, BssgpBvci bvci, inout roro_integer roroi) -runs on test_CT { - var BSSGP_BVC_CT sgsn_bvc_ct := f_get_sgsn_bvc_ct(sgsn_idx, bvci); - [] SGSN_MGMT.receive(BssgpResetIndication:{bvci}) from sgsn_bvc_ct { - roroi[sgsn_idx] := roroi[sgsn_idx] & { bvci }; - repeat; - } -} -private altstep as_ignore_status(BSSGP_BVC_MGMT_PT pt) { -[] pt.receive(BssgpStatusIndication:?) { repeat; } -} private function f_get_sgsn_bvc_ct(integer sgsn_idx, BssgpBvci bvci) runs on test_CT return BSSGP_BVC_CT { for (var integer i := 0; i < lengthof(g_sgsn[sgsn_idx].cfg.bvc); i := i+1) { if (g_sgsn[sgsn_idx].cfg.bvc[i].bvci == bvci) { return g_sgsn[sgsn_idx].vc_BSSGP_BVC[i]; } } + log("f_get_sgsn_bvc_ct(", sgsn_idx, ", ", bvci, "): null"); return null; } + +private function f_get_sgsn_idx_bvc_ct(BSSGP_BVC_CT sgsn_bvc_ct, BssgpBvci bvci) runs on test_CT return integer { + for (var integer i := 0; i < lengthof(g_sgsn); i := i+1) { + for (var integer j := 0; j < lengthof(g_sgsn[i].vc_BSSGP_BVC); j := j+1) { + if (g_sgsn[i].cfg.bvc[j].bvci == bvci and + g_sgsn[i].vc_BSSGP_BVC[j] == sgsn_bvc_ct) { + return i; + } + } + } + log("f_get_sgsn_idx_bvc_ct(ct=", sgsn_bvc_ct, ", bvci=", bvci, "): -1"); + return -1; +} + +private altstep as_count_bvc_reset(inout roro_integer roroi) +runs on test_CT { + var BssgpResetIndication rx_bssgp_reset_ind; + var BSSGP_BVC_CT sgsn_bvc_ct; + [] SGSN_MGMT.receive(BssgpResetIndication:?) -> value rx_bssgp_reset_ind sender sgsn_bvc_ct { + var integer sgsn_idx := f_get_sgsn_idx_bvc_ct(sgsn_bvc_ct, rx_bssgp_reset_ind.bvci); + if (sgsn_idx >= 0) { + roroi[sgsn_idx] := roroi[sgsn_idx] & { rx_bssgp_reset_ind.bvci }; + } + repeat; + } +} +private altstep as_ignore_status(BSSGP_BVC_MGMT_PT pt) { + [] pt.receive(BssgpStatusIndication:?) { repeat; } +} + private function f_reset_ptp_bvc_from_pcu(integer pcu_idx, integer bvc_idx) runs on test_CT { var BSSGP_BVC_CT pcu_bvc_ct := g_pcu[pcu_idx].vc_BSSGP_BVC[bvc_idx]; var BssgpBvcConfig bvc_cfg := g_pcu[pcu_idx].cfg.bvc[bvc_idx]; var Nsei nsei_pcu := g_pcu[pcu_idx].cfg.nsei; - var ro_default defaults; var integer i; SGSN_MGMT.clear; @@ -2720,33 +2739,23 @@ /* block the PTP BVC from the PCU side */ PCU_MGMT.send(BssgpResetRequest:{cause:=BSSGP_CAUSE_OM_INTERVENTION}) to pcu_bvc_ct; - /* expect state on both PCU and SGSN side to change */ - defaults := { activate(as_ignore_status(SGSN_MGMT)) }; - - /* Activate altsteps: One for each SGSN */ - for (i := 0; i < lengthof(g_sgsn); i := i+1) { - var default d := activate(as_count_bvc_reset(i, bvc_cfg.bvci, g_roroi)); - defaults := defaults & { d }; - } - timer T := 3.0; T.start; alt { - [] PCU_MGMT.receive(tr_BssgpStsInd(nsei_pcu, bvc_cfg.bvci, BVC_S_BLOCKED)) from pcu_bvc_ct { + [] PCU_MGMT.receive(tr_BssgpStsInd(nsei_pcu, bvc_cfg.bvci, BVC_S_BLOCKED)) -> sender pcu_bvc_ct { g_roi := g_roi & { bvc_cfg.bvci }; repeat; } + [] as_count_bvc_reset(g_roroi); + [] as_ignore_status(SGSN_MGMT); /* expect state on both PCU and SGSN side to change */ [] T.timeout; } - for (i := 0; i < lengthof(defaults); i := i+1) { - deactivate(defaults[i]); - } - /* Check if BVC-RESET was received at all SGSNs */ for (i := 0; i < lengthof(g_sgsn); i := i+1) { if (not ro_integer_contains(g_roroi[i], bvc_cfg.bvci)) { - setverdict(fail, "Missing SGSN[", i, "] BVC-BLOCK of BVCI=", bvc_cfg.bvci); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Missing SGSN[", i, "] BVC-BLOCK of BVCI=", bvc_cfg.bvci, ", got ", g_roroi)); } } @@ -2762,24 +2771,27 @@ f_cleanup(); } -private altstep as_count_bvc_sts(integer sgsn_idx, BssgpBvci bvci, - template (present) BvcState exp_bvc_state, inout roro_integer roroi) +private altstep as_count_bvc_sts(template (present) BvcState exp_bvc_state, inout roro_integer roroi) runs on test_CT { - var BSSGP_BVC_CT sgsn_bvc_ct := f_get_sgsn_bvc_ct(sgsn_idx, bvci); - [] SGSN_MGMT.receive(tr_BssgpStsInd(?, bvci, exp_bvc_state)) from sgsn_bvc_ct { - roroi[sgsn_idx] := roroi[sgsn_idx] & { bvci }; + var BssgpStatusIndication rx_bssgp_st_ind; + var BSSGP_BVC_CT sgsn_bvc_ct; + [] SGSN_MGMT.receive(tr_BssgpStsInd(?, ?, exp_bvc_state)) -> value rx_bssgp_st_ind sender sgsn_bvc_ct { + var integer sgsn_idx := f_get_sgsn_idx_bvc_ct(sgsn_bvc_ct, rx_bssgp_st_ind.bvci); + if (sgsn_idx >= 0) { + roroi[sgsn_idx] := roroi[sgsn_idx] & { rx_bssgp_st_ind.bvci }; + } repeat; } } -private altstep as_count_bvc_block(integer sgsn_idx, BssgpBvci bvci, inout roro_integer roroi) +private altstep as_count_bvc_block(inout roro_integer roroi) runs on test_CT { - [] as_count_bvc_sts(sgsn_idx, bvci, BVC_S_BLOCKED, roroi); + [] as_count_bvc_sts(BVC_S_BLOCKED, roroi); } -private altstep as_count_bvc_unblock(integer sgsn_idx, BssgpBvci bvci, inout roro_integer roroi) +private altstep as_count_bvc_unblock(inout roro_integer roroi) runs on test_CT { - [] as_count_bvc_sts(sgsn_idx, bvci, BVC_S_UNBLOCKED, roroi); + [] as_count_bvc_sts(BVC_S_UNBLOCKED, roroi); } /* reset the signaling BVC from one BSS; expect no signaling BVC reset on SGSN; but BVC-BLOCK for PTP */ @@ -2795,29 +2807,16 @@ /* Start BVC-RESET procedure for BVCI=0 */ PCU_MGMT.send(BssgpResetRequest:{cause:=BSSGP_CAUSE_OM_INTERVENTION}) to g_pcu[0].vc_BSSGP; - /* Activate altsteps: One for each PTP BVC and SGSN within that PCUs NSE */ - var ro_default defaults := {}; - for (var integer i := 0; i < lengthof(g_pcu[0].cfg.bvc); i := i+1) { - var BssgpBvcConfig bvcc := g_pcu[0].cfg.bvc[i]; - for (var integer j := 0; j < lengthof(g_sgsn); j := j+1) { - var default d := activate(as_count_bvc_block(j, bvcc.bvci, g_roroi)); - defaults := defaults & { d }; - } - } - timer T := 3.0; T.start; alt { [] SGSN_MGMT.receive(BssgpResetIndication:{0}) { setverdict(fail, "BSS-side Reset of BVCI=0 should not propagate"); } + [] as_count_bvc_block(g_roroi); [] T.timeout; } - for (var integer i := 0; i < lengthof(defaults); i := i+1) { - deactivate(defaults[i]); - } - /* check if BVC-block was received on all expected BVC/SGSN */ for (var integer i := 0; i < lengthof(g_pcu[0].cfg.bvc); i := i+1) { var BssgpBvcConfig bvcc := g_pcu[0].cfg.bvc[i]; @@ -2905,11 +2904,25 @@ [] pt.receive {repeat; } } -private altstep as_count_bvc0_block(integer pcu_idx, Nsei nsei, inout ro_integer roi) +private function f_get_pcu_idx_ct(BSSGP_CT pcu_ct) runs on test_CT return integer { + for (var integer i := 0; i < lengthof(g_pcu); i := i+1) { + if (g_pcu[i].vc_BSSGP == pcu_ct) { + return i; + } + } + log("f_get_pcu_idx_ct(ct=", pcu_ct, "): -1"); + return -1; +} + +private altstep as_count_bvc0_block(inout ro_integer roi) runs on test_CT { - var BSSGP_CT pcu_ct := g_pcu[pcu_idx].vc_BSSGP; - [] PCU_MGMT.receive(BssgpResetIndication:{0}) from pcu_ct { - roi := roi & { nsei }; + var BSSGP_CT pcu_ct; + [] PCU_MGMT.receive(BssgpResetIndication:{0}) -> sender pcu_ct { + var integer pcu_idx := f_get_pcu_idx_ct(pcu_ct); + if (pcu_idx >= 0) { + var NSConfiguration nscfg := mp_nsconfig_pcu[pcu_idx]; + roi := roi & { nscfg.nsei }; + } repeat; } } @@ -2926,23 +2939,15 @@ /* Start BVC-RESET procedure for BVCI=0 */ SGSN_MGMT.send(BssgpResetRequest:{cause:=BSSGP_CAUSE_OM_INTERVENTION}) to g_sgsn[0].vc_BSSGP; - /* Defaults match in reverse activation order, this one is a catch-all for Status indications - * and reset indications sent from other components (like the ptp_bvcs). If we don't drain - * the port and a different message sits at the front we wait forever and fail the test. - */ - var ro_default defaults := { activate(as_ignore_mgmt(PCU_MGMT)) }; - - /* Activate altsteps: One for each PCU NSE */ - for (var integer i := 0; i < lengthof(g_pcu); i := i+1) { - var NSConfiguration nscfg := mp_nsconfig_pcu[i]; - var default d := activate(as_count_bvc0_block(i, nscfg.nsei, g_roi)); - defaults := defaults & { d }; - } - - f_sleep(3.0); - - for (var integer i := 0; i < lengthof(defaults); i := i+1) { - deactivate(defaults[i]); + timer T := 3.0; + T.start; + alt { + [] as_count_bvc0_block(g_roi); + /* This one is a catch-all for Status indications and reset indications sent from other components + * (like the ptp_bvcs). If we don't drain the port and a different message sits at the front we + * wait forever and fail the test.*/ + [] as_ignore_mgmt(PCU_MGMT); + [] T.timeout; } /* check if BVC-block was received on all expected BVC */ diff --git a/gbproxy/testenv.cfg b/gbproxy/testenv.cfg index 7d3b41a..7adb482 100644 --- a/gbproxy/testenv.cfg +++ b/gbproxy/testenv.cfg @@ -1,6 +1,5 @@ [testsuite] -# Some tests fail with titan 11.1.0 (OS#6800) -titan_min=9.0.0 +titan_min=11.1.0 program=GBProxy_Tests config=GBProxy_Tests.cfg -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib17c7dcb3d224a6b9e75ce5f9121a05126f81909 Gerrit-Change-Number: 41740 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: gbproxy: Fix several tests on titan 11
by laforge 12 Jan '26

12 Jan '26

Attention is currently required from: daniel, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740?usp=email ) Change subject: gbproxy: Fix several tests on titan 11 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib17c7dcb3d224a6b9e75ce5f9121a05126f81909 Gerrit-Change-Number: 41740 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jan 2026 12:12:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026