January 2026 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state
by pespin 12 Jan '26

12 Jan '26

Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email ) Change subject: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state ...................................................................... Patch Set 4: (1 comment) File src/common/power_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/41807/comment/cd8515aa_91522673?usp… : PS3, Line 151: memcpy(params, trx->ms_dpc_params, sizeof(*params)); > What's the point of moving this `memcpy()` here? Why not keeping it where it was (in `rsl_rx_chan_ac […] Because the reset function should do what it is supposed to do, reset all state to sensible/known defaults. This clarifies a lot the content of the struct at any time. In the case of DPC, it is also resetting "dpc_enabled" field, so it should also reset "dpc_params" field. In the "receive MS Power Control" we are specifically only touching those params, as it makes sense to have a specific memcpy there to change stuff. In the case of static power: -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0e2a6c2c33e0ac9a0bc1734d83eaeafc27f2f4df Gerrit-Change-Number: 41807 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jan 2026 10:29:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-bts[master]: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state
by pespin 12 Jan '26

12 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email ) Change subject: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state ...................................................................... Patch Set 3: (2 comments) File src/common/power_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/41807/comment/bb13e55f_9df929f1?usp… : PS3, Line 343: memcpy(params, trx->ms_dpc_params, sizeof(*params)); > And you say pointers are the source of bugs... […] Done File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/41807/comment/f64a9457_afbac29c?usp… : PS3, Line 2082: lchan->ms_power_ctrl.dpc_enabled = true; > ```suggestion […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0e2a6c2c33e0ac9a0bc1734d83eaeafc27f2f4df Gerrit-Change-Number: 41807 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jan 2026 10:23:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-bts[master]: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state
by pespin 12 Jan '26

12 Jan '26

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review-1 by fixeria, Verified+1 by Jenkins Builder Change subject: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state ...................................................................... {bs,ms}_power_control: Move params inside lchan_power_ctrl_state Those fields are also part of the power control state, since they are modified through the lifecycle of the lchan eg. during rx of CHAN (RE)ACT, MS POWER CONTROL, etc. Those should also be reset together with other fields. Moreover, with this patch we get rid of an extra indirection pointer which could be NULL (under static configuration) and hence create potential problems. Change-Id: I0e2a6c2c33e0ac9a0bc1734d83eaeafc27f2f4df --- M include/osmo-bts/lchan.h M src/common/power_control.c M src/common/rsl.c M src/common/vty.c M tests/power/bs_power_loop_test.c M tests/power/ms_power_loop_test.c 6 files changed, 74 insertions(+), 88 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/07/41807/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0e2a6c2c33e0ac9a0bc1734d83eaeafc27f2f4df Gerrit-Change-Number: 41807 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: TC_pcu_{rts_req,time_ind}: Relax expectancies on rx primitive count
by pespin 12 Jan '26

12 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41783?usp=email ) Change subject: bts: TC_pcu_{rts_req,time_ind}: Relax expectancies on rx primitive count ...................................................................... bts: TC_pcu_{rts_req,time_ind}: Relax expectancies on rx primitive count Even with latest changes I can still sometimes run into up to 6 FNs less than the currently minimum expected. That's usually 1-2 primitives less, which in the number of >100 we are receiving over 5 seconds, seems like a plausible drift. Change-Id: I887bd80a90e3ef8142cc29acde2ac9a3ea4869d6 --- M bts/BTS_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 1df5aa5..26fe18d 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -6116,7 +6116,7 @@ /* verify the number of frames expired matches our expectation */ const float c_GSM_FN_DURATION_MS := 4.61538; var float fn_expected := test_duration * 1000.0 / c_GSM_FN_DURATION_MS; - var template integer t_fn_expected := f_tolerance(float2int(fn_expected), 1, 100000, 20); + var template integer t_fn_expected := f_tolerance(float2int(fn_expected), 1, 100000, 30); if (not match(fn_expired, t_fn_expected)) { setverdict(fail, "Number of TDMA Frames (", fn_expired, ") not matching ", t_fn_expected); } @@ -6204,7 +6204,7 @@ /* verify the number of frames expired matches our expectation */ const float c_GSM_FN_DURATION_MS := 4.61538; var float fn_expected := test_duration * 1000.0 / c_GSM_FN_DURATION_MS; - var template integer t_fn_expected := f_tolerance(float2int(fn_expected), 1, 100000, 20); + var template integer t_fn_expected := f_tolerance(float2int(fn_expected), 1, 100000, 30); if (not match(fn_expired, t_fn_expected)) { setverdict(fail, "Number of TDMA Frames (", fn_expired, ") not matching ", t_fn_expected); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41783?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I887bd80a90e3ef8142cc29acde2ac9a3ea4869d6 Gerrit-Change-Number: 41783 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl
by pespin 12 Jan '26

12 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email ) Change subject: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl ...................................................................... bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl Fix following sporadic race condition: TTCN-MS IUTS-BTS TTCN-BSC | |<----CHAN_ACT------| |<--SACCH(A)-- | | | |<--MS_PWR_CTRL(B)- | |<--SACCH(B)---| Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 --- M bts/BTS_Tests.ttcn 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 26fe18d..c681da9 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -3834,6 +3834,7 @@ private function f_tc_rsl_ms_pwr_ctrl(charstring id) runs on ConnHdlr { var SacchL1Header l1h; var uint5_t power_level := 0; + var boolean first_after_wait := true; f_l1_tune(L1CTL); RSL.clear; @@ -3849,10 +3850,18 @@ alt { [] as_l1_sacch_l1h(l1h, do_apply := false) { if (l1h.ms_power_lvl != power_level) { - setverdict(fail, "Power level := ", l1h.ms_power_lvl, "does not ", + if (first_after_wait) { + /* It may happen that BTS transmits SACCH before it receives our RSL MS POWER CONTROL: */ + log("Power level := ", l1h.ms_power_lvl, " does not ", + "match the signaled (RSL) power level := ", power_level); + first_after_wait := false; + repeat; + } + setverdict(fail, "Power level := ", l1h.ms_power_lvl, " does not ", "match the signaled (RSL) power level := ", power_level); Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } + first_after_wait := true; /* Signal a new power level via RSL for the next turn. */ if (power_level < 31) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 Gerrit-Change-Number: 41785 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: Validate no TIME.ind block gaps in TC_pcu_time_ind
by pespin 12 Jan '26

12 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41784?usp=email ) Change subject: bts: Validate no TIME.ind block gaps in TC_pcu_time_ind ...................................................................... bts: Validate no TIME.ind block gaps in TC_pcu_time_ind Change-Id: Ibce780009389b2cd06d1a6d79afa77d8e58187bc --- M bts/BTS_Tests.ttcn 1 file changed, 17 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index bf59eb8..1df5aa5 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -6056,6 +6056,13 @@ } /* test for periodic TIME_IND; check number of FN expired and number of TIME_IND within frames */ +private function f_next_pcuif_time_ind_block(GsmFrameNumber fn) return GsmFrameNumber +{ + var uint32_t bn := ((fn mod 13) / 4) + 1; + fn := fn - (fn mod 13); + fn := fn + bn * 4 + bn / 3; + return fn mod GsmMaxFrameNumber; +} testcase TC_pcu_time_ind() runs on test_CT { var integer num_time_ind := 0; var integer first_fn, last_fn; @@ -6072,10 +6079,18 @@ alt { [] as_pcuif_msg(msg, tr_PCUIF_TIME_IND(0, ?)) { num_time_ind := num_time_ind + 1; - if (not isbound(first_fn)) { + if (isbound(first_fn)) { + var integer exp_fn := f_next_pcuif_time_ind_block(last_fn); + if (msg.u.time_ind.fn != exp_fn) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Rx TIME.ind for FN ", msg.u.time_ind.fn, + " vs exp ", exp_fn, " (last_fn " , last_fn, ")")); + } + last_fn := msg.u.time_ind.fn; + } else { first_fn := msg.u.time_ind.fn; + last_fn := msg.u.time_ind.fn; } - last_fn := msg.u.time_ind.fn; repeat; } [] as_pcuif_msg(msg, tr_PCUIF_TIME_IND(?, ?)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibce780009389b2cd06d1a6d79afa77d8e58187bc Gerrit-Change-Number: 41784 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: bts: Validate no PDTCH/PTCCH block gaps in TC_pcu_rts_req
by pespin 12 Jan '26

12 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41781?usp=email ) Change subject: bts: Validate no PDTCH/PTCCH block gaps in TC_pcu_rts_req ...................................................................... bts: Validate no PDTCH/PTCCH block gaps in TC_pcu_rts_req Change-Id: I0bf3540523c231ed7172cab720163816d5d81e26 --- M bts/BTS_Tests.ttcn M library/GSM_Types.ttcn 2 files changed, 40 insertions(+), 12 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 7bac7ee..592e58f 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -6110,7 +6110,8 @@ /* test for periodic RTS_REQ; check number of FN expired and number of RTS_IND per SAPI */ testcase TC_pcu_rts_req() runs on test_CT { - var integer first_fn, last_fn; + var integer pdtch_first_fn, pdtch_last_fn; + var integer ptcch_first_fn, ptcch_last_fn; var integer num_rts_pdtch := 0; var integer num_rts_ptcch := 0; var float test_duration := 5.0; @@ -6125,18 +6126,34 @@ alt { [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(0, 0, 7, PCU_IF_SAPI_PDTCH, ?, ?)) { num_rts_pdtch := num_rts_pdtch + 1; - if (not isbound(first_fn)) { - first_fn := msg.u.rts_req.fn; + if (isbound(pdtch_first_fn)) { + var integer exp_fn := f_next_pdtch_block(pdtch_last_fn); + if (msg.u.rts_req.fn != exp_fn) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Rx RTS.req for PDTCH FN ", msg.u.rts_req.fn, + " vs exp ", exp_fn, " (last_fn " , pdtch_last_fn, ")")); + } + pdtch_last_fn := msg.u.rts_req.fn; + } else { + pdtch_first_fn := msg.u.rts_req.fn; + pdtch_last_fn := msg.u.rts_req.fn; } - last_fn := msg.u.rts_req.fn; repeat; } [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(0, 0, 7, PCU_IF_SAPI_PTCCH, ?, ?)) { num_rts_ptcch := num_rts_ptcch + 1; - if (not isbound(first_fn)) { - first_fn := msg.u.rts_req.fn; + if (isbound(ptcch_first_fn)) { + var integer exp_fn := f_next_ptcch_dl_block(ptcch_last_fn); + if (msg.u.rts_req.fn != exp_fn) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Rx RTS.req for PTTCH FN ", msg.u.rts_req.fn, + " vs exp ", exp_fn, " (last_fn " , ptcch_last_fn, ")")); + } + ptcch_last_fn := msg.u.rts_req.fn; + } else { + ptcch_first_fn := msg.u.rts_req.fn; + ptcch_last_fn := msg.u.rts_req.fn; } - last_fn := msg.u.rts_req.fn; repeat; } [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ) { @@ -6148,9 +6165,8 @@ } [] T.timeout {} } - var integer fn_expired := last_fn - first_fn; - log(fn_expired, " fn expired with num_rts_pdtch=", num_rts_pdtch, - ", num_rts_ptcch=", num_rts_ptcch); + var integer fn_expired := f_max(pdtch_last_fn, ptcch_last_fn) - f_min(pdtch_first_fn, ptcch_first_fn); + log(fn_expired, " fn expired with num_rts_pdtch=", num_rts_pdtch, ", num_rts_ptcch=", num_rts_ptcch); /* verify the number of frames expired matches our expectation */ const float c_GSM_FN_DURATION_MS := 4.61538; @@ -6164,7 +6180,7 @@ var float ptcch_expected := int2float(fn_expired) / 52.0 * 0.5; var template integer t_ptcch_exp := f_tolerance(float2int(ptcch_expected), 1, 100000, 1); if (not match(num_rts_ptcch, t_ptcch_exp)) { - setverdict(fail, "Number of RTS.ind for PTCCH (", num_rts_ptcch, ") not matching ", + setverdict(fail, "Number of RTS.req for PTCCH (", num_rts_ptcch, ") not matching ", t_ptcch_exp); } @@ -6172,7 +6188,7 @@ var float pdtch_expected := int2float(fn_expired) / 52.0 * 12.0; var template integer t_pdtch_exp := f_tolerance(float2int(pdtch_expected), 1, 100000, 2); if (not match(num_rts_pdtch, t_pdtch_exp)) { - setverdict(fail, "Number of RTS.ind for PDTCH (", num_rts_pdtch, ") not matching ", + setverdict(fail, "Number of RTS.req for PDTCH (", num_rts_pdtch, ") not matching ", t_pdtch_exp); } diff --git a/library/GSM_Types.ttcn b/library/GSM_Types.ttcn index 8333e58..b3b6dc9 100644 --- a/library/GSM_Types.ttcn +++ b/library/GSM_Types.ttcn @@ -547,4 +547,16 @@ return fn mod GsmMaxFrameNumber; } +private function ptcch_fn2bn(GsmFrameNumber fn) return uint32_t { + return (fn mod 416) / 104; +} +function f_next_ptcch_dl_block(GsmFrameNumber fn) return GsmFrameNumber +{ + var uint32_t bn := ptcch_fn2bn(fn) + 1; + fn := fn - (fn mod 416); + fn := fn + bn * 104 + 12; + return fn mod GsmMaxFrameNumber; +} + + } with { encode "RAW"; variant "FIELDORDER(msb)" } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41781?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0bf3540523c231ed7172cab720163816d5d81e26 Gerrit-Change-Number: 41781 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: TC_pcu_{rts_req,time_ind}: process FNs in port queue after time out
by pespin 12 Jan '26

12 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41782?usp=email ) Change subject: bts: TC_pcu_{rts_req,time_ind}: process FNs in port queue after time out ...................................................................... bts: TC_pcu_{rts_req,time_ind}: process FNs in port queue after time out Since we sometimes run short on counted FNs, but we validate that there were no FN gaps, it means we are simply late counting the generated RTS.req from IUT. Let's try to get a more accurate count by trying to process RTS.req in the port queue after the timeframe of the test finishes. In the end, we want to count the RTS.req transmitted by the IUT, not the ones we can receive in time. Change-Id: Iacd4eafbdb42207465ac0c5e03492c460280ecf7 --- M bts/BTS_Tests.ttcn 1 file changed, 20 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 592e58f..bf59eb8 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -6062,6 +6062,7 @@ var float test_duration := 5.0; var PCUIF_Message msg; timer T; + timer Tcountremaining; f_init_with_pcuif(); f_TC_pcu_act_req(0, 0, 7, true); @@ -6084,7 +6085,15 @@ [] PCU.receive { repeat; } - [] T.timeout {} + [] T.timeout { + /* Disable new incoming elements; but current queue elements are still processed. + * This way we get a more accurate count of TIME_IND submitted by IUT during the specified time. */ + PCU.halt; + log("Finish processing remaining queued messages"); + Tcountremaining.start(1.0); + repeat; + } + [] Tcountremaining.timeout { } } var integer fn_expired := last_fn - first_fn; log(fn_expired, " fn expired with ", num_time_ind, " PCU_TIME.ind"); @@ -6117,6 +6126,7 @@ var float test_duration := 5.0; var PCUIF_Message msg; timer T; + timer Tcountremaining; f_init_with_pcuif(); f_TC_pcu_act_req(0, 0, 7, true); @@ -6163,7 +6173,15 @@ [] PCU.receive { repeat; } - [] T.timeout {} + [] T.timeout { + /* Disable new incoming elements; but current queue elements are still processed. + * This way we get a more accurate count of RTS.req submitted by IUT during the specified time. */ + PCU.halt; + log("Finish processing remaining queued messages"); + Tcountremaining.start(1.0); + repeat; + } + [] Tcountremaining.timeout { } } var integer fn_expired := f_max(pdtch_last_fn, ptcch_last_fn) - f_min(pdtch_first_fn, ptcch_first_fn); log(fn_expired, " fn expired with num_rts_pdtch=", num_rts_pdtch, ", num_rts_ptcch=", num_rts_ptcch); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iacd4eafbdb42207465ac0c5e03492c460280ecf7 Gerrit-Change-Number: 41782 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in pysim[master]: personalization: refactor ConfigurableParameter, Iccid, Imsi
by pespin 12 Jan '26

12 Jan '26

Attention is currently required from: dexter, laforge, neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email ) Change subject: personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... Patch Set 15: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39742/comment/a298d06b_1c3273fc?usp=em… : PS13, Line 50: r"""Base class representing a part of the eSIM profile that is configurable during the > > abc has no purpose and it doesn't work. […] While I'm not a python expert, I agree with fixeria and laforge here, I think fixeria wrote down quite well my thoughts on it. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 15 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jan 2026 10:17:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in libosmocore[master]: Add Emscripten build support and JS callback logging backend
by pespin 12 Jan '26

12 Jan '26

Attention is currently required from: Timur Davydov, neels. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email ) Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 5: Code-Review-1 (12 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/7bd15204_b1ed5902?… : PS5, Line 7: Add Emscripten build support and JS callback logging backend Why is this needed? How is this used? What's the context? I'm missing a good description here for a feature is not obvious we need. File include/osmocom/core/logging.h: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/34e2672b_8f00cd59?… : PS5, Line 285: LOG_TGT_TYPE_WEB, /*!< Web logging */ AFAIU this is not "web generic" but "emscripten" specific, so let's please rename to something more meaningful, like "_EMSCRIPTEN" File src/core/netdev.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/2d7abf8a_b341e9b0?… : PS5, Line 67: #if (!EMBEDDED) && !defined(__EMSCRIPTEN__) I'd say better do this logic inside configure.ac and add a new auto variable HAVE_NETDEV or whatever. BTW, what's actually the poroblem here when building for emscripten? does it fail to compile? does it fail at runtime? File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/6a392a82_e3c785b2?… : PS5, Line 7: HAVE_LIBSCTP > This comes from `config.h`, which is included below. […] Indeed config.h should be at the top. File src/core/serial.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/cb4121c4_ad9127ec?… : PS5, Line 27: #if !defined(__EMSCRIPTEN__) Again, I'd say better add a HAVE_SERIAL or alike in configure.ac. And again, what's failing to build/run here exactly? This is the kind of stuff which should be also documented in the commit description. File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/15140efa_3b148e26?… : PS5, Line 2050: #ifdef HAVE_LIBSCTP missing explanation for this change. It may be a separate patch. https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/1b1ccc3c_082d86e4?… : PS5, Line 1928: #ifdef HAVE_LIBSCTP Why this change? I'm lacking any rationale here. Also, looks like this may be a separate patch. File src/vty/Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/4dfded30_dfe96217?… : PS5, Line 36: libosmovty_la_SOURCES += telnet_interface_dummy.c This for sure also needs an explanation. File src/vty/logging_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/f909049f_7dedfa63?… : PS5, Line 907: #if !defined(__EMSCRIPTEN__) this also needs explanation. https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/49f5f516_50b53edb?… : PS5, Line 1038: DEFUN(cfg_log_web, cfg_log_web_cmd, #if defined(__EMSCRIPTEN__) https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/fdab9457_8f2390c4?… : PS5, Line 1047: vty_out(vty, "%% Unable to create WEB log for %s", VTY_NEWLINE); this string end looks wrong https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/b0da8cfc_9bb5b867?… : PS5, Line 1067: vty_out(vty, "%% Unable to find WEB log target for %s", VTY_NEWLINE); this string end looks wrong -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 5 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 12 Jan 2026 10:13:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026