January 2026 - gerrit-log - lists.osmocom.org

[L] Change in libosmocore[master]: Add Emscripten build support and JS callback logging backend
by fixeria 11 Jan '26

11 Jan '26

Attention is currently required from: Timur Davydov, neels, pespin. fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email ) Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 5: (4 comments) File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/c04eea48_c9ec41d6?… : PS5, Line 7: HAVE_LIBSCTP This comes from `config.h`, which is included below. I believe you need to move the include above, otherwise this ifdef is always false. File src/vty/logging_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/56a7df5e_043a9f62?… : PS5, Line 1130: No need for a space here. https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/8fc01b3e_525acbeb?… : PS5, Line 1361: install_lib_element(CONFIG_NODE, &cfg_log_web_cmd); : install_lib_element(CONFIG_NODE, &cfg_no_log_web_cmd); I assume these commands are only relevant for emscripten? ```suggestion #if defined(__EMSCRIPTEN__) install_lib_element(CONFIG_NODE, &cfg_log_web_cmd); install_lib_element(CONFIG_NODE, &cfg_no_log_web_cmd); #endif /* defined(__EMSCRIPTEN__) */ ``` File src/vty/telnet_interface_dummy.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/388cadc4_6123c7f8?… : PS5, Line 18: #include <sys/socket.h> : #include <netinet/in.h> : #include <errno.h> : #include <stdlib.h> : #include <stdio.h> : #include <string.h> : #i (Not critical) Most if the includes are not needed here and can be removed? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 5 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Sun, 11 Jan 2026 22:09:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-bts[master]: {bs,ms}_power_control: Reset state during lchan deactivation
by laforge 11 Jan '26

11 Jan '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/41793?usp=email ) Change subject: {bs,ms}_power_control: Reset state during lchan deactivation ...................................................................... {bs,ms}_power_control: Reset state during lchan deactivation Change-Id: I0c247414d27d7ac636c6dbb294b0dd3bffc4ed97 --- M src/common/lchan.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified dexter: Looks good to me, but someone else must approve diff --git a/src/common/lchan.c b/src/common/lchan.c index 7123cee..b115e1e 100644 --- a/src/common/lchan.c +++ b/src/common/lchan.c @@ -326,6 +326,8 @@ lchan->pending_rel_ind_msg = NULL; msgb_free(lchan->pending_chan_activ); lchan->pending_chan_activ = NULL; + lchan_bs_pwr_ctrl_reset(lchan); + lchan_ms_pwr_ctrl_reset(lchan); lchan_ms_ta_ctrl_reset(lchan); /* fall through */ default: -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41793?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0c247414d27d7ac636c6dbb294b0dd3bffc4ed97 Gerrit-Change-Number: 41793 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-bts[master]: {bs,ms}_power_control: Add helper function to reset state
by laforge 11 Jan '26

11 Jan '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/41792?usp=email ) Change subject: {bs,ms}_power_control: Add helper function to reset state ...................................................................... {bs,ms}_power_control: Add helper function to reset state This way we can better document and identify places where the state is reset. Change-Id: I3e010a4ed72ba2574ce6c1316b8460689fc1d482 --- M include/osmo-bts/power_control.h M src/common/power_control.c M src/common/rsl.c 3 files changed, 27 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmo-bts/power_control.h b/include/osmo-bts/power_control.h index 0764ba7..031d462 100644 --- a/include/osmo-bts/power_control.h +++ b/include/osmo-bts/power_control.h @@ -81,10 +81,12 @@ void power_ctrl_params_def_reset(struct gsm_power_ctrl_params *params, bool is_bs_pwr); struct gsm_lchan; +void lchan_ms_pwr_ctrl_reset(struct gsm_lchan *lchan); int lchan_ms_pwr_ctrl(struct gsm_lchan *lchan, const uint8_t ms_power_lvl, const int8_t ul_rssi_dbm, const int16_t ul_lqual_cb); +void lchan_bs_pwr_ctrl_reset(struct gsm_lchan *lchan); int lchan_bs_pwr_ctrl(struct gsm_lchan *lchan, const struct gsm48_meas_res *mr); diff --git a/src/common/power_control.c b/src/common/power_control.c index 45d8969..0520ed8 100644 --- a/src/common/power_control.c +++ b/src/common/power_control.c @@ -137,6 +137,16 @@ return delta; } +void lchan_ms_pwr_ctrl_reset(struct gsm_lchan *lchan) +{ + struct lchan_power_ctrl_state *state = &lchan->ms_power_ctrl; + + /* This below implicitly sets: + * state->dpc_params = NULL (static mode). + * state->skip_block_num = 0, so that 1st power input is taken into account. */ + memset(state, 0, sizeof(*state)); +} + /* Shall we skip current block based on configured interval? */ static bool ctrl_interval_skip_block(const struct gsm_power_ctrl_params *params, struct lchan_power_ctrl_state *state) @@ -310,6 +320,16 @@ return 1; } +void lchan_bs_pwr_ctrl_reset(struct gsm_lchan *lchan) +{ + struct lchan_power_ctrl_state *state = &lchan->bs_power_ctrl; + + /* This below implicitly sets: + * state->dpc_params = NULL (static mode). + * state->skip_block_num = 0, so that 1st power input is taken into account. */ + memset(state, 0, sizeof(*state)); +} + /*! compute the new Downlink attenuation value for the given logical channel. * \param lchan logical channel for which to compute (and in which to store) new power value. * \param[in] mr pointer to a *valid* Measurement Report. diff --git a/src/common/rsl.c b/src/common/rsl.c index ba403bc..cb13977 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -58,6 +58,7 @@ #include <osmo-bts/pcuif_proto.h> #include <osmo-bts/notification.h> #include <osmo-bts/asci.h> +#include <osmo-bts/power_control.h> #include <osmo-bts/ta_control.h> //#define FAKE_CIPH_MODE_COMPL @@ -1764,8 +1765,8 @@ lchan->tch_mode = 0; memset(&lchan->encr, 0, sizeof(lchan->encr)); memset(&lchan->ho, 0, sizeof(lchan->ho)); - memset(&lchan->ms_power_ctrl, 0, sizeof(lchan->ms_power_ctrl)); - memset(&lchan->bs_power_ctrl, 0, sizeof(lchan->bs_power_ctrl)); + lchan_bs_pwr_ctrl_reset(lchan); + lchan_ms_pwr_ctrl_reset(lchan); lchan_ms_ta_ctrl_reset(lchan); copy_sacch_si_to_lchan(lchan); memset(&lchan->tch, 0, sizeof(lchan->tch)); @@ -1989,8 +1990,8 @@ } /* Initialize MS/BS Power Control state */ - memset(&lchan->ms_power_ctrl, 0, sizeof(lchan->ms_power_ctrl)); - memset(&lchan->bs_power_ctrl, 0, sizeof(lchan->bs_power_ctrl)); + lchan_bs_pwr_ctrl_reset(lchan); + lchan_ms_pwr_ctrl_reset(lchan); /* 9.3.6 Channel Mode */ if (type != RSL_ACT_OSMO_PDCH) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41792?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3e010a4ed72ba2574ce6c1316b8460689fc1d482 Gerrit-Change-Number: 41792 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-bts[master]: ta_control: Reset state during lchan deactivation
by laforge 11 Jan '26

11 Jan '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/41791?usp=email ) Change subject: ta_control: Reset state during lchan deactivation ...................................................................... ta_control: Reset state during lchan deactivation Otherwise next time the lchan is activated, its ta_ctrl.skip_block_num will be different based on previous lchan state. Change-Id: I2aacbbc5b2db46c17b1266b5b5e84d8286d0cf83 --- M src/common/lchan.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/common/lchan.c b/src/common/lchan.c index 0afc294..7123cee 100644 --- a/src/common/lchan.c +++ b/src/common/lchan.c @@ -34,6 +34,7 @@ #include <osmo-bts/l1sap.h> #include <osmo-bts/bts_model.h> #include <osmo-bts/asci.h> +#include <osmo-bts/ta_control.h> #include <errno.h> static const struct value_string lchan_s_names[] = { @@ -325,6 +326,7 @@ lchan->pending_rel_ind_msg = NULL; msgb_free(lchan->pending_chan_activ); lchan->pending_chan_activ = NULL; + lchan_ms_ta_ctrl_reset(lchan); /* fall through */ default: if (lchan->early_rr_ia) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41791?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2aacbbc5b2db46c17b1266b5b5e84d8286d0cf83 Gerrit-Change-Number: 41791 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-bts[master]: ta_power_control: reset during lchan activation
by laforge 11 Jan '26

11 Jan '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41796?usp=email ) Change subject: ta_power_control: reset during lchan activation ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I149fffa73ef651fd21e52e5423b31f8e95e57941 Gerrit-Change-Number: 41796 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 11 Jan 2026 22:03:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: ms_power_control: Apply defaults during reset
by laforge 11 Jan '26

11 Jan '26

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41795?usp=email ) Change subject: ms_power_control: Apply defaults during reset ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41795?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5c0137ba8bf1e057abdc1911716e3d1bf8c61ea3 Gerrit-Change-Number: 41795 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 11 Jan 2026 22:03:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bts[master]: {bs,ms}_power_control: Reset state during lchan deactivation
by laforge 11 Jan '26

11 Jan '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41793?usp=email ) Change subject: {bs,ms}_power_control: Reset state during lchan deactivation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41793?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0c247414d27d7ac636c6dbb294b0dd3bffc4ed97 Gerrit-Change-Number: 41793 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 11 Jan 2026 22:02:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: {bs,ms}_power_control: Add helper function to reset state
by laforge 11 Jan '26

11 Jan '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41792?usp=email ) Change subject: {bs,ms}_power_control: Add helper function to reset state ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41792?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3e010a4ed72ba2574ce6c1316b8460689fc1d482 Gerrit-Change-Number: 41792 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 11 Jan 2026 22:02:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bts[master]: ta_control: Reset state during lchan deactivation
by laforge 11 Jan '26

11 Jan '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41791?usp=email ) Change subject: ta_control: Reset state during lchan deactivation ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41791?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2aacbbc5b2db46c17b1266b5b5e84d8286d0cf83 Gerrit-Change-Number: 41791 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 11 Jan 2026 22:02:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in android-apdu-proxy[master]: OmapiCallbackHandlerVpcd: simplify/fix SELECT by DF-Name (aid)
by laforge 11 Jan '26

11 Jan '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/41806?usp=email ) Change subject: OmapiCallbackHandlerVpcd: simplify/fix SELECT by DF-Name (aid) ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41806?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: Ib4873b18d233e549e075b9384906a536907c6260 Gerrit-Change-Number: 41806 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 11 Jan 2026 22:01:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026