January 2026 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: runtime/cosmetic: add line break
by dexter 12 Jan '26

12 Jan '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41811?usp=email ) Change subject: runtime/cosmetic: add line break ...................................................................... runtime/cosmetic: add line break The other source files have a line break between the character encoding qualifier line and the python comment. Let's add a line break here as well to maintain consistency. Change-Id: Ied6b77eede748f1ddf6fde17c9b434fa4dd1114a --- M pySim/runtime.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/runtime.py b/pySim/runtime.py index 35452a0..19d3538 100644 --- a/pySim/runtime.py +++ b/pySim/runtime.py @@ -1,4 +1,5 @@ # coding=utf-8 + """Representation of the runtime state of an application like pySim-shell. """ -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41811?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ied6b77eede748f1ddf6fde17c9b434fa4dd1114a Gerrit-Change-Number: 41811 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: transport/init/cosmetic: move copryight header to the top
by dexter 12 Jan '26

12 Jan '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41810?usp=email ) Change subject: transport/init/cosmetic: move copryight header to the top ...................................................................... transport/init/cosmetic: move copryight header to the top The copyright header seems to be misplaced, let's move it to the top. Change-Id: I8358cca3bc9adb5a186a8b38a3bd90d7aec60d5c --- M pySim/transport/__init__.py 1 file changed, 10 insertions(+), 13 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/transport/__init__.py b/pySim/transport/__init__.py index 099b018..f82f4df 100644 --- a/pySim/transport/__init__.py +++ b/pySim/transport/__init__.py @@ -3,18 +3,6 @@ """ pySim: PCSC reader transport link base """ -import os -import abc -import argparse -from typing import Optional, Tuple -from construct import Construct -from osmocom.utils import b2h, h2b, i2h, Hexstr - -from pySim.exceptions import * -from pySim.utils import SwHexstr, SwMatchstr, ResTuple, sw_match, parse_command_apdu -from pySim.cat import ProactiveCommand, CommandDetails, DeviceIdentities, Result - -# # Copyright (C) 2009-2010 Sylvain Munaut <tnt(a)246tNt.com> # Copyright (C) 2021-2023 Harald Welte <laforge(a)osmocom.org> # @@ -30,8 +18,17 @@ # # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -# +import os +import abc +import argparse +from typing import Optional, Tuple +from construct import Construct +from osmocom.utils import b2h, h2b, i2h, Hexstr + +from pySim.exceptions import * +from pySim.utils import SwHexstr, SwMatchstr, ResTuple, sw_match, parse_command_apdu +from pySim.cat import ProactiveCommand, CommandDetails, DeviceIdentities, Result class ApduTracer: def trace_command(self, cmd): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41810?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8358cca3bc9adb5a186a8b38a3bd90d7aec60d5c Gerrit-Change-Number: 41810 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-bts[master]: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state
by fixeria 11 Jan '26

11 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email ) Change subject: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state ...................................................................... Patch Set 3: Code-Review-1 (4 comments) Patchset: PS2: > > So far I had a quick look and I don't really understand/see what do we benefit from this refactori […] >> From what I remember, I intentionally wanted to have the power control parameters separated from the power control state. And using the pointer allows to avoid memcpy()ing parameters which are identical for all lchans in 99% cases. > You are still holding a copy on each lchan. All I'm doing is getting rid of one extra pointer field. I guess my original intention was to let the `*params` point to either per-TRX or per-lchan power control parameters structure. However, this idea has a flow: changing the global per-TRX parameters would immediately affect all logical channels, which is not what we want. This is why each lchan always holds its own copy of the power control parameters. And you're right, we always do `memcpy()` anyway. With that, I am no longer against merging this change. However, there are some issues (see my other comments), thus CR-1. File src/common/power_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/41807/comment/c0559abe_158c5091?usp… : PS3, Line 151: memcpy(params, trx->ms_dpc_params, sizeof(*params)); What's the point of moving this `memcpy()` here? Why not keeping it where it was (in `rsl_rx_chan_activ()`). This `memcpy()` is redundant when static power control is used. This specific change also creates inconsistency with `rsl_rx_ms_pwr_ctrl()`, where this `memcpy()` is preserved. https://gerrit.osmocom.org/c/osmo-bts/+/41807/comment/886c80c9_a6842b2e?usp… : PS3, Line 343: memcpy(params, trx->ms_dpc_params, sizeof(*params)); And you say pointers are the source of bugs... The real source of bugs is the copy-paste function in text editors :D ```suggestion memcpy(params, trx->bs_dpc_params, sizeof(*params)); ``` But likewise here, I believe this `memcpy()` should be kept where it was. File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/41807/comment/d30596b7_5173aae4?usp… : PS3, Line 2082: lchan->ms_power_ctrl.dpc_enabled = true; ```suggestion lchan->bs_power_ctrl.dpc_enabled = true; ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0e2a6c2c33e0ac9a0bc1734d83eaeafc27f2f4df Gerrit-Change-Number: 41807 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 11 Jan 2026 23:51:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: TC_tx_power_ramp_adm_state_change: Fix Tguard too low sometimes ...
by fixeria 11 Jan '26

11 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809?usp=email ) Change subject: bts: TC_tx_power_ramp_adm_state_change: Fix Tguard too low sometimes triggering ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I95448c732d08a30893cb958af79bf21c39ff10cb Gerrit-Change-Number: 41809 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 11 Jan 2026 23:16:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: Validate no TIME.ind block gaps in TC_pcu_time_ind
by fixeria 11 Jan '26

11 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41784?usp=email ) Change subject: bts: Validate no TIME.ind block gaps in TC_pcu_time_ind ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibce780009389b2cd06d1a6d79afa77d8e58187bc Gerrit-Change-Number: 41784 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 11 Jan 2026 23:15:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: TC_pcu_{rts_req,time_ind}: process FNs in port queue after time out
by fixeria 11 Jan '26

11 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41782?usp=email ) Change subject: bts: TC_pcu_{rts_req,time_ind}: process FNs in port queue after time out ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iacd4eafbdb42207465ac0c5e03492c460280ecf7 Gerrit-Change-Number: 41782 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 11 Jan 2026 23:15:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: bts: Validate no PDTCH/PTCCH block gaps in TC_pcu_rts_req
by fixeria 11 Jan '26

11 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41781?usp=email ) Change subject: bts: Validate no PDTCH/PTCCH block gaps in TC_pcu_rts_req ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41781?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0bf3540523c231ed7172cab720163816d5d81e26 Gerrit-Change-Number: 41781 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 11 Jan 2026 23:14:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl
by fixeria 11 Jan '26

11 Jan '26

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email ) Change subject: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785/comment/f439504b_2aa1… : PS2, Line 3853: if (first_after_wait) { : /* It may happen that BTS transmits SACCH before it receives our RSL MS POWER CONTROL: */ : log("Power level := ", l1h.ms_power_lvl, " does not ", : "match the signaled (RSL) power level := ", power_level); : first_after_wait := false; : repeat; : > This seems to be discard+repeat all the time, while I only want to discard only *once after each RSL […] Ah, I missed that you are resetting `first_after_wait` back to `true`. Then the `L1CTL.trigger(...)` is not usable here, indeed. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 Gerrit-Change-Number: 41785 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 11 Jan 2026 23:13:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: ms_power_control: Apply defaults during reset
by fixeria 11 Jan '26

11 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41795?usp=email ) Change subject: ms_power_control: Apply defaults during reset ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41795?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5c0137ba8bf1e057abdc1911716e3d1bf8c61ea3 Gerrit-Change-Number: 41795 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 11 Jan 2026 23:02:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: personalization: refactor ConfigurableParameter, Iccid, Imsi
by fixeria 11 Jan '26

11 Jan '26

Attention is currently required from: dexter, laforge, neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email ) Change subject: personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... Patch Set 15: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39742/comment/8185ff57_1a27e96d?usp=em… : PS13, Line 50: r"""Base class representing a part of the eSIM profile that is configurable during the > abc has no purpose and it doesn't work. This is quite a bold statement. I don't know what you expect from it, but in my experience it does the job: a) classes that inherit from `abc.ABC` (and their sub-classes that inherit indirectly) cannot be instantiated unless all the abstract methods are defined; b) it clearly tells to whoever is reading the code that it's an abstract class. I must admit Python's abstract class model is not as advanced as in other languages, like Java or C#. For instance, you can still inherit a class without defining all abstract classmethods in it - this will fail not during parsing, but during instantiation at run-time. Yet it's still better than nothing. Harald's concern is perfectly valid: using `abc.abstractmethod` but not inheriting from `abc.ABC` will result in the former doing nothing. The ABC magic simply does not work without that. BTW, the build verification failure is a good argument for using abc stuff: https://jenkins.osmocom.org/jenkins/job/gerrit-pysim-build/JOB_TYPE=test,a1… ``` TypeError: Can't instantiate abstract class Puk1 with abstract method apply_val ``` Looks like there's some mix-up of `apply()` and `apply_val()`? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 15 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 11 Jan 2026 22:54:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026