Attention is currently required from: pespin.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41753?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: 5gc: Document procedures not implemented in open5gs
......................................................................
5gc: Document procedures not implemented in open5gs
Change-Id: I1480dc8ee1f0db78c179406fa9090835364c01e8
---
M 5gc/C5G_Tests.ttcn
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/53/41753/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41753?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1480dc8ee1f0db78c179406fa9090835364c01e8
Gerrit-Change-Number: 41753
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, laforge, osmith.
Hello Jenkins Builder, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41747?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: 5gc: Test UE Triggered Service Request
......................................................................
5gc: Test UE Triggered Service Request
Related: SYS#7073
Change-Id: I65cf7844d11be55d9d5c8e31fd87a3c72e6a607b
---
M 5gc/C5G_Tests.ttcn
M 5gc/ConnHdlr.ttcn
M 5gc/expected-results.xml
M library/NGAP_Functions.ttcn
M library/NG_NAS_Osmo_Templates.ttcn
M library/NG_NAS_Osmo_Types.ttcn
6 files changed, 346 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/47/41747/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41747?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I65cf7844d11be55d9d5c8e31fd87a3c72e6a607b
Gerrit-Change-Number: 41747
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/41795?usp=email )
Change subject: ms_power_control: Apply defaults during reset
......................................................................
ms_power_control: Apply defaults during reset
lchan_ms_pwr_ctrl_reset() is already called furhter above in
rsl_rx_chan_activ(), so simplify mode the default values there and no
need to re-apply them twice.
Change-Id: I5c0137ba8bf1e057abdc1911716e3d1bf8c61ea3
---
M src/common/power_control.c
M src/common/rsl.c
2 files changed, 8 insertions(+), 6 deletions(-)
Approvals:
fixeria: Looks good to me, approved
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
diff --git a/src/common/power_control.c b/src/common/power_control.c
index bf310c6..c4ff5e6 100644
--- a/src/common/power_control.c
+++ b/src/common/power_control.c
@@ -145,6 +145,10 @@
* state->dpc_params = NULL (static mode).
* state->skip_block_num = 0, so that 1st power input is taken into account. */
memset(state, 0, sizeof(*state));
+
+ /* XXX: should we use the maximum power level instead of 0 dBm? */
+ state->max = ms_pwr_ctl_lvl(lchan->ts->trx->bts->band, 0);
+ state->current = state->max;
}
/* Shall we skip current block based on configured interval? */
diff --git a/src/common/rsl.c b/src/common/rsl.c
index 863167e..e620545 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -1989,8 +1989,6 @@
}
}
- lchan_ms_pwr_ctrl_reset(lchan);
-
/* 9.3.6 Channel Mode */
if (type != RSL_ACT_OSMO_PDCH) {
if (rsl_handle_chan_mod_ie(lchan, &tp, &cause) != 0)
@@ -2050,11 +2048,11 @@
}
/* 9.3.13 MS Power */
- if (TLVP_PRES_LEN(&tp, RSL_IE_MS_POWER, 1))
+ lchan_ms_pwr_ctrl_reset(lchan);
+ if (TLVP_PRES_LEN(&tp, RSL_IE_MS_POWER, 1)) {
lchan->ms_power_ctrl.max = *TLVP_VAL(&tp, RSL_IE_MS_POWER) & 0x1F;
- else /* XXX: should we use the maximum power level instead of 0 dBm? */
- lchan->ms_power_ctrl.max = ms_pwr_ctl_lvl(lchan->ts->trx->bts->band, 0);
- lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max;
+ lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max;
+ }
/* 9.3.24 Timing Advance */
if (TLVP_PRES_LEN(&tp, RSL_IE_TIMING_ADVANCE, 1))
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41795?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5c0137ba8bf1e057abdc1911716e3d1bf8c61ea3
Gerrit-Change-Number: 41795
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/41796?usp=email )
Change subject: ta_power_control: reset during lchan activation
......................................................................
ta_power_control: reset during lchan activation
This way lchan->ta_ctrl.skip_block_num is also reset to 0 during chan
re-activation case, in which case we allow the TA control loop to kick
in during first input after re-activation.
Change-Id: I149fffa73ef651fd21e52e5423b31f8e95e57941
---
M src/common/rsl.c
M src/common/ta_control.c
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
diff --git a/src/common/rsl.c b/src/common/rsl.c
index e620545..23207b2 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -2055,10 +2055,9 @@
}
/* 9.3.24 Timing Advance */
+ lchan_ms_ta_ctrl_reset(lchan);
if (TLVP_PRES_LEN(&tp, RSL_IE_TIMING_ADVANCE, 1))
lchan->ta_ctrl.current = *TLVP_VAL(&tp, RSL_IE_TIMING_ADVANCE);
- else /* assume TA=0 if not indicated by the BSC */
- lchan->ta_ctrl.current = 0;
/* 9.3.31 (TLV) MS Power Parameters IE (vendor specific) */
if ((ie = TLVP_GET(&tp, RSL_IE_MS_POWER_PARAM)) != NULL) {
diff --git a/src/common/ta_control.c b/src/common/ta_control.c
index b5d9cb2..85e5f81 100644
--- a/src/common/ta_control.c
+++ b/src/common/ta_control.c
@@ -46,6 +46,7 @@
{
/* Trigger loop on first TA input: */
lchan->ta_ctrl.skip_block_num = 0;
+ /* Assume TA=0 if not indicated by the BSC */
lchan->ta_ctrl.current = 0;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41796?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I149fffa73ef651fd21e52e5423b31f8e95e57941
Gerrit-Change-Number: 41796
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email )
Change subject: ipaccess-config-e1-driver: Make sure struct input_signal_data is zero initialized
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bsc/+/41773/comment/978a23ce_d556a6b2?usp… :
PS1, Line 7: struct input_signal_data is zero initialized
> What's the goal of doing that? Keep in mind that only the actual struct fields are initialized when […]
I spotted this while looking at a libosmo-abis patch from @andreas@eversberg.eu which was aiming at adding new fields to that address (I don't have the patch link at hand, maybe Andreas can provide since it shows up in his UI).
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If97c4a4202eaf96446d48e821d5e59c98bafe51c
Gerrit-Change-Number: 41773
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Jan 2026 12:43:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809?usp=email )
Change subject: bts: TC_tx_power_ramp_adm_state_change: Fix Tguard too low sometimes triggering
......................................................................
bts: TC_tx_power_ramp_adm_state_change: Fix Tguard too low sometimes triggering
One can see with the following failing output below that the Tguard is
too low:
"""
13:36:12.459089 5684 BTS_Tests.ttcn:2836 Reached full power, wating a bit more until success
13:36:12.459097 5684 BTS_Tests.ttcn:2837 Start timer T: 2 s
13:36:14.358525 5684 Misc_Helpers.ttcn:35 setverdict(fail): pass -> fail reason: ""BTS_Tests.ttcn:729 : Tguard timeout"", new component reason: ""BTS_Tests.ttcn:729 : Tguard timeout""
"""
Change-Id: I95448c732d08a30893cb958af79bf21c39ff10cb
---
M bts/BTS_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
pespin: Looks good to me, approved
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index c681da9..b060cbd 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -3035,7 +3035,7 @@
var ConnHdlr vc_conn;
var ConnHdlrPars pars;
f_init();
- pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN));
+ pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN, t_guard := 60.0));
vc_conn := f_start_handler(refers(f_TC_tx_power_ramp_adm_state_change), pars,
pcu_comp := false, trxc_comp := true);
vc_conn.done;
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I95448c732d08a30893cb958af79bf21c39ff10cb
Gerrit-Change-Number: 41809
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>