January 2026 - gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: ttcn3-bts-test: bpftrace: filter by executable name
by pespin 12 Jan '26

12 Jan '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/docker-playground/+/41778?usp=email ) Change subject: ttcn3-bts-test: bpftrace: filter by executable name ...................................................................... Patch Set 2: (1 comment) File ttcn3-bts-test/bpftrace/ksys_write_delay.bt: https://gerrit.osmocom.org/c/docker-playground/+/41778/comment/46c3c677_996… : PS2, Line 28: kretprobe:ksys_write / comm == str($1) && @start[tid] / This change is not needed, since the other condition can only be true already when comm == str($1) -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I04c2e36806534a8ca650733bacf521ea57950692 Gerrit-Change-Number: 41778 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jan 2026 23:07:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in docker-playground[master]: ttcn3-bts-test: bpftrace: filter by executable name
by fixeria 12 Jan '26

12 Jan '26

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/docker-playground/+/41778?usp=email ) Change subject: ttcn3-bts-test: bpftrace: filter by executable name ...................................................................... Patch Set 1: (2 comments) This change is ready for review. File ttcn3-bts-test/bpftrace/ksys_write_delay.bt: https://gerrit.osmocom.org/c/docker-playground/+/41778/comment/f0c4e7ae_b3e… : PS1, Line 20: kprobe:ksys_write / comm == $1 / > This needs to be: / comm == str($1) / Done File ttcn3-bts-test/bpftrace/udp_sendmsg_delay.bt: https://gerrit.osmocom.org/c/docker-playground/+/41778/comment/f11d9fe9_7a0… : PS1, Line 20: kprobe:udp_sendmsg / comm == $1 / > This needs to be: / comm == str($1) / Done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I04c2e36806534a8ca650733bacf521ea57950692 Gerrit-Change-Number: 41778 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jan 2026 22:03:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: omo_io: poll: Support multiple iov on all read/write variants
by pespin 12 Jan '26

12 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41832?usp=email ) Change subject: omo_io: poll: Support multiple iov on all read/write variants ...................................................................... omo_io: poll: Support multiple iov on all read/write variants The logic was already in place for io_uring, but was missing for poll backend. So this patch mainly takes the existing logic from there and adapts it to poll. This way we can get some easy optimizations even when using poll(), for programs doing multiple msgb sends on the same event loop iteration. Related: OS#6705 Change-Id: I64a2a6725f91b5e5f575c6fc104bd58b50063873 --- M src/core/osmo_io.c M src/core/osmo_io_poll.c 2 files changed, 87 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/32/41832/1 diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index 10e6e3f..b28f170 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -857,9 +857,6 @@ if (iofd->mode != OSMO_IO_FD_MODE_READ_WRITE) return -EINVAL; - if (g_io_backend != OSMO_IO_BACKEND_IO_URING) - return -EINVAL; - if (buffers < 1 || buffers > IOFD_MSGHDR_IO_BUFFERS) return -EINVAL; diff --git a/src/core/osmo_io_poll.c b/src/core/osmo_io_poll.c index d27a5d6..c37d436 100644 --- a/src/core/osmo_io_poll.c +++ b/src/core/osmo_io_poll.c @@ -29,6 +29,7 @@ #include <unistd.h> #include <stdbool.h> #include <sys/socket.h> +#include <sys/uio.h> #include <osmocom/core/osmo_io.h> #include <osmocom/core/linuxlist.h> @@ -41,62 +42,116 @@ #include "osmo_io_internal.h" +/*! completion call-back for READ */ +static void iofd_poll_handle_recv(struct iofd_msghdr *msghdr, int rc) +{ + struct osmo_io_fd *iofd = msghdr->iofd; + uint8_t idx; + + for (idx = 0; idx < msghdr->io_len; idx++) { + struct msgb *msg = msghdr->msg[idx]; + int chunk; + + msghdr->msg[idx] = NULL; + if (rc > 0) { + if (rc > msghdr->iov[idx].iov_len) + chunk = msghdr->iov[idx].iov_len; + else + chunk = rc; + rc -= chunk; + msgb_put(msg, chunk); + } else { + chunk = rc; + } + + /* Check for every iteration, because iofd might get unregistered/closed during receive function. */ + if (IOFD_FLAG_ISSET(iofd, IOFD_FLAG_FD_REGISTERED) && (iofd->u.poll.ofd.when & OSMO_FD_READ)) + iofd_handle_recv(iofd, msg, chunk, msghdr); + else + msgb_free(msg); + + if (rc <= 0) + break; + } + while (++idx < msghdr->io_len) { + msgb_free(msghdr->msg[idx]); + msghdr->msg[idx] = NULL; + } + + iofd_msghdr_free(msghdr); +} + static void iofd_poll_ofd_cb_recvmsg_sendmsg(struct osmo_fd *ofd, unsigned int what) { struct osmo_io_fd *iofd = ofd->data; - struct msgb *msg; - int rc, flags = 0; + enum iofd_msg_action action; + struct iofd_msghdr *msghdr; + int rc; + uint8_t idx; if (what & OSMO_FD_READ) { - struct iofd_msghdr hdr; - - msg = iofd_msgb_alloc(iofd); - if (!msg) { - LOGPIO(iofd, LOGL_ERROR, "Could not allocate msgb for reading\n"); - OSMO_ASSERT(0); - } switch (iofd->mode) { case OSMO_IO_FD_MODE_READ_WRITE: - rc = read(ofd->fd, msg->tail, msgb_tailroom(msg)); - if (rc > 0) - msgb_put(msg, rc); - iofd_handle_recv(iofd, msg, (rc < 0 && errno > 0) ? -errno : rc, NULL); + action = IOFD_ACT_READ; break; case OSMO_IO_FD_MODE_RECVFROM_SENDTO: + action = IOFD_ACT_RECVFROM; + break; case OSMO_IO_FD_MODE_RECVMSG_SENDMSG: - hdr.msg[0] = msg; - hdr.iov[0].iov_base = msg->tail; - hdr.iov[0].iov_len = msgb_tailroom(msg); - hdr.hdr = (struct msghdr) { - .msg_iov = &hdr.iov[0], - .msg_iovlen = 1, - .msg_name = &hdr.osa.u.sa, - .msg_namelen = sizeof(struct osmo_sockaddr), - }; - if (iofd->mode == OSMO_IO_FD_MODE_RECVMSG_SENDMSG) { - hdr.hdr.msg_control = alloca(iofd->cmsg_size); - hdr.hdr.msg_controllen = iofd->cmsg_size; - } - rc = recvmsg(ofd->fd, &hdr.hdr, flags); - if (rc > 0) - msgb_put(msg, rc); - iofd_handle_recv(iofd, msg, (rc < 0 && errno > 0) ? -errno : rc, &hdr); + action = IOFD_ACT_RECVMSG; break; default: OSMO_ASSERT(0); } + + msghdr = iofd_msghdr_alloc(iofd, action, NULL, iofd->cmsg_size); + for (idx = 0; idx < msghdr->io_len; idx++) { + msghdr->iov[idx].iov_base = msghdr->msg[idx]->tail; + msghdr->iov[idx].iov_len = msgb_tailroom(msghdr->msg[idx]); + } + + switch (action) { + case IOFD_ACT_RECVMSG: + msghdr->hdr.msg_control = msghdr->cmsg; + msghdr->hdr.msg_controllen = iofd->cmsg_size; + /* fall-through */ + case IOFD_ACT_RECVFROM: + msghdr->hdr.msg_name = &msghdr->osa.u.sa; + msghdr->hdr.msg_namelen = osmo_sockaddr_size(&msghdr->osa); + /* fall-through */ + case IOFD_ACT_READ: + msghdr->hdr.msg_iov = &msghdr->iov[0]; + msghdr->hdr.msg_iovlen = msghdr->io_len; + break; + default: + OSMO_ASSERT(0); + } + + switch (action) { + case IOFD_ACT_READ: + rc = readv(ofd->fd, msghdr->hdr.msg_iov, msghdr->hdr.msg_iovlen); + break; + case IOFD_ACT_RECVFROM: + case IOFD_ACT_RECVMSG: + rc = recvmsg(ofd->fd, &msghdr->hdr, msghdr->flags); + break; + default: + OSMO_ASSERT(0); + } + + iofd_poll_handle_recv(msghdr, (rc < 0 && errno > 0) ? -errno : rc); } if (IOFD_FLAG_ISSET(iofd, IOFD_FLAG_CLOSED)) return; if (what & OSMO_FD_WRITE) { - struct iofd_msghdr *msghdr = iofd_txqueue_dequeue(iofd); + msghdr = iofd_txqueue_dequeue(iofd); if (msghdr) { switch (iofd->mode) { case OSMO_IO_FD_MODE_READ_WRITE: - rc = write(ofd->fd, msghdr->iov[0].iov_base, msghdr->iov[0].iov_len); + rc = writev(ofd->fd, msghdr->iov, msghdr->io_len); break; case OSMO_IO_FD_MODE_RECVFROM_SENDTO: case OSMO_IO_FD_MODE_RECVMSG_SENDMSG: -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41832?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I64a2a6725f91b5e5f575c6fc104bd58b50063873 Gerrit-Change-Number: 41832 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: contrib/known_hosts: update gerrit ssh key
by fixeria 12 Jan '26

12 Jan '26

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41831?usp=email ) Change subject: contrib/known_hosts: update gerrit ssh key ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41831?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I66e5d96dcb34d33a21f5a70899fba9a75e6127ed Gerrit-Change-Number: 41831 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jan 2026 16:21:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: contrib/known_hosts: update gerrit ssh key
by pespin 12 Jan '26

12 Jan '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41831?usp=email ) Change subject: contrib/known_hosts: update gerrit ssh key ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41831?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I66e5d96dcb34d33a21f5a70899fba9a75e6127ed Gerrit-Change-Number: 41831 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jan 2026 14:32:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: contrib/known_hosts: update gerrit ssh key
by osmith 12 Jan '26

12 Jan '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/41831?usp=email ) Change subject: contrib/known_hosts: update gerrit ssh key ...................................................................... contrib/known_hosts: update gerrit ssh key Related: OS#6920 Change-Id: I66e5d96dcb34d33a21f5a70899fba9a75e6127ed --- M ansible/roles/osmocom-jenkins-slave/tasks/main.yml M contrib/known_hosts 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/31/41831/1 diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/main.yml b/ansible/roles/osmocom-jenkins-slave/tasks/main.yml index 1ddbff9..58caf7a 100644 --- a/ansible/roles/osmocom-jenkins-slave/tasks/main.yml +++ b/ansible/roles/osmocom-jenkins-slave/tasks/main.yml @@ -30,7 +30,7 @@ - name: setup gerrit ssh key (known_hosts) known_hosts: name: '[gerrit.osmocom.org]:29418' - key: '[gerrit.osmocom.org]:29418 ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAAAgQDI4wZwtcGz2V98iZWWEtsA162PolLtgQTBjnC14ONzZGQkTh9bTPsoSxnM5TKOm4F2bzq7gb+Qrsj4ZECD19qztmD37kMP9jn7/2i1V8oLAy9ojyklXAdBVTliQteVI7ieDOyKCnGbszvFWXY2isoO1k7yJLv0QyL7F5AuZlxeHw==' + key: '[gerrit.osmocom.org]:29418 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIJoTejinQkDyqXpGUYNf+lDV2bjncR9scdPDGrPCUFFw gerrit-code-review(a)gerrit.osmocom.org' path: /etc/ssh/ssh_known_hosts state: present diff --git a/contrib/known_hosts b/contrib/known_hosts index 5be5736..7becb33 100644 --- a/contrib/known_hosts +++ b/contrib/known_hosts @@ -1,4 +1,4 @@ [ftp.osmocom.org]:48 ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDDgQ9HntlpWNmh953a2Gc8NysKE4orOatVT1wQkyzhARnfYUerRuwyNr1GqMyBKdSI9amYVBXJIOUFcpV81niA7zQRUs66bpIMkE9/rHxBd81SkorEPOIS84W4vm3SZtuNqa+fADcqe88Hcb0ZdTzjKILuwi19gzrQyME2knHY71EOETe9Yow5RD2hTIpB5ecNxI0LUKDq+Ii8HfBvndPBIr0BWYDugckQ3Bocf+yn/tn2/GZieFEyFpBGF/MnLbAAfUKIdeyFRX7ufaiWWz5yKAfEhtziqdAGZaXNaLG6gkpy3EixOAy6ZXuTAk3b3Y0FUmDjhOHllbPmTOcKMry9 [ftp.osmocom.org]:48 ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBPdWn1kEousXuKsZ+qJEZTt/NSeASxCrUfNDW3LWtH+d8Ust7ZuKp/vuyG+5pe5pwpPOgFu7TjN+0lVjYJVXH54= [ftp.osmocom.org]:48 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIK8iivY70EiR5NiGChV39gRLjNpC8lvu1ZdHtdMw2zuX -[gerrit.osmocom.org]:29418 ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAAAgQDI4wZwtcGz2V98iZWWEtsA162PolLtgQTBjnC14ONzZGQkTh9bTPsoSxnM5TKOm4F2bzq7gb+Qrsj4ZECD19qztmD37kMP9jn7/2i1V8oLAy9ojyklXAdBVTliQteVI7ieDOyKCnGbszvFWXY2isoO1k7yJLv0QyL7F5AuZlxeHw== +[gerrit.osmocom.org]:29418 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIJoTejinQkDyqXpGUYNf+lDV2bjncR9scdPDGrPCUFFw gerrit-code-review(a)gerrit.osmocom.org -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41831?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I66e5d96dcb34d33a21f5a70899fba9a75e6127ed Gerrit-Change-Number: 41831 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in android-apdu-proxy[master]: README.md: add adb install commandline
by dexter 12 Jan '26

12 Jan '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/41799?usp=email ) Change subject: README.md: add adb install commandline ...................................................................... README.md: add adb install commandline Change-Id: I4ab62c24dd265ed6813d8b941d84d2f2126df2fa --- M README.md 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/README.md b/README.md index cc8e34f..738a671 100644 --- a/README.md +++ b/README.md @@ -183,6 +183,10 @@ ./app/build/outputs/apk/release. This file can be installed on the Android device. +``` +$ adb install ./app/build/outputs/apk/release/app-release.apk +``` + Signing and ARA-M configuration ------------------------------- -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41799?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: I4ab62c24dd265ed6813d8b941d84d2f2126df2fa Gerrit-Change-Number: 41799 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-bsc[master]: ipaccess-config-e1-driver: Make sure struct input_signal_data is zero...
by pespin 12 Jan '26

12 Jan '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email ) Change subject: ipaccess-config-e1-driver: Make sure struct input_signal_data is zero initialized ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/41773/comment/69dc920a_60cf3c10?usp… : PS1, Line 7: struct input_signal_data is zero initialized > Fine with me, just mentioning a corner care that I faced myself some time ago ;) Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If97c4a4202eaf96446d48e821d5e59c98bafe51c Gerrit-Change-Number: 41773 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jan 2026 12:52:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: ipaccess-config-e1-driver: Make sure struct input_signal_data is zero...
by pespin 12 Jan '26

12 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email ) Change subject: ipaccess-config-e1-driver: Make sure struct input_signal_data is zero initialized ...................................................................... ipaccess-config-e1-driver: Make sure struct input_signal_data is zero initialized Change-Id: If97c4a4202eaf96446d48e821d5e59c98bafe51c --- M src/ipaccess/ipaccess-config-e1-driver.c 1 file changed, 8 insertions(+), 7 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve jolly: Looks good to me, but someone else must approve fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/ipaccess/ipaccess-config-e1-driver.c b/src/ipaccess/ipaccess-config-e1-driver.c index 631e430..8164642 100644 --- a/src/ipaccess/ipaccess-config-e1-driver.c +++ b/src/ipaccess/ipaccess-config-e1-driver.c @@ -77,13 +77,14 @@ static int e1inp_int_snd_event(struct e1inp_ts *ts, struct e1inp_sign_link *link, int evt) { - struct input_signal_data isd; - isd.line = ts->line; - isd.ts_nr = ts->num; - isd.link_type = link->type; - isd.trx = link->trx; - isd.tei = link->tei; - isd.sapi = link->sapi; + struct input_signal_data isd = { + .line = ts->line, + .ts_nr = ts->num, + .link_type = link->type, + .trx = link->trx, + .tei = link->tei, + .sapi = link->sapi, + }; /* report further upwards */ osmo_signal_dispatch(SS_L_INPUT, evt, &isd); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If97c4a4202eaf96446d48e821d5e59c98bafe51c Gerrit-Change-Number: 41773 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: ipaccess-config-e1-driver: Make sure struct input_signal_data is zero...
by osmith 12 Jan '26

12 Jan '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email ) Change subject: ipaccess-config-e1-driver: Make sure struct input_signal_data is zero initialized ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If97c4a4202eaf96446d48e821d5e59c98bafe51c Gerrit-Change-Number: 41773 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Jan 2026 12:48:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026