August 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: GTPv1C_Templates: add cause code GTP_CAUSE_IMSI_IMEI_NOT_KNOWN

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39263?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: GTPv1C_Templates: add cause code GTP_CAUSE_IMSI_IMEI_NOT_KNOWN ...................................................................... GTPv1C_Templates: add cause code GTP_CAUSE_IMSI_IMEI_NOT_KNOWN It will be used by SGSN Context Req/Resp/Ack test cases in the SGSN. Change-Id: I8f919d5982a3c9a317d309c383b36043ad5d3278 --- M library/GTPv1C_Templates.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/63/39263/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39263?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8f919d5982a3c9a317d309c383b36043ad5d3278 Gerrit-Change-Number: 39263 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 month

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: L3_Templates: add MM cause codes

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39264?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: L3_Templates: add MM cause codes ...................................................................... L3_Templates: add MM cause codes It will be used by SGSN Context Req/Resp/Ack test cases in the SGSN. Change-Id: I396ddaf5b08faddcf002317307dcc20840898aa9 --- M library/L3_Templates.ttcn 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/64/39264/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39264?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I396ddaf5b08faddcf002317307dcc20840898aa9 Gerrit-Change-Number: 39264 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS...

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236?usp=email ) Change subject: MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS Purge ...................................................................... MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS Purge Currently the MSC/VLR doesn't inform the HLR when a MS detaches. Change-Id: I9e87537efc2c921fa860539a706316ed410b45d5 --- M msc/MSC_Tests.ttcn M msc/expected-results.xml 2 files changed, 20 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 3f4afe4..675fc55 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -3455,6 +3455,24 @@ f_vty_config(MSCVTY, "msc", "no sms-over-gsup"); } +/* LU followed by detach and will trigger a Purge MS */ +friend function f_tc_gsup_lu_and_det(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + f_init_handler(pars, t_guard := 8.0); + f_perform_lu(); + + f_imsi_detach_by_imsi(); + + GSUP.receive(tr_GSUP_PURGE_MS_REQ(g_pars.imsi, OSMO_GSUP_CN_DOMAIN_CS)); + GSUP.send(ts_GSUP_PURGE_MS_RES(g_pars.imsi)); +} +testcase TC_gsup_lu_and_det() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + + vc_conn := f_start_handler(refers(f_tc_gsup_lu_and_det), 103); + vc_conn.done; +} + /* convert GSM L3 TON to SMPP_TON enum */ function f_sm_ton_from_gsm(BIT3 ton) return SMPP_TON { select (ton) { @@ -7888,6 +7906,7 @@ execute( TC_gsup_mt_sms_lu_delay() ); execute( TC_gsup_mt_sms_paging_timeout() ); execute( TC_gsup_mt_sms_conn_timeout() ); + execute( TC_gsup_lu_and_det() ); execute( TC_lu_and_mo_ussd_single_request() ); execute( TC_lu_and_mt_ussd_notification() ); diff --git a/msc/expected-results.xml b/msc/expected-results.xml index 65f6d8e..25c49b4 100644 --- a/msc/expected-results.xml +++ b/msc/expected-results.xml @@ -83,6 +83,7 @@ <testcase classname='MSC_Tests' name='TC_gsup_mt_sms_lu_delay' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_gsup_mt_sms_paging_timeout' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_gsup_mt_sms_conn_timeout' time='MASKED'/> + <testcase classname='MSC_Tests' name='TC_gsup_lu_and_det' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_lu_and_mo_ussd_single_request' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_lu_and_mt_ussd_notification' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_lu_and_mo_ussd_during_mt_call' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9e87537efc2c921fa860539a706316ed410b45d5 Gerrit-Change-Number: 39236 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 month

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: BSSGP_ConnHdlr: f_service_request: allow to define if a Service Accep...

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40651?usp=email ) Change subject: BSSGP_ConnHdlr: f_service_request: allow to define if a Service Accept is expected ...................................................................... BSSGP_ConnHdlr: f_service_request: allow to define if a Service Accept is expected A SecurityModeCommand is defined as an implicit Service Accept when the UE is in PMM_IDLE (meaning, having no Iu signalling connection) Change-Id: I5c190db28263c530a8eea188bf570a58eaffdd4d --- M sgsn/BSSGP_ConnHdlr.ttcn M sgsn/SGSN_Tests_Iu.ttcn 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/sgsn/BSSGP_ConnHdlr.ttcn b/sgsn/BSSGP_ConnHdlr.ttcn index aea981c..f976135 100644 --- a/sgsn/BSSGP_ConnHdlr.ttcn +++ b/sgsn/BSSGP_ConnHdlr.ttcn @@ -758,6 +758,7 @@ template (value) OCT2 pdp_status := '0000'O, boolean exp_ggsn_pdp_del := false, boolean expect_auth := false, + boolean expect_service_acc := true, integer ran_index := 0, float Tval := 5.0) runs on BSSGP_ConnHdlr { timer T := Tval; @@ -790,7 +791,7 @@ } alt { - [] as_service_request(exp_service_acc := true, ran_index := ran_index) { setverdict(pass); } + [] as_service_request(exp_service_acc := expect_service_acc, ran_index := ran_index) { setverdict(pass); } [not expect_auth] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_AUTH_REQ)) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Service Request: Unexpected GMM Auth Req"); diff --git a/sgsn/SGSN_Tests_Iu.ttcn b/sgsn/SGSN_Tests_Iu.ttcn index e84869f..6e8b5b6 100644 --- a/sgsn/SGSN_Tests_Iu.ttcn +++ b/sgsn/SGSN_Tests_Iu.ttcn @@ -138,7 +138,7 @@ /* first perform regular attach */ f_gmm_attach(umts_aka_challenge := true, force_gsm_sres := false, ran_index := 3); - f_service_request(apars, service_type := SERVICE_TYPE_Signalling, ran_index := 3); + f_service_request(apars, service_type := SERVICE_TYPE_Signalling, expect_service_acc := false, ran_index := 3); f_pdp_ctx_act(apars, ran_index := 3); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40651?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5c190db28263c530a8eea188bf570a58eaffdd4d Gerrit-Change-Number: 40651 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 month

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: GSUP_Templates: fix whitespace issues

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40668?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: GSUP_Templates: fix whitespace issues ...................................................................... GSUP_Templates: fix whitespace issues Change-Id: I03be75063a71153bd2881afd1d741454c508fada --- M library/GSUP_Templates.ttcn 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index 1fc18f1..671e36d 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -448,8 +448,8 @@ template (omit) octetstring source_name := omit, template (omit) octetstring destination_name := omit) := ts_GSUP(OSMO_GSUP_MSGT_INSERT_DATA_RESULT, - f_gen_ts_ies(imsi, source_name := source_name, - destination_name := destination_name)); + f_gen_ts_ies(imsi, source_name := source_name, + destination_name := destination_name)); template GSUP_PDU tr_GSUP_ISD_RES(template hexstring imsi) := tr_GSUP_IMSI(OSMO_GSUP_MSGT_INSERT_DATA_RESULT, imsi); @@ -500,7 +500,7 @@ tr_GSUP_IE_IMSI(imsi), tr_GSUP_IE_Cause(cause) }); template (value) GSUP_PDU ts_GSUP_CHECK_IMEI_REQ(hexstring imsi, hexstring imei, - template (omit) octetstring source_name := omit) := + template (omit) octetstring source_name := omit) := ts_GSUP(OSMO_GSUP_MSGT_CHECK_IMEI_REQUEST, f_gen_ts_ies(imsi, imei := imei, source_name := source_name)); template GSUP_PDU tr_GSUP_CHECK_IMEI_REQ( -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40668?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I03be75063a71153bd2881afd1d741454c508fada Gerrit-Change-Number: 40668 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: GSUP Templates: fix empty destination_name in GSUP ISD/UL

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666?usp=email ) Change subject: GSUP Templates: fix empty destination_name in GSUP ISD/UL ...................................................................... GSUP Templates: fix empty destination_name in GSUP ISD/UL The destination_name TLV should be either set with a valid name or not present, but a field with length 0 shouldn't be used. Change-Id: Ia89b5a82665e407fa578e5209fbcde0676326df0 --- M library/GSUP_Templates.ttcn 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index 227a7d2..3206d1c 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -418,9 +418,9 @@ template GSUP_PDU tr_GSUP_UL_REQ(template hexstring imsi) := tr_GSUP_IMSI(OSMO_GSUP_MSGT_UPDATE_LOCATION_REQUEST, imsi); -template (value) GSUP_PDU ts_GSUP_UL_RES(hexstring imsi, octetstring destination_name := ''O) := - ts_GSUP(OSMO_GSUP_MSGT_UPDATE_LOCATION_RESULT, { valueof(ts_GSUP_IE_IMSI(imsi)), - valueof(ts_GSUP_IE_Destination_Name(destination_name))}); +template (value) GSUP_PDU ts_GSUP_UL_RES(hexstring imsi, template (omit) octetstring destination_name := omit) := + ts_GSUP(OSMO_GSUP_MSGT_UPDATE_LOCATION_RESULT, + f_gen_ts_ies(imsi, destination_name := destination_name)); template GSUP_PDU tr_GSUP_UL_RES(template hexstring imsi, template octetstring destination_name := omit) := tr_GSUP(OSMO_GSUP_MSGT_UPDATE_LOCATION_RESULT, f_gen_tr_ies(imsi, destination_name := destination_name)); @@ -434,19 +434,19 @@ tr_GSUP(OSMO_GSUP_MSGT_UPDATE_LOCATION_ERROR, f_gen_tr_ies(imsi, cause := cause, destination_name := destination_name)); -template (value) GSUP_PDU ts_GSUP_ISD_REQ(hexstring imsi, hexstring msisdn, octetstring destination_name := ''O) := - ts_GSUP(OSMO_GSUP_MSGT_INSERT_DATA_REQUEST, { - valueof(ts_GSUP_IE_IMSI(imsi)), valueof(ts_GSUP_IE_MSISDN(msisdn)), - valueof(ts_GSUP_IE_Destination_Name(destination_name))}); +template (value) GSUP_PDU ts_GSUP_ISD_REQ(hexstring imsi, hexstring msisdn, template (omit) octetstring destination_name := omit) := + ts_GSUP(OSMO_GSUP_MSGT_INSERT_DATA_REQUEST, + f_gen_ts_ies(imsi, destination_name := destination_name) & { + valueof(ts_GSUP_IE_MSISDN(msisdn)) }); template GSUP_PDU tr_GSUP_ISD_REQ(template hexstring imsi, template hexstring msisdn := ?, template octetstring destination_name := omit) := tr_GSUP(OSMO_GSUP_MSGT_INSERT_DATA_REQUEST, f_gen_tr_ies(imsi, msisdn := msisdn, destination_name := destination_name)); -template GSUP_PDU ts_GSUP_ISD_RES(hexstring imsi, - template octetstring source_name := omit, - template octetstring destination_name := omit) := +template (value) GSUP_PDU ts_GSUP_ISD_RES(hexstring imsi, + template (omit) octetstring source_name := omit, + template (omit) octetstring destination_name := omit) := ts_GSUP(OSMO_GSUP_MSGT_INSERT_DATA_RESULT, f_gen_ts_ies(imsi, source_name := source_name, destination_name := destination_name)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia89b5a82665e407fa578e5209fbcde0676326df0 Gerrit-Change-Number: 40666 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 month

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: GSUP_Templates: ts_GSUP_UL_REQ: add template scopes

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40667?usp=email ) Change subject: GSUP_Templates: ts_GSUP_UL_REQ: add template scopes ...................................................................... GSUP_Templates: ts_GSUP_UL_REQ: add template scopes Allow to omit the source_name TLV in GSUP UL Request. The whole ts_GSUP_UL_REQ must resolve to a value. Change-Id: I250960a1e1c19dfa1efa81f6bbc93efa07cb225c --- M library/GSUP_Templates.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index 3206d1c..1fc18f1 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -410,8 +410,8 @@ tr_GSUP(OSMO_GSUP_MSGT_SEND_AUTH_INFO_RESULT, { tr_GSUP_IE_IMSI(imsi), *, auth_tuple_ie, * }); -template GSUP_PDU ts_GSUP_UL_REQ(hexstring imsi, GSUP_CnDomain dom := OSMO_GSUP_CN_DOMAIN_PS, - template octetstring source_name := omit) := +template (value) GSUP_PDU ts_GSUP_UL_REQ(hexstring imsi, GSUP_CnDomain dom := OSMO_GSUP_CN_DOMAIN_PS, + template (omit) octetstring source_name := omit) := ts_GSUP(OSMO_GSUP_MSGT_UPDATE_LOCATION_REQUEST, f_gen_ts_ies(imsi, dom := dom, source_name := source_name)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40667?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I250960a1e1c19dfa1efa81f6bbc93efa07cb225c Gerrit-Change-Number: 40667 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 month

1
0
0 0

[XS] Change in osmo-upf[master]: contrib/jenkins.sh: use https:// instead of git://

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/40897?usp=email ) Change subject: contrib/jenkins.sh: use https:// instead of git:// ...................................................................... contrib/jenkins.sh: use https:// instead of git:// Change-Id: I5f184fd100230e1b9c0076739f49901ab2782b4f --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index b81d1a6..002bdc4 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -48,7 +48,7 @@ if [ -d "./$project" ]; then rm -rf "./$project" fi - git clone "git://git.netfilter.org/$project" "$project" + git clone "https://git.netfilter.org/$project" "$project" cd "$project" autoreconf --install --force ./configure \ -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/40897?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I5f184fd100230e1b9c0076739f49901ab2782b4f Gerrit-Change-Number: 40897 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 month

1
0
0 0

[XS] Change in osmo-upf[master]: contrib/jenkins.sh: specify --with-unitdir for nftables

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/40896?usp=email ) Change subject: contrib/jenkins.sh: specify --with-unitdir for nftables ...................................................................... contrib/jenkins.sh: specify --with-unitdir for nftables Since recently (see the related commit), libnftables installs a systemd unit file that loads a ruleset from a file on boot. contrib/jenkins.sh currently fails with the following error: /usr/bin/install: cannot create regular file '/lib/systemd/system/nftables.service': Permission denied Let's specify the unit directory like we do for other projects. Change-Id: I9ab473dd6f734606518a980152fd4b00c2e23690 Related: nftables.git c4b17cf8305108f91d8e63880317a59e8e806c80 --- M contrib/jenkins.sh 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 807774a..b81d1a6 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -37,6 +37,7 @@ build_from_netfilter() { ### TODO: enable osmo-build-dep.sh to build from git.netfilter.org URL? project="$1" + cfg="$2" set +x echo echo @@ -54,12 +55,13 @@ --prefix="$inst/stow/$project" \ --without-cli \ --disable-man-doc \ - --enable-python=no + --enable-python=no \ + $cfg $MAKE $PARALLEL_MAKE install STOW_DIR="$inst/stow" stow --restow $project } build_from_netfilter libnftnl -build_from_netfilter nftables +build_from_netfilter nftables "--with-unitdir=$inst/stow/$project/lib/systemd/system" # Additional configure options and depends CONFIG="" -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/40896?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I9ab473dd6f734606518a980152fd4b00c2e23690 Gerrit-Change-Number: 40896 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 month

1
0
0 0

[XS] Change in osmo-upf[master]: contrib/jenkins.sh: use https:// instead of git://

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-upf/+/40897?usp=email ) Change subject: contrib/jenkins.sh: use https:// instead of git:// ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/40897?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I5f184fd100230e1b9c0076739f49901ab2782b4f Gerrit-Change-Number: 40897 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Aug 2025 11:18:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025