lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

August 2025

  • 1 participants
  • 1086 discussions
[XS] Change in osmo-ci[master]: jobs/gerrit-verifications: osmo-ttcn3-hacks: do make clean
by lynxis lazus 22 Aug '25

22 Aug '25
Attention is currently required from: fixeria, osmith. lynxis lazus has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/40908?usp=email ) Change subject: jobs/gerrit-verifications: osmo-ttcn3-hacks: do make clean ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: @vyanitskiy@sysmocom.de thanks for fixing it. But could we do always a clean jenkins workspace and move the /build directory into the workspace? We could cache all external repositories (e.g. ttcn3) to prevent downloading them again and again in a separate .git directory. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40908?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I886a99e7b1e8c42ccc7441685ecd7b2c54d5a7af Gerrit-Change-Number: 40908 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Aug 2025 20:49:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[XS] Change in osmo-ci[master]: jobs/gerrit-verifications: osmo-ttcn3-hacks: do make clean
by fixeria 22 Aug '25

22 Aug '25
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40908?usp=email ) Change subject: jobs/gerrit-verifications: osmo-ttcn3-hacks: do make clean ...................................................................... jobs/gerrit-verifications: osmo-ttcn3-hacks: do make clean It's easy to break the build verification [for everybody] by submitting a patch that creates a symlink to a non-existent file. The workspace is not wiped, so the stale symlink remains and results in failures like this: (cd sgsn && ./gen_links.sh && ./regen_makefile.sh) ttcn3_makefilegen: error: Cannot find any source file for argument `NAS_Templates.ttcn'. make: *** [Makefile:131: _build/sgsn/Makefile] Error 1 Let's invoke the 'clean' recipe before 'compile' to avoid this. Change-Id: I886a99e7b1e8c42ccc7441685ecd7b2c54d5a7af --- M jobs/gerrit-verifications.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/08/40908/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 48ba632..f91cbb8 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -524,7 +524,7 @@ ln -s "$i" /build/deps/ fi done - su build -c "make -C /build compile" + su build -c "make -C /build clean compile" ' pipeline_binpkgs: "" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40908?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I886a99e7b1e8c42ccc7441685ecd7b2c54d5a7af Gerrit-Change-Number: 40908 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[XS] Change in ...osmo-s1gw[master]: enb_uptime: remove debugging leftover
by fixeria 22 Aug '25

22 Aug '25
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40900?usp=email ) Change subject: enb_uptime: remove debugging leftover ...................................................................... enb_uptime: remove debugging leftover Change-Id: I7fc9c4a1ec4952c9ec58f6c82bf5ae1bb743ef7b Fixes: a4cec554 ("enb_uptime: track eNB uptime") --- M src/enb_uptime.erl 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/00/40900/1 diff --git a/src/enb_uptime.erl b/src/enb_uptime.erl index 6283fd0..ac71ebd 100644 --- a/src/enb_uptime.erl +++ b/src/enb_uptime.erl @@ -82,7 +82,6 @@ T1 = erlang:monotonic_time(), Diff = erlang:convert_time_unit(T1 - T0, native, second), s1gw_metrics:ctr_inc(?S1GW_CTR_ENB_UPTIME(GlobalENBId), Diff), - ?LOG_INFO("Td ~p second(s)", [Diff]), loop(S#{time => T1}) end; -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7fc9c4a1ec4952c9ec58f6c82bf5ae1bb743ef7b Gerrit-Change-Number: 40900 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[XS] Change in ...osmo-s1gw[master]: sctp_server: remove unused include of s1ap.hrl
by fixeria 22 Aug '25

22 Aug '25
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40901?usp=email ) Change subject: sctp_server: remove unused include of s1ap.hrl ...................................................................... sctp_server: remove unused include of s1ap.hrl Change-Id: I3faf5714e7abc3ab261bd4ae841f214c3c9f117c --- M src/sctp_server.erl 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/01/40901/1 diff --git a/src/sctp_server.erl b/src/sctp_server.erl index 1eeb075..5530677 100644 --- a/src/sctp_server.erl +++ b/src/sctp_server.erl @@ -50,7 +50,6 @@ -include_lib("kernel/include/inet_sctp.hrl"). -include("s1gw_metrics.hrl"). --include("s1ap.hrl"). -type addr_port() :: {inet:ip_address(), inet:port_number()}. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I3faf5714e7abc3ab261bd4ae841f214c3c9f117c Gerrit-Change-Number: 40901 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[XS] Change in ...osmo-s1gw[master]: enb_uptime: handle 'stop' when Global-eNB-ID is unknown
by fixeria 22 Aug '25

22 Aug '25
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40899?usp=email ) Change subject: enb_uptime: handle 'stop' when Global-eNB-ID is unknown ...................................................................... enb_uptime: handle 'stop' when Global-eNB-ID is unknown Change-Id: I706d78ee6cc39ff836ad8cd6b998041db5e09d19 Fixes: a4cec554 ("enb_uptime: track eNB uptime") --- M src/enb_uptime.erl 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/99/40899/1 diff --git a/src/enb_uptime.erl b/src/enb_uptime.erl index 4c6f76a..6283fd0 100644 --- a/src/enb_uptime.erl +++ b/src/enb_uptime.erl @@ -91,6 +91,8 @@ {genb_id_ind, GlobalENBId} -> catch exometer:new(?S1GW_CTR_ENB_UPTIME(GlobalENBId), counter), loop(S#{genb_id => GlobalENBId}); + stop -> + ok; Event -> ?LOG_ERROR("Rx unexpected event: ~p", [Event]) end. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I706d78ee6cc39ff836ad8cd6b998041db5e09d19 Gerrit-Change-Number: 40899 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[S] Change in ...osmo-s1gw[master]: pfcp_peer: add fetch_info/0
by fixeria 22 Aug '25

22 Aug '25
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40902?usp=email ) Change subject: pfcp_peer: add fetch_info/0 ...................................................................... pfcp_peer: add fetch_info/0 Change-Id: I3fdcf7f6daac09a8c523826995a610c04f5a327b --- M src/pfcp_peer.erl 1 file changed, 26 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/02/40902/1 diff --git a/src/pfcp_peer.erl b/src/pfcp_peer.erl index a7e9515..ff3cfce 100644 --- a/src/pfcp_peer.erl +++ b/src/pfcp_peer.erl @@ -48,6 +48,7 @@ session_establish_req/3, session_modify_req/3, session_delete_req/1, + fetch_info/0, shutdown/0]). -include_lib("kernel/include/logger.hrl"). @@ -69,7 +70,14 @@ -type pfcp_msg() :: {pfcp_msg_type(), pfcp_ies()}. -type pfcp_pdu() :: #pfcp{}. --export_type([pfcp_session_rsp/0, +-type peer_info() :: #{state := atom(), + laddr := inet:ip_address(), + raddr := inet:ip_address(), + lrts := pos_integer(), + rrts => pos_integer()}. + +-export_type([peer_info/0, + pfcp_session_rsp/0, pfcp_msg_type/0, pfcp_seq_nr/0, pfcp_seid/0, @@ -139,6 +147,11 @@ gen_statem:call(?MODULE, {?FUNCTION_NAME, SEID}). +-spec fetch_info() -> peer_info(). +fetch_info() -> + gen_statem:call(?MODULE, ?FUNCTION_NAME). + + shutdown() -> gen_statem:stop(?MODULE). @@ -339,6 +352,18 @@ S1 = registry_del({Pid, Ref}, S0), {keep_state, S1}; +handle_event(State, + {call, From}, fetch_info, + #peer_state{} = S) -> + Info = #{state => State, + laddr => S#peer_state.loc_addr, + raddr => S#peer_state.rem_addr, + lrts => S#peer_state.loc_rts, + rrts => S#peer_state.rem_rts}, + %% omit props with Value =:= undefined + Reply = maps:filter(fun(_K, V) -> V =/= undefined end, Info), + {keep_state_and_data, {reply, From, Reply}}; + handle_event(State, Event, EventData, S) -> ?LOG_ERROR("Unexpected event ~p in state ~p: ~p", [Event, State, EventData]), {keep_state, S}. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40902?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I3fdcf7f6daac09a8c523826995a610c04f5a327b Gerrit-Change-Number: 40902 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[S] Change in ...osmo-s1gw[master]: sctp_proxy: fix non-existent fields in fetch_info/0
by fixeria 22 Aug '25

22 Aug '25
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40903?usp=email ) Change subject: sctp_proxy: fix non-existent fields in fetch_info/0 ...................................................................... sctp_proxy: fix non-existent fields in fetch_info/0 The mme_addr and mme_port have been moved into the conn_cfg sub-map. Change-Id: I386a0268d5e465cbd5ad7ee02ed768425e6ec17f Fixes: 1221b6d ("sctp_{client,server}: accept arguments in form of a map") --- M src/sctp_proxy.erl 1 file changed, 7 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/03/40903/1 diff --git a/src/sctp_proxy.erl b/src/sctp_proxy.erl index e8460a4..badadcd 100644 --- a/src/sctp_proxy.erl +++ b/src/sctp_proxy.erl @@ -205,10 +205,13 @@ %% Event handler for all states handle_event(State, {call, From}, fetch_info, - #{handler := Pid} = S0) -> - ERABs = s1ap_proxy:fetch_erab_list(Pid), - S1 = maps:with([enb_aid, mme_aid, mme_addr, mme_port], S0), - S2 = S1#{state => State, erab_list => ERABs}, + #{handler := Pid, conn_cfg := ConnCfg} = S0) -> + ERABs = s1ap_proxy:fetch_erab_list(Pid), %% TODO: separate API + S1 = maps:with([enb_aid, mme_aid], S0), + S2 = S1#{state => State, + erab_list => ERABs, + mme_addr => maps:get(raddr, ConnCfg), + mme_port => maps:get(rport, ConnCfg)}, Reply = proplists:from_map(S2), {keep_state_and_data, {reply, From, Reply}}; -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40903?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I386a0268d5e465cbd5ad7ee02ed768425e6ec17f Gerrit-Change-Number: 40903 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[XS] Change in ...osmo-s1gw[master]: sctp_proxy: return handler Pid in fetch_info/0
by fixeria 22 Aug '25

22 Aug '25
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40904?usp=email ) Change subject: sctp_proxy: return handler Pid in fetch_info/0 ...................................................................... sctp_proxy: return handler Pid in fetch_info/0 Change-Id: I3911bfc107fea3ca572cf44f1d93b768b3c82b4f --- M src/sctp_proxy.erl 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/04/40904/1 diff --git a/src/sctp_proxy.erl b/src/sctp_proxy.erl index badadcd..b9258c3 100644 --- a/src/sctp_proxy.erl +++ b/src/sctp_proxy.erl @@ -206,10 +206,9 @@ %% Event handler for all states handle_event(State, {call, From}, fetch_info, #{handler := Pid, conn_cfg := ConnCfg} = S0) -> - ERABs = s1ap_proxy:fetch_erab_list(Pid), %% TODO: separate API S1 = maps:with([enb_aid, mme_aid], S0), S2 = S1#{state => State, - erab_list => ERABs, + handler => Pid, mme_addr => maps:get(raddr, ConnCfg), mme_port => maps:get(rport, ConnCfg)}, Reply = proplists:from_map(S2), -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I3911bfc107fea3ca572cf44f1d93b768b3c82b4f Gerrit-Change-Number: 40904 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[S] Change in ...osmo-s1gw[master]: sctp_proxy: make fetch_info/1 return a map
by fixeria 22 Aug '25

22 Aug '25
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40905?usp=email ) Change subject: sctp_proxy: make fetch_info/1 return a map ...................................................................... sctp_proxy: make fetch_info/1 return a map Change-Id: I24029faa7e44efe34599b46fae731c801ff6191d --- M src/sctp_proxy.erl 1 file changed, 18 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/05/40905/1 diff --git a/src/sctp_proxy.erl b/src/sctp_proxy.erl index b9258c3..830fe91 100644 --- a/src/sctp_proxy.erl +++ b/src/sctp_proxy.erl @@ -53,6 +53,18 @@ -include("s1gw_metrics.hrl"). + +-type conn_info() :: #{state := atom(), + handler := pid(), + mme_addr := inet:ip_address(), + mme_port := inet:port_number(), + enb_aid := gen_sctp:assoc_id(), + mme_aid => gen_sctp:assoc_id() + }. + +-export_type([conn_info/0]). + + %% ------------------------------------------------------------------ %% public API %% ------------------------------------------------------------------ @@ -70,7 +82,7 @@ gen_statem:cast(Pid, {send_data, Data}). --spec fetch_info(pid()) -> proplists:proplist(). +-spec fetch_info(pid()) -> conn_info(). fetch_info(Pid) -> gen_statem:call(Pid, ?FUNCTION_NAME). @@ -207,12 +219,11 @@ handle_event(State, {call, From}, fetch_info, #{handler := Pid, conn_cfg := ConnCfg} = S0) -> S1 = maps:with([enb_aid, mme_aid], S0), - S2 = S1#{state => State, - handler => Pid, - mme_addr => maps:get(raddr, ConnCfg), - mme_port => maps:get(rport, ConnCfg)}, - Reply = proplists:from_map(S2), - {keep_state_and_data, {reply, From, Reply}}; + Info = S1#{state => State, + handler => Pid, + mme_addr => maps:get(raddr, ConnCfg), + mme_port => maps:get(rport, ConnCfg)}, + {keep_state_and_data, {reply, From, Info}}; handle_event(State, {call, From}, EventData, _S) -> ?LOG_ERROR("Unexpected call in state ~p: ~p", [State, EventData]), -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40905?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I24029faa7e44efe34599b46fae731c801ff6191d Gerrit-Change-Number: 40905 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[S] Change in ...osmo-s1gw[master]: erab_fsm: make fetch_info/1 return a map
by fixeria 22 Aug '25

22 Aug '25
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40906?usp=email ) Change subject: erab_fsm: make fetch_info/1 return a map ...................................................................... erab_fsm: make fetch_info/1 return a map Change-Id: I83999fa9346d19260cb44e0bb6a36b7ee1c12ce1 --- M src/erab_fsm.erl M src/s1ap_proxy.erl M test/erab_fsm_test.erl 3 files changed, 26 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/06/40906/1 diff --git a/src/erab_fsm.erl b/src/erab_fsm.erl index cd4fa27..f5d8efe 100644 --- a/src/erab_fsm.erl +++ b/src/erab_fsm.erl @@ -103,6 +103,17 @@ -type iface() :: 'Core' | 'Access'. -type pfcp_ie() :: map(). +-type erab_info() :: #{uid := term(), + state := atom(), + f_teid_u2c => teid_addr(), + f_teid_c2u => teid_addr(), + f_teid_a2u => teid_addr(), + f_teid_u2a => teid_addr(), + seid_loc := pfcp_peer:pfcp_seid(), + seid_rem => pfcp_peer:pfcp_seid()}. + +-export_type([erab_info/0]). + %% ------------------------------------------------------------------ %% public API @@ -205,7 +216,7 @@ gen_statem:cast(Pid, ?FUNCTION_NAME). --spec fetch_info(pid()) -> proplists:proplist(). +-spec fetch_info(pid()) -> erab_info(). fetch_info(Pid) -> gen_statem:call(Pid, ?FUNCTION_NAME). @@ -542,16 +553,16 @@ %% Event handler for all states handle_event(State, {call, From}, fetch_info, #erab_state{} = S) -> - Info = [{state, State}, - {uid, S#erab_state.uid}, - {f_teid_u2c, S#erab_state.u2c}, - {f_teid_c2u, S#erab_state.c2u}, - {f_teid_a2u, S#erab_state.a2u}, - {f_teid_u2a, S#erab_state.u2a}, - {seid_loc, S#erab_state.seid_loc}, - {seid_rem, S#erab_state.seid_rem}], - %% omit props with Value =:= undefined - Reply = lists:filter(fun({_, V}) -> V =/= undefined end, Info), + Info = #{state => State, + uid => S#erab_state.uid, + f_teid_u2c => S#erab_state.u2c, + f_teid_c2u => S#erab_state.c2u, + f_teid_a2u => S#erab_state.a2u, + f_teid_u2a => S#erab_state.u2a, + seid_loc => S#erab_state.seid_loc, + seid_rem => S#erab_state.seid_rem}, + %% omit fields with Value =:= undefined + Reply = maps:filter(fun(_K, V) -> V =/= undefined end, Info), {keep_state_and_data, {reply, From, Reply}}; handle_event(State, {call, From}, EventData, _S) -> diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index 8111ad6..c36fad6 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -907,12 +907,12 @@ {ok, Pid} -> %% Ignore F-TEID in the original message, just replace it with C2U F-TEID Info = erab_fsm:fetch_info(Pid), - case proplists:get_value(f_teid_c2u, Info) of - {TEID, TLA} -> + case maps:find(f_teid_c2u, Info) of + {ok, {TEID, TLA}} -> C1 = C0#'E-RABNotToBeModifiedItemBearerModInd'{'transportLayerAddress' = TLA, 'dL-GTP-TEID' = << TEID:32/big >>}, {{ok, C1}, S}; - undefined -> + error -> ?LOG_ERROR("E-RAB-ID ~p :: missing C2U F-TEID", [erab_uid(ERABId, S)]), {{error, missing_f_teid}, S} end; diff --git a/test/erab_fsm_test.erl b/test/erab_fsm_test.erl index a3dfb4d..e49d5cc 100644 --- a/test/erab_fsm_test.erl +++ b/test/erab_fsm_test.erl @@ -35,7 +35,7 @@ erab_fsm_info(Pid, Key) -> Info = erab_fsm:fetch_info(Pid), - proplists:get_value(Key, Info). + maps:get(Key, Info). %% ------------------------------------------------------------------ -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40906?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I83999fa9346d19260cb44e0bb6a36b7ee1c12ce1 Gerrit-Change-Number: 40906 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 43
  • 44
  • 45
  • 46
  • 47
  • 48
  • 49
  • ...
  • 109
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.