August 2025 - gerrit-log - lists.osmocom.org

[XS] Change in ...osmo-s1gw[master]: sctp_server: remove unused include of s1ap.hrl

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40901?usp=email ) Change subject: sctp_server: remove unused include of s1ap.hrl ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I3faf5714e7abc3ab261bd4ae841f214c3c9f117c Gerrit-Change-Number: 40901 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 24 Aug 2025 17:08:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: enb_uptime: remove debugging leftover

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40900?usp=email ) Change subject: enb_uptime: remove debugging leftover ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7fc9c4a1ec4952c9ec58f6c82bf5ae1bb743ef7b Gerrit-Change-Number: 40900 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 24 Aug 2025 17:08:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: enb_uptime: handle 'stop' when Global-eNB-ID is unknown

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40899?usp=email ) Change subject: enb_uptime: handle 'stop' when Global-eNB-ID is unknown ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I706d78ee6cc39ff836ad8cd6b998041db5e09d19 Gerrit-Change-Number: 40899 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 24 Aug 2025 17:08:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month

1
0
0 0

[XL] Change in libosmo-netif[master]: bring twrtp into libosmo-netif

by falconia

Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email ) Change subject: bring twrtp into libosmo-netif ...................................................................... Patch Set 6: (1 comment) File src/twrtp_base.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/afc999bc_c843908… : PS1, Line 132: * another variant of this API with that alternative behavior. > ack, I think we are aligned with what I mean now :) Patchset 6 includes an implementation of this requested feature, making RTCP UDP socket optional. Please provide feedback. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib63215aaf13ef8ab8f2e0c8d310164cd5c8824eb Gerrit-Change-Number: 39281 Gerrit-PatchSet: 6 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Aug 2025 21:32:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 month

1
0
0 0

[XL] Change in libosmo-netif[master]: bring twjit into libosmo-netif

by falconia

Attention is currently required from: fixeria, jolly, laforge, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email ) Change subject: bring twjit into libosmo-netif ...................................................................... Patch Set 6: (4 comments) File include/osmocom/netif/twjit.h: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/80548049_cc6eaf0… : PS2, Line 35: /*! buffer depth: starting minimum */ > It probably makes sense to submit this or parts of this document in text format under doc/, so it ca […] My current plan is to add a third patch to this series (after twjit and twrtp) that will add an Osmocom-controlled version of twrtp guide document to `libosmo-netif/doc`. https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/ea3ee5c1_c0b89b7… : PS2, Line 137: bool osmo_twjit_got_any_input(struct osmo_twjit *twjit); > I'll go with the shorter `osmo_twjit_rr_info_valid()` then. Done File src/twjit.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/7f96843f_9c5cccd… : PS2, Line 504: rtph = osmo_rtp_get_hdr(msg); > "M bit take precedence". […] The M bit feature was implemented in Patchset 6 as you asked. Please provide feedback. File src/twjit.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/542e30f7_ebf7637… : PS3, Line 331: static void analytics_cont(struct osmo_twjit *twjit, uint16_t rx_seq, > I'm currently on it reading your pdf. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 Gerrit-Change-Number: 39280 Gerrit-PatchSet: 6 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Aug 2025 21:29:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 month

1
0
0 0

[XL] Change in libosmo-netif[master]: bring twrtp into libosmo-netif

by falconia

Attention is currently required from: falconia. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: bring twrtp into libosmo-netif ...................................................................... bring twrtp into libosmo-netif twrtp is the top layer of Themyscira Wireless RTP endpoint implementation, an alternative to Belledonne libortp. Unlike Belledonne software, ThemWi RTP library was developed specifically for use in Osmocom-based GSM, ISDN and IP-PSTN network elements, and is built on top of libosmocore primitives - thus it can function more natively in Osmocom universe than ortp. This ThemWi library was initially developed externally to Osmocom, but is now being brought into libosmo-netif so it can be used by native Osmocom projects, particularly OsmoBTS. Related: OS#6474 Change-Id: Ib63215aaf13ef8ab8f2e0c8d310164cd5c8824eb --- M include/osmocom/netif/Makefile.am A include/osmocom/netif/rtcp_defs.h A include/osmocom/netif/twrtp.h M src/Makefile.am A src/twrtp.c 5 files changed, 1,531 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/81/39281/6 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib63215aaf13ef8ab8f2e0c8d310164cd5c8824eb Gerrit-Change-Number: 39281 Gerrit-PatchSet: 6 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org>

1 month

1
0
0 0

[XL] Change in libosmo-netif[master]: bring twjit into libosmo-netif

by falconia

Attention is currently required from: falconia, fixeria, jolly, laforge. Hello Jenkins Builder, fixeria, jolly, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: bring twjit into libosmo-netif ...................................................................... bring twjit into libosmo-netif twjit is the jitter buffer portion of Themyscira Wireless RTP endpoint implementation, an alternative to Belledonne libortp. Unlike Belledonne software, ThemWi RTP library was developed specifically for use in Osmocom-based GSM, ISDN and IP-PSTN network elements, and is built on top of libosmocore primitives - thus it can function more natively in Osmocom universe than ortp. This ThemWi library was initially developed externally to Osmocom, but is now being brought into libosmo-netif so it can be used by native Osmocom projects, particularly OsmoBTS. Related: OS#6474 Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 --- M configure.ac M contrib/libosmo-netif.spec.in M include/osmocom/netif/Makefile.am A include/osmocom/netif/twjit.h M src/Makefile.am A src/twjit.c A src/twjit_vty.c 7 files changed, 1,134 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/80/39280/6 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 Gerrit-Change-Number: 39280 Gerrit-PatchSet: 6 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 month

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/gerrit-verifications: osmo-ttcn3-hacks: do make clean

by fixeria

Attention is currently required from: lynxis lazus, osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/40908?usp=email ) Change subject: jobs/gerrit-verifications: osmo-ttcn3-hacks: do make clean ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > But could we do always a clean jenkins workspace and move the /build directory into the workspace? I might be wrong, but I believe `/build` points exactly to the workspace. We just never wipe it (`wipe-workspace: false` by default). In projects where we have `contrib/jenkins.sh`, we usually call `osmo-clean-workspace.sh`, but here we don't for some reason. @osmith@sysmocom.de Maybe we should call this script instead? > We could cache all external repositories (e.g. ttcn3) to prevent downloading them again and again in a separate .git directory. The deps are part of the `registry.osmocom.org/osmocom-build/debian-bookworm-titan` image and we simply create symlinks to them, so caching is not needed. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40908?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I886a99e7b1e8c42ccc7441685ecd7b2c54d5a7af Gerrit-Change-Number: 40908 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 22 Aug 2025 21:11:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 month

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: Makefile: DIR_clean_template: clean depends on Makefile

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40909?usp=email ) Change subject: Makefile: DIR_clean_template: clean depends on Makefile ...................................................................... Makefile: DIR_clean_template: clean depends on Makefile Change-Id: I4934f345f4a1d54fa939143d46033c1ef6751aba --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/09/40909/1 diff --git a/Makefile b/Makefile index 75e79ff..2724dec 100644 --- a/Makefile +++ b/Makefile @@ -116,7 +116,7 @@ define DIR_clean_template .PHONY: $(1)/clean -$(1)/clean: +$(1)/clean: $(BUILDDIR)/$(1)/Makefile $(MAKE) -C $(BUILDDIR)/$(1) clean endef -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40909?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4934f345f4a1d54fa939143d46033c1ef6751aba Gerrit-Change-Number: 40909 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 month

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/gerrit-verifications: osmo-ttcn3-hacks: do make clean

by lynxis lazus

Attention is currently required from: fixeria, osmith. lynxis lazus has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/40908?usp=email ) Change subject: jobs/gerrit-verifications: osmo-ttcn3-hacks: do make clean ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40908?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I886a99e7b1e8c42ccc7441685ecd7b2c54d5a7af Gerrit-Change-Number: 40908 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Aug 2025 20:50:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025