August 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-msc[master]: vlr: add PS support

by neels

Attention is currently required from: lynxis lazus, pespin. neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email ) Change subject: vlr: add PS support ...................................................................... Patch Set 11: Code-Review+1 (2 comments) File src/libvlr/vlr_lu_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/e1e4ace2_3f96afae?usp… : PS5, Line 771: /*! count times timer T timed out */ > i will veto block this patch unless you make this: […] Done https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/ad13d0c6_28e46fc5?usp… : PS5, Line 1611: fi->T > (Nearly) All of the timers used in the VLR are different between CS and PS. […] yes but my point is: any program using a VLR is only CS or PS, never both CS *and* PS. So I would expect that a PS program simply uses the PS timers, and does not need to also pass the CS timers as argument all the time, because, the entire program does never need CS timer values. Right? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0 Gerrit-Change-Number: 38490 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 21 Aug 2025 21:51:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 month

1
0
0 0

[XS] Change in osmo-msc[master]: vlr: remove old TODO to switch to osmo_tdef_fsm_inst_state_chg

by neels

Attention is currently required from: lynxis lazus. neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/40422?usp=email ) Change subject: vlr: remove old TODO to switch to osmo_tdef_fsm_inst_state_chg ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40422?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I1eecfeec494a2e129c41a6e964c56ed4430611de Gerrit-Change-Number: 40422 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 21 Aug 2025 21:46:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month

1
0
0 0

[L] Change in osmo-msc[master]: vlr_lu_fsm: terminate the FSM instead of dispatching only a signal to...

by neels

Attention is currently required from: lynxis lazus. neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38491?usp=email ) Change subject: vlr_lu_fsm: terminate the FSM instead of dispatching only a signal to the parent ...................................................................... Patch Set 11: Code-Review+1 (1 comment) File tests/msc_vlr/msc_vlr_test_authen_reuse.err: https://gerrit.osmocom.org/c/osmo-msc/+/38491/comment/fed842f8_7e5c0267?usp… : PS11, Line 184: DVLR vlr_lu_fsm(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:GERAN-A:LU){VLR_ULA_S_DONE}: Deferring: will deallocate with msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:GERAN-A:LU) I see here that we deallocate the msc_a much much earlier. I am not sure about the details anymore, but there was a lot of trouble with instances deallocating, but dependent objects still accessing them for cleanup -- or dependent objects being talloc children and already disappearing before they can cleanup. Such tedious crap... This "Deferring" is a sign that there was such trouble and the fix was to deallocate the msc_a later. Now, there has been a general fix in osmocom for such problems, which is that we don't deallocate, but move to OTC_SELECT. It is quite possible that this patch finally gets rid of the old deferring that was necessary before we had OTC_SELECT? I am writing this comment because, I expect that it's fine, but can you somehow check if it really is fine, please? If we use OTC_SELECT where it says "Deallocated" above on line 166 then we are fine... -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I27fd1048f85363797b43808d2061ce28be6da81b Gerrit-Change-Number: 38491 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 21 Aug 2025 21:46:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 month

1
0
0 0

[M] Change in osmo-msc[master]: vlr: when receiving imsi detach, purge the subscriber towards HLR

by neels

Attention is currently required from: lynxis lazus. neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38489?usp=email ) Change subject: vlr: when receiving imsi detach, purge the subscriber towards HLR ...................................................................... Patch Set 9: Code-Review+2 (2 comments) File tests/msc_vlr/msc_vlr_test_ms_timeout.err: https://gerrit.osmocom.org/c/osmo-msc/+/38489/comment/57b1089e_fc773422?usp… : PS9, Line 668: GSUP --> HLR: OSMO_GSUP_MSGT_PURGE_MS_REQUEST: 0c010809710000004026f02801020a0101 ^ This change looks different. All the others directly follow an IMSI_DETACH. Here, there is an IMSI DETACH, but it's way up there at line 644... edit: it's fine. In this test, there is just also a pending Paging and a pending SMS being canceled in-between the IMSI DETACH rx and notifying the HLR. File tests/msc_vlr/msc_vlr_test_no_authen.err: https://gerrit.osmocom.org/c/osmo-msc/+/38489/comment/f62c6fe2_70381d0b?usp… : PS9, Line 3020: GSUP --> HLR: OSMO_GSUP_MSGT_PURGE_MS_REQUEST: 0c010809710000004026f02801020a0101 This also looks different from the others; because it shows the case when a subscriber fails to do a periodic LU in time. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9c2569c45e69b422ce26050b682e6eb26c1c2625 Gerrit-Change-Number: 38489 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 21 Aug 2025 21:34:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 month

1
0
0 0

[S] Change in osmo-msc[master]: vlr: extend the subscriber invalidate callback with reasons

by neels

Attention is currently required from: lynxis lazus. neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email ) Change subject: vlr: extend the subscriber invalidate callback with reasons ...................................................................... Patch Set 9: Code-Review+2 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/07db23bf_fb005693?usp… : PS5, Line 13: b) if the HLR do a Cancel Location Procedure with reason withdraw > I think your idea is correct, that we simply drop the subscriber from the VLR cache. […] Done Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/cfabf467_827cef6a?usp… : PS8, Line 15: d) duplicate entries (unsure if this is valid, but keeping the code as is) > duplicate entries are very important to prevent. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie5b687318b106a230fcee52deba86649641004b3 Gerrit-Change-Number: 38488 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 21 Aug 2025 21:21:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 month

1
0
0 0

[S] Change in osmo-msc[master]: vlr: extend the subscriber invalidate callback with reasons

by lynxis lazus

Attention is currently required from: neels. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email ) Change subject: vlr: extend the subscriber invalidate callback with reasons ...................................................................... Patch Set 9: (2 comments) Patchset: PS9: b File include/osmocom/vlr/vlr.h: https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/aab3d4d2_ba8e0c32?usp… : PS8, Line 207: enum vlr_inval_reason { > these aren't from a spec, right? If they are, a comment to link to it would be great no they don't come from the spec. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie5b687318b106a230fcee52deba86649641004b3 Gerrit-Change-Number: 38488 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Aug 2025 21:15:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>

1 month

1
0
0 0

[M] Change in osmo-sgsn[master]: Re-introduce Iu/UTRAN support

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email ) Change subject: Re-introduce Iu/UTRAN support ...................................................................... Patch Set 7: (1 comment) File tests/gprs_routing_area/gprs_routing_area_test.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/227ea2d5_2b4ea6b7?us… : PS6, Line 542: * The SGSN explicit not support the same LAC/RA for GERAN and UTRAN at the same time. > "The SGSN explicit not support" this is wrong language-wise. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889 Gerrit-Change-Number: 40813 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Aug 2025 21:09:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 month

1
0
0 0

[M] Change in osmo-sgsn[master]: Re-introduce Iu/UTRAN support

by lynxis lazus

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Re-introduce Iu/UTRAN support ...................................................................... Re-introduce Iu/UTRAN support Add support for UTRAN routing areas. Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889 --- M include/osmocom/sgsn/gprs_routing_area.h M src/sgsn/gprs_ranap.c M src/sgsn/gprs_routing_area.c M tests/gprs_routing_area/gprs_routing_area_test.c 4 files changed, 206 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/13/40813/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889 Gerrit-Change-Number: 40813 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 month

1
0
0 0

[M] Change in osmo-sgsn[master]: Re-introduce Iu/UTRAN support

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email ) Change subject: Re-introduce Iu/UTRAN support ...................................................................... Patch Set 6: (1 comment) File src/sgsn/gprs_routing_area.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/0d41f9d1_e78e035d?us… : PS6, Line 487: else if (mmctx->p_tmsi_old != GSM_RESERVED_TMSI) > I think it is better this way, […] what ever if you like it better without else, I'll update it. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889 Gerrit-Change-Number: 40813 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Aug 2025 21:07:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 month

1
0
0 0

[M] Change in osmo-sgsn[master]: Re-introduce Iu/UTRAN support

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email ) Change subject: Re-introduce Iu/UTRAN support ...................................................................... Patch Set 6: (1 comment) File src/sgsn/gprs_routing_area.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/8068ecb9_ad548eb8?us… : PS6, Line 487: else if (mmctx->p_tmsi_old != GSM_RESERVED_TMSI) > this else can be removed, you forgot. I think it is better this way, because it explicit connects both statements and keep then in an order. IMHO it improve the code readiness. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889 Gerrit-Change-Number: 40813 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Aug 2025 21:06:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025