Attention is currently required from: lynxis lazus, pespin.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS Purge
......................................................................
MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS Purge
Currently the MSC/VLR doesn't inform the HLR when a MS detaches.
Change-Id: I9e87537efc2c921fa860539a706316ed410b45d5
---
M msc/MSC_Tests.ttcn
M msc/expected-results.xml
2 files changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/39236/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9e87537efc2c921fa860539a706316ed410b45d5
Gerrit-Change-Number: 39236
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: lynxis lazus, pespin.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS Purge
......................................................................
MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS Purge
Currently the MSC/VLR doesn't inform the HLR when a MS detaches.
Change-Id: I9e87537efc2c921fa860539a706316ed410b45d5
---
M msc/MSC_Tests.ttcn
M msc/expected-results.xml
2 files changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/39236/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9e87537efc2c921fa860539a706316ed410b45d5
Gerrit-Change-Number: 39236
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: daniel, laforge, pespin.
Hello Jenkins Builder, daniel, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email
to look at the new patch set (#10).
Change subject: Deprecate iu_client
......................................................................
Deprecate iu_client
The only remaining use of iu_client is osmo-sgsn.
iu_client was originally meant to be used by osmo-msc
and osmo-sgsn. But the abstraction didn't hold up and
osmo-msc stopped using iu_client for a long time.
To start development, osmo-sgsn will start with a copy of
iu_client until it can be completely dropped from the osmo-sgsn codebase.
Future osmo-sgsn versions won't use the osmo-iuh' iu_client.
Related: OS#5487
Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de
---
M TODO-RELEASE
M include/osmocom/ranap/iu_client.h
2 files changed, 26 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/47/40847/10
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de
Gerrit-Change-Number: 40847
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: daniel, laforge, lynxis lazus, pespin.
Hello Jenkins Builder, daniel, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email
to look at the new patch set (#9).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Deprecate iu_client
......................................................................
Deprecate iu_client
The only remaining use of iu_client is osmo-sgsn.
iu_client was originally meant to be used by osmo-msc
and osmo-sgsn. But the abstraction didn't hold up and
osmo-msc stopped using iu_client for a long time.
To start development, osmo-sgsn will start with a copy of
iu_client until it can be completely dropped from the osmo-sgsn codebase.
Future osmo-sgsn versions won't use the osmo-iuh' iu_client.
Related: OS#5487
Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de
---
M TODO-RELEASE
M include/osmocom/ranap/iu_client.h
2 files changed, 26 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/47/40847/9
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de
Gerrit-Change-Number: 40847
Gerrit-PatchSet: 9
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: fixeria, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40667?usp=email )
Change subject: GSUP_Templates: ts_GSUP_UL_REQ: add template scopes
......................................................................
Patch Set 3:
(1 comment)
File library/GSUP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40667/comment/5fa62bde_5566… :
PS2, Line 413: omit
> This makes no sense. It should be `(value)` because this template always yields a value.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40667?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I250960a1e1c19dfa1efa81f6bbc93efa07cb225c
Gerrit-Change-Number: 40667
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Aug 2025 20:38:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666?usp=email )
Change subject: GSUP Templates: fix empty destination_name in GSUP ISD/UL
......................................................................
Patch Set 3:
(4 comments)
File library/GSUP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/4028ef49_99cb… :
PS2, Line 421: omit
> This change makes no sense to me, since `ts_GSUP_UL_RES` cannot yield `omit`. It's always a value.
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/4d996413_94dd… :
PS2, Line 437: omit
> This change makes no sense to me, since `ts_GSUP_UL_RES` cannot yield `omit`. It's always a value.
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/88f2c3a1_02dc… :
PS2, Line 447: omit
> likewise, it should be `(value)`
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/0678b5db_9c9b… :
PS2, Line 448: template (omit) octetstring source_name := omit,
:
> please fix alignment here
hopefully this is correct.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia89b5a82665e407fa578e5209fbcde0676326df0
Gerrit-Change-Number: 40666
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Aug 2025 20:37:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40668?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: GSUP_Templates: fix whitespace issues
......................................................................
GSUP_Templates: fix whitespace issues
Change-Id: I03be75063a71153bd2881afd1d741454c508fada
---
M library/GSUP_Templates.ttcn
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/68/40668/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40668?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I03be75063a71153bd2881afd1d741454c508fada
Gerrit-Change-Number: 40668
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: fixeria, lynxis lazus, pespin.
Hello Jenkins Builder, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40667?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by pespin, Code-Review-1 by fixeria, Verified+1 by Jenkins Builder
Change subject: GSUP_Templates: ts_GSUP_UL_REQ: add template scopes
......................................................................
GSUP_Templates: ts_GSUP_UL_REQ: add template scopes
Allow to omit the source_name TLV in GSUP UL Request.
The whole ts_GSUP_UL_REQ must resolve to a value.
Change-Id: I250960a1e1c19dfa1efa81f6bbc93efa07cb225c
---
M library/GSUP_Templates.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/67/40667/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40667?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I250960a1e1c19dfa1efa81f6bbc93efa07cb225c
Gerrit-Change-Number: 40667
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>