August 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-upf[master]: contrib/jenkins.sh: specify --with-unitdir for nftables

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-upf/+/40896?usp=email ) Change subject: contrib/jenkins.sh: specify --with-unitdir for nftables ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/40896?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I9ab473dd6f734606518a980152fd4b00c2e23690 Gerrit-Change-Number: 40896 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Aug 2025 09:45:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month

1
0
0 0

[M] Change in osmo-msc[master]: vlr: add PS support

by lynxis lazus

Attention is currently required from: neels, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email ) Change subject: vlr: add PS support ...................................................................... Patch Set 11: (1 comment) File src/libvlr/vlr_lu_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/6b7c54bd_11c2d989?usp… : PS5, Line 1611: fi->T > yes but my point is: […] Yes, that's right. But for coding style, I used the `osmo_timer_schedule(&fi->timer, vlr_timer_secs(vlr, fi->T, fi->T), 0);` because this is much longer and everywhere else I used vlr_timer_secs(): instead of `osmo_timer_schedule(&fi->timer, osmo_tdef_get(vlr_tdefs, fi->T, OSMO_TDEF_S, 0), 0);` -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0 Gerrit-Change-Number: 38490 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Aug 2025 09:25:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 month

1
0
0 0

[XS] Change in osmo-upf[master]: contrib/jenkins.sh: specify --with-unitdir for nftables

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/40896?usp=email ) Change subject: contrib/jenkins.sh: specify --with-unitdir for nftables ...................................................................... contrib/jenkins.sh: specify --with-unitdir for nftables Since recently (see the related commit), libnftables installs a systemd unit file that loads a ruleset from a file on boot. contrib/jenkins.sh currently fails with the following error: /usr/bin/install: cannot create regular file '/lib/systemd/system/nftables.service': Permission denied Let's specify the unit directory like we do for other projects. Change-Id: I9ab473dd6f734606518a980152fd4b00c2e23690 Related: nftables.git c4b17cf8305108f91d8e63880317a59e8e806c80 --- M contrib/jenkins.sh 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/96/40896/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 807774a..b81d1a6 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -37,6 +37,7 @@ build_from_netfilter() { ### TODO: enable osmo-build-dep.sh to build from git.netfilter.org URL? project="$1" + cfg="$2" set +x echo echo @@ -54,12 +55,13 @@ --prefix="$inst/stow/$project" \ --without-cli \ --disable-man-doc \ - --enable-python=no + --enable-python=no \ + $cfg $MAKE $PARALLEL_MAKE install STOW_DIR="$inst/stow" stow --restow $project } build_from_netfilter libnftnl -build_from_netfilter nftables +build_from_netfilter nftables "--with-unitdir=$inst/stow/$project/lib/systemd/system" # Additional configure options and depends CONFIG="" -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/40896?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I9ab473dd6f734606518a980152fd4b00c2e23690 Gerrit-Change-Number: 40896 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 month

1
0
0 0

[XS] Change in osmo-upf[master]: contrib/jenkins.sh: use https:// instead of git://

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/40897?usp=email ) Change subject: contrib/jenkins.sh: use https:// instead of git:// ...................................................................... contrib/jenkins.sh: use https:// instead of git:// Change-Id: I5f184fd100230e1b9c0076739f49901ab2782b4f --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/97/40897/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index b81d1a6..002bdc4 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -48,7 +48,7 @@ if [ -d "./$project" ]; then rm -rf "./$project" fi - git clone "git://git.netfilter.org/$project" "$project" + git clone "https://git.netfilter.org/$project" "$project" cd "$project" autoreconf --install --force ./configure \ -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/40897?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I5f184fd100230e1b9c0076739f49901ab2782b4f Gerrit-Change-Number: 40897 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 month

1
0
0 0

[S] Change in libosmocore[master]: Remove old empty io_uring

by jolly

Attention is currently required from: laforge. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40855?usp=email ) Change subject: Remove old empty io_uring ...................................................................... Patch Set 5: (1 comment) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40855/comment/70a204aa_b2e6e129?… : PS5, Line 620: sqe = io_uring_get_sqe_and_count(g_ring); Wrong ring here and down below. I am running TTCN3 tests. Fix will follow. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40855?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id2d2a0400ad442198c684ea0ead4eaeaead4c53d Gerrit-Change-Number: 40855 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 22 Aug 2025 08:31:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 month

1
0
0 0

[XS] Change in pysim[master]: bsp: fix maxpayloadsize

by fixeria

Attention is currently required from: Hoernchen. fixeria has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/40882?usp=email ) Change subject: bsp: fix maxpayloadsize ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I08f544877b79681ad1f758a1ca31c292eae9f868 Gerrit-Change-Number: 40882 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Aug 2025 08:14:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: GSUP_Templates: ts_GSUP_UL_REQ: add template scopes

by fixeria

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40667?usp=email ) Change subject: GSUP_Templates: ts_GSUP_UL_REQ: add template scopes ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40667?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I250960a1e1c19dfa1efa81f6bbc93efa07cb225c Gerrit-Change-Number: 40667 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 22 Aug 2025 07:14:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: GSUP Templates: fix empty destination_name in GSUP ISD/UL

by fixeria

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666?usp=email ) Change subject: GSUP Templates: fix empty destination_name in GSUP ISD/UL ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia89b5a82665e407fa578e5209fbcde0676326df0 Gerrit-Change-Number: 40666 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 22 Aug 2025 07:14:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS...

by fixeria

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236?usp=email ) Change subject: MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS Purge ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9e87537efc2c921fa860539a706316ed410b45d5 Gerrit-Change-Number: 39236 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 22 Aug 2025 07:11:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month

1
0
0 0

[XL] Change in libosmo-netif[master]: bring twjit into libosmo-netif

by falconia

Attention is currently required from: fixeria, jolly, laforge, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email ) Change subject: bring twjit into libosmo-netif ...................................................................... Patch Set 5: (1 comment) File src/twjit.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/8c26cfc3_e006745… : PS2, Line 504: rtph = osmo_rtp_get_hdr(msg); > I wouldn't mind getting rid of ortp and switching to something else. […] Regarding the question of what to do in OsmoBTS, I really prefer to tackle that question *after* the present addition of twrtp to libosmo-netif is merged, not before. The present concern of extending libosmo-netif should be independent of what we ultimately decide to do in OsmoBTS. Now back to the original thread question of adding support for M bit in twjit: I am now ready to work on this task, and I have an additional question to @pespin@sysmocom.de. My current idea is to add the optional check of M bit to `check_input_for_subbuf()` function - I hope you'll agree it seems like the best place. The question is: should this M bit check go before or after the currently implemented `if (ts_delta < 0)` check? Consider this scenario: a packet comes in M bit set, but the timestamp is in the past relative to `head_ts`. Should the past timestamp take precedence (discard the packet as too old), or should the M bit take precedence and invoke reset in HUNT or handover in FLOWING? You might wish to consider scenarios in which marker and non-marker packets get reordered by the IP network, if such reordering is possible in those worlds where you say M bit handling is needed. From my PoV, I treat this M bit handling as a customer-requested feature, and you are the customer-like requestor - hence I need you to tell me exactly how you want it to work. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 Gerrit-Change-Number: 39280 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Aug 2025 22:17:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025