Attention is currently required from: lynxis lazus, pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Re-introduce Iu/UTRAN support
......................................................................
Re-introduce Iu/UTRAN support
Add support for UTRAN routing areas.
Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889
---
M include/osmocom/sgsn/gprs_routing_area.h
M src/sgsn/gprs_ranap.c
M src/sgsn/gprs_routing_area.c
M tests/gprs_routing_area/gprs_routing_area_test.c
M tests/gprs_routing_area/gprs_routing_area_test.ok
5 files changed, 203 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/13/40813/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889
Gerrit-Change-Number: 40813
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: pespin.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email )
Change subject: Re-introduce Iu/UTRAN support
......................................................................
Patch Set 4:
(1 comment)
File src/sgsn/gprs_ranap.c:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/5fa82239_6b1a0d1c?us… :
PS4, Line 219: if (new_area->cell_type != RANAP_IU_NEW_RAC) {
braces {} are not necessary for single statement blocks
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889
Gerrit-Change-Number: 40813
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Aug 2025 16:51:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Re-introduce Iu/UTRAN support
......................................................................
Re-introduce Iu/UTRAN support
Add support for UTRAN routing areas.
Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889
---
M include/osmocom/sgsn/gprs_routing_area.h
M src/sgsn/gprs_ranap.c
M src/sgsn/gprs_routing_area.c
M tests/gprs_routing_area/gprs_routing_area_test.c
M tests/gprs_routing_area/gprs_routing_area_test.ok
5 files changed, 204 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/13/40813/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889
Gerrit-Change-Number: 40813
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email )
Change subject: Re-introduce Iu/UTRAN support
......................................................................
Patch Set 3:
(4 comments)
File src/sgsn/gprs_routing_area.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/12ce160b_f13e25bf?us… :
PS2, Line 439: } else {
> You can move this code path above as an early return.
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/1f550c1d_fd38f9cf?us… :
PS2, Line 483: else if (mmctx->p_tmsi_old != GSM_RESERVED_TMSI)
> these "else" here and below are not needed since you are doing early return.
Done
File tests/gprs_routing_area/gprs_routing_area_test.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/4a3591c6_07995963?us… :
PS2, Line 541: /* check if a GERAN RA/cell with the same LAC as an already register UTRAN gets rejected */
> registered?
I switched to a different wording.
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/277d8359_0465ad6c?us… :
PS2, Line 542: void test_routing_area_mv_utran_geran_reject(void)
> I think it's worth explaining here that this is an implementation decision we took and that it's not […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889
Gerrit-Change-Number: 40813
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Aug 2025 16:50:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel, laforge, lynxis lazus, pespin.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email )
Change subject: Deprecate iu_client
......................................................................
Patch Set 8:
(2 comments)
File TODO-RELEASE:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-iuh/+/40847/comment/6145d374_0cce31b8?usp… :
PS8, Line 17: libosmo-ranap deprecate iu_client iu_client will be further developed within osmo-sgsn. Only keeped for compatiblity.
'compatiblity' may be misspelled - perhaps 'compatibility'?
File include/osmocom/ranap/iu_client.h:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-iuh/+/40847/comment/3c462bef_375d6352?usp… :
PS8, Line 10: /* keep the following headers for backwards compatibilty */
'compatibilty' may be misspelled - perhaps 'compatibility'?
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de
Gerrit-Change-Number: 40847
Gerrit-PatchSet: 8
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 21 Aug 2025 16:40:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: daniel, laforge, lynxis lazus, pespin.
Hello Jenkins Builder, daniel, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Code-Review-1 by pespin, Verified+1 by Jenkins Builder
Change subject: Deprecate iu_client
......................................................................
Deprecate iu_client
The only remaining use of iu_client is osmo-sgsn.
iu_client was originally meant to be used by osmo-msc
and osmo-sgsn. But the abstraction didn't hold up and
osmo-msc stopped using iu_client for a long time.
To start development, osmo-sgsn will start with a copy of
iu_client until it can be completely dropped from the osmo-sgsn codebase.
Future osmo-sgsn versions won't use the osmo-iuh' iu_client.
Related: OS#5487
Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de
---
M TODO-RELEASE
M include/osmocom/ranap/iu_client.h
2 files changed, 26 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/47/40847/8
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de
Gerrit-Change-Number: 40847
Gerrit-PatchSet: 8
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: lynxis lazus.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email )
Change subject: Re-introduce Iu/UTRAN support
......................................................................
Patch Set 3:
(2 comments)
File src/sgsn/gprs_ranap.c:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/1118ca2d_a1247a82?us… :
PS3, Line 219: if (new_area->cell_type != RANAP_IU_NEW_RAC) {
braces {} are not necessary for single statement blocks
File src/sgsn/gprs_routing_area.c:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/ea41fcc1_d51624f7?us… :
PS3, Line 439: } else {
else is not generally useful after a break or return
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889
Gerrit-Change-Number: 40813
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 21 Aug 2025 16:38:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
