Attention is currently required from: fixeria, jolly, laforge, osmith.
Hello Jenkins Builder, fixeria, jolly, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: 5gc: Support PDU Session Establishment procedure
......................................................................
5gc: Support PDU Session Establishment procedure
This commit adds initial support to issue a successful PDU Session
Establishment procedure towards the 5GC, getting a ready-to-use GTPU
session with IPv4 addr + TEID + UE IP address.
commit has to our nas.git fork is updated in order to have multiple
fixes and improvements needed to have everything working fine.
Related: SYS#7073
Change-Id: If0769afd07a4bae7778d7a7c347cebaa5909b5f8
---
M 5gc/C5G_Tests.ttcn
M 5gc/gen_links.sh
M deps/Makefile
M library/NGAP_Functions.ttcn
M library/NG_NAS_Functions.ttcn
M library/NG_NAS_Osmo_Templates.ttcn
A library/NG_NAS_Osmo_Types.ttcn
M library/ngap/NGAP_EncDec.cc
M library/ngap/NGAP_Templates.ttcn
M library/ngap/NGAP_Types.ttcn
10 files changed, 490 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/40445/7
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If0769afd07a4bae7778d7a7c347cebaa5909b5f8
Gerrit-Change-Number: 40445
Gerrit-PatchSet: 7
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, jolly, laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445?usp=email )
Change subject: 5gc: Support PDU Session Establishment procedure
......................................................................
Patch Set 6:
(6 comments)
Patchset:
PS6:
I'm updating deps/makefile again to contain a couple fixes I submitted upstream here: https://forge.etsi.org/rep/int/5g-core/nas/-/merge_requests/10
File 5gc/C5G_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445/comment/e9024638_c6db… :
PS6, Line 324: log("Rx NAS message: ", rx_nas);
> looks unrelated
It's not needed anymore, part of this next step towards having steps consolidated.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445/comment/38c34695_328d… :
PS6, Line 386: log("Rx inner NAS: ", rx_nas);
> looks unrelated
It's not needed anymore, part of this next step towards having steps consolidated.
File deps/Makefile:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445/comment/3e586d33_5bb5… :
PS6, Line 74: Do not put references to branches here
> This has been removed in a recent commit. Looks like a rebase artifact.
Done
File library/NG_NAS_Osmo_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445/comment/5bf6294b_7bb3… :
PS6, Line 584: omit
> How can the whole template be `omit`? It always yields a `value`, right?
Done
File library/NG_NAS_Osmo_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445/comment/2a9acfab_cb52… :
PS6, Line 70: errorbehavior(ALL:WARNING)
> Interesting, haven't seen this before. […]
No idea, just copied it from the superset union provided in nas.git.
I think it sets RAW enc/dec logging to desired level.
Removing it since it's not really important here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If0769afd07a4bae7778d7a7c347cebaa5909b5f8
Gerrit-Change-Number: 40445
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 24 Jul 2025 10:41:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, jolly, laforge, osmith, pespin.
Hello Jenkins Builder, fixeria, jolly, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445?usp=email
to look at the new patch set (#6).
Change subject: 5gc: Support PDU Session Establishment procedure
......................................................................
5gc: Support PDU Session Establishment procedure
This commit adds initial support to issue a successful PDU Session
Establishment procedure towards the 5GC, getting a ready-to-use GTPU
session with IPv4 addr + TEID + UE IP address.
commit has to our nas.git fork is updated in order to have multiple
fixes and improvements needed to have everything working fine.
Related: SYS#7073
Change-Id: If0769afd07a4bae7778d7a7c347cebaa5909b5f8
---
M 5gc/C5G_Tests.ttcn
M 5gc/gen_links.sh
M deps/Makefile
M library/NGAP_Functions.ttcn
M library/NG_NAS_Functions.ttcn
M library/NG_NAS_Osmo_Templates.ttcn
A library/NG_NAS_Osmo_Types.ttcn
M library/ngap/NGAP_EncDec.cc
M library/ngap/NGAP_Templates.ttcn
M library/ngap/NGAP_Types.ttcn
10 files changed, 493 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/40445/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If0769afd07a4bae7778d7a7c347cebaa5909b5f8
Gerrit-Change-Number: 40445
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, jolly, laforge, osmith, pespin.
Hello Jenkins Builder, fixeria, jolly, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: 5gc: Support PDU Session Establishment procedure
......................................................................
5gc: Support PDU Session Establishment procedure
This commit adds initial support to issue a successful PDU Session
Establishment procedure towards the 5GC, getting a ready-to-use GTPU
session with IPv4 addr + TEID + UE IP address.
commit has to our nas.git fork is updated in order to have multiple
fixes and improvements needed to have everything working fine.
Related: SYS#7073
Change-Id: If0769afd07a4bae7778d7a7c347cebaa5909b5f8
---
M 5gc/C5G_Tests.ttcn
M 5gc/gen_links.sh
M deps/Makefile
M library/NGAP_Functions.ttcn
M library/NG_NAS_Functions.ttcn
M library/NG_NAS_Osmo_Templates.ttcn
A library/NG_NAS_Osmo_Types.ttcn
M library/ngap/NGAP_EncDec.cc
M library/ngap/NGAP_Templates.ttcn
M library/ngap/NGAP_Types.ttcn
10 files changed, 493 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/40445/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If0769afd07a4bae7778d7a7c347cebaa5909b5f8
Gerrit-Change-Number: 40445
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40741?usp=email )
Change subject: Cosmetic: deps/Makefile: update comments
......................................................................
Cosmetic: deps/Makefile: update comments
Remove the part about caching logic of docker containers, as most
testsuites don't use docker-playground anymore. The main reason for
using commits here is that we have exact commits when doing regression
testing.
Replace the verbose license header with the SPDX version while at it.
Change-Id: I7eddc64aeab20292922ba013221679dfe952ff45
---
M deps/Makefile
1 file changed, 3 insertions(+), 16 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
diff --git a/deps/Makefile b/deps/Makefile
index 0792c09..8739abc 100644
--- a/deps/Makefile
+++ b/deps/Makefile
@@ -1,17 +1,6 @@
# Copyright 2017 Harald Welte
# Copyright 2018 sysmocom - s.f.m.c. GmbH
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
+# SPDX-License-Identifier: Apache-2.0
ECLIPSEGITLAB:=https://gitlab.eclipse.org/eclipse/titanOSMOGITHUB:=https://github.com/osmocom
@@ -81,10 +70,8 @@
$(OSMOGITEA_REPOS) \
$(FORKEDGITLAB_REPOS)
-# Tag names from 'git-describe --tags'; if not available, a commit hash may be used instead.
-# Do not put references to branches here, except for local testing: this breaks the caching
-# logic of docker containers, which only invalidate their cached ttcn3 dependencies if this
-# file changed.
+# Use tag names from 'git describe --tags' or commit hashes. This way we get
+# exact commits of deps when doing regression testing.
nas_commit= eff069b772a53e16773638f07599e7936ffcdd9a
titan.Libraries.TCCUsefulFunctions_commit= R.35.B-6-gb3687da
titan.ProtocolEmulations.M3UA_commit= b58f92046e48a7b1ed531e243a2319ebca53bf4c
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40741?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7eddc64aeab20292922ba013221679dfe952ff45
Gerrit-Change-Number: 40741
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>