[S] Change in libosmocore[master]: osmo-io: Put together message buffers when dequeued from tx queue
Attention is currently required from: jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40760?usp=email ) Change subject: osmo-io: Put together message buffers when dequeued from tx queue ...................................................................... Patch Set 3: (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40760/comment/26d7d64b_d9220840?u... : PS3, Line 261: * There can be empty buffers, when a msghdr is queued to the front with incomplete write. */ do we have some unit test coverage for those rather hard-to-trigger code paths? I think it's hard to know they work as expected without such tests... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I97c366211dd266fd58ec252890ec017d6d334534 Gerrit-Change-Number: 40760 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Comment-Date: Thu, 31 Jul 2025 13:00:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
participants (1)
-
laforge